* [PATCH] tty: n_gsm: clean up indenting in gsm_queue()
@ 2021-10-04 10:43 Dan Carpenter
2021-10-06 5:52 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-10-04 10:43 UTC (permalink / raw)
To: Greg Kroah-Hartman, Zhenguo Zhao
Cc: Jiri Slaby, linux-kernel, kernel-janitors
These two lines need to be indented one more tab.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/tty/n_gsm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 157b51ce9cc0..3bbfcccd79d3 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -1854,8 +1854,8 @@ static void gsm_queue(struct gsm_mux *gsm)
if (address_tmp == address) {
for (k = j; k < addr_cnt; k++)
addr_open[k] = addr_open[k+1];
- addr_cnt--;
- break;
+ addr_cnt--;
+ break;
}
}
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tty: n_gsm: clean up indenting in gsm_queue()
2021-10-04 10:43 [PATCH] tty: n_gsm: clean up indenting in gsm_queue() Dan Carpenter
@ 2021-10-06 5:52 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2021-10-06 5:52 UTC (permalink / raw)
To: Dan Carpenter, Greg Kroah-Hartman, Zhenguo Zhao
Cc: linux-kernel, kernel-janitors
On 04. 10. 21, 12:43, Dan Carpenter wrote:
> These two lines need to be indented one more tab.
Right, the indentation is incorrect (and not the closing brace).
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/tty/n_gsm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> index 157b51ce9cc0..3bbfcccd79d3 100644
> --- a/drivers/tty/n_gsm.c
> +++ b/drivers/tty/n_gsm.c
> @@ -1854,8 +1854,8 @@ static void gsm_queue(struct gsm_mux *gsm)
> if (address_tmp == address) {
> for (k = j; k < addr_cnt; k++)
> addr_open[k] = addr_open[k+1];
> - addr_cnt--;
> - break;
> + addr_cnt--;
> + break;
> }
> }
> }
>
--
js
suse labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-06 5:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04 10:43 [PATCH] tty: n_gsm: clean up indenting in gsm_queue() Dan Carpenter
2021-10-06 5:52 ` Jiri Slaby
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.