From: "Paweł Anikiel" <pan@semihalf.com> To: jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, robh+dt@kernel.org, p.zabel@pengutronix.de, arnd@arndb.de, olof@lixom.net, soc@kernel.org, dinguyen@kernel.org, p.yadav@ti.com, Tudor.Ambarus@microchip.com Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, alexandre.belloni@bootlin.com, sre@kernel.org, thunder.leizhen@huawei.com, Jonathan.Cameron@huawei.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ka@semihalf.com, tn@semihalf.com, jam@semihalf.com, amstan@google.com, "Paweł Anikiel" <pan@semihalf.com> Subject: [PATCH v2 1/4] i2c: check bus number property in DesignWare I2C Controller Date: Tue, 5 Oct 2021 16:37:45 +0200 [thread overview] Message-ID: <20211005143748.2471647-2-pan@semihalf.com> (raw) In-Reply-To: <20211005143748.2471647-1-pan@semihalf.com> On SoCFPGA systems, it's desireable to have fixed numbering for i2c busses, while being able to enable/disable them (e.g. have i2c1 be mapped to /dev/i2c-1, even though i2c0 is disabled). This can also be achieved using devicetree aliases (see i2c_add_adapter). However, having the driver be self-contained without relying on aliases is more robust. Signed-off-by: Paweł Anikiel <pan@semihalf.com> --- drivers/i2c/busses/i2c-designware-platdrv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index 21113665ddea..f27e6bc9ad9d 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -280,7 +280,8 @@ static int dw_i2c_plat_probe(struct platform_device *pdev) I2C_CLASS_HWMON : I2C_CLASS_DEPRECATED; ACPI_COMPANION_SET(&adap->dev, ACPI_COMPANION(&pdev->dev)); adap->dev.of_node = pdev->dev.of_node; - adap->nr = -1; + if (of_property_read_u32(pdev->dev.of_node, "busno", &adap->nr)) + adap->nr = -1; if (dev->flags & ACCESS_NO_IRQ_SUSPEND) { dev_pm_set_driver_flags(&pdev->dev, -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: "Paweł Anikiel" <pan@semihalf.com> To: jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, robh+dt@kernel.org, p.zabel@pengutronix.de, arnd@arndb.de, olof@lixom.net, soc@kernel.org, dinguyen@kernel.org, p.yadav@ti.com, Tudor.Ambarus@microchip.com Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, alexandre.belloni@bootlin.com, sre@kernel.org, thunder.leizhen@huawei.com, Jonathan.Cameron@huawei.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ka@semihalf.com, tn@semihalf.com, jam@semihalf.com, amstan@google.com, "Paweł Anikiel" <pan@semihalf.com> Subject: [PATCH v2 1/4] i2c: check bus number property in DesignWare I2C Controller Date: Tue, 5 Oct 2021 16:37:45 +0200 [thread overview] Message-ID: <20211005143748.2471647-2-pan@semihalf.com> (raw) Message-ID: <20211005143745.KzSPsixDL4qG7NmMnTdV7Cu5_ERt2hASRD4vxiWs0nw@z> (raw) In-Reply-To: <20211005143748.2471647-1-pan@semihalf.com> On SoCFPGA systems, it's desireable to have fixed numbering for i2c busses, while being able to enable/disable them (e.g. have i2c1 be mapped to /dev/i2c-1, even though i2c0 is disabled). This can also be achieved using devicetree aliases (see i2c_add_adapter). However, having the driver be self-contained without relying on aliases is more robust. Signed-off-by: Paweł Anikiel <pan@semihalf.com> --- drivers/i2c/busses/i2c-designware-platdrv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index 21113665ddea..f27e6bc9ad9d 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -280,7 +280,8 @@ static int dw_i2c_plat_probe(struct platform_device *pdev) I2C_CLASS_HWMON : I2C_CLASS_DEPRECATED; ACPI_COMPANION_SET(&adap->dev, ACPI_COMPANION(&pdev->dev)); adap->dev.of_node = pdev->dev.of_node; - adap->nr = -1; + if (of_property_read_u32(pdev->dev.of_node, "busno", &adap->nr)) + adap->nr = -1; if (dev->flags & ACCESS_NO_IRQ_SUSPEND) { dev_pm_set_driver_flags(&pdev->dev, -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-05 14:38 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-05 14:37 [PATCH v2 0/4] Add support for the Mercury+ AA1 module Paweł Anikiel 2021-10-05 14:37 ` Paweł Anikiel 2021-10-05 14:37 ` Paweł Anikiel [this message] 2021-10-05 14:37 ` [PATCH v2 1/4] i2c: check bus number property in DesignWare I2C Controller Paweł Anikiel 2021-10-05 16:19 ` Andy Shevchenko 2021-10-05 16:19 ` Andy Shevchenko 2021-10-05 14:37 ` [PATCH v2 2/4] dt-bindings: add bus number property Paweł Anikiel 2021-10-14 16:46 ` Rob Herring 2021-10-14 16:46 ` Rob Herring 2021-10-05 14:37 ` Paweł Anikiel 2021-10-05 14:37 ` Paweł Anikiel 2021-10-05 16:22 ` Arnd Bergmann 2021-10-05 16:22 ` Arnd Bergmann 2021-10-05 16:28 ` Alexandre Belloni 2021-10-05 16:28 ` Alexandre Belloni 2021-10-06 9:21 ` Paweł Anikiel 2021-10-06 9:41 ` Arnd Bergmann 2021-10-06 9:41 ` Arnd Bergmann 2021-10-06 9:29 ` Paweł Anikiel 2021-10-06 9:29 ` Paweł Anikiel 2021-10-05 14:37 ` [PATCH v2 3/4] reset: socfpga: add empty driver allowing consumers to probe Paweł Anikiel 2021-10-05 14:37 ` Paweł Anikiel 2021-10-05 14:37 ` [PATCH v2 4/4] dts: socfpga: Add Mercury+ AA1 devicetree Paweł Anikiel 2021-10-05 14:37 ` Paweł Anikiel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211005143748.2471647-2-pan@semihalf.com \ --to=pan@semihalf.com \ --cc=Jonathan.Cameron@huawei.com \ --cc=Tudor.Ambarus@microchip.com \ --cc=alexandre.belloni@bootlin.com \ --cc=amstan@google.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=arnd@arndb.de \ --cc=devicetree@vger.kernel.org \ --cc=dinguyen@kernel.org \ --cc=jam@semihalf.com \ --cc=jarkko.nikula@linux.intel.com \ --cc=ka@semihalf.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mika.westerberg@linux.intel.com \ --cc=olof@lixom.net \ --cc=p.yadav@ti.com \ --cc=p.zabel@pengutronix.de \ --cc=robh+dt@kernel.org \ --cc=soc@kernel.org \ --cc=sre@kernel.org \ --cc=thunder.leizhen@huawei.com \ --cc=tn@semihalf.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.