From: Brent Lu <brent.lu@intel.com> To: alsa-devel@alsa-project.org Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Cezary Rojewski <cezary.rojewski@intel.com>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Jie Yang <yang.jie@linux.intel.com>, Brent Lu <brent.lu@intel.com>, Kai Vehmanen <kai.vehmanen@linux.intel.com>, Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>, Yong Zhi <yong.zhi@intel.com>, Vamshi Krishna Gopal <vamshi.krishna.gopal@intel.com>, linux-kernel@vger.kernel.org, Rander Wang <rander.wang@intel.com>, Bard Liao <bard.liao@intel.com>, Malik_Hsu <malik_hsu@wistron.corp-partner.google.com>, Libin Yang <libin.yang@intel.com>, Hans de Goede <hdegoede@redhat.com>, Charles Keepax <ckeepax@opensource.cirrus.com>, Paul Olaru <paul.olaru@oss.nxp.com>, Curtis Malainey <cujomalainey@chromium.org>, Mac Chiang <mac.chiang@intel.com>, Gongjun Song <gongjun.song@intel.com> Subject: [PATCH v2 1/3] ASoC: soc-acpi: add comp_ids field for machine driver matching Date: Thu, 7 Oct 2021 21:35:14 +0800 [thread overview] Message-ID: <20211007133516.1464655-2-brent.lu@intel.com> (raw) In-Reply-To: <20211007133516.1464655-1-brent.lu@intel.com> A machine driver needs to be enumerated by more than one ACPI HID if it supports second headphone driver (i.e. rt5682 and rt5682s). However, the id field in snd_soc_acpi_mach structure could contain only one HID. By adding a 'comp_ids' field which can contain several HIDs, we can enumerate a machine driver by multiple ACPI HIDs. Signed-off-by: Brent Lu <brent.lu@intel.com> --- include/sound/soc-acpi.h | 2 ++ sound/soc/soc-acpi.c | 24 ++++++++++++++++++++++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/include/sound/soc-acpi.h b/include/sound/soc-acpi.h index 2f3fa385c092..43cf520f145e 100644 --- a/include/sound/soc-acpi.h +++ b/include/sound/soc-acpi.h @@ -129,6 +129,7 @@ struct snd_soc_acpi_link_adr { * all firmware/topology related fields. * * @id: ACPI ID (usually the codec's) used to find a matching machine driver. + * @comp_ids: a list of audio codecs also used to find a matching machine driver. * @link_mask: describes required board layout, e.g. for SoundWire. * @links: array of link _ADR descriptors, null terminated. * @drv_name: machine driver name @@ -146,6 +147,7 @@ struct snd_soc_acpi_link_adr { /* Descriptor for SST ASoC machine driver */ struct snd_soc_acpi_mach { const u8 id[ACPI_ID_LEN]; + struct snd_soc_acpi_codecs *comp_ids; const u32 link_mask; const struct snd_soc_acpi_link_adr *links; const char *drv_name; diff --git a/sound/soc/soc-acpi.c b/sound/soc/soc-acpi.c index 395229bf5c51..aca7c2020567 100644 --- a/sound/soc/soc-acpi.c +++ b/sound/soc/soc-acpi.c @@ -8,14 +8,34 @@ #include <linux/module.h> #include <sound/soc-acpi.h> +static bool snd_soc_acpi_id_present(struct snd_soc_acpi_mach *machine) +{ + struct snd_soc_acpi_codecs *comp_ids = machine->comp_ids; + int i; + + if (machine->id[0]) { + if (acpi_dev_present(machine->id, NULL, -1)) + return true; + } + + if (comp_ids) { + for (i = 0; i < comp_ids->num_codecs; i++) { + if (acpi_dev_present(comp_ids->codecs[i], NULL, -1)) + return true; + } + } + + return false; +} + struct snd_soc_acpi_mach * snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines) { struct snd_soc_acpi_mach *mach; struct snd_soc_acpi_mach *mach_alt; - for (mach = machines; mach->id[0]; mach++) { - if (acpi_dev_present(mach->id, NULL, -1)) { + for (mach = machines; mach->id[0] || mach->comp_ids; mach++) { + if (snd_soc_acpi_id_present(mach)) { if (mach->machine_quirk) { mach_alt = mach->machine_quirk(mach); if (!mach_alt) -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Brent Lu <brent.lu@intel.com> To: alsa-devel@alsa-project.org Cc: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>, Cezary Rojewski <cezary.rojewski@intel.com>, Jie Yang <yang.jie@linux.intel.com>, Rander Wang <rander.wang@intel.com>, Mac Chiang <mac.chiang@intel.com>, Gongjun Song <gongjun.song@intel.com>, Bard Liao <bard.liao@intel.com>, Takashi Iwai <tiwai@suse.com>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Vamshi Krishna Gopal <vamshi.krishna.gopal@intel.com>, Yong Zhi <yong.zhi@intel.com>, Charles Keepax <ckeepax@opensource.cirrus.com>, Hans de Goede <hdegoede@redhat.com>, Mark Brown <broonie@kernel.org>, Paul Olaru <paul.olaru@oss.nxp.com>, Brent Lu <brent.lu@intel.com>, Libin Yang <libin.yang@intel.com>, Malik_Hsu <malik_hsu@wistron.corp-partner.google.com>, Kai Vehmanen <kai.vehmanen@linux.intel.com>, Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org, Curtis Malainey <cujomalainey@chromium.org> Subject: [PATCH v2 1/3] ASoC: soc-acpi: add comp_ids field for machine driver matching Date: Thu, 7 Oct 2021 21:35:14 +0800 [thread overview] Message-ID: <20211007133516.1464655-2-brent.lu@intel.com> (raw) In-Reply-To: <20211007133516.1464655-1-brent.lu@intel.com> A machine driver needs to be enumerated by more than one ACPI HID if it supports second headphone driver (i.e. rt5682 and rt5682s). However, the id field in snd_soc_acpi_mach structure could contain only one HID. By adding a 'comp_ids' field which can contain several HIDs, we can enumerate a machine driver by multiple ACPI HIDs. Signed-off-by: Brent Lu <brent.lu@intel.com> --- include/sound/soc-acpi.h | 2 ++ sound/soc/soc-acpi.c | 24 ++++++++++++++++++++++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/include/sound/soc-acpi.h b/include/sound/soc-acpi.h index 2f3fa385c092..43cf520f145e 100644 --- a/include/sound/soc-acpi.h +++ b/include/sound/soc-acpi.h @@ -129,6 +129,7 @@ struct snd_soc_acpi_link_adr { * all firmware/topology related fields. * * @id: ACPI ID (usually the codec's) used to find a matching machine driver. + * @comp_ids: a list of audio codecs also used to find a matching machine driver. * @link_mask: describes required board layout, e.g. for SoundWire. * @links: array of link _ADR descriptors, null terminated. * @drv_name: machine driver name @@ -146,6 +147,7 @@ struct snd_soc_acpi_link_adr { /* Descriptor for SST ASoC machine driver */ struct snd_soc_acpi_mach { const u8 id[ACPI_ID_LEN]; + struct snd_soc_acpi_codecs *comp_ids; const u32 link_mask; const struct snd_soc_acpi_link_adr *links; const char *drv_name; diff --git a/sound/soc/soc-acpi.c b/sound/soc/soc-acpi.c index 395229bf5c51..aca7c2020567 100644 --- a/sound/soc/soc-acpi.c +++ b/sound/soc/soc-acpi.c @@ -8,14 +8,34 @@ #include <linux/module.h> #include <sound/soc-acpi.h> +static bool snd_soc_acpi_id_present(struct snd_soc_acpi_mach *machine) +{ + struct snd_soc_acpi_codecs *comp_ids = machine->comp_ids; + int i; + + if (machine->id[0]) { + if (acpi_dev_present(machine->id, NULL, -1)) + return true; + } + + if (comp_ids) { + for (i = 0; i < comp_ids->num_codecs; i++) { + if (acpi_dev_present(comp_ids->codecs[i], NULL, -1)) + return true; + } + } + + return false; +} + struct snd_soc_acpi_mach * snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines) { struct snd_soc_acpi_mach *mach; struct snd_soc_acpi_mach *mach_alt; - for (mach = machines; mach->id[0]; mach++) { - if (acpi_dev_present(mach->id, NULL, -1)) { + for (mach = machines; mach->id[0] || mach->comp_ids; mach++) { + if (snd_soc_acpi_id_present(mach)) { if (mach->machine_quirk) { mach_alt = mach->machine_quirk(mach); if (!mach_alt) -- 2.25.1
next prev parent reply other threads:[~2021-10-07 13:37 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-07 13:35 [PATCH v2 0/3] Multiple headphone codec driver support Brent Lu 2021-10-07 13:35 ` Brent Lu 2021-10-07 13:35 ` Brent Lu [this message] 2021-10-07 13:35 ` [PATCH v2 1/3] ASoC: soc-acpi: add comp_ids field for machine driver matching Brent Lu 2021-10-07 17:05 ` Cezary Rojewski 2021-10-07 17:05 ` Cezary Rojewski 2021-10-07 17:27 ` Pierre-Louis Bossart 2021-10-07 17:27 ` Pierre-Louis Bossart 2021-10-07 18:46 ` Cezary Rojewski 2021-10-07 18:46 ` Cezary Rojewski 2021-10-07 13:35 ` [PATCH v2 2/3] ASoC: Intel: sof_rt5682: detect codec variant in probe function Brent Lu 2021-10-07 13:35 ` Brent Lu 2021-10-07 13:35 ` [PATCH v2 3/3] ASoC: Intel: sof_rt5682: use comp_ids to enumerate rt5682s Brent Lu 2021-10-07 13:35 ` Brent Lu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211007133516.1464655-2-brent.lu@intel.com \ --to=brent.lu@intel.com \ --cc=alsa-devel@alsa-project.org \ --cc=bard.liao@intel.com \ --cc=broonie@kernel.org \ --cc=cezary.rojewski@intel.com \ --cc=ckeepax@opensource.cirrus.com \ --cc=cujomalainey@chromium.org \ --cc=gongjun.song@intel.com \ --cc=guennadi.liakhovetski@linux.intel.com \ --cc=hdegoede@redhat.com \ --cc=kai.vehmanen@linux.intel.com \ --cc=lgirdwood@gmail.com \ --cc=libin.yang@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mac.chiang@intel.com \ --cc=malik_hsu@wistron.corp-partner.google.com \ --cc=paul.olaru@oss.nxp.com \ --cc=perex@perex.cz \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=rander.wang@intel.com \ --cc=tiwai@suse.com \ --cc=vamshi.krishna.gopal@intel.com \ --cc=yang.jie@linux.intel.com \ --cc=yong.zhi@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.