From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Brent Lu <brent.lu@intel.com>, <alsa-devel@alsa-project.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
Yong Zhi <yong.zhi@intel.com>,
Vamshi Krishna Gopal <vamshi.krishna.gopal@intel.com>,
<linux-kernel@vger.kernel.org>,
Rander Wang <rander.wang@intel.com>,
"Bard Liao" <bard.liao@intel.com>,
Malik_Hsu <malik_hsu@wistron.corp-partner.google.com>,
Libin Yang <libin.yang@intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Paul Olaru <paul.olaru@oss.nxp.com>,
"Curtis Malainey" <cujomalainey@chromium.org>,
Mac Chiang <mac.chiang@intel.com>,
Gongjun Song <gongjun.song@intel.com>
Subject: Re: [PATCH v2 1/3] ASoC: soc-acpi: add comp_ids field for machine driver matching
Date: Thu, 7 Oct 2021 19:05:39 +0200 [thread overview]
Message-ID: <7e6cf92f-b889-aed9-b13a-615d4d5f9b93@intel.com> (raw)
In-Reply-To: <20211007133516.1464655-2-brent.lu@intel.com>
On 2021-10-07 3:35 PM, Brent Lu wrote:
...
>
> +static bool snd_soc_acpi_id_present(struct snd_soc_acpi_mach *machine)
> +{
> + struct snd_soc_acpi_codecs *comp_ids = machine->comp_ids;
> + int i;
> +
> + if (machine->id[0]) {
> + if (acpi_dev_present(machine->id, NULL, -1))
> + return true;
> + }
> +
> + if (comp_ids) {
> + for (i = 0; i < comp_ids->num_codecs; i++) {
> + if (acpi_dev_present(comp_ids->codecs[i], NULL, -1))
> + return true;
> + }
> + }
> +
> + return false;
> +}
In cover letter you mention:
"- can use 'comp_ids' field alone to enumerate driver"
which leads me to an opinion that field 'id' should be removed,
entirely. With 'comp_ids' added, 'id' is basically rendered
optional/redundant.
> +
> struct snd_soc_acpi_mach *
> snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines)
> {
> struct snd_soc_acpi_mach *mach;
> struct snd_soc_acpi_mach *mach_alt;
>
> - for (mach = machines; mach->id[0]; mach++) {
> - if (acpi_dev_present(mach->id, NULL, -1)) {
> + for (mach = machines; mach->id[0] || mach->comp_ids; mach++) {
Such loops are hard to maintain i.e. 'comp_ids' acts here like a flex
array that follows 'id'. Removal of 'id' field and streamlining code to
only use 'comp_ids' should make this loop more intuitive.
> + if (snd_soc_acpi_id_present(mach)) {
> if (mach->machine_quirk) {
> mach_alt = mach->machine_quirk(mach);
> if (!mach_alt)
>
WARNING: multiple messages have this Message-ID (diff)
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Brent Lu <brent.lu@intel.com>, <alsa-devel@alsa-project.org>
Cc: Libin Yang <libin.yang@intel.com>,
Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
Malik_Hsu <malik_hsu@wistron.corp-partner.google.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rander Wang <rander.wang@intel.com>,
linux-kernel@vger.kernel.org, Jie Yang <yang.jie@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>,
Hans de Goede <hdegoede@redhat.com>,
Mac Chiang <mac.chiang@intel.com>,
Mark Brown <broonie@kernel.org>, Bard Liao <bard.liao@intel.com>,
Paul Olaru <paul.olaru@oss.nxp.com>,
Curtis Malainey <cujomalainey@chromium.org>,
Gongjun Song <gongjun.song@intel.com>,
Vamshi Krishna Gopal <vamshi.krishna.gopal@intel.com>,
Yong Zhi <yong.zhi@intel.com>
Subject: Re: [PATCH v2 1/3] ASoC: soc-acpi: add comp_ids field for machine driver matching
Date: Thu, 7 Oct 2021 19:05:39 +0200 [thread overview]
Message-ID: <7e6cf92f-b889-aed9-b13a-615d4d5f9b93@intel.com> (raw)
In-Reply-To: <20211007133516.1464655-2-brent.lu@intel.com>
On 2021-10-07 3:35 PM, Brent Lu wrote:
...
>
> +static bool snd_soc_acpi_id_present(struct snd_soc_acpi_mach *machine)
> +{
> + struct snd_soc_acpi_codecs *comp_ids = machine->comp_ids;
> + int i;
> +
> + if (machine->id[0]) {
> + if (acpi_dev_present(machine->id, NULL, -1))
> + return true;
> + }
> +
> + if (comp_ids) {
> + for (i = 0; i < comp_ids->num_codecs; i++) {
> + if (acpi_dev_present(comp_ids->codecs[i], NULL, -1))
> + return true;
> + }
> + }
> +
> + return false;
> +}
In cover letter you mention:
"- can use 'comp_ids' field alone to enumerate driver"
which leads me to an opinion that field 'id' should be removed,
entirely. With 'comp_ids' added, 'id' is basically rendered
optional/redundant.
> +
> struct snd_soc_acpi_mach *
> snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines)
> {
> struct snd_soc_acpi_mach *mach;
> struct snd_soc_acpi_mach *mach_alt;
>
> - for (mach = machines; mach->id[0]; mach++) {
> - if (acpi_dev_present(mach->id, NULL, -1)) {
> + for (mach = machines; mach->id[0] || mach->comp_ids; mach++) {
Such loops are hard to maintain i.e. 'comp_ids' acts here like a flex
array that follows 'id'. Removal of 'id' field and streamlining code to
only use 'comp_ids' should make this loop more intuitive.
> + if (snd_soc_acpi_id_present(mach)) {
> if (mach->machine_quirk) {
> mach_alt = mach->machine_quirk(mach);
> if (!mach_alt)
>
next prev parent reply other threads:[~2021-10-07 17:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 13:35 [PATCH v2 0/3] Multiple headphone codec driver support Brent Lu
2021-10-07 13:35 ` Brent Lu
2021-10-07 13:35 ` [PATCH v2 1/3] ASoC: soc-acpi: add comp_ids field for machine driver matching Brent Lu
2021-10-07 13:35 ` Brent Lu
2021-10-07 17:05 ` Cezary Rojewski [this message]
2021-10-07 17:05 ` Cezary Rojewski
2021-10-07 17:27 ` Pierre-Louis Bossart
2021-10-07 17:27 ` Pierre-Louis Bossart
2021-10-07 18:46 ` Cezary Rojewski
2021-10-07 18:46 ` Cezary Rojewski
2021-10-07 13:35 ` [PATCH v2 2/3] ASoC: Intel: sof_rt5682: detect codec variant in probe function Brent Lu
2021-10-07 13:35 ` Brent Lu
2021-10-07 13:35 ` [PATCH v2 3/3] ASoC: Intel: sof_rt5682: use comp_ids to enumerate rt5682s Brent Lu
2021-10-07 13:35 ` Brent Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e6cf92f-b889-aed9-b13a-615d4d5f9b93@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=cujomalainey@chromium.org \
--cc=gongjun.song@intel.com \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=libin.yang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=malik_hsu@wistron.corp-partner.google.com \
--cc=paul.olaru@oss.nxp.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@intel.com \
--cc=tiwai@suse.com \
--cc=vamshi.krishna.gopal@intel.com \
--cc=yang.jie@linux.intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.