Re: [PATCH v12 00/11] Add support for Hikey 970 PCIe

[Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>]

On Sat, Oct 09, 2021 at 01:44:24AM +0000, Songxiaowei (Kirin_DRV) wrote:
> Ack-by Xiaowei Song.

First of all, you should not top-post:

https://kernelnewbies.org/PatchCulture

Second the format does not match the guidelines:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html

So let's retry to send your ACK a third time please.

Thanks,
Lorenzo

> 
> > Hi Lorenzo,
> > 
> > Em Thu, 7 Oct 2021 15:41:03 +0100
> > Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> escreveu:
> > 
> > > On Tue, Oct 05, 2021 at 01:23:21PM -0500, Bjorn Helgaas wrote:
> > > > [+cc Lorenzo]
> > > > 
> > > > On Tue, Oct 05, 2021 at 11:24:48AM +0200, Mauro Carvalho Chehab wrote:  
> > > > > Hi Bjorn,
> > > > > 
> > > > > Em Tue, 28 Sep 2021 09:34:10 +0200
> > > > > Mauro Carvalho Chehab <mchehab+huawei@kernel.org> escreveu:  
> > > >   
> > > > > >   PCI: kirin: Reorganize the PHY logic inside the driver
> > > > > >   PCI: kirin: Add support for a PHY layer
> > > > > >   PCI: kirin: Use regmap for APB registers
> > > > > >   PCI: kirin: Add support for bridge slot DT schema
> > > > > >   PCI: kirin: Add Kirin 970 compatible
> > > > > >   PCI: kirin: Add MODULE_* macros
> > > > > >   PCI: kirin: Allow building it as a module
> > > > > >   PCI: kirin: Add power_off support for Kirin 960 PHY
> > > > > >   PCI: kirin: fix poweroff sequence
> > > > > >   PCI: kirin: Allow removing the driver  
> > > > > 
> > > > > I guess everything is already satisfying the review feedbacks.
> > > > > If so, could you please merge the PCI ones?  
> > > > 
> > > > Lorenzo takes care of the native host bridge drivers, so I'm sure this
> > > > is on his list.  I added him to cc: in case not.  
> > > 
> > > Ideally I'd like to see these patches ACKed/Review-ed by the kirin
> > > maintainers - that's what I was waiting for and that's what they
> > > are there for.
> > > 
> > > Having said that, I will keep an eye on this series so that we
> > > can hopefully queue it for v5.16.
> > 
> > Not sure if you received the e-mail from Xiaowei with his ack.
> 
> I have not (and it did not make it to linux-pci either).
> 
> > At least here, I only received on my internal e-mail (perhaps because
> > the original e-mail was base64-encoded with gb2312 charset). 
> > 
> > So, let me forward his answer to you, c/c the mailing lists.
> 
> Patches should be acked with tags that tooling recognize, this
> would help me.
> 
> > Thanks,
> > Mauro
> > 
> 
> Thanks.