All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next 1/7] ethernet: constify references to netdev->dev_addr in drivers
Date: Thu, 14 Oct 2021 13:36:58 +0800	[thread overview]
Message-ID: <202110141337.zNVPEAKN-lkp@intel.com> (raw)
In-Reply-To: <20211013204435.322561-2-kuba@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 4082 bytes --]

Hi Jakub,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Jakub-Kicinski/ethernet-more-netdev-dev_addr-write-removals/20211014-045931
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 5f3b8acee9fee04ece54376a4f842847000a97f3
config: sparc64-randconfig-s032-20211013 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/6ead16677b0e7c54f6a7679276c70ffa1bbc17f3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jakub-Kicinski/ethernet-more-netdev-dev_addr-write-removals/20211014-045931
        git checkout 6ead16677b0e7c54f6a7679276c70ffa1bbc17f3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=sparc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/qlogic/qed/qed_l2.c: In function 'qed_req_bulletin_update_mac':
>> drivers/net/ethernet/qlogic/qed/qed_l2.c:2861:61: warning: passing argument 2 of 'qed_vf_pf_bulletin_update_mac' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    2861 |                 ret = qed_vf_pf_bulletin_update_mac(p_hwfn, mac);
         |                                                             ^~~
   In file included from drivers/net/ethernet/qlogic/qed/qed_sriov.h:10,
                    from drivers/net/ethernet/qlogic/qed/qed_l2.c:39:
   drivers/net/ethernet/qlogic/qed/qed_vf.h:1262:53: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'const u8 *' {aka 'const unsigned char *'}
    1262 |                                                 u8 *p_mac)
         |                                                 ~~~~^~~~~


sparse warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/qlogic/qed/qed_l2.c:2861:61: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected unsigned char [usertype] *p_mac @@     got unsigned char const [usertype] *mac @@
   drivers/net/ethernet/qlogic/qed/qed_l2.c:2861:61: sparse:     expected unsigned char [usertype] *p_mac
   drivers/net/ethernet/qlogic/qed/qed_l2.c:2861:61: sparse:     got unsigned char const [usertype] *mac

vim +2861 drivers/net/ethernet/qlogic/qed/qed_l2.c

cee4d26448c100 Manish Chopra  2015-10-26  2850  
6ead16677b0e7c Jakub Kicinski 2021-10-13  2851  static int qed_req_bulletin_update_mac(struct qed_dev *cdev, const u8 *mac)
809c45a091d93e Shahed Shaikh  2018-04-19  2852  {
809c45a091d93e Shahed Shaikh  2018-04-19  2853  	int i, ret;
809c45a091d93e Shahed Shaikh  2018-04-19  2854  
809c45a091d93e Shahed Shaikh  2018-04-19  2855  	if (IS_PF(cdev))
809c45a091d93e Shahed Shaikh  2018-04-19  2856  		return 0;
809c45a091d93e Shahed Shaikh  2018-04-19  2857  
809c45a091d93e Shahed Shaikh  2018-04-19  2858  	for_each_hwfn(cdev, i) {
809c45a091d93e Shahed Shaikh  2018-04-19  2859  		struct qed_hwfn *p_hwfn = &cdev->hwfns[i];
809c45a091d93e Shahed Shaikh  2018-04-19  2860  
809c45a091d93e Shahed Shaikh  2018-04-19 @2861  		ret = qed_vf_pf_bulletin_update_mac(p_hwfn, mac);
809c45a091d93e Shahed Shaikh  2018-04-19  2862  		if (ret)
809c45a091d93e Shahed Shaikh  2018-04-19  2863  			return ret;
809c45a091d93e Shahed Shaikh  2018-04-19  2864  	}
809c45a091d93e Shahed Shaikh  2018-04-19  2865  
809c45a091d93e Shahed Shaikh  2018-04-19  2866  	return 0;
809c45a091d93e Shahed Shaikh  2018-04-19  2867  }
809c45a091d93e Shahed Shaikh  2018-04-19  2868  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35693 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH net-next 1/7] ethernet: constify references to netdev->dev_addr in drivers
Date: Thu, 14 Oct 2021 13:36:58 +0800	[thread overview]
Message-ID: <202110141337.zNVPEAKN-lkp@intel.com> (raw)
In-Reply-To: <20211013204435.322561-2-kuba@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 4152 bytes --]

Hi Jakub,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Jakub-Kicinski/ethernet-more-netdev-dev_addr-write-removals/20211014-045931
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 5f3b8acee9fee04ece54376a4f842847000a97f3
config: sparc64-randconfig-s032-20211013 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/6ead16677b0e7c54f6a7679276c70ffa1bbc17f3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jakub-Kicinski/ethernet-more-netdev-dev_addr-write-removals/20211014-045931
        git checkout 6ead16677b0e7c54f6a7679276c70ffa1bbc17f3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=sparc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/qlogic/qed/qed_l2.c: In function 'qed_req_bulletin_update_mac':
>> drivers/net/ethernet/qlogic/qed/qed_l2.c:2861:61: warning: passing argument 2 of 'qed_vf_pf_bulletin_update_mac' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    2861 |                 ret = qed_vf_pf_bulletin_update_mac(p_hwfn, mac);
         |                                                             ^~~
   In file included from drivers/net/ethernet/qlogic/qed/qed_sriov.h:10,
                    from drivers/net/ethernet/qlogic/qed/qed_l2.c:39:
   drivers/net/ethernet/qlogic/qed/qed_vf.h:1262:53: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'const u8 *' {aka 'const unsigned char *'}
    1262 |                                                 u8 *p_mac)
         |                                                 ~~~~^~~~~


sparse warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/qlogic/qed/qed_l2.c:2861:61: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected unsigned char [usertype] *p_mac @@     got unsigned char const [usertype] *mac @@
   drivers/net/ethernet/qlogic/qed/qed_l2.c:2861:61: sparse:     expected unsigned char [usertype] *p_mac
   drivers/net/ethernet/qlogic/qed/qed_l2.c:2861:61: sparse:     got unsigned char const [usertype] *mac

vim +2861 drivers/net/ethernet/qlogic/qed/qed_l2.c

cee4d26448c100 Manish Chopra  2015-10-26  2850  
6ead16677b0e7c Jakub Kicinski 2021-10-13  2851  static int qed_req_bulletin_update_mac(struct qed_dev *cdev, const u8 *mac)
809c45a091d93e Shahed Shaikh  2018-04-19  2852  {
809c45a091d93e Shahed Shaikh  2018-04-19  2853  	int i, ret;
809c45a091d93e Shahed Shaikh  2018-04-19  2854  
809c45a091d93e Shahed Shaikh  2018-04-19  2855  	if (IS_PF(cdev))
809c45a091d93e Shahed Shaikh  2018-04-19  2856  		return 0;
809c45a091d93e Shahed Shaikh  2018-04-19  2857  
809c45a091d93e Shahed Shaikh  2018-04-19  2858  	for_each_hwfn(cdev, i) {
809c45a091d93e Shahed Shaikh  2018-04-19  2859  		struct qed_hwfn *p_hwfn = &cdev->hwfns[i];
809c45a091d93e Shahed Shaikh  2018-04-19  2860  
809c45a091d93e Shahed Shaikh  2018-04-19 @2861  		ret = qed_vf_pf_bulletin_update_mac(p_hwfn, mac);
809c45a091d93e Shahed Shaikh  2018-04-19  2862  		if (ret)
809c45a091d93e Shahed Shaikh  2018-04-19  2863  			return ret;
809c45a091d93e Shahed Shaikh  2018-04-19  2864  	}
809c45a091d93e Shahed Shaikh  2018-04-19  2865  
809c45a091d93e Shahed Shaikh  2018-04-19  2866  	return 0;
809c45a091d93e Shahed Shaikh  2018-04-19  2867  }
809c45a091d93e Shahed Shaikh  2018-04-19  2868  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35693 bytes --]

  reply	other threads:[~2021-10-14  5:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13 20:44 [PATCH net-next 0/7] ethernet: more netdev->dev_addr write removals Jakub Kicinski
2021-10-13 20:44 ` [PATCH net-next 1/7] ethernet: constify references to netdev->dev_addr in drivers Jakub Kicinski
2021-10-14  5:36   ` kernel test robot [this message]
2021-10-14  5:36     ` kernel test robot
2021-10-14  6:15   ` kernel test robot
2021-10-14  6:15     ` kernel test robot
2021-10-13 20:44 ` [PATCH net-next 2/7] ethernet: make eth_hw_addr_random() use dev_addr_set() Jakub Kicinski
2021-10-13 20:44 ` [PATCH net-next 3/7] ethernet: make use of eth_hw_addr_random() where appropriate Jakub Kicinski
2021-10-13 20:44   ` Jakub Kicinski
2021-10-13 23:50   ` Linus Walleij
2021-10-13 23:50     ` Linus Walleij
2021-10-13 20:44 ` [PATCH net-next 4/7] ethernet: manually convert memcpy(dev_addr,..., sizeof(addr)) Jakub Kicinski
2021-10-14  2:27   ` Florian Fainelli
2021-10-14  7:43   ` Petko Manolov
2021-10-14  8:14   ` Nicolas Ferre
2021-10-13 20:44 ` [PATCH net-next 5/7] ethernet: ibm/emac: use of_get_ethdev_address() to load dev_addr Jakub Kicinski
2021-10-13 20:44 ` [PATCH net-next 6/7] ethernet: replace netdev->dev_addr assignment loops Jakub Kicinski
2021-10-13 20:44 ` [PATCH net-next 7/7] ethernet: replace netdev->dev_addr 16bit writes Jakub Kicinski
2021-10-14  2:28   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202110141337.zNVPEAKN-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=davem@davemloft.net \
    --cc=kbuild-all@lists.01.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.