All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	chris.snook@gmail.com,
	Hans Ulli Kroll <ulli.kroll@googlemail.com>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	Salil Mehta <salil.mehta@huawei.com>,
	subashab@codeaurora.org, stranche@codeaurora.org,
	Michael Walle <michael@walle.cc>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH net-next 3/7] ethernet: make use of eth_hw_addr_random() where appropriate
Date: Thu, 14 Oct 2021 01:50:15 +0200	[thread overview]
Message-ID: <CACRpkdbVqFkNNbJ9RUTJioG3F8Hx=ryvM-uVHV0x5KV8yYUHWQ@mail.gmail.com> (raw)
In-Reply-To: <20211013204435.322561-4-kuba@kernel.org>

On Wed, Oct 13, 2021 at 10:44 PM Jakub Kicinski <kuba@kernel.org> wrote:

> Number of drivers use eth_random_addr(netdev->dev_addr)
> thus writing to netdev->dev_addr directly, and not setting
> the address type. Switch them to eth_hw_addr_random().
>
>   @@
>   expression netdev;
>   @@
>   - eth_random_addr(netdev->dev_addr);
>   + eth_hw_addr_random(netdev);
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Oh this is better.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	chris.snook@gmail.com,
	Hans Ulli Kroll <ulli.kroll@googlemail.com>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	 Salil Mehta <salil.mehta@huawei.com>,
	subashab@codeaurora.org, stranche@codeaurora.org,
	Michael Walle <michael@walle.cc>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH net-next 3/7] ethernet: make use of eth_hw_addr_random() where appropriate
Date: Thu, 14 Oct 2021 01:50:15 +0200	[thread overview]
Message-ID: <CACRpkdbVqFkNNbJ9RUTJioG3F8Hx=ryvM-uVHV0x5KV8yYUHWQ@mail.gmail.com> (raw)
In-Reply-To: <20211013204435.322561-4-kuba@kernel.org>

On Wed, Oct 13, 2021 at 10:44 PM Jakub Kicinski <kuba@kernel.org> wrote:

> Number of drivers use eth_random_addr(netdev->dev_addr)
> thus writing to netdev->dev_addr directly, and not setting
> the address type. Switch them to eth_hw_addr_random().
>
>   @@
>   expression netdev;
>   @@
>   - eth_random_addr(netdev->dev_addr);
>   + eth_hw_addr_random(netdev);
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Oh this is better.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-13 23:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13 20:44 [PATCH net-next 0/7] ethernet: more netdev->dev_addr write removals Jakub Kicinski
2021-10-13 20:44 ` [PATCH net-next 1/7] ethernet: constify references to netdev->dev_addr in drivers Jakub Kicinski
2021-10-14  5:36   ` kernel test robot
2021-10-14  5:36     ` kernel test robot
2021-10-14  6:15   ` kernel test robot
2021-10-14  6:15     ` kernel test robot
2021-10-13 20:44 ` [PATCH net-next 2/7] ethernet: make eth_hw_addr_random() use dev_addr_set() Jakub Kicinski
2021-10-13 20:44 ` [PATCH net-next 3/7] ethernet: make use of eth_hw_addr_random() where appropriate Jakub Kicinski
2021-10-13 20:44   ` Jakub Kicinski
2021-10-13 23:50   ` Linus Walleij [this message]
2021-10-13 23:50     ` Linus Walleij
2021-10-13 20:44 ` [PATCH net-next 4/7] ethernet: manually convert memcpy(dev_addr,..., sizeof(addr)) Jakub Kicinski
2021-10-14  2:27   ` Florian Fainelli
2021-10-14  7:43   ` Petko Manolov
2021-10-14  8:14   ` Nicolas Ferre
2021-10-13 20:44 ` [PATCH net-next 5/7] ethernet: ibm/emac: use of_get_ethdev_address() to load dev_addr Jakub Kicinski
2021-10-13 20:44 ` [PATCH net-next 6/7] ethernet: replace netdev->dev_addr assignment loops Jakub Kicinski
2021-10-13 20:44 ` [PATCH net-next 7/7] ethernet: replace netdev->dev_addr 16bit writes Jakub Kicinski
2021-10-14  2:28   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdbVqFkNNbJ9RUTJioG3F8Hx=ryvM-uVHV0x5KV8yYUHWQ@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=chris.snook@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=netdev@vger.kernel.org \
    --cc=salil.mehta@huawei.com \
    --cc=stranche@codeaurora.org \
    --cc=subashab@codeaurora.org \
    --cc=ulli.kroll@googlemail.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.