* [PATCH 1/1] RDMA/irdma: remove the unused spin lock in struct irdma_qp_uk
@ 2021-10-21 23:06 yanjun.zhu
2021-10-22 23:16 ` Saleem, Shiraz
2021-10-25 17:52 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: yanjun.zhu @ 2021-10-21 23:06 UTC (permalink / raw)
To: mustafa.ismail, shiraz.saleem, dledford, jgg, linux-rdma,
yanjun.zhu, leon
From: Zhu Yanjun <yanjun.zhu@linux.dev>
The spin lock in struct irdma_qp_uk is not used. So remove it.
Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
drivers/infiniband/hw/irdma/user.h | 1 -
drivers/infiniband/hw/irdma/verbs.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/infiniband/hw/irdma/user.h b/drivers/infiniband/hw/irdma/user.h
index 3dcbb1fbf2c6..e0e9512ad3d5 100644
--- a/drivers/infiniband/hw/irdma/user.h
+++ b/drivers/infiniband/hw/irdma/user.h
@@ -369,7 +369,6 @@ struct irdma_qp_uk {
bool rq_flush_complete:1; /* Indicates flush was seen and RQ was empty after the flush */
bool destroy_pending:1; /* Indicates the QP is being destroyed */
void *back_qp;
- spinlock_t *lock;
u8 dbg_rq_flushed;
u8 sq_flush_seen;
u8 rq_flush_seen;
diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c
index 7110ebf834f9..02ca1f80968e 100644
--- a/drivers/infiniband/hw/irdma/verbs.c
+++ b/drivers/infiniband/hw/irdma/verbs.c
@@ -833,7 +833,6 @@ static int irdma_create_qp(struct ib_qp *ibqp,
qp = &iwqp->sc_qp;
qp->qp_uk.back_qp = iwqp;
- qp->qp_uk.lock = &iwqp->lock;
qp->push_idx = IRDMA_INVALID_PUSH_PAGE_INDEX;
iwqp->iwdev = iwdev;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH 1/1] RDMA/irdma: remove the unused spin lock in struct irdma_qp_uk
2021-10-21 23:06 [PATCH 1/1] RDMA/irdma: remove the unused spin lock in struct irdma_qp_uk yanjun.zhu
@ 2021-10-22 23:16 ` Saleem, Shiraz
2021-10-25 17:52 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Saleem, Shiraz @ 2021-10-22 23:16 UTC (permalink / raw)
To: yanjun.zhu, Ismail, Mustafa, dledford, jgg, linux-rdma, leon
> Subject: [PATCH 1/1] RDMA/irdma: remove the unused spin lock in struct
> irdma_qp_uk
>
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> The spin lock in struct irdma_qp_uk is not used. So remove it.
>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
> drivers/infiniband/hw/irdma/user.h | 1 - drivers/infiniband/hw/irdma/verbs.c | 1 -
> 2 files changed, 2 deletions(-)
>
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] RDMA/irdma: remove the unused spin lock in struct irdma_qp_uk
2021-10-21 23:06 [PATCH 1/1] RDMA/irdma: remove the unused spin lock in struct irdma_qp_uk yanjun.zhu
2021-10-22 23:16 ` Saleem, Shiraz
@ 2021-10-25 17:52 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2021-10-25 17:52 UTC (permalink / raw)
To: yanjun.zhu; +Cc: mustafa.ismail, shiraz.saleem, dledford, linux-rdma, leon
On Thu, Oct 21, 2021 at 07:06:12PM -0400, yanjun.zhu@linux.dev wrote:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> The spin lock in struct irdma_qp_uk is not used. So remove it.
>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
> ---
> drivers/infiniband/hw/irdma/user.h | 1 -
> drivers/infiniband/hw/irdma/verbs.c | 1 -
> 2 files changed, 2 deletions(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-25 17:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-21 23:06 [PATCH 1/1] RDMA/irdma: remove the unused spin lock in struct irdma_qp_uk yanjun.zhu
2021-10-22 23:16 ` Saleem, Shiraz
2021-10-25 17:52 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.