[PATCH 1/1] RDMA/irdma: remove the unused spin lock in struct irdma_qp_uk

[PATCH 1/1] RDMA/irdma: remove the unused spin lock in struct irdma_qp_uk

[yanjun.zhu]

From: Zhu Yanjun <yanjun.zhu@linux.dev>

The spin lock in struct irdma_qp_uk is not used. So remove it.

Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
 drivers/infiniband/hw/irdma/user.h  | 1 -
 drivers/infiniband/hw/irdma/verbs.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/infiniband/hw/irdma/user.h b/drivers/infiniband/hw/irdma/user.h
index 3dcbb1fbf2c6..e0e9512ad3d5 100644
--- a/drivers/infiniband/hw/irdma/user.h
+++ b/drivers/infiniband/hw/irdma/user.h
@@ -369,7 +369,6 @@ struct irdma_qp_uk {
 	bool rq_flush_complete:1; /* Indicates flush was seen and RQ was empty after the flush */
 	bool destroy_pending:1; /* Indicates the QP is being destroyed */
 	void *back_qp;
-	spinlock_t *lock;
 	u8 dbg_rq_flushed;
 	u8 sq_flush_seen;
 	u8 rq_flush_seen;
diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c
index 7110ebf834f9..02ca1f80968e 100644
--- a/drivers/infiniband/hw/irdma/verbs.c
+++ b/drivers/infiniband/hw/irdma/verbs.c
@@ -833,7 +833,6 @@ static int irdma_create_qp(struct ib_qp *ibqp,
 
 	qp = &iwqp->sc_qp;
 	qp->qp_uk.back_qp = iwqp;
-	qp->qp_uk.lock = &iwqp->lock;
 	qp->push_idx = IRDMA_INVALID_PUSH_PAGE_INDEX;
 
 	iwqp->iwdev = iwdev;
-- 
2.27.0

RE: [PATCH 1/1] RDMA/irdma: remove the unused spin lock in struct irdma_qp_uk

[Saleem, Shiraz]

> Subject: [PATCH 1/1] RDMA/irdma: remove the unused spin lock in struct
> irdma_qp_uk
> 
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
> 
> The spin lock in struct irdma_qp_uk is not used. So remove it.
> 
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
>  drivers/infiniband/hw/irdma/user.h  | 1 -  drivers/infiniband/hw/irdma/verbs.c | 1 -
>  2 files changed, 2 deletions(-)
> 

Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>

Re: [PATCH 1/1] RDMA/irdma: remove the unused spin lock in struct irdma_qp_uk

[Jason Gunthorpe]

On Thu, Oct 21, 2021 at 07:06:12PM -0400, yanjun.zhu@linux.dev wrote:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
> 
> The spin lock in struct irdma_qp_uk is not used. So remove it.
> 
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
> ---
>  drivers/infiniband/hw/irdma/user.h  | 1 -
>  drivers/infiniband/hw/irdma/verbs.c | 1 -
>  2 files changed, 2 deletions(-)

Applied to for-next, thanks

Jason