* [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY
@ 2021-10-26 21:09 ` Qian Cai
0 siblings, 0 replies; 12+ messages in thread
From: Qian Cai @ 2021-10-26 21:09 UTC (permalink / raw)
To: Marc Zyngier
Cc: Will Deacon, Qian Cai, linux-kernel, kvmarm, Catalin Marinas,
linux-arm-kernel
TRNG_NO_ENTROPY was unused when introduced and now. This is also caught by
GCC (W=2):
arch/arm64/kvm/trng.c:17: warning: macro "TRNG_NO_ENTROPY" is not used [-Wunused-macros]
17 | #define TRNG_NO_ENTROPY ((unsigned long)-3)
Signed-off-by: Qian Cai <quic_qiancai@quicinc.com>
---
arch/arm64/kvm/trng.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/kvm/trng.c b/arch/arm64/kvm/trng.c
index 99bdd7103c9c..6a46b3ac3970 100644
--- a/arch/arm64/kvm/trng.c
+++ b/arch/arm64/kvm/trng.c
@@ -14,7 +14,6 @@
#define TRNG_SUCCESS 0UL
#define TRNG_NOT_SUPPORTED ((unsigned long)-1)
#define TRNG_INVALID_PARAMETER ((unsigned long)-2)
-#define TRNG_NO_ENTROPY ((unsigned long)-3)
#define TRNG_MAX_BITS64 192
--
2.30.2
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY
@ 2021-10-26 21:09 ` Qian Cai
0 siblings, 0 replies; 12+ messages in thread
From: Qian Cai @ 2021-10-26 21:09 UTC (permalink / raw)
To: Marc Zyngier
Cc: James Morse, Ard Biesheuvel, Alexandru Elisei, Suzuki K Poulose,
Catalin Marinas, Will Deacon, linux-arm-kernel, kvmarm,
linux-kernel, Qian Cai
TRNG_NO_ENTROPY was unused when introduced and now. This is also caught by
GCC (W=2):
arch/arm64/kvm/trng.c:17: warning: macro "TRNG_NO_ENTROPY" is not used [-Wunused-macros]
17 | #define TRNG_NO_ENTROPY ((unsigned long)-3)
Signed-off-by: Qian Cai <quic_qiancai@quicinc.com>
---
arch/arm64/kvm/trng.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/kvm/trng.c b/arch/arm64/kvm/trng.c
index 99bdd7103c9c..6a46b3ac3970 100644
--- a/arch/arm64/kvm/trng.c
+++ b/arch/arm64/kvm/trng.c
@@ -14,7 +14,6 @@
#define TRNG_SUCCESS 0UL
#define TRNG_NOT_SUPPORTED ((unsigned long)-1)
#define TRNG_INVALID_PARAMETER ((unsigned long)-2)
-#define TRNG_NO_ENTROPY ((unsigned long)-3)
#define TRNG_MAX_BITS64 192
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY
2021-10-26 21:09 ` Qian Cai
(?)
@ 2021-10-27 7:37 ` Will Deacon
-1 siblings, 0 replies; 12+ messages in thread
From: Will Deacon @ 2021-10-27 7:37 UTC (permalink / raw)
To: Qian Cai
Cc: Marc Zyngier, James Morse, Ard Biesheuvel, Alexandru Elisei,
Suzuki K Poulose, Catalin Marinas, linux-arm-kernel, kvmarm,
linux-kernel
On Tue, Oct 26, 2021 at 05:09:13PM -0400, Qian Cai wrote:
> TRNG_NO_ENTROPY was unused when introduced and now. This is also caught by
> GCC (W=2):
>
> arch/arm64/kvm/trng.c:17: warning: macro "TRNG_NO_ENTROPY" is not used [-Wunused-macros]
> 17 | #define TRNG_NO_ENTROPY ((unsigned long)-3)
This return value is defined by the TRNG SMCCC spec (Arm DEN0098) so I'd
rather just keep it around given that it's not causing any problems.
Will
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY
@ 2021-10-27 7:37 ` Will Deacon
0 siblings, 0 replies; 12+ messages in thread
From: Will Deacon @ 2021-10-27 7:37 UTC (permalink / raw)
To: Qian Cai
Cc: Marc Zyngier, James Morse, Ard Biesheuvel, Alexandru Elisei,
Suzuki K Poulose, Catalin Marinas, linux-arm-kernel, kvmarm,
linux-kernel
On Tue, Oct 26, 2021 at 05:09:13PM -0400, Qian Cai wrote:
> TRNG_NO_ENTROPY was unused when introduced and now. This is also caught by
> GCC (W=2):
>
> arch/arm64/kvm/trng.c:17: warning: macro "TRNG_NO_ENTROPY" is not used [-Wunused-macros]
> 17 | #define TRNG_NO_ENTROPY ((unsigned long)-3)
This return value is defined by the TRNG SMCCC spec (Arm DEN0098) so I'd
rather just keep it around given that it's not causing any problems.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY
@ 2021-10-27 7:37 ` Will Deacon
0 siblings, 0 replies; 12+ messages in thread
From: Will Deacon @ 2021-10-27 7:37 UTC (permalink / raw)
To: Qian Cai
Cc: Marc Zyngier, linux-kernel, kvmarm, Catalin Marinas, linux-arm-kernel
On Tue, Oct 26, 2021 at 05:09:13PM -0400, Qian Cai wrote:
> TRNG_NO_ENTROPY was unused when introduced and now. This is also caught by
> GCC (W=2):
>
> arch/arm64/kvm/trng.c:17: warning: macro "TRNG_NO_ENTROPY" is not used [-Wunused-macros]
> 17 | #define TRNG_NO_ENTROPY ((unsigned long)-3)
This return value is defined by the TRNG SMCCC spec (Arm DEN0098) so I'd
rather just keep it around given that it's not causing any problems.
Will
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY
2021-10-26 21:09 ` Qian Cai
(?)
@ 2021-10-27 7:46 ` Marc Zyngier
-1 siblings, 0 replies; 12+ messages in thread
From: Marc Zyngier @ 2021-10-27 7:46 UTC (permalink / raw)
To: Qian Cai
Cc: James Morse, Ard Biesheuvel, Alexandru Elisei, Suzuki K Poulose,
Catalin Marinas, Will Deacon, linux-arm-kernel, kvmarm,
linux-kernel
On 2021-10-26 22:09, Qian Cai wrote:
> TRNG_NO_ENTROPY was unused when introduced and now. This is also caught
> by
> GCC (W=2):
>
> arch/arm64/kvm/trng.c:17: warning: macro "TRNG_NO_ENTROPY" is not used
> [-Wunused-macros]
> 17 | #define TRNG_NO_ENTROPY ((unsigned long)-3)
>
> Signed-off-by: Qian Cai <quic_qiancai@quicinc.com>
> ---
> arch/arm64/kvm/trng.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/kvm/trng.c b/arch/arm64/kvm/trng.c
> index 99bdd7103c9c..6a46b3ac3970 100644
> --- a/arch/arm64/kvm/trng.c
> +++ b/arch/arm64/kvm/trng.c
> @@ -14,7 +14,6 @@
> #define TRNG_SUCCESS 0UL
> #define TRNG_NOT_SUPPORTED ((unsigned long)-1)
> #define TRNG_INVALID_PARAMETER ((unsigned long)-2)
> -#define TRNG_NO_ENTROPY ((unsigned long)-3)
>
> #define TRNG_MAX_BITS64 192
That's an architectural definition that doesn't cause any problem.
If anything, that's documentation.
We have *tons* of other definitions with no user all over the
arm64 code. They save the exact same purpose.
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY
@ 2021-10-27 7:46 ` Marc Zyngier
0 siblings, 0 replies; 12+ messages in thread
From: Marc Zyngier @ 2021-10-27 7:46 UTC (permalink / raw)
To: Qian Cai
Cc: James Morse, Ard Biesheuvel, Alexandru Elisei, Suzuki K Poulose,
Catalin Marinas, Will Deacon, linux-arm-kernel, kvmarm,
linux-kernel
On 2021-10-26 22:09, Qian Cai wrote:
> TRNG_NO_ENTROPY was unused when introduced and now. This is also caught
> by
> GCC (W=2):
>
> arch/arm64/kvm/trng.c:17: warning: macro "TRNG_NO_ENTROPY" is not used
> [-Wunused-macros]
> 17 | #define TRNG_NO_ENTROPY ((unsigned long)-3)
>
> Signed-off-by: Qian Cai <quic_qiancai@quicinc.com>
> ---
> arch/arm64/kvm/trng.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/kvm/trng.c b/arch/arm64/kvm/trng.c
> index 99bdd7103c9c..6a46b3ac3970 100644
> --- a/arch/arm64/kvm/trng.c
> +++ b/arch/arm64/kvm/trng.c
> @@ -14,7 +14,6 @@
> #define TRNG_SUCCESS 0UL
> #define TRNG_NOT_SUPPORTED ((unsigned long)-1)
> #define TRNG_INVALID_PARAMETER ((unsigned long)-2)
> -#define TRNG_NO_ENTROPY ((unsigned long)-3)
>
> #define TRNG_MAX_BITS64 192
That's an architectural definition that doesn't cause any problem.
If anything, that's documentation.
We have *tons* of other definitions with no user all over the
arm64 code. They save the exact same purpose.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY
@ 2021-10-27 7:46 ` Marc Zyngier
0 siblings, 0 replies; 12+ messages in thread
From: Marc Zyngier @ 2021-10-27 7:46 UTC (permalink / raw)
To: Qian Cai
Cc: Will Deacon, linux-kernel, kvmarm, Catalin Marinas, linux-arm-kernel
On 2021-10-26 22:09, Qian Cai wrote:
> TRNG_NO_ENTROPY was unused when introduced and now. This is also caught
> by
> GCC (W=2):
>
> arch/arm64/kvm/trng.c:17: warning: macro "TRNG_NO_ENTROPY" is not used
> [-Wunused-macros]
> 17 | #define TRNG_NO_ENTROPY ((unsigned long)-3)
>
> Signed-off-by: Qian Cai <quic_qiancai@quicinc.com>
> ---
> arch/arm64/kvm/trng.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/kvm/trng.c b/arch/arm64/kvm/trng.c
> index 99bdd7103c9c..6a46b3ac3970 100644
> --- a/arch/arm64/kvm/trng.c
> +++ b/arch/arm64/kvm/trng.c
> @@ -14,7 +14,6 @@
> #define TRNG_SUCCESS 0UL
> #define TRNG_NOT_SUPPORTED ((unsigned long)-1)
> #define TRNG_INVALID_PARAMETER ((unsigned long)-2)
> -#define TRNG_NO_ENTROPY ((unsigned long)-3)
>
> #define TRNG_MAX_BITS64 192
That's an architectural definition that doesn't cause any problem.
If anything, that's documentation.
We have *tons* of other definitions with no user all over the
arm64 code. They save the exact same purpose.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY
2021-10-27 7:46 ` Marc Zyngier
(?)
@ 2021-10-27 15:17 ` Qian Cai
-1 siblings, 0 replies; 12+ messages in thread
From: Qian Cai @ 2021-10-27 15:17 UTC (permalink / raw)
To: Marc Zyngier
Cc: James Morse, Ard Biesheuvel, Alexandru Elisei, Suzuki K Poulose,
Catalin Marinas, Will Deacon, linux-arm-kernel, kvmarm,
linux-kernel
On 10/27/21 3:46 AM, Marc Zyngier wrote:
> That's an architectural definition that doesn't cause any problem.
> If anything, that's documentation.
>
> We have *tons* of other definitions with no user all over the
> arm64 code. They save the exact same purpose.
Understood. Thanks for the quick feedback, guys!
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY
@ 2021-10-27 15:17 ` Qian Cai
0 siblings, 0 replies; 12+ messages in thread
From: Qian Cai @ 2021-10-27 15:17 UTC (permalink / raw)
To: Marc Zyngier
Cc: Will Deacon, linux-kernel, kvmarm, Catalin Marinas, linux-arm-kernel
On 10/27/21 3:46 AM, Marc Zyngier wrote:
> That's an architectural definition that doesn't cause any problem.
> If anything, that's documentation.
>
> We have *tons* of other definitions with no user all over the
> arm64 code. They save the exact same purpose.
Understood. Thanks for the quick feedback, guys!
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY
@ 2021-10-27 15:17 ` Qian Cai
0 siblings, 0 replies; 12+ messages in thread
From: Qian Cai @ 2021-10-27 15:17 UTC (permalink / raw)
To: Marc Zyngier
Cc: James Morse, Ard Biesheuvel, Alexandru Elisei, Suzuki K Poulose,
Catalin Marinas, Will Deacon, linux-arm-kernel, kvmarm,
linux-kernel
On 10/27/21 3:46 AM, Marc Zyngier wrote:
> That's an architectural definition that doesn't cause any problem.
> If anything, that's documentation.
>
> We have *tons* of other definitions with no user all over the
> arm64 code. They save the exact same purpose.
Understood. Thanks for the quick feedback, guys!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread