All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Russell King <linux@armlinux.org.uk>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, Sekhar Nori <nsekhar@ti.com>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Linus Walleij <linusw@kernel.org>, Imre Kaloz <kaloz@openwrt.org>,
	Krzysztof Halasa <khalasa@piap.pl>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Dinh Nguyen <dinguyen@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: [PATCH 13/13] arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment
Date: Thu, 28 Oct 2021 16:19:38 +0200	[thread overview]
Message-ID: <20211028141938.3530-14-lukas.bulwahn@gmail.com> (raw)
In-Reply-To: <20211028141938.3530-1-lukas.bulwahn@gmail.com>

Commit 5615f69bc209 ("ARM: 9016/2: Initialize the mapping of KASan shadow
memory") adds some nested ifdef's in ./arch/arm/mm/pgd.c, and follows the
good practice to annotate the endif's with a comment to indicate the
corresponding ifdef condition.

One comment annotation refers to CONFIG_LPAE, whereas the config is
actually called CONFIG_ARM_LPAE. That imprecision in a comment is probably
tolerable for all human readers.

However, the script ./scripts/checkkconfigsymbols.py, which checks the
kernel tree for references to non-existing Kconfig symbols, identifies and
reports that the reference to CONFIG_LPAE is invalid.

The script ./scripts/checkkconfigsymbols.py has been quite useful to
identify a number of bugs with Kconfig symbols and deserves to be executed
and checked regularly.

So, repair the comment to reduce the reports from this script and simplify
to use this script, as new issues are easier to spot when the list of
reports is shorter.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 arch/arm/mm/pgd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mm/pgd.c b/arch/arm/mm/pgd.c
index f8e9bc58a84f..bf2935f21c12 100644
--- a/arch/arm/mm/pgd.c
+++ b/arch/arm/mm/pgd.c
@@ -80,7 +80,7 @@ pgd_t *pgd_alloc(struct mm_struct *mm)
 	       * sizeof(pmd_t));
 	clean_dcache_area(new_pmd, PTRS_PER_PMD * sizeof(pmd_t));
 #endif /* CONFIG_KASAN */
-#endif /* CONFIG_LPAE */
+#endif /* CONFIG_ARM_LPAE */
 
 	if (!vectors_high()) {
 		/*
-- 
2.26.2


WARNING: multiple messages have this Message-ID (diff)
From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Russell King <linux@armlinux.org.uk>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, Sekhar Nori <nsekhar@ti.com>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Linus Walleij <linusw@kernel.org>, Imre Kaloz <kaloz@openwrt.org>,
	Krzysztof Halasa <khalasa@piap.pl>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Dinh Nguyen <dinguyen@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: [PATCH 13/13] arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment
Date: Thu, 28 Oct 2021 16:19:38 +0200	[thread overview]
Message-ID: <20211028141938.3530-14-lukas.bulwahn@gmail.com> (raw)
In-Reply-To: <20211028141938.3530-1-lukas.bulwahn@gmail.com>

Commit 5615f69bc209 ("ARM: 9016/2: Initialize the mapping of KASan shadow
memory") adds some nested ifdef's in ./arch/arm/mm/pgd.c, and follows the
good practice to annotate the endif's with a comment to indicate the
corresponding ifdef condition.

One comment annotation refers to CONFIG_LPAE, whereas the config is
actually called CONFIG_ARM_LPAE. That imprecision in a comment is probably
tolerable for all human readers.

However, the script ./scripts/checkkconfigsymbols.py, which checks the
kernel tree for references to non-existing Kconfig symbols, identifies and
reports that the reference to CONFIG_LPAE is invalid.

The script ./scripts/checkkconfigsymbols.py has been quite useful to
identify a number of bugs with Kconfig symbols and deserves to be executed
and checked regularly.

So, repair the comment to reduce the reports from this script and simplify
to use this script, as new issues are easier to spot when the list of
reports is shorter.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 arch/arm/mm/pgd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mm/pgd.c b/arch/arm/mm/pgd.c
index f8e9bc58a84f..bf2935f21c12 100644
--- a/arch/arm/mm/pgd.c
+++ b/arch/arm/mm/pgd.c
@@ -80,7 +80,7 @@ pgd_t *pgd_alloc(struct mm_struct *mm)
 	       * sizeof(pmd_t));
 	clean_dcache_area(new_pmd, PTRS_PER_PMD * sizeof(pmd_t));
 #endif /* CONFIG_KASAN */
-#endif /* CONFIG_LPAE */
+#endif /* CONFIG_ARM_LPAE */
 
 	if (!vectors_high()) {
 		/*
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Russell King <linux@armlinux.org.uk>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, Sekhar Nori <nsekhar@ti.com>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Linus Walleij <linusw@kernel.org>, Imre Kaloz <kaloz@openwrt.org>,
	Krzysztof Halasa <khalasa@piap.pl>,
	Avi Fishman <avifishman70@gmail.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Tali Perry <tali.perry1@gmail.com>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Benjamin Fair <benjaminfair@google.com>,
	Dinh Nguyen <dinguyen@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 13/13] arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment
Date: Thu, 28 Oct 2021 16:19:38 +0200	[thread overview]
Message-ID: <20211028141938.3530-14-lukas.bulwahn@gmail.com> (raw)
In-Reply-To: <20211028141938.3530-1-lukas.bulwahn@gmail.com>

Commit 5615f69bc209 ("ARM: 9016/2: Initialize the mapping of KASan shadow
memory") adds some nested ifdef's in ./arch/arm/mm/pgd.c, and follows the
good practice to annotate the endif's with a comment to indicate the
corresponding ifdef condition.

One comment annotation refers to CONFIG_LPAE, whereas the config is
actually called CONFIG_ARM_LPAE. That imprecision in a comment is probably
tolerable for all human readers.

However, the script ./scripts/checkkconfigsymbols.py, which checks the
kernel tree for references to non-existing Kconfig symbols, identifies and
reports that the reference to CONFIG_LPAE is invalid.

The script ./scripts/checkkconfigsymbols.py has been quite useful to
identify a number of bugs with Kconfig symbols and deserves to be executed
and checked regularly.

So, repair the comment to reduce the reports from this script and simplify
to use this script, as new issues are easier to spot when the list of
reports is shorter.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 arch/arm/mm/pgd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mm/pgd.c b/arch/arm/mm/pgd.c
index f8e9bc58a84f..bf2935f21c12 100644
--- a/arch/arm/mm/pgd.c
+++ b/arch/arm/mm/pgd.c
@@ -80,7 +80,7 @@ pgd_t *pgd_alloc(struct mm_struct *mm)
 	       * sizeof(pmd_t));
 	clean_dcache_area(new_pmd, PTRS_PER_PMD * sizeof(pmd_t));
 #endif /* CONFIG_KASAN */
-#endif /* CONFIG_LPAE */
+#endif /* CONFIG_ARM_LPAE */
 
 	if (!vectors_high()) {
 		/*
-- 
2.26.2


  parent reply	other threads:[~2021-10-28 14:20 UTC|newest]

Thread overview: 131+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28 14:19 [PATCH 00/13] Kconfig symbol clean-up on ./arch/arm{64} Lukas Bulwahn
2021-10-28 14:19 ` Lukas Bulwahn
2021-10-28 14:19 ` Lukas Bulwahn
2021-10-28 14:19 ` [PATCH 01/13] arm: debug: remove obsolete debug code for DEBUG_ZTE_ZX Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:38   ` Arnd Bergmann
2021-10-28 14:38     ` Arnd Bergmann
2021-10-28 14:38     ` Arnd Bergmann
2021-10-29  5:34     ` Lukas Bulwahn
2021-10-29  5:34       ` Lukas Bulwahn
2021-10-29  5:34       ` Lukas Bulwahn
2021-10-29  6:10       ` Arnd Bergmann
2021-10-29  6:10         ` Arnd Bergmann
2021-10-29  6:10         ` Arnd Bergmann
2021-10-28 14:19 ` [PATCH 02/13] arm: debug: reuse the config DEBUG_OMAP2UART{1,2} for OMAP{3,4,5} Lukas Bulwahn
2021-10-28 14:19   ` [PATCH 02/13] arm: debug: reuse the config DEBUG_OMAP2UART{1, 2} for OMAP{3, 4, 5} Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:39   ` [PATCH 02/13] arm: debug: reuse the config DEBUG_OMAP2UART{1,2} for OMAP{3,4,5} Arnd Bergmann
2021-10-28 14:39     ` Arnd Bergmann
2021-10-28 14:39     ` Arnd Bergmann
2021-10-28 14:19 ` [PATCH 03/13] arm: Kconfig.debug: drop reference to removed ARCH_MSM Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:42   ` Arnd Bergmann
2021-10-28 14:42     ` Arnd Bergmann
2021-10-28 14:42     ` Arnd Bergmann
2021-11-02  7:55     ` Lukas Bulwahn
2021-11-02  7:55       ` Lukas Bulwahn
2021-11-02  7:55       ` Lukas Bulwahn
2021-10-28 14:19 ` [PATCH 04/13] arm: drop an obsolete ifdef with the removed config PCI_HOST_ITE8152 Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:46   ` Arnd Bergmann
2021-10-28 14:46     ` Arnd Bergmann
2021-10-28 14:46     ` Arnd Bergmann
2021-10-28 15:35     ` Russell King (Oracle)
2021-10-28 15:35       ` Russell King (Oracle)
2021-10-28 15:35       ` Russell King (Oracle)
2021-10-29  5:53       ` Lukas Bulwahn
2021-10-29  5:53         ` Lukas Bulwahn
2021-10-29  5:53         ` Lukas Bulwahn
2021-10-28 14:19 ` [PATCH 05/13] arm: davinci: remove reference to obsolete BLK_DEV_PALMCHIP_BK3710 Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:47   ` Arnd Bergmann
2021-10-28 14:47     ` Arnd Bergmann
2021-10-28 14:47     ` Arnd Bergmann
2021-10-28 14:19 ` [PATCH 06/13] arm: ixp4xx: remove dead configs CPU_IXP43X and CPU_IXP46X Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:47   ` Arnd Bergmann
2021-10-28 14:47     ` Arnd Bergmann
2021-10-28 14:47     ` Arnd Bergmann
2021-11-10  8:27   ` Linus Walleij
2021-11-10  8:27     ` Linus Walleij
2021-11-10  8:27     ` Linus Walleij
2021-10-28 14:19 ` [PATCH 07/13] arm: imx: remove dead left-over from i.MX{27,31,35} removal Lukas Bulwahn
2021-10-28 14:19   ` [PATCH 07/13] arm: imx: remove dead left-over from i.MX{27, 31, 35} removal Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:48   ` [PATCH 07/13] arm: imx: remove dead left-over from i.MX{27,31,35} removal Arnd Bergmann
2021-10-28 14:48     ` [PATCH 07/13] arm: imx: remove dead left-over from i.MX{27, 31, 35} removal Arnd Bergmann
2021-10-28 14:48     ` Arnd Bergmann
2021-11-21  8:43   ` [PATCH 07/13] arm: imx: remove dead left-over from i.MX{27,31,35} removal Shawn Guo
2021-11-21  8:43     ` Shawn Guo
2021-11-21  8:43     ` Shawn Guo
2021-10-28 14:19 ` [PATCH 08/13] arm: imx: rename DEBUG_IMX21_IMX27_UART to DEBUG_IMX27_UART Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:49   ` Arnd Bergmann
2021-10-28 14:49     ` Arnd Bergmann
2021-10-28 14:49     ` Arnd Bergmann
2021-11-21  8:47   ` Shawn Guo
2021-11-21  8:47     ` Shawn Guo
2021-11-21  8:47     ` Shawn Guo
2021-10-28 14:19 ` [PATCH 09/13] arm: milbeaut: remove select of non-existing PINCTRL_MILBEAUT Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:55   ` Arnd Bergmann
2021-10-28 14:55     ` Arnd Bergmann
2021-10-28 14:55     ` Arnd Bergmann
2021-11-01 13:53     ` Sugaya Taichi
2021-11-01 13:53       ` Sugaya Taichi
2021-10-28 14:19 ` [PATCH 10/13] arm: nomadik: drop selecting obsolete CLKSRC_NOMADIK_MTU_SCHED_CLOCK Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:55   ` Arnd Bergmann
2021-10-28 14:55     ` Arnd Bergmann
2021-10-28 14:55     ` Arnd Bergmann
2021-11-10  8:28   ` Linus Walleij
2021-11-10  8:28     ` Linus Walleij
2021-11-10  8:28     ` Linus Walleij
2021-10-28 14:19 ` [PATCH 11/13] arm: npcm: drop selecting non-existing ARM_ERRATA_794072 Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:56   ` Arnd Bergmann
2021-10-28 14:56     ` Arnd Bergmann
2021-10-28 14:56     ` Arnd Bergmann
2021-10-29  6:36     ` Joel Stanley
2021-10-29  6:36       ` Joel Stanley
2021-10-29  6:36       ` Joel Stanley
2021-11-02  7:31       ` Lukas Bulwahn
2021-11-02  7:31         ` Lukas Bulwahn
2021-11-02  7:31         ` Lukas Bulwahn
2021-11-02  8:10         ` Arnd Bergmann
2021-11-02  8:10           ` Arnd Bergmann
2021-11-02  8:10           ` Arnd Bergmann
2021-11-02 12:14           ` Lukas Bulwahn
2021-11-02 12:14             ` Lukas Bulwahn
2021-11-02 12:14             ` Lukas Bulwahn
2021-11-02  8:22         ` Avi Fishman
2021-11-02  8:22           ` Avi Fishman
2021-11-02  8:22           ` Avi Fishman
2021-11-02  8:33           ` Avi Fishman
2021-11-02  8:33             ` Avi Fishman
2021-11-02  8:33             ` Avi Fishman
2021-10-28 14:19 ` [PATCH 12/13] arm: socfpga: always select PL310_ERRATA_753970 Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:58   ` Arnd Bergmann
2021-10-28 14:58     ` Arnd Bergmann
2021-10-28 14:58     ` Arnd Bergmann
2021-10-28 14:19 ` Lukas Bulwahn [this message]
2021-10-28 14:19   ` [PATCH 13/13] arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment Lukas Bulwahn
2021-10-28 14:19   ` Lukas Bulwahn
2021-10-28 14:58   ` Arnd Bergmann
2021-10-28 14:58     ` Arnd Bergmann
2021-10-28 14:58     ` Arnd Bergmann
2021-11-09  4:52   ` Linus Walleij
2021-11-09  4:52     ` Linus Walleij
2021-11-09  4:52     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211028141938.3530-14-lukas.bulwahn@gmail.com \
    --to=lukas.bulwahn@gmail.com \
    --cc=arnd@arndb.de \
    --cc=avifishman70@gmail.com \
    --cc=benjaminfair@google.com \
    --cc=brgl@bgdev.pl \
    --cc=dinguyen@kernel.org \
    --cc=festevam@gmail.com \
    --cc=kaloz@openwrt.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=khalasa@piap.pl \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=nsekhar@ti.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=tali.perry1@gmail.com \
    --cc=tmaimon77@gmail.com \
    --cc=venture@google.com \
    --cc=yuenn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.