* [Buildroot] [PATCH 1/2] package/netdata: add libcap optional dependency
@ 2021-10-28 16:03 Fabrice Fontaine
2021-10-28 16:03 ` [Buildroot] [PATCH 2/2] package/netdata: disable unit tests Fabrice Fontaine
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Fabrice Fontaine @ 2021-10-28 16:03 UTC (permalink / raw)
To: buildroot; +Cc: Marcin Niestroj, Fabrice Fontaine
libcap is an optional dependency which is enabled by default since the
addition of the package in commit
1d2bb469078b5818aa2390b9868cd632200f17a2
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/netdata/netdata.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/netdata/netdata.mk b/package/netdata/netdata.mk
index 1c20c49dee..d66a9602e2 100644
--- a/package/netdata/netdata.mk
+++ b/package/netdata/netdata.mk
@@ -33,6 +33,13 @@ else
NETDATA_CONF_OPTS += --disable-jsonc
endif
+ifeq ($(BR2_PACKAGE_LIBCAP),y)
+NETDATA_CONF_OPTS += --with-libcap
+NETDATA_DEPENDENCIES += libcap
+else
+NETDATA_CONF_OPTS += --without-libcap
+endif
+
ifeq ($(BR2_PACKAGE_NFACCT),y)
NETDATA_CONF_OPTS += --enable-plugin-nfacct
NETDATA_DEPENDENCIES += nfacct
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Buildroot] [PATCH 2/2] package/netdata: disable unit tests
2021-10-28 16:03 [Buildroot] [PATCH 1/2] package/netdata: add libcap optional dependency Fabrice Fontaine
@ 2021-10-28 16:03 ` Fabrice Fontaine
2021-10-28 21:16 ` Marcin Niestrój
` (2 more replies)
2021-10-28 21:16 ` [Buildroot] [PATCH 1/2] package/netdata: add libcap optional dependency Marcin Niestrój
` (2 subsequent siblings)
3 siblings, 3 replies; 8+ messages in thread
From: Fabrice Fontaine @ 2021-10-28 16:03 UTC (permalink / raw)
To: buildroot; +Cc: Marcin Niestroj, Fabrice Fontaine
Disable unit tests which are enabled by default if cmocka is found since
the addition of the package in commit
1d2bb469078b5818aa2390b9868cd632200f17a2
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/netdata/netdata.mk | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/package/netdata/netdata.mk b/package/netdata/netdata.mk
index d66a9602e2..34365cbf56 100644
--- a/package/netdata/netdata.mk
+++ b/package/netdata/netdata.mk
@@ -10,7 +10,9 @@ NETDATA_LICENSE = GPL-3.0+
NETDATA_LICENSE_FILES = LICENSE
# netdata's source code is released without a generated configure script
NETDATA_AUTORECONF = YES
-NETDATA_CONF_OPTS = --disable-dbengine
+NETDATA_CONF_OPTS = \
+ --disable-dbengine \
+ --disable-unit-tests
NETDATA_DEPENDENCIES = libuv util-linux zlib
ifeq ($(BR2_GCC_ENABLE_LTO),y)
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Buildroot] [PATCH 2/2] package/netdata: disable unit tests
2021-10-28 16:03 ` [Buildroot] [PATCH 2/2] package/netdata: disable unit tests Fabrice Fontaine
@ 2021-10-28 21:16 ` Marcin Niestrój
2021-11-05 16:24 ` Peter Korsgaard
2021-11-08 16:01 ` Peter Korsgaard
2 siblings, 0 replies; 8+ messages in thread
From: Marcin Niestrój @ 2021-10-28 21:16 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Disable unit tests which are enabled by default if cmocka is found since
> the addition of the package in commit
> 1d2bb469078b5818aa2390b9868cd632200f17a2
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/netdata/netdata.mk | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/package/netdata/netdata.mk b/package/netdata/netdata.mk
> index d66a9602e2..34365cbf56 100644
> --- a/package/netdata/netdata.mk
> +++ b/package/netdata/netdata.mk
> @@ -10,7 +10,9 @@ NETDATA_LICENSE = GPL-3.0+
> NETDATA_LICENSE_FILES = LICENSE
> # netdata's source code is released without a generated configure script
> NETDATA_AUTORECONF = YES
> -NETDATA_CONF_OPTS = --disable-dbengine
> +NETDATA_CONF_OPTS = \
> + --disable-dbengine \
> + --disable-unit-tests
> NETDATA_DEPENDENCIES = libuv util-linux zlib
>
> ifeq ($(BR2_GCC_ENABLE_LTO),y)
Reviewed-by: Marcin Niestroj <m.niestroj@grinn-global.com>
--
Marcin Niestrój
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/netdata: disable unit tests
2021-10-28 16:03 ` [Buildroot] [PATCH 2/2] package/netdata: disable unit tests Fabrice Fontaine
2021-10-28 21:16 ` Marcin Niestrój
@ 2021-11-05 16:24 ` Peter Korsgaard
2021-11-08 16:01 ` Peter Korsgaard
2 siblings, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2021-11-05 16:24 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Marcin Niestroj, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Disable unit tests which are enabled by default if cmocka is found since
> the addition of the package in commit
> 1d2bb469078b5818aa2390b9868cd632200f17a2
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 2/2] package/netdata: disable unit tests
2021-10-28 16:03 ` [Buildroot] [PATCH 2/2] package/netdata: disable unit tests Fabrice Fontaine
2021-10-28 21:16 ` Marcin Niestrój
2021-11-05 16:24 ` Peter Korsgaard
@ 2021-11-08 16:01 ` Peter Korsgaard
2 siblings, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2021-11-08 16:01 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Marcin Niestroj, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Disable unit tests which are enabled by default if cmocka is found since
> the addition of the package in commit
> 1d2bb469078b5818aa2390b9868cd632200f17a2
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2021.02.x and 2021.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/netdata: add libcap optional dependency
2021-10-28 16:03 [Buildroot] [PATCH 1/2] package/netdata: add libcap optional dependency Fabrice Fontaine
2021-10-28 16:03 ` [Buildroot] [PATCH 2/2] package/netdata: disable unit tests Fabrice Fontaine
@ 2021-10-28 21:16 ` Marcin Niestrój
2021-11-05 16:23 ` Peter Korsgaard
2021-11-08 16:01 ` Peter Korsgaard
3 siblings, 0 replies; 8+ messages in thread
From: Marcin Niestrój @ 2021-10-28 21:16 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> libcap is an optional dependency which is enabled by default since the
> addition of the package in commit
> 1d2bb469078b5818aa2390b9868cd632200f17a2
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/netdata/netdata.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/netdata/netdata.mk b/package/netdata/netdata.mk
> index 1c20c49dee..d66a9602e2 100644
> --- a/package/netdata/netdata.mk
> +++ b/package/netdata/netdata.mk
> @@ -33,6 +33,13 @@ else
> NETDATA_CONF_OPTS += --disable-jsonc
> endif
>
> +ifeq ($(BR2_PACKAGE_LIBCAP),y)
> +NETDATA_CONF_OPTS += --with-libcap
> +NETDATA_DEPENDENCIES += libcap
> +else
> +NETDATA_CONF_OPTS += --without-libcap
> +endif
> +
> ifeq ($(BR2_PACKAGE_NFACCT),y)
> NETDATA_CONF_OPTS += --enable-plugin-nfacct
> NETDATA_DEPENDENCIES += nfacct
Reviewed-by: Marcin Niestroj <m.niestroj@grinn-global.com>
--
Marcin Niestrój
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/netdata: add libcap optional dependency
2021-10-28 16:03 [Buildroot] [PATCH 1/2] package/netdata: add libcap optional dependency Fabrice Fontaine
2021-10-28 16:03 ` [Buildroot] [PATCH 2/2] package/netdata: disable unit tests Fabrice Fontaine
2021-10-28 21:16 ` [Buildroot] [PATCH 1/2] package/netdata: add libcap optional dependency Marcin Niestrój
@ 2021-11-05 16:23 ` Peter Korsgaard
2021-11-08 16:01 ` Peter Korsgaard
3 siblings, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2021-11-05 16:23 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Marcin Niestroj, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> libcap is an optional dependency which is enabled by default since the
> addition of the package in commit
> 1d2bb469078b5818aa2390b9868cd632200f17a2
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/netdata: add libcap optional dependency
2021-10-28 16:03 [Buildroot] [PATCH 1/2] package/netdata: add libcap optional dependency Fabrice Fontaine
` (2 preceding siblings ...)
2021-11-05 16:23 ` Peter Korsgaard
@ 2021-11-08 16:01 ` Peter Korsgaard
3 siblings, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2021-11-08 16:01 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Marcin Niestroj, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> libcap is an optional dependency which is enabled by default since the
> addition of the package in commit
> 1d2bb469078b5818aa2390b9868cd632200f17a2
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2021.02.x and 2021.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-11-08 16:02 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-28 16:03 [Buildroot] [PATCH 1/2] package/netdata: add libcap optional dependency Fabrice Fontaine
2021-10-28 16:03 ` [Buildroot] [PATCH 2/2] package/netdata: disable unit tests Fabrice Fontaine
2021-10-28 21:16 ` Marcin Niestrój
2021-11-05 16:24 ` Peter Korsgaard
2021-11-08 16:01 ` Peter Korsgaard
2021-10-28 21:16 ` [Buildroot] [PATCH 1/2] package/netdata: add libcap optional dependency Marcin Niestrój
2021-11-05 16:23 ` Peter Korsgaard
2021-11-08 16:01 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.