From: jae.hyun.yoo@intel.com To: Rob Herring <robh+dt@kernel.org>, Corey Minyard <minyard@acm.org>, Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>, Cedric Le Goater <clg@kaod.org>, Haiyue Wang <haiyue.wang@linux.intel.com>, Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, openipmi-developer@lists.sourceforge.net Subject: [PATCH -next 4/4] ipmi: kcs_bmc_aspeed: add clock control logic Date: Mon, 1 Nov 2021 16:37:51 -0700 [thread overview] Message-ID: <20211101233751.49222-5-jae.hyun.yoo@intel.com> (raw) In-Reply-To: <20211101233751.49222-1-jae.hyun.yoo@intel.com> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> If LPC KCS driver is registered ahead of lpc-ctrl module, LPC KCS block will be enabled without heart beating of LCLK until lpc-ctrl enables the LCLK. This issue causes improper handling on host interrupts when the host sends interrupts in that time frame. Then kernel eventually forcibly disables the interrupt with dumping stack and printing a 'nobody cared this irq' message out. To prevent this issue, all LPC sub drivers should enable LCLK individually so this patch adds clock control logic into the LPC KCS driver. Fixes: be2ed207e374 ("ipmi: add an Aspeed KCS IPMI BMC driver") Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> --- drivers/char/ipmi/kcs_bmc_aspeed.c | 31 ++++++++++++++++++++++++++---- 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c index 92a37b33494c..00706472cc4d 100644 --- a/drivers/char/ipmi/kcs_bmc_aspeed.c +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c @@ -6,6 +6,7 @@ #define pr_fmt(fmt) "aspeed-kcs-bmc: " fmt #include <linux/atomic.h> +#include <linux/clk.h> #include <linux/errno.h> #include <linux/interrupt.h> #include <linux/io.h> @@ -126,6 +127,8 @@ struct aspeed_kcs_bmc { bool remove; struct timer_list timer; } obe; + + struct clk *clk; }; struct aspeed_kcs_of_ops { @@ -620,24 +623,37 @@ static int aspeed_kcs_probe(struct platform_device *pdev) return -ENODEV; } + priv->clk = devm_clk_get(&pdev->dev, NULL); + if (IS_ERR(priv->clk)) { + rc = PTR_ERR(priv->clk); + if (rc != -EPROBE_DEFER) + dev_err(&pdev->dev, "Couldn't get clock\n"); + return rc; + } + rc = clk_prepare_enable(priv->clk); + if (rc) { + dev_err(&pdev->dev, "Couldn't enable clock\n"); + return rc; + } + spin_lock_init(&priv->obe.lock); priv->obe.remove = false; timer_setup(&priv->obe.timer, aspeed_kcs_check_obe, 0); rc = aspeed_kcs_set_address(kcs_bmc, addrs, nr_addrs); if (rc) - return rc; + goto err; /* Host to BMC IRQ */ rc = aspeed_kcs_config_downstream_irq(kcs_bmc, pdev); if (rc) - return rc; + goto err; /* BMC to Host IRQ */ if (have_upstream_irq) { rc = aspeed_kcs_config_upstream_irq(priv, upstream_irq[0], upstream_irq[1]); if (rc < 0) - return rc; + goto err; } else { priv->upstream_irq.mode = aspeed_kcs_irq_none; } @@ -650,13 +666,19 @@ static int aspeed_kcs_probe(struct platform_device *pdev) rc = kcs_bmc_add_device(&priv->kcs_bmc); if (rc) { dev_warn(&pdev->dev, "Failed to register channel %d: %d\n", kcs_bmc->channel, rc); - return rc; + goto err; } dev_info(&pdev->dev, "Initialised channel %d at 0x%x\n", kcs_bmc->channel, addrs[0]); return 0; + +err: + aspeed_kcs_enable_channel(kcs_bmc, false); + clk_disable_unprepare(priv->clk); + + return rc; } static int aspeed_kcs_remove(struct platform_device *pdev) @@ -664,6 +686,7 @@ static int aspeed_kcs_remove(struct platform_device *pdev) struct aspeed_kcs_bmc *priv = platform_get_drvdata(pdev); struct kcs_bmc_device *kcs_bmc = &priv->kcs_bmc; + clk_disable_unprepare(priv->clk); kcs_bmc_remove_device(kcs_bmc); aspeed_kcs_enable_channel(kcs_bmc, false); -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: jae.hyun.yoo@intel.com To: Rob Herring <robh+dt@kernel.org>, Corey Minyard <minyard@acm.org>, Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>, Cedric Le Goater <clg@kaod.org>, Haiyue Wang <haiyue.wang@linux.intel.com>, Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, openipmi-developer@lists.sourceforge.net Subject: [PATCH -next 4/4] ipmi: kcs_bmc_aspeed: add clock control logic Date: Mon, 1 Nov 2021 16:37:51 -0700 [thread overview] Message-ID: <20211101233751.49222-5-jae.hyun.yoo@intel.com> (raw) In-Reply-To: <20211101233751.49222-1-jae.hyun.yoo@intel.com> From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> If LPC KCS driver is registered ahead of lpc-ctrl module, LPC KCS block will be enabled without heart beating of LCLK until lpc-ctrl enables the LCLK. This issue causes improper handling on host interrupts when the host sends interrupts in that time frame. Then kernel eventually forcibly disables the interrupt with dumping stack and printing a 'nobody cared this irq' message out. To prevent this issue, all LPC sub drivers should enable LCLK individually so this patch adds clock control logic into the LPC KCS driver. Fixes: be2ed207e374 ("ipmi: add an Aspeed KCS IPMI BMC driver") Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> --- drivers/char/ipmi/kcs_bmc_aspeed.c | 31 ++++++++++++++++++++++++++---- 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c index 92a37b33494c..00706472cc4d 100644 --- a/drivers/char/ipmi/kcs_bmc_aspeed.c +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c @@ -6,6 +6,7 @@ #define pr_fmt(fmt) "aspeed-kcs-bmc: " fmt #include <linux/atomic.h> +#include <linux/clk.h> #include <linux/errno.h> #include <linux/interrupt.h> #include <linux/io.h> @@ -126,6 +127,8 @@ struct aspeed_kcs_bmc { bool remove; struct timer_list timer; } obe; + + struct clk *clk; }; struct aspeed_kcs_of_ops { @@ -620,24 +623,37 @@ static int aspeed_kcs_probe(struct platform_device *pdev) return -ENODEV; } + priv->clk = devm_clk_get(&pdev->dev, NULL); + if (IS_ERR(priv->clk)) { + rc = PTR_ERR(priv->clk); + if (rc != -EPROBE_DEFER) + dev_err(&pdev->dev, "Couldn't get clock\n"); + return rc; + } + rc = clk_prepare_enable(priv->clk); + if (rc) { + dev_err(&pdev->dev, "Couldn't enable clock\n"); + return rc; + } + spin_lock_init(&priv->obe.lock); priv->obe.remove = false; timer_setup(&priv->obe.timer, aspeed_kcs_check_obe, 0); rc = aspeed_kcs_set_address(kcs_bmc, addrs, nr_addrs); if (rc) - return rc; + goto err; /* Host to BMC IRQ */ rc = aspeed_kcs_config_downstream_irq(kcs_bmc, pdev); if (rc) - return rc; + goto err; /* BMC to Host IRQ */ if (have_upstream_irq) { rc = aspeed_kcs_config_upstream_irq(priv, upstream_irq[0], upstream_irq[1]); if (rc < 0) - return rc; + goto err; } else { priv->upstream_irq.mode = aspeed_kcs_irq_none; } @@ -650,13 +666,19 @@ static int aspeed_kcs_probe(struct platform_device *pdev) rc = kcs_bmc_add_device(&priv->kcs_bmc); if (rc) { dev_warn(&pdev->dev, "Failed to register channel %d: %d\n", kcs_bmc->channel, rc); - return rc; + goto err; } dev_info(&pdev->dev, "Initialised channel %d at 0x%x\n", kcs_bmc->channel, addrs[0]); return 0; + +err: + aspeed_kcs_enable_channel(kcs_bmc, false); + clk_disable_unprepare(priv->clk); + + return rc; } static int aspeed_kcs_remove(struct platform_device *pdev) @@ -664,6 +686,7 @@ static int aspeed_kcs_remove(struct platform_device *pdev) struct aspeed_kcs_bmc *priv = platform_get_drvdata(pdev); struct kcs_bmc_device *kcs_bmc = &priv->kcs_bmc; + clk_disable_unprepare(priv->clk); kcs_bmc_remove_device(kcs_bmc); aspeed_kcs_enable_channel(kcs_bmc, false); -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-01 23:18 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-01 23:37 [PATCH -next 0/4] Add LCLK control into Aspeed LPC sub drivers jae.hyun.yoo 2021-11-01 23:37 ` jae.hyun.yoo 2021-11-01 23:36 ` Joel Stanley 2021-11-01 23:36 ` Joel Stanley 2021-11-02 12:22 ` Corey Minyard 2021-11-02 12:22 ` Corey Minyard 2021-11-02 16:38 ` Jae Hyun Yoo 2021-11-02 16:38 ` Jae Hyun Yoo 2021-11-03 0:04 ` Zev Weiss 2021-11-03 0:04 ` Zev Weiss 2021-11-03 0:17 ` Jae Hyun Yoo 2021-11-03 0:17 ` Jae Hyun Yoo 2021-11-03 0:30 ` Zev Weiss 2021-11-03 0:30 ` Zev Weiss 2021-11-03 0:54 ` Jae Hyun Yoo 2021-11-03 0:54 ` Jae Hyun Yoo 2021-11-03 1:09 ` Zev Weiss 2021-11-03 1:09 ` Zev Weiss 2021-11-03 15:56 ` Jae Hyun Yoo 2021-11-03 15:56 ` Jae Hyun Yoo 2021-11-04 1:48 ` Zev Weiss 2021-11-04 1:48 ` Zev Weiss 2021-11-04 16:09 ` Jae Hyun Yoo 2021-11-04 16:09 ` Jae Hyun Yoo 2021-11-01 23:37 ` [PATCH -next 1/4] ARM: dts: aspeed: add LCLK setting into LPC IBT node jae.hyun.yoo 2021-11-01 23:37 ` jae.hyun.yoo 2021-11-01 23:33 ` Joel Stanley 2021-11-01 23:33 ` Joel Stanley 2021-11-01 23:48 ` Jae Hyun Yoo 2021-11-01 23:48 ` Jae Hyun Yoo 2021-11-01 23:52 ` Joel Stanley 2021-11-01 23:52 ` Joel Stanley 2021-11-01 23:59 ` Jae Hyun Yoo 2021-11-01 23:59 ` Jae Hyun Yoo 2021-11-02 22:21 ` Andrew Jeffery 2021-11-02 22:21 ` Andrew Jeffery 2021-11-01 23:37 ` [PATCH -next 2/4] ipmi: bt: add clock control logic jae.hyun.yoo 2021-11-01 23:37 ` jae.hyun.yoo 2021-11-01 23:32 ` Joel Stanley 2021-11-01 23:32 ` Joel Stanley 2021-11-02 9:35 ` Cédric Le Goater 2021-11-02 9:35 ` Cédric Le Goater 2021-11-02 16:36 ` Jae Hyun Yoo 2021-11-02 16:36 ` Jae Hyun Yoo 2021-11-02 22:14 ` Andrew Jeffery 2021-11-02 22:14 ` Andrew Jeffery 2021-11-01 23:37 ` [PATCH -next 3/4] ARM: dts: aspeed: add LCLK setting into LPC KCS nodes jae.hyun.yoo 2021-11-01 23:37 ` jae.hyun.yoo 2021-11-01 23:34 ` Joel Stanley 2021-11-01 23:34 ` Joel Stanley 2021-11-02 22:22 ` Andrew Jeffery 2021-11-02 22:22 ` Andrew Jeffery 2021-11-03 16:15 ` Jae Hyun Yoo 2021-11-03 16:15 ` Jae Hyun Yoo 2021-11-01 23:37 ` jae.hyun.yoo [this message] 2021-11-01 23:37 ` [PATCH -next 4/4] ipmi: kcs_bmc_aspeed: add clock control logic jae.hyun.yoo 2021-11-01 23:33 ` Joel Stanley 2021-11-01 23:33 ` Joel Stanley 2021-11-02 3:15 ` ChiaWei Wang 2021-11-02 3:15 ` ChiaWei Wang 2021-11-02 3:28 ` Joel Stanley 2021-11-02 3:28 ` Joel Stanley 2021-11-02 16:35 ` Jae Hyun Yoo 2021-11-02 16:35 ` Jae Hyun Yoo 2021-11-03 1:55 ` ChiaWei Wang 2021-11-03 1:55 ` ChiaWei Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211101233751.49222-5-jae.hyun.yoo@intel.com \ --to=jae.hyun.yoo@intel.com \ --cc=andrew@aj.id.au \ --cc=clg@kaod.org \ --cc=devicetree@vger.kernel.org \ --cc=haiyue.wang@linux.intel.com \ --cc=jae.hyun.yoo@linux.intel.com \ --cc=joel@jms.id.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=minyard@acm.org \ --cc=openipmi-developer@lists.sourceforge.net \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.