* [PATCH] mpm-transport: Do not use append with += operator
@ 2021-11-04 17:29 Khem Raj
2021-11-04 17:54 ` [meta-ti] " Denys Dmytriyenko
[not found] ` <16B46967FE386BDB.15444@lists.yoctoproject.org>
0 siblings, 2 replies; 5+ messages in thread
From: Khem Raj @ 2021-11-04 17:29 UTC (permalink / raw)
To: meta-ti; +Cc: Khem Raj
this is undefined behaviour, mant times devs used them together to get
the missing space at the beginning of string which append/prepend needs
but thats not intended behaviour
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
recipes-ti/mpm-transport/mpm-transport_git.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/recipes-ti/mpm-transport/mpm-transport_git.bb b/recipes-ti/mpm-transport/mpm-transport_git.bb
index 38aefc24..3b80af34 100644
--- a/recipes-ti/mpm-transport/mpm-transport_git.bb
+++ b/recipes-ti/mpm-transport/mpm-transport_git.bb
@@ -21,8 +21,8 @@ PR = "r0"
CC += "-fcommon"
EXTRA_OEMAKE = "PDK_INSTALL_PATH=${STAGING_INCDIR}"
-EXTRA_OEMAKE:append:k2hk += "HYPLNK_TRANSPORT=true SRIO_TRANSPORT=true"
-EXTRA_OEMAKE:append:k2e += "HYPLNK_TRANSPORT=true"
+EXTRA_OEMAKE:append:k2hk = " HYPLNK_TRANSPORT=true SRIO_TRANSPORT=true"
+EXTRA_OEMAKE:append:k2e = " HYPLNK_TRANSPORT=true"
INSANE_SKIP:${PN} += "ldflags"
S = "${WORKDIR}/git"
--
2.33.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [meta-ti] [PATCH] mpm-transport: Do not use append with += operator
2021-11-04 17:29 [PATCH] mpm-transport: Do not use append with += operator Khem Raj
@ 2021-11-04 17:54 ` Denys Dmytriyenko
[not found] ` <16B46967FE386BDB.15444@lists.yoctoproject.org>
1 sibling, 0 replies; 5+ messages in thread
From: Denys Dmytriyenko @ 2021-11-04 17:54 UTC (permalink / raw)
To: Khem Raj; +Cc: meta-ti
On Thu, Nov 04, 2021 at 10:29:34AM -0700, Khem Raj wrote:
> this is undefined behaviour, mant times devs used them together to get
> the missing space at the beginning of string which append/prepend needs
> but thats not intended behaviour
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Acked-by: Denys Dmytriyenko <denys@konsulko.com>
> ---
> recipes-ti/mpm-transport/mpm-transport_git.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-ti/mpm-transport/mpm-transport_git.bb b/recipes-ti/mpm-transport/mpm-transport_git.bb
> index 38aefc24..3b80af34 100644
> --- a/recipes-ti/mpm-transport/mpm-transport_git.bb
> +++ b/recipes-ti/mpm-transport/mpm-transport_git.bb
> @@ -21,8 +21,8 @@ PR = "r0"
>
> CC += "-fcommon"
> EXTRA_OEMAKE = "PDK_INSTALL_PATH=${STAGING_INCDIR}"
> -EXTRA_OEMAKE:append:k2hk += "HYPLNK_TRANSPORT=true SRIO_TRANSPORT=true"
> -EXTRA_OEMAKE:append:k2e += "HYPLNK_TRANSPORT=true"
> +EXTRA_OEMAKE:append:k2hk = " HYPLNK_TRANSPORT=true SRIO_TRANSPORT=true"
> +EXTRA_OEMAKE:append:k2e = " HYPLNK_TRANSPORT=true"
> INSANE_SKIP:${PN} += "ldflags"
>
> S = "${WORKDIR}/git"
> --
> 2.33.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-ti] [PATCH] mpm-transport: Do not use append with += operator
[not found] ` <16B46967FE386BDB.15444@lists.yoctoproject.org>
@ 2021-11-15 20:24 ` Denys Dmytriyenko
2021-11-15 20:52 ` Yogesh Siraswar
0 siblings, 1 reply; 5+ messages in thread
From: Denys Dmytriyenko @ 2021-11-15 20:24 UTC (permalink / raw)
To: meta-ti
On Thu, Nov 04, 2021 at 01:54:16PM -0400, Denys Dmytriyenko wrote:
> On Thu, Nov 04, 2021 at 10:29:34AM -0700, Khem Raj wrote:
> > this is undefined behaviour, mant times devs used them together to get
> > the missing space at the beginning of string which append/prepend needs
> > but thats not intended behaviour
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
>
> Acked-by: Denys Dmytriyenko <denys@konsulko.com>
Yogesh,
I don't believe this patch has made it into master...
> > ---
> > recipes-ti/mpm-transport/mpm-transport_git.bb | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/recipes-ti/mpm-transport/mpm-transport_git.bb b/recipes-ti/mpm-transport/mpm-transport_git.bb
> > index 38aefc24..3b80af34 100644
> > --- a/recipes-ti/mpm-transport/mpm-transport_git.bb
> > +++ b/recipes-ti/mpm-transport/mpm-transport_git.bb
> > @@ -21,8 +21,8 @@ PR = "r0"
> >
> > CC += "-fcommon"
> > EXTRA_OEMAKE = "PDK_INSTALL_PATH=${STAGING_INCDIR}"
> > -EXTRA_OEMAKE:append:k2hk += "HYPLNK_TRANSPORT=true SRIO_TRANSPORT=true"
> > -EXTRA_OEMAKE:append:k2e += "HYPLNK_TRANSPORT=true"
> > +EXTRA_OEMAKE:append:k2hk = " HYPLNK_TRANSPORT=true SRIO_TRANSPORT=true"
> > +EXTRA_OEMAKE:append:k2e = " HYPLNK_TRANSPORT=true"
> > INSANE_SKIP:${PN} += "ldflags"
> >
> > S = "${WORKDIR}/git"
> > --
> > 2.33.1
> >
--
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186 6D76 4209 0272 9A92 C964
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-ti] [PATCH] mpm-transport: Do not use append with += operator
2021-11-15 20:24 ` Denys Dmytriyenko
@ 2021-11-15 20:52 ` Yogesh Siraswar
2021-11-15 23:09 ` Denys Dmytriyenko
0 siblings, 1 reply; 5+ messages in thread
From: Yogesh Siraswar @ 2021-11-15 20:52 UTC (permalink / raw)
To: Denys Dmytriyenko, meta-ti
On 11/15/2021 2:24 PM, Denys Dmytriyenko wrote:
> On Thu, Nov 04, 2021 at 01:54:16PM -0400, Denys Dmytriyenko wrote:
>> On Thu, Nov 04, 2021 at 10:29:34AM -0700, Khem Raj wrote:
>>> this is undefined behaviour, mant times devs used them together to get
>>> the missing space at the beginning of string which append/prepend needs
>>> but thats not intended behaviour
>>>
>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>
>> Acked-by: Denys Dmytriyenko <denys@konsulko.com>
>
> Yogesh,
>
> I don't believe this patch has made it into master...
Yes, I have not sync master. Is this applicable for dunfell?
>
>
>>> ---
>>> recipes-ti/mpm-transport/mpm-transport_git.bb | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/recipes-ti/mpm-transport/mpm-transport_git.bb b/recipes-ti/mpm-transport/mpm-transport_git.bb
>>> index 38aefc24..3b80af34 100644
>>> --- a/recipes-ti/mpm-transport/mpm-transport_git.bb
>>> +++ b/recipes-ti/mpm-transport/mpm-transport_git.bb
>>> @@ -21,8 +21,8 @@ PR = "r0"
>>>
>>> CC += "-fcommon"
>>> EXTRA_OEMAKE = "PDK_INSTALL_PATH=${STAGING_INCDIR}"
>>> -EXTRA_OEMAKE:append:k2hk += "HYPLNK_TRANSPORT=true SRIO_TRANSPORT=true"
>>> -EXTRA_OEMAKE:append:k2e += "HYPLNK_TRANSPORT=true"
>>> +EXTRA_OEMAKE:append:k2hk = " HYPLNK_TRANSPORT=true SRIO_TRANSPORT=true"
>>> +EXTRA_OEMAKE:append:k2e = " HYPLNK_TRANSPORT=true"
>>> INSANE_SKIP:${PN} += "ldflags"
>>>
>>> S = "${WORKDIR}/git"
>>> --
>>> 2.33.1
>>>
>
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-ti] [PATCH] mpm-transport: Do not use append with += operator
2021-11-15 20:52 ` Yogesh Siraswar
@ 2021-11-15 23:09 ` Denys Dmytriyenko
0 siblings, 0 replies; 5+ messages in thread
From: Denys Dmytriyenko @ 2021-11-15 23:09 UTC (permalink / raw)
To: Siraswar, Yogesh; +Cc: meta-ti
On Mon, Nov 15, 2021 at 02:52:31PM -0600, Siraswar, Yogesh wrote:
>
>
> On 11/15/2021 2:24 PM, Denys Dmytriyenko wrote:
> >On Thu, Nov 04, 2021 at 01:54:16PM -0400, Denys Dmytriyenko wrote:
> >>On Thu, Nov 04, 2021 at 10:29:34AM -0700, Khem Raj wrote:
> >>>this is undefined behaviour, mant times devs used them together to get
> >>>the missing space at the beginning of string which append/prepend needs
> >>>but thats not intended behaviour
> >>>
> >>>Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >>
> >>Acked-by: Denys Dmytriyenko <denys@konsulko.com>
> >
> >Yogesh,
> >
> >I don't believe this patch has made it into master...
>
> Yes, I have not sync master. Is this applicable for dunfell?
This fixes a warning in master, since bitbake now checks for mixing
append/prepend/remove overrides along with +=
In dunfell it's not checked and no warning, but it's still not recommended,
so it's up to you.
> >>>---
> >>> recipes-ti/mpm-transport/mpm-transport_git.bb | 4 ++--
> >>> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>>diff --git a/recipes-ti/mpm-transport/mpm-transport_git.bb b/recipes-ti/mpm-transport/mpm-transport_git.bb
> >>>index 38aefc24..3b80af34 100644
> >>>--- a/recipes-ti/mpm-transport/mpm-transport_git.bb
> >>>+++ b/recipes-ti/mpm-transport/mpm-transport_git.bb
> >>>@@ -21,8 +21,8 @@ PR = "r0"
> >>> CC += "-fcommon"
> >>> EXTRA_OEMAKE = "PDK_INSTALL_PATH=${STAGING_INCDIR}"
> >>>-EXTRA_OEMAKE:append:k2hk += "HYPLNK_TRANSPORT=true SRIO_TRANSPORT=true"
> >>>-EXTRA_OEMAKE:append:k2e += "HYPLNK_TRANSPORT=true"
> >>>+EXTRA_OEMAKE:append:k2hk = " HYPLNK_TRANSPORT=true SRIO_TRANSPORT=true"
> >>>+EXTRA_OEMAKE:append:k2e = " HYPLNK_TRANSPORT=true"
> >>> INSANE_SKIP:${PN} += "ldflags"
> >>> S = "${WORKDIR}/git"
> >>>--
> >>>2.33.1
> >>>
--
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186 6D76 4209 0272 9A92 C964
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-11-15 23:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-04 17:29 [PATCH] mpm-transport: Do not use append with += operator Khem Raj
2021-11-04 17:54 ` [meta-ti] " Denys Dmytriyenko
[not found] ` <16B46967FE386BDB.15444@lists.yoctoproject.org>
2021-11-15 20:24 ` Denys Dmytriyenko
2021-11-15 20:52 ` Yogesh Siraswar
2021-11-15 23:09 ` Denys Dmytriyenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.