* [PATCH 1/9] arm64: dts: renesas: r8a774a1: Fix thermal bindings
2021-11-04 22:40 [PATCH 0/9] arm64: dts: renesas: Thermal binding validation Kieran Bingham
@ 2021-11-04 22:40 ` Kieran Bingham
2021-11-04 22:40 ` [PATCH 2/9] arm64: dts: renesas: r8a774b1: " Kieran Bingham
` (8 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Kieran Bingham @ 2021-11-04 22:40 UTC (permalink / raw)
To: linux-renesas-soc, devicetree, linux-kernel
Cc: Geert Uytterhoeven, Rob Herring, Kieran Bingham
The binding node names for the thermal zones are not successfully
validated by the dt-schemas.
Fix the validation by changing from sensor-thermalN to sensorN-thermal
and sensor_thermalN to sensorN_thermal.
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
index 6f4fffacfca2..e70aa5a08740 100644
--- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
@@ -2784,7 +2784,7 @@ prr: chipid@fff00044 {
};
thermal-zones {
- sensor_thermal1: sensor-thermal1 {
+ sensor1_thermal: sensor1-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 0>;
@@ -2799,7 +2799,7 @@ sensor1_crit: sensor1-crit {
};
};
- sensor_thermal2: sensor-thermal2 {
+ sensor2_thermal: sensor2-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 1>;
@@ -2814,7 +2814,7 @@ sensor2_crit: sensor2-crit {
};
};
- sensor_thermal3: sensor-thermal3 {
+ sensor3_thermal: sensor3-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 2>;
--
2.30.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 2/9] arm64: dts: renesas: r8a774b1: Fix thermal bindings
2021-11-04 22:40 [PATCH 0/9] arm64: dts: renesas: Thermal binding validation Kieran Bingham
2021-11-04 22:40 ` [PATCH 1/9] arm64: dts: renesas: r8a774a1: Fix thermal bindings Kieran Bingham
@ 2021-11-04 22:40 ` Kieran Bingham
2021-11-04 22:40 ` [PATCH 3/9] arm64: dts: renesas: r8a774e1: " Kieran Bingham
` (7 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Kieran Bingham @ 2021-11-04 22:40 UTC (permalink / raw)
To: linux-renesas-soc, devicetree, linux-kernel
Cc: Geert Uytterhoeven, Rob Herring, Kieran Bingham
The binding node names for the thermal zones are not successfully
validated by the dt-schemas.
Fix the validation by changing from sensor-thermalN to sensorN-thermal
and sensor_thermalN to sensorN_thermal.
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
index 0f7bdfc90a0d..6c5694fa6690 100644
--- a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
@@ -2629,7 +2629,7 @@ prr: chipid@fff00044 {
};
thermal-zones {
- sensor_thermal1: sensor-thermal1 {
+ sensor1_thermal: sensor1-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 0>;
@@ -2644,7 +2644,7 @@ sensor1_crit: sensor1-crit {
};
};
- sensor_thermal2: sensor-thermal2 {
+ sensor2_thermal: sensor2-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 1>;
@@ -2659,7 +2659,7 @@ sensor2_crit: sensor2-crit {
};
};
- sensor_thermal3: sensor-thermal3 {
+ sensor3_thermal: sensor3-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 2>;
--
2.30.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 3/9] arm64: dts: renesas: r8a774e1: Fix thermal bindings
2021-11-04 22:40 [PATCH 0/9] arm64: dts: renesas: Thermal binding validation Kieran Bingham
2021-11-04 22:40 ` [PATCH 1/9] arm64: dts: renesas: r8a774a1: Fix thermal bindings Kieran Bingham
2021-11-04 22:40 ` [PATCH 2/9] arm64: dts: renesas: r8a774b1: " Kieran Bingham
@ 2021-11-04 22:40 ` Kieran Bingham
2021-11-04 22:40 ` [PATCH 4/9] arm64: dts: renesas: r8a77951: " Kieran Bingham
` (6 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Kieran Bingham @ 2021-11-04 22:40 UTC (permalink / raw)
To: linux-renesas-soc, devicetree, linux-kernel
Cc: Geert Uytterhoeven, Rob Herring, Kieran Bingham
The binding node names for the thermal zones are not successfully
validated by the dt-schemas.
Fix the validation by changing from sensor-thermalN to sensorN-thermal
and sensor_thermalN to sensorN_thermal.
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
index 379a1300272b..62209ab6deb9 100644
--- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
@@ -2904,7 +2904,7 @@ prr: chipid@fff00044 {
};
thermal-zones {
- sensor_thermal1: sensor-thermal1 {
+ sensor1_thermal: sensor1-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 0>;
@@ -2919,7 +2919,7 @@ sensor1_crit: sensor1-crit {
};
};
- sensor_thermal2: sensor-thermal2 {
+ sensor2_thermal: sensor2-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 1>;
@@ -2934,7 +2934,7 @@ sensor2_crit: sensor2-crit {
};
};
- sensor_thermal3: sensor-thermal3 {
+ sensor3_thermal: sensor3-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 2>;
--
2.30.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 4/9] arm64: dts: renesas: r8a77951: Fix thermal bindings
2021-11-04 22:40 [PATCH 0/9] arm64: dts: renesas: Thermal binding validation Kieran Bingham
` (2 preceding siblings ...)
2021-11-04 22:40 ` [PATCH 3/9] arm64: dts: renesas: r8a774e1: " Kieran Bingham
@ 2021-11-04 22:40 ` Kieran Bingham
2021-11-04 22:40 ` [PATCH 5/9] arm64: dts: renesas: r8a77960: " Kieran Bingham
` (5 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Kieran Bingham @ 2021-11-04 22:40 UTC (permalink / raw)
To: linux-renesas-soc, devicetree, linux-kernel
Cc: Geert Uytterhoeven, Rob Herring, Kieran Bingham
The binding node names for the thermal zones are not successfully
validated by the dt-schemas.
Fix the validation by changing from sensor-thermalN to sensorN-thermal
and sensor_thermalN to sensorN_thermal.
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a77951.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77951.dtsi b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
index 1768a3e6bb8d..193d81be40fc 100644
--- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
@@ -3375,7 +3375,7 @@ prr: chipid@fff00044 {
};
thermal-zones {
- sensor_thermal1: sensor-thermal1 {
+ sensor1_thermal: sensor1-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 0>;
@@ -3390,7 +3390,7 @@ sensor1_crit: sensor1-crit {
};
};
- sensor_thermal2: sensor-thermal2 {
+ sensor2_thermal: sensor2-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 1>;
@@ -3405,7 +3405,7 @@ sensor2_crit: sensor2-crit {
};
};
- sensor_thermal3: sensor-thermal3 {
+ sensor3_thermal: sensor3-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 2>;
--
2.30.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 5/9] arm64: dts: renesas: r8a77960: Fix thermal bindings
2021-11-04 22:40 [PATCH 0/9] arm64: dts: renesas: Thermal binding validation Kieran Bingham
` (3 preceding siblings ...)
2021-11-04 22:40 ` [PATCH 4/9] arm64: dts: renesas: r8a77951: " Kieran Bingham
@ 2021-11-04 22:40 ` Kieran Bingham
2021-11-04 22:40 ` [PATCH 6/9] arm64: dts: renesas: r8a77961: " Kieran Bingham
` (4 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Kieran Bingham @ 2021-11-04 22:40 UTC (permalink / raw)
To: linux-renesas-soc, devicetree, linux-kernel
Cc: Geert Uytterhoeven, Rob Herring, Kieran Bingham
The binding node names for the thermal zones are not successfully
validated by the dt-schemas.
Fix the validation by changing from sensor-thermalN to sensorN-thermal
and sensor_thermalN to sensorN_thermal.
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a77960.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77960.dtsi b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
index 2bd8169735d3..b526e4f0ee6a 100644
--- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
@@ -2972,7 +2972,7 @@ prr: chipid@fff00044 {
};
thermal-zones {
- sensor_thermal1: sensor-thermal1 {
+ sensor1_thermal: sensor1-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 0>;
@@ -2987,7 +2987,7 @@ sensor1_crit: sensor1-crit {
};
};
- sensor_thermal2: sensor-thermal2 {
+ sensor2_thermal: sensor2-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 1>;
@@ -3002,7 +3002,7 @@ sensor2_crit: sensor2-crit {
};
};
- sensor_thermal3: sensor-thermal3 {
+ sensor3_thermal: sensor3-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 2>;
--
2.30.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 6/9] arm64: dts: renesas: r8a77961: Fix thermal bindings
2021-11-04 22:40 [PATCH 0/9] arm64: dts: renesas: Thermal binding validation Kieran Bingham
` (4 preceding siblings ...)
2021-11-04 22:40 ` [PATCH 5/9] arm64: dts: renesas: r8a77960: " Kieran Bingham
@ 2021-11-04 22:40 ` Kieran Bingham
2021-11-04 22:40 ` [PATCH 7/9] arm64: dts: renesas: r8a77965: " Kieran Bingham
` (3 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Kieran Bingham @ 2021-11-04 22:40 UTC (permalink / raw)
To: linux-renesas-soc, devicetree, linux-kernel
Cc: Geert Uytterhoeven, Rob Herring, Kieran Bingham
The binding node names for the thermal zones are not successfully
validated by the dt-schemas.
Fix the validation by changing from sensor-thermalN to sensorN-thermal
and sensor_thermalN to sensorN_thermal.
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a77961.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
index 86d59e7e1a87..b1a00f5df431 100644
--- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
@@ -2730,7 +2730,7 @@ prr: chipid@fff00044 {
};
thermal-zones {
- sensor_thermal1: sensor-thermal1 {
+ sensor1_thermal: sensor1-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 0>;
@@ -2745,7 +2745,7 @@ sensor1_crit: sensor1-crit {
};
};
- sensor_thermal2: sensor-thermal2 {
+ sensor2_thermal: sensor2-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 1>;
@@ -2760,7 +2760,7 @@ sensor2_crit: sensor2-crit {
};
};
- sensor_thermal3: sensor-thermal3 {
+ sensor3_thermal: sensor3-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 2>;
--
2.30.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 7/9] arm64: dts: renesas: r8a77965: Fix thermal bindings
2021-11-04 22:40 [PATCH 0/9] arm64: dts: renesas: Thermal binding validation Kieran Bingham
` (5 preceding siblings ...)
2021-11-04 22:40 ` [PATCH 6/9] arm64: dts: renesas: r8a77961: " Kieran Bingham
@ 2021-11-04 22:40 ` Kieran Bingham
2021-11-04 22:40 ` [PATCH 8/9] arm64: dts: renesas: r8a77980: " Kieran Bingham
` (2 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Kieran Bingham @ 2021-11-04 22:40 UTC (permalink / raw)
To: linux-renesas-soc, devicetree, linux-kernel
Cc: Geert Uytterhoeven, Rob Herring, Kieran Bingham
The binding node names for the thermal zones are not successfully
validated by the dt-schemas.
Fix the validation by changing from sensor-thermalN to sensorN-thermal
and sensor_thermalN to sensorN_thermal.
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 08df75606430..f9679a4dd85f 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -2784,7 +2784,7 @@ prr: chipid@fff00044 {
};
thermal-zones {
- sensor_thermal1: sensor-thermal1 {
+ sensor1_thermal: sensor1-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 0>;
@@ -2799,7 +2799,7 @@ sensor1_crit: sensor1-crit {
};
};
- sensor_thermal2: sensor-thermal2 {
+ sensor2_thermal: sensor2-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 1>;
@@ -2814,7 +2814,7 @@ sensor2_crit: sensor2-crit {
};
};
- sensor_thermal3: sensor-thermal3 {
+ sensor3_thermal: sensor3-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 2>;
--
2.30.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 8/9] arm64: dts: renesas: r8a77980: Fix thermal bindings
2021-11-04 22:40 [PATCH 0/9] arm64: dts: renesas: Thermal binding validation Kieran Bingham
` (6 preceding siblings ...)
2021-11-04 22:40 ` [PATCH 7/9] arm64: dts: renesas: r8a77965: " Kieran Bingham
@ 2021-11-04 22:40 ` Kieran Bingham
2021-11-04 22:40 ` [PATCH 9/9] arm64: dts: renesas: r8a779a0: " Kieran Bingham
2021-11-09 8:29 ` [PATCH 0/9] arm64: dts: renesas: Thermal binding validation Geert Uytterhoeven
9 siblings, 0 replies; 15+ messages in thread
From: Kieran Bingham @ 2021-11-04 22:40 UTC (permalink / raw)
To: linux-renesas-soc, devicetree, linux-kernel
Cc: Geert Uytterhoeven, Rob Herring, Kieran Bingham
The binding node names for the thermal zones are not successfully
validated by the dt-schemas.
Fix the validation by changing from thermal-sensor-N to sensorN-thermal
and providing node labels of the form sensorN_thermal to ensure
consistency with the other platform implementations.
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a77980.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
index 6347d15e66b6..21fe602bd25a 100644
--- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
@@ -1580,7 +1580,7 @@ prr: chipid@fff00044 {
};
thermal-zones {
- thermal-sensor-1 {
+ sensor1_thermal: sensor1-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 0>;
@@ -1599,7 +1599,7 @@ sensor1-critical {
};
};
- thermal-sensor-2 {
+ sensor2_thermal: sensor2-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 1>;
--
2.30.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 9/9] arm64: dts: renesas: r8a779a0: Fix thermal bindings
2021-11-04 22:40 [PATCH 0/9] arm64: dts: renesas: Thermal binding validation Kieran Bingham
` (7 preceding siblings ...)
2021-11-04 22:40 ` [PATCH 8/9] arm64: dts: renesas: r8a77980: " Kieran Bingham
@ 2021-11-04 22:40 ` Kieran Bingham
2021-11-09 8:29 ` [PATCH 0/9] arm64: dts: renesas: Thermal binding validation Geert Uytterhoeven
9 siblings, 0 replies; 15+ messages in thread
From: Kieran Bingham @ 2021-11-04 22:40 UTC (permalink / raw)
To: linux-renesas-soc, devicetree, linux-kernel
Cc: Geert Uytterhoeven, Rob Herring, Kieran Bingham
The binding node names for the thermal zones are not successfully
validated by the dt-schemas.
Fix the validation by changing from sensor-thermalN to sensorN-thermal
and sensor_thermalN to sensorN_thermal.
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
index e53f8b983c30..733fbeff9c13 100644
--- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
@@ -2718,7 +2718,7 @@ prr: chipid@fff00044 {
};
thermal-zones {
- sensor_thermal1: sensor-thermal1 {
+ sensor1_thermal: sensor1-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 0>;
@@ -2732,7 +2732,7 @@ sensor1_crit: sensor1-crit {
};
};
- sensor_thermal2: sensor-thermal2 {
+ sensor2_thermal: sensor2-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 1>;
@@ -2746,7 +2746,7 @@ sensor2_crit: sensor2-crit {
};
};
- sensor_thermal3: sensor-thermal3 {
+ sensor3_thermal: sensor3-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 2>;
@@ -2760,7 +2760,7 @@ sensor3_crit: sensor3-crit {
};
};
- sensor_thermal4: sensor-thermal4 {
+ sensor4_thermal: sensor4-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 3>;
@@ -2774,7 +2774,7 @@ sensor4_crit: sensor4-crit {
};
};
- sensor_thermal5: sensor-thermal5 {
+ sensor5_thermal: sensor5-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
thermal-sensors = <&tsc 4>;
--
2.30.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 0/9] arm64: dts: renesas: Thermal binding validation
2021-11-04 22:40 [PATCH 0/9] arm64: dts: renesas: Thermal binding validation Kieran Bingham
` (8 preceding siblings ...)
2021-11-04 22:40 ` [PATCH 9/9] arm64: dts: renesas: r8a779a0: " Kieran Bingham
@ 2021-11-09 8:29 ` Geert Uytterhoeven
2021-11-09 8:43 ` Niklas Söderlund
9 siblings, 1 reply; 15+ messages in thread
From: Geert Uytterhoeven @ 2021-11-09 8:29 UTC (permalink / raw)
To: Kieran Bingham, Niklas Söderlund
Cc: Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List, Rob Herring
Hi Kieran,
On Thu, Nov 4, 2021 at 11:40 PM Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
> The thermal sensor bindings were not matched correctly against the
> expected naming scheme.
>
> r8a77980.dtsi also used a different naming scheme compared to the other
> related platforms.
It lacked the labels, which you added for consistency.
Is there any point in providing them, as there are no users? Or should
they be removed instead?
> This series cleans up the dtsi files for the CPU target thermal sensors,
> allowing the validation to run.
>
> Enabling this validation shows up a new validation failure:
>
> linux/arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dt.yaml: thermal-zones: sensor3-thermal:cooling-maps:map0:contribution:0:0: 1024 is greater than the maximum of 100
> From schema: Documentation/devicetree/bindings/thermal/thermal-zones.yaml
>
> This validation error appears to be pervasive across all of these
> bindings, but changing that will be more invasive and require someone to
> perform dedicated testing with the thermal drivers to ensure that the
> updates to the ranges do not cause unexpected side effects.
Niklas?
> Kieran Bingham (9):
> arm64: dts: renesas: r8a774a1: Fix thermal bindings
> arm64: dts: renesas: r8a774b1: Fix thermal bindings
> arm64: dts: renesas: r8a774e1: Fix thermal bindings
> arm64: dts: renesas: r8a77951: Fix thermal bindings
> arm64: dts: renesas: r8a77960: Fix thermal bindings
> arm64: dts: renesas: r8a77961: Fix thermal bindings
> arm64: dts: renesas: r8a77965: Fix thermal bindings
> arm64: dts: renesas: r8a77980: Fix thermal bindings
> arm64: dts: renesas: r8a779a0: Fix thermal bindings
For the whole series:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 0/9] arm64: dts: renesas: Thermal binding validation
2021-11-09 8:29 ` [PATCH 0/9] arm64: dts: renesas: Thermal binding validation Geert Uytterhoeven
@ 2021-11-09 8:43 ` Niklas Söderlund
2021-11-09 9:09 ` Niklas Söderlund
0 siblings, 1 reply; 15+ messages in thread
From: Niklas Söderlund @ 2021-11-09 8:43 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Kieran Bingham, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List, Rob Herring
Hello,
On 2021-11-09 09:29:01 +0100, Geert Uytterhoeven wrote:
> Hi Kieran,
>
> On Thu, Nov 4, 2021 at 11:40 PM Kieran Bingham
> <kieran.bingham+renesas@ideasonboard.com> wrote:
> > The thermal sensor bindings were not matched correctly against the
> > expected naming scheme.
> >
> > r8a77980.dtsi also used a different naming scheme compared to the other
> > related platforms.
>
> It lacked the labels, which you added for consistency.
> Is there any point in providing them, as there are no users? Or should
> they be removed instead?
>
> > This series cleans up the dtsi files for the CPU target thermal sensors,
> > allowing the validation to run.
> >
> > Enabling this validation shows up a new validation failure:
> >
> > linux/arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dt.yaml: thermal-zones: sensor3-thermal:cooling-maps:map0:contribution:0:0: 1024 is greater than the maximum of 100
> > From schema: Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> >
> > This validation error appears to be pervasive across all of these
> > bindings, but changing that will be more invasive and require someone to
> > perform dedicated testing with the thermal drivers to ensure that the
> > updates to the ranges do not cause unexpected side effects.
>
> Niklas?
I will have a look. The thermal driver is the one driver where I have
automated CI test running.
>
> > Kieran Bingham (9):
> > arm64: dts: renesas: r8a774a1: Fix thermal bindings
> > arm64: dts: renesas: r8a774b1: Fix thermal bindings
> > arm64: dts: renesas: r8a774e1: Fix thermal bindings
> > arm64: dts: renesas: r8a77951: Fix thermal bindings
> > arm64: dts: renesas: r8a77960: Fix thermal bindings
> > arm64: dts: renesas: r8a77961: Fix thermal bindings
> > arm64: dts: renesas: r8a77965: Fix thermal bindings
> > arm64: dts: renesas: r8a77980: Fix thermal bindings
> > arm64: dts: renesas: r8a779a0: Fix thermal bindings
>
> For the whole series:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Kind Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 0/9] arm64: dts: renesas: Thermal binding validation
2021-11-09 8:43 ` Niklas Söderlund
@ 2021-11-09 9:09 ` Niklas Söderlund
2021-11-30 16:45 ` Geert Uytterhoeven
0 siblings, 1 reply; 15+ messages in thread
From: Niklas Söderlund @ 2021-11-09 9:09 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Kieran Bingham, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List, Rob Herring
On 2021-11-09 09:43:33 +0100, Niklas Söderlund wrote:
> > > linux/arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dt.yaml:
> > > thermal-zones: sensor3-thermal:cooling-maps:map0:contribution:0:0:
> > > 1024 is greater than the maximum of 100
> > > From schema: Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> > >
> > > This validation error appears to be pervasive across all of these
> > > bindings, but changing that will be more invasive and require someone to
> > > perform dedicated testing with the thermal drivers to ensure that the
> > > updates to the ranges do not cause unexpected side effects.
> >
> > Niklas?
>
> I will have a look. The thermal driver is the one driver where I have
> automated CI test running.
So the core of the issue is that the definition of the property changed
in the txt to yaml conversion. The original definition was,
Optional property:
- contribution: The cooling contribution to the thermal zone of the
Type: unsigned referred cooling device at the referred trip point.
Size: one cell The contribution is a ratio of the sum
of all cooling contributions within a thermal zone.
While the new binding states,
contribution:
$ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 100
description:
The percentage contribution of the cooling devices at the
specific trip temperature referenced in this map
to this thermal zone
Looking at the real world usage of this only 2 out of 17 platforms sets
a contribution value less or equal to 100. I will send a patch to fix
the bindings.
--
Kind Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 0/9] arm64: dts: renesas: Thermal binding validation
2021-11-09 9:09 ` Niklas Söderlund
@ 2021-11-30 16:45 ` Geert Uytterhoeven
2021-11-30 16:49 ` Niklas Söderlund
0 siblings, 1 reply; 15+ messages in thread
From: Geert Uytterhoeven @ 2021-11-30 16:45 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Kieran Bingham, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List, Rob Herring
Hi Niklas,
On Tue, Nov 9, 2021 at 10:09 AM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> On 2021-11-09 09:43:33 +0100, Niklas Söderlund wrote:
> > > > linux/arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dt.yaml:
> > > > thermal-zones: sensor3-thermal:cooling-maps:map0:contribution:0:0:
> > > > 1024 is greater than the maximum of 100
> > > > From schema: Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> > > >
> > > > This validation error appears to be pervasive across all of these
> > > > bindings, but changing that will be more invasive and require someone to
> > > > perform dedicated testing with the thermal drivers to ensure that the
> > > > updates to the ranges do not cause unexpected side effects.
> > >
> > > Niklas?
> >
> > I will have a look. The thermal driver is the one driver where I have
> > automated CI test running.
>
> So the core of the issue is that the definition of the property changed
> in the txt to yaml conversion. The original definition was,
>
> Optional property:
> - contribution: The cooling contribution to the thermal zone of the
> Type: unsigned referred cooling device at the referred trip point.
> Size: one cell The contribution is a ratio of the sum
> of all cooling contributions within a thermal zone.
>
> While the new binding states,
>
> contribution:
> $ref: /schemas/types.yaml#/definitions/uint32
> minimum: 0
> maximum: 100
> description:
> The percentage contribution of the cooling devices at the
> specific trip temperature referenced in this map
> to this thermal zone
>
> Looking at the real world usage of this only 2 out of 17 platforms sets
> a contribution value less or equal to 100. I will send a patch to fix
> the bindings.
Given Rob said he applied your patch[1], does that mean this series
is good to be applied?
Thanks!
[1] https://lore.kernel.org/all/YaU4XuiaJgEjGCdQ@robh.at.kernel.org/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 0/9] arm64: dts: renesas: Thermal binding validation
2021-11-30 16:45 ` Geert Uytterhoeven
@ 2021-11-30 16:49 ` Niklas Söderlund
0 siblings, 0 replies; 15+ messages in thread
From: Niklas Söderlund @ 2021-11-30 16:49 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Kieran Bingham, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List, Rob Herring
Hi Geert,
On 2021-11-30 17:45:11 +0100, Geert Uytterhoeven wrote:
> Given Rob said he applied your patch[1], does that mean this series
> is good to be applied?
> Thanks!
>
> [1] https://lore.kernel.org/all/YaU4XuiaJgEjGCdQ@robh.at.kernel.org/
Yes, with that patch applied this change won't generate any (new)
warnings from DT :-)
--
Kind Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 15+ messages in thread