* [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
@ 2021-11-07 2:10 ` kernel test robot
0 siblings, 0 replies; 18+ messages in thread
From: kernel test robot @ 2021-11-07 2:10 UTC (permalink / raw)
To: Marc Zyngier
Cc: llvm, kbuild-all, linux-arm-kernel, Oliver Upton, Mark Rutland
[-- Attachment #1: Type: text/plain, Size: 4839 bytes --]
Hi Marc,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git timers/tval-ectomy
head: c171b519551d424290bb74a3ddbd9068b30c0396
commit: 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e [2/17] clocksource/arm_arch_timer: Drop CNT*_TVAL read accessors
config: arm-randconfig-c002-20210929 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dc6e8dfdfe7efecfda318d43a06fae18b40eb498)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?id=9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
git remote add arm-platforms https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
git fetch --no-tags arm-platforms timers/tval-ectomy
git checkout 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:147:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:139:9: note: initialize the variable 'val' to silence this warning
u32 val;
^
= 0
2 warnings generated.
vim +/val +156 drivers/clocksource/arm_arch_timer.c
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 134
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 135 static __always_inline
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 136 u32 arch_timer_reg_read(int access, enum arch_timer_reg reg,
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 137 struct clock_event_device *clk)
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 138 {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 139 u32 val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 140
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 141 if (access == ARCH_TIMER_MEM_PHYS_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 142 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 143 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 144 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 145 val = readl_relaxed(timer->base + CNTP_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 146 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 147 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 148 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 149 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 150 } else if (access == ARCH_TIMER_MEM_VIRT_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 151 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 152 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 153 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 154 val = readl_relaxed(timer->base + CNTV_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 155 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 @156 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 157 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 158 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 159 } else {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 160 val = arch_timer_reg_read_cp15(access, reg);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 161 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 162
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 163 return val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 164 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 165
:::::: The code at line 156 was first introduced by commit
:::::: 0bc2c9327c236c28cdb2784d11ca349ef3b1ca0a clocksource/arm_arch_timer: Add build-time guards for unhandled register accesses
:::::: TO: Marc Zyngier <maz@kernel.org>
:::::: CC: Marc Zyngier <maz@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38002 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread* [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
@ 2021-11-07 2:10 ` kernel test robot
0 siblings, 0 replies; 18+ messages in thread
From: kernel test robot @ 2021-11-07 2:10 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4930 bytes --]
Hi Marc,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git timers/tval-ectomy
head: c171b519551d424290bb74a3ddbd9068b30c0396
commit: 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e [2/17] clocksource/arm_arch_timer: Drop CNT*_TVAL read accessors
config: arm-randconfig-c002-20210929 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dc6e8dfdfe7efecfda318d43a06fae18b40eb498)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?id=9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
git remote add arm-platforms https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
git fetch --no-tags arm-platforms timers/tval-ectomy
git checkout 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:147:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:139:9: note: initialize the variable 'val' to silence this warning
u32 val;
^
= 0
2 warnings generated.
vim +/val +156 drivers/clocksource/arm_arch_timer.c
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 134
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 135 static __always_inline
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 136 u32 arch_timer_reg_read(int access, enum arch_timer_reg reg,
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 137 struct clock_event_device *clk)
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 138 {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 139 u32 val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 140
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 141 if (access == ARCH_TIMER_MEM_PHYS_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 142 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 143 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 144 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 145 val = readl_relaxed(timer->base + CNTP_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 146 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 147 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 148 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 149 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 150 } else if (access == ARCH_TIMER_MEM_VIRT_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 151 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 152 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 153 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 154 val = readl_relaxed(timer->base + CNTV_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 155 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 @156 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 157 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 158 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 159 } else {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 160 val = arch_timer_reg_read_cp15(access, reg);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 161 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 162
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 163 return val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 164 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 165
:::::: The code at line 156 was first introduced by commit
:::::: 0bc2c9327c236c28cdb2784d11ca349ef3b1ca0a clocksource/arm_arch_timer: Add build-time guards for unhandled register accesses
:::::: TO: Marc Zyngier <maz@kernel.org>
:::::: CC: Marc Zyngier <maz@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38002 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread* [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
@ 2021-11-07 2:10 ` kernel test robot
0 siblings, 0 replies; 18+ messages in thread
From: kernel test robot @ 2021-11-07 2:10 UTC (permalink / raw)
To: Marc Zyngier
Cc: llvm, kbuild-all, linux-arm-kernel, Oliver Upton, Mark Rutland
[-- Attachment #1: Type: text/plain, Size: 4839 bytes --]
Hi Marc,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git timers/tval-ectomy
head: c171b519551d424290bb74a3ddbd9068b30c0396
commit: 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e [2/17] clocksource/arm_arch_timer: Drop CNT*_TVAL read accessors
config: arm-randconfig-c002-20210929 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dc6e8dfdfe7efecfda318d43a06fae18b40eb498)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?id=9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
git remote add arm-platforms https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
git fetch --no-tags arm-platforms timers/tval-ectomy
git checkout 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:147:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:139:9: note: initialize the variable 'val' to silence this warning
u32 val;
^
= 0
2 warnings generated.
vim +/val +156 drivers/clocksource/arm_arch_timer.c
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 134
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 135 static __always_inline
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 136 u32 arch_timer_reg_read(int access, enum arch_timer_reg reg,
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 137 struct clock_event_device *clk)
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 138 {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 139 u32 val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 140
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 141 if (access == ARCH_TIMER_MEM_PHYS_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 142 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 143 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 144 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 145 val = readl_relaxed(timer->base + CNTP_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 146 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 147 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 148 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 149 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 150 } else if (access == ARCH_TIMER_MEM_VIRT_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 151 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 152 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 153 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 154 val = readl_relaxed(timer->base + CNTV_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 155 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 @156 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 157 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 158 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 159 } else {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 160 val = arch_timer_reg_read_cp15(access, reg);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 161 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 162
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 163 return val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 164 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 165
:::::: The code at line 156 was first introduced by commit
:::::: 0bc2c9327c236c28cdb2784d11ca349ef3b1ca0a clocksource/arm_arch_timer: Add build-time guards for unhandled register accesses
:::::: TO: Marc Zyngier <maz@kernel.org>
:::::: CC: Marc Zyngier <maz@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38002 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 18+ messages in thread
* [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
@ 2021-10-09 21:12 ` kernel test robot
0 siblings, 0 replies; 18+ messages in thread
From: kernel test robot @ 2021-10-09 21:12 UTC (permalink / raw)
To: Marc Zyngier
Cc: llvm, kbuild-all, linux-arm-kernel, Oliver Upton, Mark Rutland
[-- Attachment #1: Type: text/plain, Size: 4796 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git timers/tval-ectomy
head: c815d60a6292c90ea228c635b4150f022322908b
commit: 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e [2/17] clocksource/arm_arch_timer: Drop CNT*_TVAL read accessors
config: arm64-randconfig-r026-20211010 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 30caca39f401ae17927439c0a0bd6d1b1916dd6a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?id=9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
git remote add arm-platforms https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
git fetch --no-tags arm-platforms timers/tval-ectomy
git checkout 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:147:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:139:9: note: initialize the variable 'val' to silence this warning
u32 val;
^
= 0
2 warnings generated.
vim +/val +156 drivers/clocksource/arm_arch_timer.c
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 134
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 135 static __always_inline
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 136 u32 arch_timer_reg_read(int access, enum arch_timer_reg reg,
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 137 struct clock_event_device *clk)
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 138 {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 139 u32 val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 140
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 141 if (access == ARCH_TIMER_MEM_PHYS_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 142 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 143 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 144 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 145 val = readl_relaxed(timer->base + CNTP_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 146 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 147 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 148 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 149 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 150 } else if (access == ARCH_TIMER_MEM_VIRT_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 151 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 152 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 153 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 154 val = readl_relaxed(timer->base + CNTV_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 155 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 @156 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 157 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 158 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 159 } else {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 160 val = arch_timer_reg_read_cp15(access, reg);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 161 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 162
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 163 return val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 164 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 165
:::::: The code at line 156 was first introduced by commit
:::::: 0bc2c9327c236c28cdb2784d11ca349ef3b1ca0a clocksource/arm_arch_timer: Add build-time guards for unhandled register accesses
:::::: TO: Marc Zyngier <maz@kernel.org>
:::::: CC: Marc Zyngier <maz@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40124 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread* [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
@ 2021-10-09 21:12 ` kernel test robot
0 siblings, 0 replies; 18+ messages in thread
From: kernel test robot @ 2021-10-09 21:12 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4883 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git timers/tval-ectomy
head: c815d60a6292c90ea228c635b4150f022322908b
commit: 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e [2/17] clocksource/arm_arch_timer: Drop CNT*_TVAL read accessors
config: arm64-randconfig-r026-20211010 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 30caca39f401ae17927439c0a0bd6d1b1916dd6a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?id=9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
git remote add arm-platforms https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
git fetch --no-tags arm-platforms timers/tval-ectomy
git checkout 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:147:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:139:9: note: initialize the variable 'val' to silence this warning
u32 val;
^
= 0
2 warnings generated.
vim +/val +156 drivers/clocksource/arm_arch_timer.c
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 134
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 135 static __always_inline
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 136 u32 arch_timer_reg_read(int access, enum arch_timer_reg reg,
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 137 struct clock_event_device *clk)
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 138 {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 139 u32 val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 140
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 141 if (access == ARCH_TIMER_MEM_PHYS_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 142 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 143 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 144 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 145 val = readl_relaxed(timer->base + CNTP_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 146 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 147 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 148 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 149 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 150 } else if (access == ARCH_TIMER_MEM_VIRT_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 151 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 152 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 153 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 154 val = readl_relaxed(timer->base + CNTV_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 155 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 @156 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 157 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 158 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 159 } else {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 160 val = arch_timer_reg_read_cp15(access, reg);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 161 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 162
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 163 return val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 164 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 165
:::::: The code at line 156 was first introduced by commit
:::::: 0bc2c9327c236c28cdb2784d11ca349ef3b1ca0a clocksource/arm_arch_timer: Add build-time guards for unhandled register accesses
:::::: TO: Marc Zyngier <maz@kernel.org>
:::::: CC: Marc Zyngier <maz@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 40124 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread* [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
@ 2021-10-09 21:12 ` kernel test robot
0 siblings, 0 replies; 18+ messages in thread
From: kernel test robot @ 2021-10-09 21:12 UTC (permalink / raw)
To: Marc Zyngier
Cc: llvm, kbuild-all, linux-arm-kernel, Oliver Upton, Mark Rutland
[-- Attachment #1: Type: text/plain, Size: 4796 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git timers/tval-ectomy
head: c815d60a6292c90ea228c635b4150f022322908b
commit: 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e [2/17] clocksource/arm_arch_timer: Drop CNT*_TVAL read accessors
config: arm64-randconfig-r026-20211010 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 30caca39f401ae17927439c0a0bd6d1b1916dd6a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?id=9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
git remote add arm-platforms https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
git fetch --no-tags arm-platforms timers/tval-ectomy
git checkout 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:147:3: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use occurs here
return val;
^~~
drivers/clocksource/arm_arch_timer.c:139:9: note: initialize the variable 'val' to silence this warning
u32 val;
^
= 0
2 warnings generated.
vim +/val +156 drivers/clocksource/arm_arch_timer.c
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 134
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 135 static __always_inline
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 136 u32 arch_timer_reg_read(int access, enum arch_timer_reg reg,
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 137 struct clock_event_device *clk)
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 138 {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 139 u32 val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 140
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 141 if (access == ARCH_TIMER_MEM_PHYS_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 142 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 143 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 144 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 145 val = readl_relaxed(timer->base + CNTP_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 146 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 147 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 148 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 149 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 150 } else if (access == ARCH_TIMER_MEM_VIRT_ACCESS) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 151 struct arch_timer *timer = to_arch_timer(clk);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 152 switch (reg) {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 153 case ARCH_TIMER_REG_CTRL:
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 154 val = readl_relaxed(timer->base + CNTV_CTL);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 155 break;
0bc2c9327c236c Marc Zyngier 2021-09-20 @156 default:
0bc2c9327c236c Marc Zyngier 2021-09-20 157 BUILD_BUG();
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 158 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 159 } else {
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 160 val = arch_timer_reg_read_cp15(access, reg);
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 161 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 162
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 163 return val;
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 164 }
f4e00a1a55c7f9 Marc Zyngier 2017-01-20 165
:::::: The code at line 156 was first introduced by commit
:::::: 0bc2c9327c236c28cdb2784d11ca349ef3b1ca0a clocksource/arm_arch_timer: Add build-time guards for unhandled register accesses
:::::: TO: Marc Zyngier <maz@kernel.org>
:::::: CC: Marc Zyngier <maz@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40124 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
2021-10-09 21:12 ` kernel test robot
(?)
@ 2021-10-10 9:37 ` Marc Zyngier
-1 siblings, 0 replies; 18+ messages in thread
From: Marc Zyngier @ 2021-10-10 9:37 UTC (permalink / raw)
To: kernel test robot
Cc: llvm, kbuild-all, linux-arm-kernel, Oliver Upton, Mark Rutland
On 2021-10-09 22:12, kernel test robot wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
> timers/tval-ectomy
> head: c815d60a6292c90ea228c635b4150f022322908b
> commit: 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e [2/17]
> clocksource/arm_arch_timer: Drop CNT*_TVAL read accessors
> config: arm64-randconfig-r026-20211010 (attached as .config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
> 30caca39f401ae17927439c0a0bd6d1b1916dd6a)
> reproduce (this is a W=1 build):
> wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install arm64 cross compiling tool for clang build
> # apt-get install binutils-aarch64-linux-gnu
> #
> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?id=9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
> git remote add arm-platforms
> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
> git fetch --no-tags arm-platforms timers/tval-ectomy
> git checkout 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
> ARCH=arm64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
This is *not* an issue, see below.
>
> All warnings (new ones prefixed by >>):
>
>>> drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val'
>>> is used uninitialized whenever switch default is taken
>>> [-Wsometimes-uninitialized]
> default:
> ^~~~~~~
> drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use
> occurs here
> return val;
> ^~~
> drivers/clocksource/arm_arch_timer.c:147:3: warning: variable 'val'
> is used uninitialized whenever switch default is taken
> [-Wsometimes-uninitialized]
> default:
> ^~~~~~~
> drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use
> occurs here
> return val;
> ^~~
> drivers/clocksource/arm_arch_timer.c:139:9: note: initialize the
> variable 'val' to silence this warning
> u32 val;
> ^
> = 0
> 2 warnings generated.
>
>
> vim +/val +156 drivers/clocksource/arm_arch_timer.c
>
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 134
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 135 static __always_inline
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 136 u32
> arch_timer_reg_read(int access, enum arch_timer_reg reg,
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 137 struct
> clock_event_device *clk)
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 138 {
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 139 u32 val;
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 140
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 141 if (access ==
> ARCH_TIMER_MEM_PHYS_ACCESS) {
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 142 struct arch_timer
> *timer = to_arch_timer(clk);
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 143 switch (reg) {
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 144 case
> ARCH_TIMER_REG_CTRL:
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 145 val =
> readl_relaxed(timer->base + CNTP_CTL);
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 146 break;
> 0bc2c9327c236c Marc Zyngier 2021-09-20 147 default:
> 0bc2c9327c236c Marc Zyngier 2021-09-20 148 BUILD_BUG();
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 149 }
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 150 } else if (access ==
> ARCH_TIMER_MEM_VIRT_ACCESS) {
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 151 struct arch_timer
> *timer = to_arch_timer(clk);
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 152 switch (reg) {
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 153 case
> ARCH_TIMER_REG_CTRL:
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 154 val =
> readl_relaxed(timer->base + CNTV_CTL);
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 155 break;
> 0bc2c9327c236c Marc Zyngier 2021-09-20 @156 default:
> 0bc2c9327c236c Marc Zyngier 2021-09-20 157 BUILD_BUG();
If you hit this case, which results in a compilation failure...
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 158 }
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 159 } else {
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 160 val =
> arch_timer_reg_read_cp15(access, reg);
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 161 }
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 162
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 163 return val;
... how can you return anything the first place?
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 164 }
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 165
I think the problem squarely lies with the compiler (or the
way it interprets the BUILD_BUG helper). If it cannot see that
BUILD_BUG() trumps the control flow analysis, then this warning
is totally useless.
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
@ 2021-10-10 9:37 ` Marc Zyngier
0 siblings, 0 replies; 18+ messages in thread
From: Marc Zyngier @ 2021-10-10 9:37 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 5196 bytes --]
On 2021-10-09 22:12, kernel test robot wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
> timers/tval-ectomy
> head: c815d60a6292c90ea228c635b4150f022322908b
> commit: 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e [2/17]
> clocksource/arm_arch_timer: Drop CNT*_TVAL read accessors
> config: arm64-randconfig-r026-20211010 (attached as .config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
> 30caca39f401ae17927439c0a0bd6d1b1916dd6a)
> reproduce (this is a W=1 build):
> wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install arm64 cross compiling tool for clang build
> # apt-get install binutils-aarch64-linux-gnu
> #
> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?id=9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
> git remote add arm-platforms
> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
> git fetch --no-tags arm-platforms timers/tval-ectomy
> git checkout 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
> ARCH=arm64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
This is *not* an issue, see below.
>
> All warnings (new ones prefixed by >>):
>
>>> drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val'
>>> is used uninitialized whenever switch default is taken
>>> [-Wsometimes-uninitialized]
> default:
> ^~~~~~~
> drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use
> occurs here
> return val;
> ^~~
> drivers/clocksource/arm_arch_timer.c:147:3: warning: variable 'val'
> is used uninitialized whenever switch default is taken
> [-Wsometimes-uninitialized]
> default:
> ^~~~~~~
> drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use
> occurs here
> return val;
> ^~~
> drivers/clocksource/arm_arch_timer.c:139:9: note: initialize the
> variable 'val' to silence this warning
> u32 val;
> ^
> = 0
> 2 warnings generated.
>
>
> vim +/val +156 drivers/clocksource/arm_arch_timer.c
>
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 134
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 135 static __always_inline
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 136 u32
> arch_timer_reg_read(int access, enum arch_timer_reg reg,
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 137 struct
> clock_event_device *clk)
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 138 {
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 139 u32 val;
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 140
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 141 if (access ==
> ARCH_TIMER_MEM_PHYS_ACCESS) {
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 142 struct arch_timer
> *timer = to_arch_timer(clk);
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 143 switch (reg) {
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 144 case
> ARCH_TIMER_REG_CTRL:
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 145 val =
> readl_relaxed(timer->base + CNTP_CTL);
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 146 break;
> 0bc2c9327c236c Marc Zyngier 2021-09-20 147 default:
> 0bc2c9327c236c Marc Zyngier 2021-09-20 148 BUILD_BUG();
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 149 }
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 150 } else if (access ==
> ARCH_TIMER_MEM_VIRT_ACCESS) {
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 151 struct arch_timer
> *timer = to_arch_timer(clk);
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 152 switch (reg) {
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 153 case
> ARCH_TIMER_REG_CTRL:
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 154 val =
> readl_relaxed(timer->base + CNTV_CTL);
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 155 break;
> 0bc2c9327c236c Marc Zyngier 2021-09-20 @156 default:
> 0bc2c9327c236c Marc Zyngier 2021-09-20 157 BUILD_BUG();
If you hit this case, which results in a compilation failure...
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 158 }
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 159 } else {
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 160 val =
> arch_timer_reg_read_cp15(access, reg);
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 161 }
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 162
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 163 return val;
... how can you return anything the first place?
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 164 }
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 165
I think the problem squarely lies with the compiler (or the
way it interprets the BUILD_BUG helper). If it cannot see that
BUILD_BUG() trumps the control flow analysis, then this warning
is totally useless.
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
@ 2021-10-10 9:37 ` Marc Zyngier
0 siblings, 0 replies; 18+ messages in thread
From: Marc Zyngier @ 2021-10-10 9:37 UTC (permalink / raw)
To: kernel test robot
Cc: llvm, kbuild-all, linux-arm-kernel, Oliver Upton, Mark Rutland
On 2021-10-09 22:12, kernel test robot wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
> timers/tval-ectomy
> head: c815d60a6292c90ea228c635b4150f022322908b
> commit: 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e [2/17]
> clocksource/arm_arch_timer: Drop CNT*_TVAL read accessors
> config: arm64-randconfig-r026-20211010 (attached as .config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
> 30caca39f401ae17927439c0a0bd6d1b1916dd6a)
> reproduce (this is a W=1 build):
> wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install arm64 cross compiling tool for clang build
> # apt-get install binutils-aarch64-linux-gnu
> #
> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?id=9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
> git remote add arm-platforms
> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
> git fetch --no-tags arm-platforms timers/tval-ectomy
> git checkout 9c6e4aa680ebd5ad816fc8f97858ec6057362c9e
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1
> ARCH=arm64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
This is *not* an issue, see below.
>
> All warnings (new ones prefixed by >>):
>
>>> drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val'
>>> is used uninitialized whenever switch default is taken
>>> [-Wsometimes-uninitialized]
> default:
> ^~~~~~~
> drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use
> occurs here
> return val;
> ^~~
> drivers/clocksource/arm_arch_timer.c:147:3: warning: variable 'val'
> is used uninitialized whenever switch default is taken
> [-Wsometimes-uninitialized]
> default:
> ^~~~~~~
> drivers/clocksource/arm_arch_timer.c:163:9: note: uninitialized use
> occurs here
> return val;
> ^~~
> drivers/clocksource/arm_arch_timer.c:139:9: note: initialize the
> variable 'val' to silence this warning
> u32 val;
> ^
> = 0
> 2 warnings generated.
>
>
> vim +/val +156 drivers/clocksource/arm_arch_timer.c
>
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 134
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 135 static __always_inline
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 136 u32
> arch_timer_reg_read(int access, enum arch_timer_reg reg,
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 137 struct
> clock_event_device *clk)
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 138 {
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 139 u32 val;
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 140
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 141 if (access ==
> ARCH_TIMER_MEM_PHYS_ACCESS) {
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 142 struct arch_timer
> *timer = to_arch_timer(clk);
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 143 switch (reg) {
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 144 case
> ARCH_TIMER_REG_CTRL:
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 145 val =
> readl_relaxed(timer->base + CNTP_CTL);
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 146 break;
> 0bc2c9327c236c Marc Zyngier 2021-09-20 147 default:
> 0bc2c9327c236c Marc Zyngier 2021-09-20 148 BUILD_BUG();
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 149 }
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 150 } else if (access ==
> ARCH_TIMER_MEM_VIRT_ACCESS) {
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 151 struct arch_timer
> *timer = to_arch_timer(clk);
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 152 switch (reg) {
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 153 case
> ARCH_TIMER_REG_CTRL:
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 154 val =
> readl_relaxed(timer->base + CNTV_CTL);
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 155 break;
> 0bc2c9327c236c Marc Zyngier 2021-09-20 @156 default:
> 0bc2c9327c236c Marc Zyngier 2021-09-20 157 BUILD_BUG();
If you hit this case, which results in a compilation failure...
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 158 }
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 159 } else {
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 160 val =
> arch_timer_reg_read_cp15(access, reg);
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 161 }
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 162
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 163 return val;
... how can you return anything the first place?
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 164 }
> f4e00a1a55c7f9 Marc Zyngier 2017-01-20 165
I think the problem squarely lies with the compiler (or the
way it interprets the BUILD_BUG helper). If it cannot see that
BUILD_BUG() trumps the control flow analysis, then this warning
is totally useless.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
2021-10-10 9:37 ` Marc Zyngier
(?)
@ 2021-10-10 10:54 ` Miguel Ojeda
-1 siblings, 0 replies; 18+ messages in thread
From: Miguel Ojeda @ 2021-10-10 10:54 UTC (permalink / raw)
To: Marc Zyngier
Cc: kernel test robot, llvm, kbuild-all, Linux ARM, Oliver Upton,
Mark Rutland
On Sun, Oct 10, 2021 at 11:37 AM Marc Zyngier <maz@kernel.org> wrote:
>
> I think the problem squarely lies with the compiler (or the
> way it interprets the BUILD_BUG helper). If it cannot see that
> BUILD_BUG() trumps the control flow analysis, then this warning
> is totally useless.
The fake, generated `__compiletime_assert` should be annotated
`__noreturn`. That gives enough information to the compiler to avoid
the warning: https://godbolt.org/z/x1v69jjYY
And we should also move `__compiletime_{error,warning}` to compiler
attributes since Clang trunk has it now, so that we catch the error
earlier: https://godbolt.org/z/jd8Eb9Mf1
I will send a couple patches.
Cheers,
Miguel
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
@ 2021-10-10 10:54 ` Miguel Ojeda
0 siblings, 0 replies; 18+ messages in thread
From: Miguel Ojeda @ 2021-10-10 10:54 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
On Sun, Oct 10, 2021 at 11:37 AM Marc Zyngier <maz@kernel.org> wrote:
>
> I think the problem squarely lies with the compiler (or the
> way it interprets the BUILD_BUG helper). If it cannot see that
> BUILD_BUG() trumps the control flow analysis, then this warning
> is totally useless.
The fake, generated `__compiletime_assert` should be annotated
`__noreturn`. That gives enough information to the compiler to avoid
the warning: https://godbolt.org/z/x1v69jjYY
And we should also move `__compiletime_{error,warning}` to compiler
attributes since Clang trunk has it now, so that we catch the error
earlier: https://godbolt.org/z/jd8Eb9Mf1
I will send a couple patches.
Cheers,
Miguel
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
@ 2021-10-10 10:54 ` Miguel Ojeda
0 siblings, 0 replies; 18+ messages in thread
From: Miguel Ojeda @ 2021-10-10 10:54 UTC (permalink / raw)
To: Marc Zyngier
Cc: kernel test robot, llvm, kbuild-all, Linux ARM, Oliver Upton,
Mark Rutland
On Sun, Oct 10, 2021 at 11:37 AM Marc Zyngier <maz@kernel.org> wrote:
>
> I think the problem squarely lies with the compiler (or the
> way it interprets the BUILD_BUG helper). If it cannot see that
> BUILD_BUG() trumps the control flow analysis, then this warning
> is totally useless.
The fake, generated `__compiletime_assert` should be annotated
`__noreturn`. That gives enough information to the compiler to avoid
the warning: https://godbolt.org/z/x1v69jjYY
And we should also move `__compiletime_{error,warning}` to compiler
attributes since Clang trunk has it now, so that we catch the error
earlier: https://godbolt.org/z/jd8Eb9Mf1
I will send a couple patches.
Cheers,
Miguel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
2021-10-10 10:54 ` Miguel Ojeda
(?)
@ 2021-10-11 20:18 ` Nick Desaulniers
-1 siblings, 0 replies; 18+ messages in thread
From: Nick Desaulniers @ 2021-10-11 20:18 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Marc Zyngier, kernel test robot, llvm, kbuild-all, Linux ARM,
Oliver Upton, Mark Rutland
On Sun, Oct 10, 2021 at 3:55 AM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Sun, Oct 10, 2021 at 11:37 AM Marc Zyngier <maz@kernel.org> wrote:
> >
> > I think the problem squarely lies with the compiler (or the
> > way it interprets the BUILD_BUG helper). If it cannot see that
> > BUILD_BUG() trumps the control flow analysis, then this warning
> > is totally useless.
>
> The fake, generated `__compiletime_assert` should be annotated
> `__noreturn`. That gives enough information to the compiler to avoid
> the warning: https://godbolt.org/z/x1v69jjYY
SGTM, please do.
>
> And we should also move `__compiletime_{error,warning}` to compiler
> attributes since Clang trunk has it now, so that we catch the error
> earlier: https://godbolt.org/z/jd8Eb9Mf1
Didn't I send a patch for that?
b83a908498d68fafca931e1276e145b339cac5fb
is in mainline.
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
@ 2021-10-11 20:18 ` Nick Desaulniers
0 siblings, 0 replies; 18+ messages in thread
From: Nick Desaulniers @ 2021-10-11 20:18 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
On Sun, Oct 10, 2021 at 3:55 AM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Sun, Oct 10, 2021 at 11:37 AM Marc Zyngier <maz@kernel.org> wrote:
> >
> > I think the problem squarely lies with the compiler (or the
> > way it interprets the BUILD_BUG helper). If it cannot see that
> > BUILD_BUG() trumps the control flow analysis, then this warning
> > is totally useless.
>
> The fake, generated `__compiletime_assert` should be annotated
> `__noreturn`. That gives enough information to the compiler to avoid
> the warning: https://godbolt.org/z/x1v69jjYY
SGTM, please do.
>
> And we should also move `__compiletime_{error,warning}` to compiler
> attributes since Clang trunk has it now, so that we catch the error
> earlier: https://godbolt.org/z/jd8Eb9Mf1
Didn't I send a patch for that?
b83a908498d68fafca931e1276e145b339cac5fb
is in mainline.
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
@ 2021-10-11 20:18 ` Nick Desaulniers
0 siblings, 0 replies; 18+ messages in thread
From: Nick Desaulniers @ 2021-10-11 20:18 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Marc Zyngier, kernel test robot, llvm, kbuild-all, Linux ARM,
Oliver Upton, Mark Rutland
On Sun, Oct 10, 2021 at 3:55 AM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Sun, Oct 10, 2021 at 11:37 AM Marc Zyngier <maz@kernel.org> wrote:
> >
> > I think the problem squarely lies with the compiler (or the
> > way it interprets the BUILD_BUG helper). If it cannot see that
> > BUILD_BUG() trumps the control flow analysis, then this warning
> > is totally useless.
>
> The fake, generated `__compiletime_assert` should be annotated
> `__noreturn`. That gives enough information to the compiler to avoid
> the warning: https://godbolt.org/z/x1v69jjYY
SGTM, please do.
>
> And we should also move `__compiletime_{error,warning}` to compiler
> attributes since Clang trunk has it now, so that we catch the error
> earlier: https://godbolt.org/z/jd8Eb9Mf1
Didn't I send a patch for that?
b83a908498d68fafca931e1276e145b339cac5fb
is in mainline.
--
Thanks,
~Nick Desaulniers
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
2021-10-11 20:18 ` Nick Desaulniers
(?)
@ 2021-10-14 13:27 ` Miguel Ojeda
-1 siblings, 0 replies; 18+ messages in thread
From: Miguel Ojeda @ 2021-10-14 13:27 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Marc Zyngier, kernel test robot, llvm, kbuild-all, Linux ARM,
Oliver Upton, Mark Rutland
On Mon, Oct 11, 2021 at 10:18 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> SGTM, please do.
https://lore.kernel.org/lkml/20211014132331.GA4811@kernel.org/
> Didn't I send a patch for that?
> b83a908498d68fafca931e1276e145b339cac5fb
> is in mainline.
That explains my déjà vu feeling -- I guess I didn't click on the
-rc's in Elixir :)
Cheers,
Miguel
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
@ 2021-10-14 13:27 ` Miguel Ojeda
0 siblings, 0 replies; 18+ messages in thread
From: Miguel Ojeda @ 2021-10-14 13:27 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
On Mon, Oct 11, 2021 at 10:18 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> SGTM, please do.
https://lore.kernel.org/lkml/20211014132331.GA4811(a)kernel.org/
> Didn't I send a patch for that?
> b83a908498d68fafca931e1276e145b339cac5fb
> is in mainline.
That explains my déjà vu feeling -- I guess I didn't click on the
-rc's in Elixir :)
Cheers,
Miguel
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken
@ 2021-10-14 13:27 ` Miguel Ojeda
0 siblings, 0 replies; 18+ messages in thread
From: Miguel Ojeda @ 2021-10-14 13:27 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Marc Zyngier, kernel test robot, llvm, kbuild-all, Linux ARM,
Oliver Upton, Mark Rutland
On Mon, Oct 11, 2021 at 10:18 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> SGTM, please do.
https://lore.kernel.org/lkml/20211014132331.GA4811@kernel.org/
> Didn't I send a patch for that?
> b83a908498d68fafca931e1276e145b339cac5fb
> is in mainline.
That explains my déjà vu feeling -- I guess I didn't click on the
-rc's in Elixir :)
Cheers,
Miguel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2021-11-07 2:12 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-07 2:10 [arm-platforms:timers/tval-ectomy 2/17] drivers/clocksource/arm_arch_timer.c:156:3: warning: variable 'val' is used uninitialized whenever switch default is taken kernel test robot
2021-11-07 2:10 ` kernel test robot
2021-11-07 2:10 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2021-10-09 21:12 kernel test robot
2021-10-09 21:12 ` kernel test robot
2021-10-09 21:12 ` kernel test robot
2021-10-10 9:37 ` Marc Zyngier
2021-10-10 9:37 ` Marc Zyngier
2021-10-10 9:37 ` Marc Zyngier
2021-10-10 10:54 ` Miguel Ojeda
2021-10-10 10:54 ` Miguel Ojeda
2021-10-10 10:54 ` Miguel Ojeda
2021-10-11 20:18 ` Nick Desaulniers
2021-10-11 20:18 ` Nick Desaulniers
2021-10-11 20:18 ` Nick Desaulniers
2021-10-14 13:27 ` Miguel Ojeda
2021-10-14 13:27 ` Miguel Ojeda
2021-10-14 13:27 ` Miguel Ojeda
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.