All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] board: ls1046ardb: force PCI device enumeration
@ 2021-11-17 11:59 Martin Schiller
  2021-11-22 16:30 ` Camelia Alexandra Groza (OSS)
  0 siblings, 1 reply; 5+ messages in thread
From: Martin Schiller @ 2021-11-17 11:59 UTC (permalink / raw)
  To: u-boot; +Cc: Martin Schiller, Priyanka Jain

Commit 045ecf899252 ("configs: enable DM_ETH support for LS1046ARDB")
resulted in the PCI bus no longer being implicitly enumerated.

However, this is necessary for the fdt pcie fixups to work.

Therefore, similar to commit 8b6558bd4187 ("board: ls1088ardb:
transition to DM_ETH"), pci_init() is now called in the board_init()
routine when CONFIG_DM_ETH is active.

Signed-off-by: Martin Schiller <ms@dev.tdt.de>
CC: Priyanka Jain <priyanka.jain@nxp.com>
---
 board/freescale/ls1046ardb/ls1046ardb.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/board/freescale/ls1046ardb/ls1046ardb.c b/board/freescale/ls1046ardb/ls1046ardb.c
index 93ef903f29..d0abfe8869 100644
--- a/board/freescale/ls1046ardb/ls1046ardb.c
+++ b/board/freescale/ls1046ardb/ls1046ardb.c
@@ -93,6 +93,10 @@ int board_init(void)
 	ppa_init();
 #endif
 
+#if !defined(CONFIG_SYS_EARLY_PCI_INIT) && defined(CONFIG_DM_ETH)
+	pci_init();
+#endif
+
 	/* invert AQR105 IRQ pins polarity */
 	out_be32(&scfg->intpcr, AQR105_IRQ_MASK);
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* RE: [PATCH] board: ls1046ardb: force PCI device enumeration
  2021-11-17 11:59 [PATCH] board: ls1046ardb: force PCI device enumeration Martin Schiller
@ 2021-11-22 16:30 ` Camelia Alexandra Groza (OSS)
  2021-11-23  6:18   ` Martin Schiller
  2021-12-06  8:23   ` Priyanka Jain (OSS)
  0 siblings, 2 replies; 5+ messages in thread
From: Camelia Alexandra Groza (OSS) @ 2021-11-22 16:30 UTC (permalink / raw)
  To: Martin Schiller, u-boot; +Cc: Priyanka Jain

> -----Original Message-----
> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Martin Schiller
> Sent: Wednesday, November 17, 2021 13:59
> To: u-boot@lists.denx.de
> Cc: Martin Schiller <ms@dev.tdt.de>; Priyanka Jain <priyanka.jain@nxp.com>
> Subject: [PATCH] board: ls1046ardb: force PCI device enumeration
> 
> Commit 045ecf899252 ("configs: enable DM_ETH support for LS1046ARDB")
> resulted in the PCI bus no longer being implicitly enumerated.
> 
> However, this is necessary for the fdt pcie fixups to work.
> 
> Therefore, similar to commit 8b6558bd4187 ("board: ls1088ardb:
> transition to DM_ETH"), pci_init() is now called in the board_init()
> routine when CONFIG_DM_ETH is active.
> 
> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
> CC: Priyanka Jain <priyanka.jain@nxp.com>
> ---
>  board/freescale/ls1046ardb/ls1046ardb.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/board/freescale/ls1046ardb/ls1046ardb.c
> b/board/freescale/ls1046ardb/ls1046ardb.c
> index 93ef903f29..d0abfe8869 100644
> --- a/board/freescale/ls1046ardb/ls1046ardb.c
> +++ b/board/freescale/ls1046ardb/ls1046ardb.c
> @@ -93,6 +93,10 @@ int board_init(void)
>  	ppa_init();
>  #endif
> 
> +#if !defined(CONFIG_SYS_EARLY_PCI_INIT) && defined(CONFIG_DM_ETH)
> +	pci_init();
> +#endif
> +
>  	/* invert AQR105 IRQ pins polarity */
>  	out_be32(&scfg->intpcr, AQR105_IRQ_MASK);
> 

Hi

Thank you for the patch. A very similar fix is needed for the ls1043ardb board.
Are you interested to send a patch for that as well?

Acked-by: Camelia Groza <camelia.groza@nxp.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] board: ls1046ardb: force PCI device enumeration
  2021-11-22 16:30 ` Camelia Alexandra Groza (OSS)
@ 2021-11-23  6:18   ` Martin Schiller
  2021-12-06  8:23   ` Priyanka Jain (OSS)
  1 sibling, 0 replies; 5+ messages in thread
From: Martin Schiller @ 2021-11-23  6:18 UTC (permalink / raw)
  To: Camelia Alexandra Groza (OSS); +Cc: u-boot, Priyanka Jain

On 2021-11-22 17:30, Camelia Alexandra Groza (OSS) wrote:
>> -----Original Message-----
>> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Martin 
>> Schiller
>> Sent: Wednesday, November 17, 2021 13:59
>> To: u-boot@lists.denx.de
>> Cc: Martin Schiller <ms@dev.tdt.de>; Priyanka Jain 
>> <priyanka.jain@nxp.com>
>> Subject: [PATCH] board: ls1046ardb: force PCI device enumeration
>> 
>> Commit 045ecf899252 ("configs: enable DM_ETH support for LS1046ARDB")
>> resulted in the PCI bus no longer being implicitly enumerated.
>> 
>> However, this is necessary for the fdt pcie fixups to work.
>> 
>> Therefore, similar to commit 8b6558bd4187 ("board: ls1088ardb:
>> transition to DM_ETH"), pci_init() is now called in the board_init()
>> routine when CONFIG_DM_ETH is active.
>> 
>> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
>> CC: Priyanka Jain <priyanka.jain@nxp.com>
>> ---
>>  board/freescale/ls1046ardb/ls1046ardb.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>> 
>> diff --git a/board/freescale/ls1046ardb/ls1046ardb.c
>> b/board/freescale/ls1046ardb/ls1046ardb.c
>> index 93ef903f29..d0abfe8869 100644
>> --- a/board/freescale/ls1046ardb/ls1046ardb.c
>> +++ b/board/freescale/ls1046ardb/ls1046ardb.c
>> @@ -93,6 +93,10 @@ int board_init(void)
>>  	ppa_init();
>>  #endif
>> 
>> +#if !defined(CONFIG_SYS_EARLY_PCI_INIT) && defined(CONFIG_DM_ETH)
>> +	pci_init();
>> +#endif
>> +
>>  	/* invert AQR105 IRQ pins polarity */
>>  	out_be32(&scfg->intpcr, AQR105_IRQ_MASK);
>> 
> 
> Hi
> 
> Thank you for the patch. A very similar fix is needed for the 
> ls1043ardb board.
> Are you interested to send a patch for that as well?
> 

Hi

Yes, I can do that. But I can't test it due to lack of hardware.

> Acked-by: Camelia Groza <camelia.groza@nxp.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* RE: [PATCH] board: ls1046ardb: force PCI device enumeration
  2021-11-22 16:30 ` Camelia Alexandra Groza (OSS)
  2021-11-23  6:18   ` Martin Schiller
@ 2021-12-06  8:23   ` Priyanka Jain (OSS)
  1 sibling, 0 replies; 5+ messages in thread
From: Priyanka Jain (OSS) @ 2021-12-06  8:23 UTC (permalink / raw)
  To: Camelia Alexandra Groza (OSS), Martin Schiller, u-boot



>-----Original Message-----
>From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Camelia Alexandra
>Groza (OSS)
>Sent: Monday, November 22, 2021 10:01 PM
>To: Martin Schiller <ms@dev.tdt.de>; u-boot@lists.denx.de
>Cc: Priyanka Jain <priyanka.jain@nxp.com>
>Subject: RE: [PATCH] board: ls1046ardb: force PCI device enumeration
>
>> -----Original Message-----
>> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Martin
>> Schiller
>> Sent: Wednesday, November 17, 2021 13:59
>> To: u-boot@lists.denx.de
>> Cc: Martin Schiller <ms@dev.tdt.de>; Priyanka Jain
>> <priyanka.jain@nxp.com>
>> Subject: [PATCH] board: ls1046ardb: force PCI device enumeration
>>
>> Commit 045ecf899252 ("configs: enable DM_ETH support for LS1046ARDB")
>> resulted in the PCI bus no longer being implicitly enumerated.
>>
>> However, this is necessary for the fdt pcie fixups to work.
>>
>> Therefore, similar to commit 8b6558bd4187 ("board: ls1088ardb:
>> transition to DM_ETH"), pci_init() is now called in the board_init()
>> routine when CONFIG_DM_ETH is active.
>>
>> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
>> CC: Priyanka Jain <priyanka.jain@nxp.com>
>> ---
>>  board/freescale/ls1046ardb/ls1046ardb.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/board/freescale/ls1046ardb/ls1046ardb.c
>> b/board/freescale/ls1046ardb/ls1046ardb.c
>> index 93ef903f29..d0abfe8869 100644
>> --- a/board/freescale/ls1046ardb/ls1046ardb.c
>> +++ b/board/freescale/ls1046ardb/ls1046ardb.c
>> @@ -93,6 +93,10 @@ int board_init(void)
>>  	ppa_init();
>>  #endif
>>
>> +#if !defined(CONFIG_SYS_EARLY_PCI_INIT) && defined(CONFIG_DM_ETH)
>> +	pci_init();
>> +#endif
>> +
>>  	/* invert AQR105 IRQ pins polarity */
>>  	out_be32(&scfg->intpcr, AQR105_IRQ_MASK);
>>
>
>Hi
>
>Thank you for the patch. A very similar fix is needed for the ls1043ardb board.
>Are you interested to send a patch for that as well?
>
>Acked-by: Camelia Groza <camelia.groza@nxp.com>
Reviewed-by: Priyanka Jain <priyanka.jain@nxp.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] board: ls1046ardb: force PCI device enumeration
@ 2021-11-17  7:02 Martin Schiller
  0 siblings, 0 replies; 5+ messages in thread
From: Martin Schiller @ 2021-11-17  7:02 UTC (permalink / raw)
  To: u-boot; +Cc: Martin Schiller, Priyanka Jain

Commit 045ecf899252 ("configs: enable DM_ETH support for LS1046ARDB")
resulted in the PCI bus no longer being implicitly enumerated.

However, this is necessary for the fdt pcie fixups to work.

Therefore, similar to commit 8b6558bd4187 ("board: ls1088ardb:
transition to DM_ETH"), pci_init() is now called in the board_init()
routine when CONFIG_DM_ETH is active.

Signed-off-by: Martin Schiller <ms@dev.tdt.de>
CC: Priyanka Jain <priyanka.jain@nxp.com>
---
 board/freescale/ls1046ardb/ls1046ardb.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/board/freescale/ls1046ardb/ls1046ardb.c b/board/freescale/ls1046ardb/ls1046ardb.c
index 93ef903f29..d0abfe8869 100644
--- a/board/freescale/ls1046ardb/ls1046ardb.c
+++ b/board/freescale/ls1046ardb/ls1046ardb.c
@@ -93,6 +93,10 @@ int board_init(void)
 	ppa_init();
 #endif
 
+#if !defined(CONFIG_SYS_EARLY_PCI_INIT) && defined(CONFIG_DM_ETH)
+	pci_init();
+#endif
+
 	/* invert AQR105 IRQ pins polarity */
 	out_be32(&scfg->intpcr, AQR105_IRQ_MASK);
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-12-06  8:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-17 11:59 [PATCH] board: ls1046ardb: force PCI device enumeration Martin Schiller
2021-11-22 16:30 ` Camelia Alexandra Groza (OSS)
2021-11-23  6:18   ` Martin Schiller
2021-12-06  8:23   ` Priyanka Jain (OSS)
  -- strict thread matches above, loose matches on Subject: below --
2021-11-17  7:02 Martin Schiller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.