From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sean Nyekjaer <sean@geanix.com>,
Boris Brezillon <boris.brezillon@collabora.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Boris Brezillon <bbrezillon@kernel.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/4] mtd: rawnand: nand_bbt: hide suspend/resume hooks while scanning bbt
Date: Fri, 19 Nov 2021 19:35:51 +0100 [thread overview]
Message-ID: <20211119183551.1330314-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20211102110204.3334609-2-sean@geanix.com>
On Tue, 2021-11-02 at 11:02:01 UTC, Sean Nyekjaer wrote:
> From: Boris Brezillon <boris.brezillon@collabora.com>
>
> The BBT scan logic use the MTD helpers before the MTD layer had a
> chance to initialize the device, and that leads to issues when
> accessing the uninitialized suspend lock. Let's temporarily set the
> suspend/resume hooks to NULL to skip the lock acquire/release step.
>
> Tested-by: Sean Nyekjaer <sean@geanix.com>
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sean Nyekjaer <sean@geanix.com>,
Boris Brezillon <boris.brezillon@collabora.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Boris Brezillon <bbrezillon@kernel.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/4] mtd: rawnand: nand_bbt: hide suspend/resume hooks while scanning bbt
Date: Fri, 19 Nov 2021 19:35:51 +0100 [thread overview]
Message-ID: <20211119183551.1330314-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20211102110204.3334609-2-sean@geanix.com>
On Tue, 2021-11-02 at 11:02:01 UTC, Sean Nyekjaer wrote:
> From: Boris Brezillon <boris.brezillon@collabora.com>
>
> The BBT scan logic use the MTD helpers before the MTD layer had a
> chance to initialize the device, and that leads to issues when
> accessing the uninitialized suspend lock. Let's temporarily set the
> suspend/resume hooks to NULL to skip the lock acquire/release step.
>
> Tested-by: Sean Nyekjaer <sean@geanix.com>
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-11-19 18:36 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 11:02 [PATCH v5 0/4] mtd: core: protect access to mtd devices while in suspend Sean Nyekjaer
2021-11-02 11:02 ` Sean Nyekjaer
2021-11-02 11:02 ` [PATCH v5 1/4] mtd: rawnand: nand_bbt: hide suspend/resume hooks while scanning bbt Sean Nyekjaer
2021-11-02 11:02 ` Sean Nyekjaer
2021-11-19 18:35 ` Miquel Raynal [this message]
2021-11-19 18:35 ` Miquel Raynal
2021-11-02 11:02 ` [PATCH v5 2/4] mtd: mtdconcat: don't use mtd_{suspend,resume}() Sean Nyekjaer
2021-11-02 11:02 ` Sean Nyekjaer
2021-11-19 18:35 ` Miquel Raynal
2021-11-19 18:35 ` Miquel Raynal
2021-11-02 11:02 ` [PATCH v5 3/4] mtd: core: protect access to MTD devices while in suspend Sean Nyekjaer
2021-11-02 11:02 ` Sean Nyekjaer
2021-11-19 18:35 ` Miquel Raynal
2021-11-19 18:35 ` Miquel Raynal
[not found] ` <CGME20211123120353eucas1p2fb2561b7cfddd8d6e7decaef8b504f4c@eucas1p2.samsung.com>
2021-11-23 12:03 ` Marek Szyprowski
2021-11-23 12:03 ` Marek Szyprowski
2021-11-23 12:50 ` Sean Nyekjaer
2021-11-23 12:50 ` Sean Nyekjaer
2021-11-23 13:07 ` Boris Brezillon
2021-11-23 13:07 ` Boris Brezillon
2021-11-29 9:19 ` Miquel Raynal
2021-11-29 9:19 ` Miquel Raynal
2021-11-29 9:41 ` Sean Nyekjaer
2021-11-29 9:41 ` Sean Nyekjaer
2021-11-29 11:17 ` Marek Szyprowski
2021-11-29 11:17 ` Marek Szyprowski
2021-11-30 12:41 ` Sean Nyekjaer
2021-11-30 12:41 ` Sean Nyekjaer
2021-11-30 13:15 ` Boris Brezillon
2021-11-30 13:15 ` Boris Brezillon
2021-11-30 13:29 ` Sean Nyekjaer
2021-11-30 13:29 ` Sean Nyekjaer
2021-11-30 13:37 ` Boris Brezillon
2021-11-30 13:37 ` Boris Brezillon
2021-12-03 13:39 ` Miquel Raynal
2021-12-03 13:39 ` Miquel Raynal
2021-12-09 14:07 ` Sean Nyekjaer
2021-12-09 14:07 ` Sean Nyekjaer
2021-12-09 14:28 ` Miquel Raynal
2021-12-09 14:28 ` Miquel Raynal
2021-12-10 13:25 ` Sean Nyekjaer
2021-12-10 13:25 ` Sean Nyekjaer
2021-12-13 9:10 ` Miquel Raynal
2021-12-13 9:10 ` Miquel Raynal
2021-12-13 9:28 ` Boris Brezillon
2021-12-13 9:28 ` Boris Brezillon
2021-12-13 9:33 ` Miquel Raynal
2021-12-13 9:33 ` Miquel Raynal
2021-12-13 9:53 ` Boris Brezillon
2021-12-13 9:53 ` Boris Brezillon
2021-12-13 10:50 ` Sean Nyekjaer
2021-12-13 10:50 ` Sean Nyekjaer
2021-12-13 11:06 ` Boris Brezillon
2021-12-13 11:06 ` Boris Brezillon
2021-11-02 11:02 ` [PATCH v5 4/4] mtd: rawnand: remove suspended check Sean Nyekjaer
2021-11-02 11:02 ` Sean Nyekjaer
2021-11-19 18:35 ` Miquel Raynal
2021-11-19 18:35 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211119183551.1330314-1-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=sean@geanix.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.