From: Miquel Raynal <miquel.raynal@bootlin.com> To: Boris Brezillon <boris.brezillon@collabora.com> Cc: Sean Nyekjaer <sean@geanix.com>, linux-kernel@vger.kernel.org, Marek Szyprowski <m.szyprowski@samsung.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Boris Brezillon <bbrezillon@kernel.org>, linux-mtd@lists.infradead.org Subject: Re: [PATCH v5 3/4] mtd: core: protect access to MTD devices while in suspend Date: Fri, 3 Dec 2021 14:39:58 +0100 [thread overview] Message-ID: <20211203143958.40645506@xps13> (raw) In-Reply-To: <20211130143705.5d0404aa@collabora.com> Hello, > > Fine by me, lets drop this series. FYI I've dropped the entire series from mtd/next. I'm waiting for the fix discussed below (without abusing the chip mutex ;-) ). Cheers, Miquèl > > We have +10.000 devices that runs with this patch: > > > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > > index 1f0d542d5923..58d48c3070fa 100644 > > --- a/drivers/mtd/nand/raw/nand_base.c > > +++ b/drivers/mtd/nand/raw/nand_base.c > > @@ -4337,7 +4337,6 @@ static int nand_suspend(struct mtd_info *mtd) > > ret = chip->ops.suspend(chip); > > if (!ret) > > chip->suspended = 1; > > - mutex_unlock(&chip->lock); > > > > return ret; > > } > > @@ -4350,7 +4349,6 @@ static void nand_resume(struct mtd_info *mtd) > > { > > struct nand_chip *chip = mtd_to_nand(mtd); > > > > - mutex_lock(&chip->lock); > > if (chip->suspended) { > > if (chip->ops.resume) > > chip->ops.resume(chip); > > > > But it's abusing the chip lock... Use a wait queue as we did at the MTD > level, and make nand_get_device() wait on this wait queue when the > device is suspended. > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com> To: Boris Brezillon <boris.brezillon@collabora.com> Cc: Sean Nyekjaer <sean@geanix.com>, linux-kernel@vger.kernel.org, Marek Szyprowski <m.szyprowski@samsung.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Boris Brezillon <bbrezillon@kernel.org>, linux-mtd@lists.infradead.org Subject: Re: [PATCH v5 3/4] mtd: core: protect access to MTD devices while in suspend Date: Fri, 3 Dec 2021 14:39:58 +0100 [thread overview] Message-ID: <20211203143958.40645506@xps13> (raw) In-Reply-To: <20211130143705.5d0404aa@collabora.com> Hello, > > Fine by me, lets drop this series. FYI I've dropped the entire series from mtd/next. I'm waiting for the fix discussed below (without abusing the chip mutex ;-) ). Cheers, Miquèl > > We have +10.000 devices that runs with this patch: > > > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > > index 1f0d542d5923..58d48c3070fa 100644 > > --- a/drivers/mtd/nand/raw/nand_base.c > > +++ b/drivers/mtd/nand/raw/nand_base.c > > @@ -4337,7 +4337,6 @@ static int nand_suspend(struct mtd_info *mtd) > > ret = chip->ops.suspend(chip); > > if (!ret) > > chip->suspended = 1; > > - mutex_unlock(&chip->lock); > > > > return ret; > > } > > @@ -4350,7 +4349,6 @@ static void nand_resume(struct mtd_info *mtd) > > { > > struct nand_chip *chip = mtd_to_nand(mtd); > > > > - mutex_lock(&chip->lock); > > if (chip->suspended) { > > if (chip->ops.resume) > > chip->ops.resume(chip); > > > > But it's abusing the chip lock... Use a wait queue as we did at the MTD > level, and make nand_get_device() wait on this wait queue when the > device is suspended. > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-12-03 13:40 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-02 11:02 [PATCH v5 0/4] mtd: core: protect access to mtd devices while in suspend Sean Nyekjaer 2021-11-02 11:02 ` Sean Nyekjaer 2021-11-02 11:02 ` [PATCH v5 1/4] mtd: rawnand: nand_bbt: hide suspend/resume hooks while scanning bbt Sean Nyekjaer 2021-11-02 11:02 ` Sean Nyekjaer 2021-11-19 18:35 ` Miquel Raynal 2021-11-19 18:35 ` Miquel Raynal 2021-11-02 11:02 ` [PATCH v5 2/4] mtd: mtdconcat: don't use mtd_{suspend,resume}() Sean Nyekjaer 2021-11-02 11:02 ` Sean Nyekjaer 2021-11-19 18:35 ` Miquel Raynal 2021-11-19 18:35 ` Miquel Raynal 2021-11-02 11:02 ` [PATCH v5 3/4] mtd: core: protect access to MTD devices while in suspend Sean Nyekjaer 2021-11-02 11:02 ` Sean Nyekjaer 2021-11-19 18:35 ` Miquel Raynal 2021-11-19 18:35 ` Miquel Raynal [not found] ` <CGME20211123120353eucas1p2fb2561b7cfddd8d6e7decaef8b504f4c@eucas1p2.samsung.com> 2021-11-23 12:03 ` Marek Szyprowski 2021-11-23 12:03 ` Marek Szyprowski 2021-11-23 12:50 ` Sean Nyekjaer 2021-11-23 12:50 ` Sean Nyekjaer 2021-11-23 13:07 ` Boris Brezillon 2021-11-23 13:07 ` Boris Brezillon 2021-11-29 9:19 ` Miquel Raynal 2021-11-29 9:19 ` Miquel Raynal 2021-11-29 9:41 ` Sean Nyekjaer 2021-11-29 9:41 ` Sean Nyekjaer 2021-11-29 11:17 ` Marek Szyprowski 2021-11-29 11:17 ` Marek Szyprowski 2021-11-30 12:41 ` Sean Nyekjaer 2021-11-30 12:41 ` Sean Nyekjaer 2021-11-30 13:15 ` Boris Brezillon 2021-11-30 13:15 ` Boris Brezillon 2021-11-30 13:29 ` Sean Nyekjaer 2021-11-30 13:29 ` Sean Nyekjaer 2021-11-30 13:37 ` Boris Brezillon 2021-11-30 13:37 ` Boris Brezillon 2021-12-03 13:39 ` Miquel Raynal [this message] 2021-12-03 13:39 ` Miquel Raynal 2021-12-09 14:07 ` Sean Nyekjaer 2021-12-09 14:07 ` Sean Nyekjaer 2021-12-09 14:28 ` Miquel Raynal 2021-12-09 14:28 ` Miquel Raynal 2021-12-10 13:25 ` Sean Nyekjaer 2021-12-10 13:25 ` Sean Nyekjaer 2021-12-13 9:10 ` Miquel Raynal 2021-12-13 9:10 ` Miquel Raynal 2021-12-13 9:28 ` Boris Brezillon 2021-12-13 9:28 ` Boris Brezillon 2021-12-13 9:33 ` Miquel Raynal 2021-12-13 9:33 ` Miquel Raynal 2021-12-13 9:53 ` Boris Brezillon 2021-12-13 9:53 ` Boris Brezillon 2021-12-13 10:50 ` Sean Nyekjaer 2021-12-13 10:50 ` Sean Nyekjaer 2021-12-13 11:06 ` Boris Brezillon 2021-12-13 11:06 ` Boris Brezillon 2021-11-02 11:02 ` [PATCH v5 4/4] mtd: rawnand: remove suspended check Sean Nyekjaer 2021-11-02 11:02 ` Sean Nyekjaer 2021-11-19 18:35 ` Miquel Raynal 2021-11-19 18:35 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211203143958.40645506@xps13 \ --to=miquel.raynal@bootlin.com \ --cc=bbrezillon@kernel.org \ --cc=boris.brezillon@collabora.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=m.szyprowski@samsung.com \ --cc=richard@nod.at \ --cc=sean@geanix.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.