From: Mike Christie <michael.christie@oracle.com> To: geert@linux-m68k.org, vverma@digitalocean.com, hdanton@sina.com, hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com, mst@redhat.com, sgarzare@redhat.com, virtualization@lists.linux-foundation.org, christian.brauner@ubuntu.com, axboe@kernel.dk, linux-kernel@vger.kernel.org Cc: Mike Christie <michael.christie@oracle.com> Subject: [PATCH V5 08/10] fork: remove create_io_thread Date: Sun, 21 Nov 2021 11:49:28 -0600 [thread overview] Message-ID: <20211121174930.6690-9-michael.christie@oracle.com> (raw) In-Reply-To: <20211121174930.6690-1-michael.christie@oracle.com> create_io_thread is not used anymore so remove it. Signed-off-by: Mike Christie <michael.christie@oracle.com> --- include/linux/sched/task.h | 1 - kernel/fork.c | 22 ---------------------- 2 files changed, 23 deletions(-) diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h index 2188be3a3142..313fb8c825ae 100644 --- a/include/linux/sched/task.h +++ b/include/linux/sched/task.h @@ -89,7 +89,6 @@ extern void exit_files(struct task_struct *); extern void exit_itimers(struct signal_struct *); extern pid_t kernel_clone(struct kernel_clone_args *kargs); -struct task_struct *create_io_thread(int (*fn)(void *), void *arg, int node); struct task_struct *kernel_worker(int (*fn)(void *), void *arg, int node, unsigned long clone_flags, u32 worker_flags); __printf(2, 3) diff --git a/kernel/fork.c b/kernel/fork.c index 3729abafbdf9..1b44d048ec16 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -2521,28 +2521,6 @@ struct mm_struct *copy_init_mm(void) return dup_mm(NULL, &init_mm); } -/* - * This is like kernel_clone(), but shaved down and tailored to just - * creating io_uring workers. It returns a created task, or an error pointer. - * The returned task is inactive, and the caller must fire it up through - * wake_up_new_task(p). All signals are blocked in the created task. - */ -struct task_struct *create_io_thread(int (*fn)(void *), void *arg, int node) -{ - unsigned long flags = CLONE_FS|CLONE_FILES|CLONE_SIGHAND|CLONE_THREAD| - CLONE_IO; - struct kernel_clone_args args = { - .flags = ((lower_32_bits(flags) | CLONE_VM | - CLONE_UNTRACED) & ~CSIGNAL), - .exit_signal = (lower_32_bits(flags) & CSIGNAL), - .stack = (unsigned long)fn, - .stack_size = (unsigned long)arg, - .worker_flags = KERN_WORKER_IO | KERN_WORKER_USER, - }; - - return copy_process(NULL, 0, node, &args); -} - static bool kernel_worker_flags_valid(struct kernel_clone_args *kargs) { /* Verify that no unknown flags are passed along. */ -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Mike Christie <michael.christie@oracle.com> To: geert@linux-m68k.org, vverma@digitalocean.com, hdanton@sina.com, hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com, mst@redhat.com, sgarzare@redhat.com, virtualization@lists.linux-foundation.org, christian.brauner@ubuntu.com, axboe@kernel.dk, linux-kernel@vger.kernel.org Subject: [PATCH V5 08/10] fork: remove create_io_thread Date: Sun, 21 Nov 2021 11:49:28 -0600 [thread overview] Message-ID: <20211121174930.6690-9-michael.christie@oracle.com> (raw) In-Reply-To: <20211121174930.6690-1-michael.christie@oracle.com> create_io_thread is not used anymore so remove it. Signed-off-by: Mike Christie <michael.christie@oracle.com> --- include/linux/sched/task.h | 1 - kernel/fork.c | 22 ---------------------- 2 files changed, 23 deletions(-) diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h index 2188be3a3142..313fb8c825ae 100644 --- a/include/linux/sched/task.h +++ b/include/linux/sched/task.h @@ -89,7 +89,6 @@ extern void exit_files(struct task_struct *); extern void exit_itimers(struct signal_struct *); extern pid_t kernel_clone(struct kernel_clone_args *kargs); -struct task_struct *create_io_thread(int (*fn)(void *), void *arg, int node); struct task_struct *kernel_worker(int (*fn)(void *), void *arg, int node, unsigned long clone_flags, u32 worker_flags); __printf(2, 3) diff --git a/kernel/fork.c b/kernel/fork.c index 3729abafbdf9..1b44d048ec16 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -2521,28 +2521,6 @@ struct mm_struct *copy_init_mm(void) return dup_mm(NULL, &init_mm); } -/* - * This is like kernel_clone(), but shaved down and tailored to just - * creating io_uring workers. It returns a created task, or an error pointer. - * The returned task is inactive, and the caller must fire it up through - * wake_up_new_task(p). All signals are blocked in the created task. - */ -struct task_struct *create_io_thread(int (*fn)(void *), void *arg, int node) -{ - unsigned long flags = CLONE_FS|CLONE_FILES|CLONE_SIGHAND|CLONE_THREAD| - CLONE_IO; - struct kernel_clone_args args = { - .flags = ((lower_32_bits(flags) | CLONE_VM | - CLONE_UNTRACED) & ~CSIGNAL), - .exit_signal = (lower_32_bits(flags) & CSIGNAL), - .stack = (unsigned long)fn, - .stack_size = (unsigned long)arg, - .worker_flags = KERN_WORKER_IO | KERN_WORKER_USER, - }; - - return copy_process(NULL, 0, node, &args); -} - static bool kernel_worker_flags_valid(struct kernel_clone_args *kargs) { /* Verify that no unknown flags are passed along. */ -- 2.25.1 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-11-21 17:50 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-21 17:49 [PATCH V5 00/10] Use copy_process/create_io_thread in vhost layer Mike Christie 2021-11-21 17:49 ` Mike Christie 2021-11-21 17:49 ` [PATCH V5 01/10] fork: Make IO worker options flag based Mike Christie 2021-11-21 17:49 ` Mike Christie 2021-11-21 17:49 ` [PATCH V5 02/10] fork/vm: Move common PF_IO_WORKER behavior to new flag Mike Christie 2021-11-21 17:49 ` Mike Christie 2021-11-22 8:08 ` Geert Uytterhoeven 2021-11-22 8:08 ` Geert Uytterhoeven 2021-11-21 17:49 ` [PATCH V5 03/10] fork: add KERNEL_WORKER flag to not dup/clone files Mike Christie 2021-11-21 17:49 ` Mike Christie 2021-11-21 17:49 ` [PATCH V5 04/10] fork: Add KERNEL_WORKER flag to ignore signals Mike Christie 2021-11-21 17:49 ` Mike Christie 2021-11-21 17:49 ` [PATCH V5 05/10] signal: Perfom autoreap for PF_USER_WORKER Mike Christie 2021-11-21 17:49 ` Mike Christie 2021-11-21 17:49 ` [PATCH V5 06/10] fork: add helper to clone a process Mike Christie 2021-11-21 17:49 ` Mike Christie 2021-11-21 17:49 ` [PATCH V5 07/10] io_uring: switch to kernel_worker Mike Christie 2021-11-21 17:49 ` Mike Christie 2021-11-21 18:17 ` Jens Axboe 2021-11-21 18:17 ` Jens Axboe 2021-11-22 10:02 ` Christian Brauner 2021-11-22 14:20 ` Jens Axboe 2021-11-22 14:20 ` Jens Axboe 2021-11-22 16:47 ` michael.christie 2021-11-22 16:47 ` michael.christie 2021-11-23 14:23 ` Christian Brauner 2021-11-21 17:49 ` Mike Christie [this message] 2021-11-21 17:49 ` [PATCH V5 08/10] fork: remove create_io_thread Mike Christie 2021-11-21 17:49 ` [PATCH V5 09/10] vhost: move worker thread fields to new struct Mike Christie 2021-11-21 17:49 ` Mike Christie 2021-11-21 17:49 ` [PATCH V5 10/10] vhost: use kernel_worker to check RLIMITs Mike Christie 2021-11-21 17:49 ` Mike Christie
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211121174930.6690-9-michael.christie@oracle.com \ --to=michael.christie@oracle.com \ --cc=axboe@kernel.dk \ --cc=christian.brauner@ubuntu.com \ --cc=geert@linux-m68k.org \ --cc=hch@infradead.org \ --cc=hdanton@sina.com \ --cc=jasowang@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mst@redhat.com \ --cc=sgarzare@redhat.com \ --cc=stefanha@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=vverma@digitalocean.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.