All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/ttm: Fix error code in i915_ttm_eviction_valuable()
@ 2021-11-22  7:41 ` Dan Carpenter
  0 siblings, 0 replies; 12+ messages in thread
From: Dan Carpenter @ 2021-11-22  7:41 UTC (permalink / raw)
  To: Jani Nikula, Matthew Auld
  Cc: Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, David Airlie,
	Daniel Vetter, Thomas Hellström, Maarten Lankhorst,
	Christian König, Jason Ekstrand, Oak Zeng, intel-gfx,
	dri-devel, kernel-janitors

This function returns a bool type so returning -EBUSY is equivalent to
returning true.  It should return false instead.

Fixes: 7ae034590cea ("drm/i915/ttm: add tt shmem backend")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
index 68cfe6e9ceab..02918b990b25 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
@@ -332,7 +332,7 @@ static bool i915_ttm_eviction_valuable(struct ttm_buffer_object *bo,
 	 * but we would like to avoid grabbing locks for no good reason.
 	 */
 	if (bo->ttm && bo->ttm->page_flags & TTM_TT_FLAG_EXTERNAL)
-		return -EBUSY;
+		return false;
 
 	/* Will do for now. Our pinned objects are still on TTM's LRU lists */
 	return i915_gem_object_evictable(obj);
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2021-11-22 18:02 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-22  7:41 [PATCH] drm/i915/ttm: Fix error code in i915_ttm_eviction_valuable() Dan Carpenter
2021-11-22  7:41 ` [Intel-gfx] " Dan Carpenter
2021-11-22  7:41 ` Dan Carpenter
2021-11-22  8:52 ` Matthew Auld
2021-11-22  8:52   ` [Intel-gfx] " Matthew Auld
2021-11-22  8:52   ` Matthew Auld
2021-11-22 11:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-11-22 14:08 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-11-22 14:20   ` Dan Carpenter
2021-11-22 14:31     ` Matthew Auld
2021-11-22 18:02       ` Vudum, Lakshminarayana
2021-11-22 16:52 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.