From: kernel test robot <lkp@intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Felix.Kuehling@amd.com, alexander.deucher@amd.com,
christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
daniel@ffwll.ch
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/amdkfd: Use bitmap_zalloc() when applicable
Date: Tue, 23 Nov 2021 06:10:43 +0800 [thread overview]
Message-ID: <202111230623.6rJzehBh-lkp@intel.com> (raw)
In-Reply-To: <2343a4e6547a8436419308744ba8c433088922a5.1637516393.git.christophe.jaillet@wanadoo.fr>
[-- Attachment #1: Type: text/plain, Size: 3269 bytes --]
Hi Christophe,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next]
[also build test ERROR on v5.16-rc2 next-20211118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Christophe-JAILLET/drm-amdkfd-Use-bitmap_zalloc-when-applicable/20211122-014305
base: git://anongit.freedesktop.org/drm/drm drm-next
config: x86_64-randconfig-a015-20211121 (attached as .config)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/0f65744094ce515a9dfe6b5e655ad59861eca35b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Christophe-JAILLET/drm-amdkfd-Use-bitmap_zalloc-when-applicable/20211122-014305
git checkout 0f65744094ce515a9dfe6b5e655ad59861eca35b
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:1438:11: error: called object type 'int' is not a function or function pointer
GFP_KERNEL);
^
include/linux/gfp.h:324:20: note: expanded from macro 'GFP_KERNEL'
#define GFP_KERNEL (__GFP_RECLAIM | __GFP_IO | __GFP_FS)
^
1 error generated.
vim +/int +1438 drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c
1426
1427 static int init_doorbell_bitmap(struct qcm_process_device *qpd,
1428 struct kfd_dev *dev)
1429 {
1430 unsigned int i;
1431 int range_start = dev->shared_resources.non_cp_doorbells_start;
1432 int range_end = dev->shared_resources.non_cp_doorbells_end;
1433
1434 if (!KFD_IS_SOC15(dev->device_info->asic_family))
1435 return 0;
1436
1437 qpd->doorbell_bitmap = bitmap_zalloc(KFD_MAX_NUM_OF_QUEUES_PER_PROCESS
> 1438 GFP_KERNEL);
1439 if (!qpd->doorbell_bitmap)
1440 return -ENOMEM;
1441
1442 /* Mask out doorbells reserved for SDMA, IH, and VCN on SOC15. */
1443 pr_debug("reserved doorbell 0x%03x - 0x%03x\n", range_start, range_end);
1444 pr_debug("reserved doorbell 0x%03x - 0x%03x\n",
1445 range_start + KFD_QUEUE_DOORBELL_MIRROR_OFFSET,
1446 range_end + KFD_QUEUE_DOORBELL_MIRROR_OFFSET);
1447
1448 for (i = 0; i < KFD_MAX_NUM_OF_QUEUES_PER_PROCESS / 2; i++) {
1449 if (i >= range_start && i <= range_end) {
1450 set_bit(i, qpd->doorbell_bitmap);
1451 set_bit(i + KFD_QUEUE_DOORBELL_MIRROR_OFFSET,
1452 qpd->doorbell_bitmap);
1453 }
1454 }
1455
1456 return 0;
1457 }
1458
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36177 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Felix.Kuehling@amd.com, alexander.deucher@amd.com,
christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
daniel@ffwll.ch
Cc: kbuild-all@lists.01.org, llvm@lists.linux.dev,
kernel-janitors@vger.kernel.org, amd-gfx@lists.freedesktop.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/amdkfd: Use bitmap_zalloc() when applicable
Date: Tue, 23 Nov 2021 06:10:43 +0800 [thread overview]
Message-ID: <202111230623.6rJzehBh-lkp@intel.com> (raw)
In-Reply-To: <2343a4e6547a8436419308744ba8c433088922a5.1637516393.git.christophe.jaillet@wanadoo.fr>
[-- Attachment #1: Type: text/plain, Size: 3269 bytes --]
Hi Christophe,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next]
[also build test ERROR on v5.16-rc2 next-20211118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Christophe-JAILLET/drm-amdkfd-Use-bitmap_zalloc-when-applicable/20211122-014305
base: git://anongit.freedesktop.org/drm/drm drm-next
config: x86_64-randconfig-a015-20211121 (attached as .config)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/0f65744094ce515a9dfe6b5e655ad59861eca35b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Christophe-JAILLET/drm-amdkfd-Use-bitmap_zalloc-when-applicable/20211122-014305
git checkout 0f65744094ce515a9dfe6b5e655ad59861eca35b
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:1438:11: error: called object type 'int' is not a function or function pointer
GFP_KERNEL);
^
include/linux/gfp.h:324:20: note: expanded from macro 'GFP_KERNEL'
#define GFP_KERNEL (__GFP_RECLAIM | __GFP_IO | __GFP_FS)
^
1 error generated.
vim +/int +1438 drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c
1426
1427 static int init_doorbell_bitmap(struct qcm_process_device *qpd,
1428 struct kfd_dev *dev)
1429 {
1430 unsigned int i;
1431 int range_start = dev->shared_resources.non_cp_doorbells_start;
1432 int range_end = dev->shared_resources.non_cp_doorbells_end;
1433
1434 if (!KFD_IS_SOC15(dev->device_info->asic_family))
1435 return 0;
1436
1437 qpd->doorbell_bitmap = bitmap_zalloc(KFD_MAX_NUM_OF_QUEUES_PER_PROCESS
> 1438 GFP_KERNEL);
1439 if (!qpd->doorbell_bitmap)
1440 return -ENOMEM;
1441
1442 /* Mask out doorbells reserved for SDMA, IH, and VCN on SOC15. */
1443 pr_debug("reserved doorbell 0x%03x - 0x%03x\n", range_start, range_end);
1444 pr_debug("reserved doorbell 0x%03x - 0x%03x\n",
1445 range_start + KFD_QUEUE_DOORBELL_MIRROR_OFFSET,
1446 range_end + KFD_QUEUE_DOORBELL_MIRROR_OFFSET);
1447
1448 for (i = 0; i < KFD_MAX_NUM_OF_QUEUES_PER_PROCESS / 2; i++) {
1449 if (i >= range_start && i <= range_end) {
1450 set_bit(i, qpd->doorbell_bitmap);
1451 set_bit(i + KFD_QUEUE_DOORBELL_MIRROR_OFFSET,
1452 qpd->doorbell_bitmap);
1453 }
1454 }
1455
1456 return 0;
1457 }
1458
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36177 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 1/2] drm/amdkfd: Use bitmap_zalloc() when applicable
Date: Tue, 23 Nov 2021 06:10:43 +0800 [thread overview]
Message-ID: <202111230623.6rJzehBh-lkp@intel.com> (raw)
In-Reply-To: <2343a4e6547a8436419308744ba8c433088922a5.1637516393.git.christophe.jaillet@wanadoo.fr>
[-- Attachment #1: Type: text/plain, Size: 3348 bytes --]
Hi Christophe,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next]
[also build test ERROR on v5.16-rc2 next-20211118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Christophe-JAILLET/drm-amdkfd-Use-bitmap_zalloc-when-applicable/20211122-014305
base: git://anongit.freedesktop.org/drm/drm drm-next
config: x86_64-randconfig-a015-20211121 (attached as .config)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/0f65744094ce515a9dfe6b5e655ad59861eca35b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Christophe-JAILLET/drm-amdkfd-Use-bitmap_zalloc-when-applicable/20211122-014305
git checkout 0f65744094ce515a9dfe6b5e655ad59861eca35b
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:1438:11: error: called object type 'int' is not a function or function pointer
GFP_KERNEL);
^
include/linux/gfp.h:324:20: note: expanded from macro 'GFP_KERNEL'
#define GFP_KERNEL (__GFP_RECLAIM | __GFP_IO | __GFP_FS)
^
1 error generated.
vim +/int +1438 drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c
1426
1427 static int init_doorbell_bitmap(struct qcm_process_device *qpd,
1428 struct kfd_dev *dev)
1429 {
1430 unsigned int i;
1431 int range_start = dev->shared_resources.non_cp_doorbells_start;
1432 int range_end = dev->shared_resources.non_cp_doorbells_end;
1433
1434 if (!KFD_IS_SOC15(dev->device_info->asic_family))
1435 return 0;
1436
1437 qpd->doorbell_bitmap = bitmap_zalloc(KFD_MAX_NUM_OF_QUEUES_PER_PROCESS
> 1438 GFP_KERNEL);
1439 if (!qpd->doorbell_bitmap)
1440 return -ENOMEM;
1441
1442 /* Mask out doorbells reserved for SDMA, IH, and VCN on SOC15. */
1443 pr_debug("reserved doorbell 0x%03x - 0x%03x\n", range_start, range_end);
1444 pr_debug("reserved doorbell 0x%03x - 0x%03x\n",
1445 range_start + KFD_QUEUE_DOORBELL_MIRROR_OFFSET,
1446 range_end + KFD_QUEUE_DOORBELL_MIRROR_OFFSET);
1447
1448 for (i = 0; i < KFD_MAX_NUM_OF_QUEUES_PER_PROCESS / 2; i++) {
1449 if (i >= range_start && i <= range_end) {
1450 set_bit(i, qpd->doorbell_bitmap);
1451 set_bit(i + KFD_QUEUE_DOORBELL_MIRROR_OFFSET,
1452 qpd->doorbell_bitmap);
1453 }
1454 }
1455
1456 return 0;
1457 }
1458
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36177 bytes --]
next prev parent reply other threads:[~2021-11-22 22:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-21 17:41 [PATCH 1/2] drm/amdkfd: Use bitmap_zalloc() when applicable Christophe JAILLET
2021-11-21 17:41 ` Christophe JAILLET
2021-11-21 17:41 ` [PATCH 2/2] drm/amdkfd: Slighly optimize 'init_doorbell_bitmap()' Christophe JAILLET
2021-11-21 17:41 ` Christophe JAILLET
2021-11-22 21:44 ` Felix Kuehling
2021-11-22 21:44 ` Felix Kuehling
2021-11-23 6:02 ` Christophe JAILLET
2021-11-23 6:02 ` Christophe JAILLET
2021-11-22 22:10 ` kernel test robot [this message]
2021-11-22 22:10 ` [PATCH 1/2] drm/amdkfd: Use bitmap_zalloc() when applicable kernel test robot
2021-11-22 22:10 ` kernel test robot
2021-11-28 16:45 Christophe JAILLET
2021-11-28 16:45 ` Christophe JAILLET
2022-04-26 18:01 ` Felix Kuehling
2022-04-26 18:01 ` Felix Kuehling
2022-04-26 18:47 ` Christophe JAILLET
2022-04-26 18:47 ` Christophe JAILLET
2022-04-26 18:47 ` Christophe JAILLET
2022-04-26 20:54 ` Felix Kuehling
2022-04-26 20:54 ` Felix Kuehling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111230623.6rJzehBh-lkp@intel.com \
--to=lkp@intel.com \
--cc=Felix.Kuehling@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kbuild-all@lists.01.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=llvm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.