* wilc1000: Fix minor typos in error messages @ 2021-12-06 23:27 David Mosberger-Tang 2021-12-06 23:27 ` [PATCH 1/2] wilc1000: Fix copy-and-paste typo in wilc_set_mac_address David Mosberger-Tang 2021-12-06 23:27 ` [PATCH 2/2] wilc1000: Fix missing newline in error message David Mosberger-Tang 0 siblings, 2 replies; 8+ messages in thread From: David Mosberger-Tang @ 2021-12-06 23:27 UTC (permalink / raw) To: Ajay Singh Cc: Claudiu Beznea, Kalle Valo, David S. Miller, Jakub Kicinski, linux-wireless, netdev, linux-kernel These two patches fix typos in error messages. drivers/net/wireless/microchip/wilc1000/hif.c | 2 +- drivers/net/wireless/microchip/wilc1000/netdev.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] wilc1000: Fix copy-and-paste typo in wilc_set_mac_address 2021-12-06 23:27 wilc1000: Fix minor typos in error messages David Mosberger-Tang @ 2021-12-06 23:27 ` David Mosberger-Tang 2021-12-14 18:43 ` Kalle Valo 2021-12-06 23:27 ` [PATCH 2/2] wilc1000: Fix missing newline in error message David Mosberger-Tang 1 sibling, 1 reply; 8+ messages in thread From: David Mosberger-Tang @ 2021-12-06 23:27 UTC (permalink / raw) To: Ajay Singh Cc: Claudiu Beznea, Kalle Valo, David S. Miller, Jakub Kicinski, linux-wireless, netdev, linux-kernel, David Mosberger-Tang The messages appears to have been copied from wilc_get_mac_address and says "get" when it should say "set". Signed-off-by: David Mosberger-Tang <davidm@egauge.net> --- drivers/net/wireless/microchip/wilc1000/hif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/microchip/wilc1000/hif.c b/drivers/net/wireless/microchip/wilc1000/hif.c index e69b9c7f3d31..a019da0bfc3f 100644 --- a/drivers/net/wireless/microchip/wilc1000/hif.c +++ b/drivers/net/wireless/microchip/wilc1000/hif.c @@ -1312,7 +1312,7 @@ int wilc_set_mac_address(struct wilc_vif *vif, u8 *mac_addr) result = wilc_send_config_pkt(vif, WILC_SET_CFG, &wid, 1); if (result) - netdev_err(vif->ndev, "Failed to get mac address\n"); + netdev_err(vif->ndev, "Failed to set mac address\n"); return result; } -- 2.25.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] wilc1000: Fix copy-and-paste typo in wilc_set_mac_address 2021-12-06 23:27 ` [PATCH 1/2] wilc1000: Fix copy-and-paste typo in wilc_set_mac_address David Mosberger-Tang @ 2021-12-14 18:43 ` Kalle Valo 0 siblings, 0 replies; 8+ messages in thread From: Kalle Valo @ 2021-12-14 18:43 UTC (permalink / raw) To: David Mosberger-Tang Cc: Ajay Singh, Claudiu Beznea, Kalle Valo, David S. Miller, Jakub Kicinski, linux-wireless, netdev, linux-kernel, David Mosberger-Tang David Mosberger-Tang <davidm@egauge.net> wrote: > The messages appears to have been copied from wilc_get_mac_address and > says "get" when it should say "set". > > Signed-off-by: David Mosberger-Tang <davidm@egauge.net> 2 patches applied to wireless-drivers-next.git, thanks. f92b9f967463 wilc1000: Fix copy-and-paste typo in wilc_set_mac_address 5ae660641db8 wilc1000: Fix missing newline in error message -- https://patchwork.kernel.org/project/linux-wireless/patch/20211206232709.3192856-2-davidm@egauge.net/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] wilc1000: Fix missing newline in error message 2021-12-06 23:27 wilc1000: Fix minor typos in error messages David Mosberger-Tang 2021-12-06 23:27 ` [PATCH 1/2] wilc1000: Fix copy-and-paste typo in wilc_set_mac_address David Mosberger-Tang @ 2021-12-06 23:27 ` David Mosberger-Tang 2021-12-07 1:33 ` Joe Perches 1 sibling, 1 reply; 8+ messages in thread From: David Mosberger-Tang @ 2021-12-06 23:27 UTC (permalink / raw) To: Ajay Singh Cc: Claudiu Beznea, Kalle Valo, David S. Miller, Jakub Kicinski, linux-wireless, netdev, linux-kernel, David Mosberger-Tang Add missing newline in pr_err() message. Signed-off-by: David Mosberger-Tang <davidm@egauge.net> --- drivers/net/wireless/microchip/wilc1000/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c index 690572e01a2a..633cb3a43f6a 100644 --- a/drivers/net/wireless/microchip/wilc1000/netdev.c +++ b/drivers/net/wireless/microchip/wilc1000/netdev.c @@ -27,7 +27,7 @@ static irqreturn_t isr_uh_routine(int irq, void *user_data) struct wilc *wilc = user_data; if (wilc->close) { - pr_err("Can't handle UH interrupt"); + pr_err("Can't handle UH interrupt\n"); return IRQ_HANDLED; } return IRQ_WAKE_THREAD; -- 2.25.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] wilc1000: Fix missing newline in error message 2021-12-06 23:27 ` [PATCH 2/2] wilc1000: Fix missing newline in error message David Mosberger-Tang @ 2021-12-07 1:33 ` Joe Perches 2021-12-07 22:58 ` David Mosberger-Tang 0 siblings, 1 reply; 8+ messages in thread From: Joe Perches @ 2021-12-07 1:33 UTC (permalink / raw) To: David Mosberger-Tang, Ajay Singh Cc: Claudiu Beznea, Kalle Valo, David S. Miller, Jakub Kicinski, linux-wireless, netdev, linux-kernel On Mon, 2021-12-06 at 23:27 +0000, David Mosberger-Tang wrote: > Add missing newline in pr_err() message. [] > diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c [] > @@ -27,7 +27,7 @@ static irqreturn_t isr_uh_routine(int irq, void *user_data) > struct wilc *wilc = user_data; > > if (wilc->close) { > - pr_err("Can't handle UH interrupt"); > + pr_err("Can't handle UH interrupt\n"); Ideally this would use wiphy_<level>: wiphy_err(wilc->wiphy, "Can't handle UH interrupt\n"); ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] wilc1000: Fix missing newline in error message 2021-12-07 1:33 ` Joe Perches @ 2021-12-07 22:58 ` David Mosberger-Tang 2021-12-08 0:23 ` Joe Perches 0 siblings, 1 reply; 8+ messages in thread From: David Mosberger-Tang @ 2021-12-07 22:58 UTC (permalink / raw) To: Joe Perches, Ajay Singh Cc: Claudiu Beznea, Kalle Valo, David S. Miller, Jakub Kicinski, linux-wireless, netdev, linux-kernel On 12/6/21 6:33 PM, Joe Perches wrote: > On Mon, 2021-12-06 at 23:27 +0000, David Mosberger-Tang wrote: >> Add missing newline in pr_err() message. > [] >> diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c > [] >> @@ -27,7 +27,7 @@ static irqreturn_t isr_uh_routine(int irq, void *user_data) >> struct wilc *wilc = user_data; >> >> if (wilc->close) { >> - pr_err("Can't handle UH interrupt"); >> + pr_err("Can't handle UH interrupt\n"); > Ideally this would use wiphy_<level>: > > wiphy_err(wilc->wiphy, "Can't handle UH interrupt\n"); Sure, but that's orthogonal to this bug fix. I do have a "cleanups" branch with various cleanups of this sort. I'll look into fixing pr_*() calls in the cleanups branch (there are several of them, unsurprisingly). --david ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] wilc1000: Fix missing newline in error message 2021-12-07 22:58 ` David Mosberger-Tang @ 2021-12-08 0:23 ` Joe Perches 2021-12-08 2:19 ` David Mosberger-Tang 0 siblings, 1 reply; 8+ messages in thread From: Joe Perches @ 2021-12-08 0:23 UTC (permalink / raw) To: David Mosberger-Tang, Ajay Singh Cc: Claudiu Beznea, Kalle Valo, David S. Miller, Jakub Kicinski, linux-wireless, netdev, linux-kernel On Tue, 2021-12-07 at 15:58 -0700, David Mosberger-Tang wrote: > On 12/6/21 6:33 PM, Joe Perches wrote: > > > On Mon, 2021-12-06 at 23:27 +0000, David Mosberger-Tang wrote: > > > Add missing newline in pr_err() message. > > [] > > > diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c > > [] > > > @@ -27,7 +27,7 @@ static irqreturn_t isr_uh_routine(int irq, void *user_data) > > > struct wilc *wilc = user_data; > > > > > > if (wilc->close) { > > > - pr_err("Can't handle UH interrupt"); > > > + pr_err("Can't handle UH interrupt\n"); > > Ideally this would use wiphy_<level>: > > > > wiphy_err(wilc->wiphy, "Can't handle UH interrupt\n"); > > Sure, but that's orthogonal to this bug fix. Of course. > I do have a "cleanups" > branch with various cleanups of this sort. I'll look into fixing pr_*() > calls in the cleanups branch (there are several of them, unsurprisingly). netdev_<level> -> wiphy_<level> conversions too where feasible please. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] wilc1000: Fix missing newline in error message 2021-12-08 0:23 ` Joe Perches @ 2021-12-08 2:19 ` David Mosberger-Tang 0 siblings, 0 replies; 8+ messages in thread From: David Mosberger-Tang @ 2021-12-08 2:19 UTC (permalink / raw) To: Joe Perches, Ajay Singh Cc: Claudiu Beznea, Kalle Valo, David S. Miller, Jakub Kicinski, linux-wireless, netdev, linux-kernel On Tue, 2021-12-07 at 16:23 -0800, Joe Perches wrote: > On Tue, 2021-12-07 at 15:58 -0700, David Mosberger-Tang wrote: > > On 12/6/21 6:33 PM, Joe Perches wrote: > > > > > On Mon, 2021-12-06 at 23:27 +0000, David Mosberger-Tang wrote: > > > > Add missing newline in pr_err() message. > > > [] > > > > diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c > > > [] > > > > @@ -27,7 +27,7 @@ static irqreturn_t isr_uh_routine(int irq, void *user_data) > > > > struct wilc *wilc = user_data; > > > > > > > > if (wilc->close) { > > > > - pr_err("Can't handle UH interrupt"); > > > > + pr_err("Can't handle UH interrupt\n"); > > > Ideally this would use wiphy_<level>: > > > > > > wiphy_err(wilc->wiphy, "Can't handle UH interrupt\n"); > > > > Sure, but that's orthogonal to this bug fix. > > Of course. > > > I do have a "cleanups" > > branch with various cleanups of this sort. I'll look into fixing pr_*() > > calls in the cleanups branch (there are several of them, unsurprisingly). > > netdev_<level> -> wiphy_<level> conversions too where feasible please. OK, I made a note for that, too, thanks. --david ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-12-14 18:43 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-12-06 23:27 wilc1000: Fix minor typos in error messages David Mosberger-Tang 2021-12-06 23:27 ` [PATCH 1/2] wilc1000: Fix copy-and-paste typo in wilc_set_mac_address David Mosberger-Tang 2021-12-14 18:43 ` Kalle Valo 2021-12-06 23:27 ` [PATCH 2/2] wilc1000: Fix missing newline in error message David Mosberger-Tang 2021-12-07 1:33 ` Joe Perches 2021-12-07 22:58 ` David Mosberger-Tang 2021-12-08 0:23 ` Joe Perches 2021-12-08 2:19 ` David Mosberger-Tang
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.