From: Marijn Suijten <marijn.suijten@somainline.org> To: Lee Jones <lee.jones@linaro.org> Cc: Daniel Thompson <daniel.thompson@linaro.org>, phone-devel@vger.kernel.org, Andy Gross <agross@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Rob Herring <robh+dt@kernel.org>, Jingoo Han <jingoohan1@gmail.com>, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Martin Botka <martin.botka@somainline.org>, Jami Kettunen <jami.kettunen@somainline.org>, Pavel Dubrova <pashadubrova@gmail.com>, Kiran Gunda <kgunda@codeaurora.org>, Bryan Wu <cooloney@gmail.com>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v3 0/9] backlight: qcom-wled: fix and solidify handling of enabled-strings Date: Wed, 22 Dec 2021 00:31:31 +0100 [thread overview] Message-ID: <20211221233131.rwjjojuawgffr2gf@SoMainline.org> (raw) In-Reply-To: <YZPRV2jD1EBYGdHL@google.com> On 2021-11-16 15:42:15, Lee Jones wrote: > On Tue, 16 Nov 2021, Daniel Thompson wrote: > > > Hi Lee > > > > On Mon, Nov 15, 2021 at 09:34:50PM +0100, Marijn Suijten wrote: > > > This patchset fixes WLED's handling of enabled-strings: besides some > > > cleanup it is now actually possible to specify a non-contiguous array of > > > enabled strings (not necessarily starting at zero) and the values from > > > DT are now validated to prevent possible unexpected out-of-bounds > > > register and array element accesses. > > > Off-by-one mistakes in the maximum number of strings, also causing > > > out-of-bounds access, have been addressed as well. > > > > They have arrived piecemeal (during v1, v2 and v3) but all patches on > > the set should now have my R-b: attached to them. > > I can see that. Nothing for you to worry about. > > I'll apply these when I conduct my next sweep, thanks. Thanks for that Lee! Has the next sweep already passed by? Seems everyone is preparing for the 5.17 merge window but these patches haven't yet landed on the backlight tree [1]. I'd appreciate it if we can make them appear in the 5.17 window :) [1]: https://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git/ Thanks! - Marijn > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Marijn Suijten <marijn.suijten@somainline.org> To: Lee Jones <lee.jones@linaro.org> Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Daniel Thompson <daniel.thompson@linaro.org>, Kiran Gunda <kgunda@codeaurora.org>, Pavel Dubrova <pashadubrova@gmail.com>, Jami Kettunen <jami.kettunen@somainline.org>, Jingoo Han <jingoohan1@gmail.com>, linux-arm-msm@vger.kernel.org, Bryan Wu <cooloney@gmail.com>, Konrad Dybcio <konrad.dybcio@somainline.org>, linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Andy Gross <agross@kernel.org>, Martin Botka <martin.botka@somainline.org>, ~postmarketos/upstreaming@lists.sr.ht, linux-fbdev@vger.kernel.org, AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>, phone-devel@vger.kernel.org Subject: Re: [PATCH v3 0/9] backlight: qcom-wled: fix and solidify handling of enabled-strings Date: Wed, 22 Dec 2021 00:31:31 +0100 [thread overview] Message-ID: <20211221233131.rwjjojuawgffr2gf@SoMainline.org> (raw) In-Reply-To: <YZPRV2jD1EBYGdHL@google.com> On 2021-11-16 15:42:15, Lee Jones wrote: > On Tue, 16 Nov 2021, Daniel Thompson wrote: > > > Hi Lee > > > > On Mon, Nov 15, 2021 at 09:34:50PM +0100, Marijn Suijten wrote: > > > This patchset fixes WLED's handling of enabled-strings: besides some > > > cleanup it is now actually possible to specify a non-contiguous array of > > > enabled strings (not necessarily starting at zero) and the values from > > > DT are now validated to prevent possible unexpected out-of-bounds > > > register and array element accesses. > > > Off-by-one mistakes in the maximum number of strings, also causing > > > out-of-bounds access, have been addressed as well. > > > > They have arrived piecemeal (during v1, v2 and v3) but all patches on > > the set should now have my R-b: attached to them. > > I can see that. Nothing for you to worry about. > > I'll apply these when I conduct my next sweep, thanks. Thanks for that Lee! Has the next sweep already passed by? Seems everyone is preparing for the 5.17 merge window but these patches haven't yet landed on the backlight tree [1]. I'd appreciate it if we can make them appear in the 5.17 window :) [1]: https://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git/ Thanks! - Marijn > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-12-21 23:31 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-15 20:34 [PATCH v3 0/9] backlight: qcom-wled: fix and solidify handling of enabled-strings Marijn Suijten 2021-11-15 20:34 ` Marijn Suijten 2021-11-15 20:34 ` [PATCH v3 1/9] backlight: qcom-wled: Validate enabled string indices in DT Marijn Suijten 2021-11-15 20:34 ` Marijn Suijten 2021-12-22 11:15 ` Lee Jones 2021-12-22 11:15 ` Lee Jones 2021-11-15 20:34 ` [PATCH v3 2/9] backlight: qcom-wled: Pass number of elements to read to read_u32_array Marijn Suijten 2021-11-15 20:34 ` Marijn Suijten 2021-12-22 11:15 ` Lee Jones 2021-12-22 11:15 ` Lee Jones 2021-11-15 20:34 ` [PATCH v3 3/9] backlight: qcom-wled: Use cpu_to_le16 macro to perform conversion Marijn Suijten 2021-11-15 20:34 ` Marijn Suijten 2021-11-16 11:56 ` Daniel Thompson 2021-11-16 11:56 ` Daniel Thompson 2021-12-22 11:16 ` Lee Jones 2021-12-22 11:16 ` Lee Jones 2021-11-15 20:34 ` [PATCH v3 4/9] backlight: qcom-wled: Fix off-by-one maximum with default num_strings Marijn Suijten 2021-11-15 20:34 ` Marijn Suijten 2021-11-16 11:58 ` Daniel Thompson 2021-11-16 11:58 ` Daniel Thompson 2021-12-22 11:16 ` Lee Jones 2021-12-22 11:16 ` Lee Jones 2021-11-15 20:34 ` [PATCH v3 5/9] backlight: qcom-wled: Override default length with qcom, enabled-strings Marijn Suijten 2021-11-15 20:34 ` [PATCH v3 5/9] backlight: qcom-wled: Override default length with qcom,enabled-strings Marijn Suijten 2021-11-16 11:59 ` Daniel Thompson 2021-11-16 11:59 ` Daniel Thompson 2021-12-22 11:17 ` Lee Jones 2021-12-22 11:17 ` Lee Jones 2021-11-15 20:34 ` [PATCH v3 6/9] backlight: qcom-wled: Remove unnecessary 4th default string in WLED3 Marijn Suijten 2021-11-15 20:34 ` Marijn Suijten 2021-12-22 11:17 ` Lee Jones 2021-12-22 11:17 ` Lee Jones 2021-11-15 20:34 ` [PATCH v3 7/9] backlight: qcom-wled: Provide enabled_strings default for WLED 4 and 5 Marijn Suijten 2021-11-15 20:34 ` Marijn Suijten 2021-12-22 11:18 ` Lee Jones 2021-12-22 11:18 ` Lee Jones 2021-11-15 20:34 ` [PATCH v3 8/9] backlight: qcom-wled: Remove unnecessary double whitespace Marijn Suijten 2021-11-15 20:34 ` Marijn Suijten 2021-12-22 11:18 ` Lee Jones 2021-12-22 11:18 ` Lee Jones 2021-11-15 20:34 ` [PATCH v3 9/9] backlight: qcom-wled: Respect enabled-strings in set_brightness Marijn Suijten 2021-11-15 20:34 ` Marijn Suijten 2021-12-22 11:18 ` Lee Jones 2021-12-22 11:18 ` Lee Jones 2021-11-16 12:02 ` [PATCH v3 0/9] backlight: qcom-wled: fix and solidify handling of enabled-strings Daniel Thompson 2021-11-16 12:02 ` Daniel Thompson 2021-11-16 15:42 ` Lee Jones 2021-11-16 15:42 ` Lee Jones 2021-12-21 23:31 ` Marijn Suijten [this message] 2021-12-21 23:31 ` Marijn Suijten 2021-12-22 10:56 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211221233131.rwjjojuawgffr2gf@SoMainline.org \ --to=marijn.suijten@somainline.org \ --cc=agross@kernel.org \ --cc=angelogioacchino.delregno@somainline.org \ --cc=bjorn.andersson@linaro.org \ --cc=cooloney@gmail.com \ --cc=daniel.thompson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jami.kettunen@somainline.org \ --cc=jingoohan1@gmail.com \ --cc=kgunda@codeaurora.org \ --cc=konrad.dybcio@somainline.org \ --cc=lee.jones@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=martin.botka@somainline.org \ --cc=pashadubrova@gmail.com \ --cc=phone-devel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=~postmarketos/upstreaming@lists.sr.ht \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.