Re: [PATCH 3/4] net/mlx5e: Use auxiliary_device driver data helpers

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 3/4] net/mlx5e: Use auxiliary_device driver data helpers
Date: Wed, 22 Dec 2021 17:56:35 +0800	[thread overview]
Message-ID: <202112221705.OaQ9zc1H-lkp@intel.com> (raw)
In-Reply-To: <20211221235852.323752-4-david.e.box@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 4419 bytes --]

Hi "David,

I love your patch! Perhaps something to improve:

[auto build test WARNING on rdma/for-next]
[also build test WARNING on staging/staging-testing linus/master v5.16-rc6 next-20211221]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/David-E-Box/driver_core-Auxiliary-drvdata-helper-cleanup/20211222-080023
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20211222/202112221705.OaQ9zc1H-lkp(a)intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1b4157338957cb848baaecc20e2cd01271bb1324
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review David-E-Box/driver_core-Auxiliary-drvdata-helper-cleanup/20211222-080023
        git checkout 1b4157338957cb848baaecc20e2cd01271bb1324
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/infiniband/hw/irdma/ drivers/infiniband/hw/mlx5/ drivers/net/ethernet/mellanox/mlx5/core/ drivers/vdpa/mlx5/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_resume':
   drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5392:35: error: implicit declaration of function 'auxiliary_get_drvdata' [-Werror=implicit-function-declaration]
    5392 |         struct mlx5e_priv *priv = auxiliary_get_drvdata(adev);
         |                                   ^~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5392:35: warning: initialization of 'struct mlx5e_priv *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
   drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_suspend':
   drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5415:35: warning: initialization of 'struct mlx5e_priv *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    5415 |         struct mlx5e_priv *priv = auxiliary_get_drvdata(adev);
         |                                   ^~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_probe':
   drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5459:9: error: implicit declaration of function 'auxiliary_set_drvdata' [-Werror=implicit-function-declaration]
    5459 |         auxiliary_set_drvdata(adev, priv);
         |         ^~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_remove':
   drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5507:35: warning: initialization of 'struct mlx5e_priv *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    5507 |         struct mlx5e_priv *priv = auxiliary_get_drvdata(adev);
         |                                   ^~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +5392 drivers/net/ethernet/mellanox/mlx5/core/en_main.c

  5388	
  5389	static int mlx5e_resume(struct auxiliary_device *adev)
  5390	{
  5391		struct mlx5_adev *edev = container_of(adev, struct mlx5_adev, adev);
> 5392		struct mlx5e_priv *priv = auxiliary_get_drvdata(adev);
  5393		struct net_device *netdev = priv->netdev;
  5394		struct mlx5_core_dev *mdev = edev->mdev;
  5395		int err;
  5396	
  5397		if (netif_device_present(netdev))
  5398			return 0;
  5399	
  5400		err = mlx5e_create_mdev_resources(mdev);
  5401		if (err)
  5402			return err;
  5403	
  5404		err = mlx5e_attach_netdev(priv);
  5405		if (err) {
  5406			mlx5e_destroy_mdev_resources(mdev);
  5407			return err;
  5408		}
  5409	
  5410		return 0;
  5411	}
  5412	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org