From: Cezary Rojewski <cezary.rojewski@intel.com>
To: "David E. Box" <david.e.box@linux.intel.com>,
<gregkh@linuxfoundation.org>, <mustafa.ismail@intel.com>,
<shiraz.saleem@intel.com>, <dledford@redhat.com>, <jgg@ziepe.ca>,
<leon@kernel.org>, <saeedm@nvidia.com>, <davem@davemloft.net>,
<kuba@kernel.org>, <vkoul@kernel.org>,
<yung-chuan.liao@linux.intel.com>,
<pierre-louis.bossart@linux.intel.com>, <mst@redhat.com>,
<jasowang@redhat.com>
Cc: <andriy.shevchenko@linux.intel.com>, <hdegoede@redhat.com>,
<virtualization@lists.linux-foundation.org>,
<alsa-devel@alsa-project.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH 1/4] RDMA/irdma: Use auxiliary_device driver data helpers
Date: Wed, 22 Dec 2021 13:27:38 +0100 [thread overview]
Message-ID: <bd0d2737-8fc0-050a-435e-8e4837c87ea5@intel.com> (raw)
In-Reply-To: <20211221235852.323752-2-david.e.box@linux.intel.com>
On 2021-12-22 12:58 AM, David E. Box wrote:
> Use auxiliary_get_drvdata and auxiliary_set_drvdata helpers.
>
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> ---
> drivers/infiniband/hw/irdma/main.c | 4 ++--
> drivers/infiniband/hw/mlx5/main.c | 8 ++++----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/hw/irdma/main.c b/drivers/infiniband/hw/irdma/main.c
> index 51a41359e0b4..9ccf4d683f8a 100644
> --- a/drivers/infiniband/hw/irdma/main.c
> +++ b/drivers/infiniband/hw/irdma/main.c
While two occurrences of aux_dev->dev have been addressed here for
irdma/main.c, there is one more that probably could get updated too:
static void irdma_iidc_event_handler(struct ice_pf *pf, struct
iidrc_event *event)
{
struct irdma_device *iwdev = dev_get_drvdata(&pf->adev->dev);
(...)
}
Note: the declaration of struct ice_pf reads:
struct ice_pf {
(...)
struct auxiliary_device *adev;
(...)
};
leads into suggestion:
struct irdma_device *iwdev = auxiliary_get_drvdata(pf->adev);
Of course, even if I'm right about this, such change could be applied
with a separate patch and does not block the current review.
Regards,
Czarek
WARNING: multiple messages have this Message-ID (diff)
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: "David E. Box" <david.e.box@linux.intel.com>,
<gregkh@linuxfoundation.org>, <mustafa.ismail@intel.com>,
<shiraz.saleem@intel.com>, <dledford@redhat.com>, <jgg@ziepe.ca>,
<leon@kernel.org>, <saeedm@nvidia.com>, <davem@davemloft.net>,
<kuba@kernel.org>, <vkoul@kernel.org>,
<yung-chuan.liao@linux.intel.com>,
<pierre-louis.bossart@linux.intel.com>, <mst@redhat.com>,
<jasowang@redhat.com>
Cc: alsa-devel@alsa-project.org, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, hdegoede@redhat.com,
andriy.shevchenko@linux.intel.com
Subject: Re: [PATCH 1/4] RDMA/irdma: Use auxiliary_device driver data helpers
Date: Wed, 22 Dec 2021 13:27:38 +0100 [thread overview]
Message-ID: <bd0d2737-8fc0-050a-435e-8e4837c87ea5@intel.com> (raw)
In-Reply-To: <20211221235852.323752-2-david.e.box@linux.intel.com>
On 2021-12-22 12:58 AM, David E. Box wrote:
> Use auxiliary_get_drvdata and auxiliary_set_drvdata helpers.
>
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> ---
> drivers/infiniband/hw/irdma/main.c | 4 ++--
> drivers/infiniband/hw/mlx5/main.c | 8 ++++----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/hw/irdma/main.c b/drivers/infiniband/hw/irdma/main.c
> index 51a41359e0b4..9ccf4d683f8a 100644
> --- a/drivers/infiniband/hw/irdma/main.c
> +++ b/drivers/infiniband/hw/irdma/main.c
While two occurrences of aux_dev->dev have been addressed here for
irdma/main.c, there is one more that probably could get updated too:
static void irdma_iidc_event_handler(struct ice_pf *pf, struct
iidrc_event *event)
{
struct irdma_device *iwdev = dev_get_drvdata(&pf->adev->dev);
(...)
}
Note: the declaration of struct ice_pf reads:
struct ice_pf {
(...)
struct auxiliary_device *adev;
(...)
};
leads into suggestion:
struct irdma_device *iwdev = auxiliary_get_drvdata(pf->adev);
Of course, even if I'm right about this, such change could be applied
with a separate patch and does not block the current review.
Regards,
Czarek
next prev parent reply other threads:[~2021-12-22 12:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 23:58 [PATCH 0/4] driver_core: Auxiliary drvdata helper cleanup David E. Box
2021-12-21 23:58 ` [PATCH 1/4] RDMA/irdma: Use auxiliary_device driver data helpers David E. Box
2021-12-22 7:34 ` kernel test robot
2021-12-22 12:27 ` Cezary Rojewski [this message]
2021-12-22 12:27 ` Cezary Rojewski
2021-12-21 23:58 ` [PATCH 2/4] soundwire: intel: " David E. Box
2021-12-22 11:18 ` Andy Shevchenko
2021-12-22 11:18 ` Andy Shevchenko
2021-12-22 11:18 ` Andy Shevchenko
2021-12-21 23:58 ` [PATCH 3/4] net/mlx5e: " David E. Box
2021-12-22 9:56 ` kernel test robot
2021-12-21 23:58 ` [PATCH 4/4] vdpa/mlx5: " David E. Box
2021-12-22 12:08 ` kernel test robot
2021-12-22 0:09 ` [PATCH 0/4] driver_core: Auxiliary drvdata helper cleanup Jason Gunthorpe
2021-12-22 0:09 ` Jason Gunthorpe
2021-12-22 0:09 ` Jason Gunthorpe
2021-12-22 0:48 ` David E. Box
2021-12-22 17:18 ` Jason Gunthorpe
2021-12-22 17:18 ` Jason Gunthorpe
2021-12-22 17:18 ` Jason Gunthorpe
2021-12-22 12:34 ` Cezary Rojewski
2021-12-22 12:34 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd0d2737-8fc0-050a-435e-8e4837c87ea5@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=david.e.box@linux.intel.com \
--cc=dledford@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jasowang@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mustafa.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=saeedm@nvidia.com \
--cc=shiraz.saleem@intel.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.