* [PATCH] mfd: db8500-prcmu: remove dead code for a non-existing config
@ 2021-12-27 6:48 ` Lukas Bulwahn
0 siblings, 0 replies; 8+ messages in thread
From: Lukas Bulwahn @ 2021-12-27 6:48 UTC (permalink / raw)
To: Linus Walleij, Lee Jones, linux-arm-kernel
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
The config DBX500_PRCMU_QOS_POWER was never introduced in the kernel
repository. So, the ifdef in ./include/linux/mfd/dbx500-prcmu.h was never
effective.
Remove these dead function prototypes.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
include/linux/mfd/dbx500-prcmu.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/include/linux/mfd/dbx500-prcmu.h b/include/linux/mfd/dbx500-prcmu.h
index cbf9d7619493..2a255362b5ac 100644
--- a/include/linux/mfd/dbx500-prcmu.h
+++ b/include/linux/mfd/dbx500-prcmu.h
@@ -556,22 +556,6 @@ static inline void prcmu_clear(unsigned int reg, u32 bits)
#define PRCMU_QOS_ARM_OPP 3
#define PRCMU_QOS_DEFAULT_VALUE -1
-#ifdef CONFIG_DBX500_PRCMU_QOS_POWER
-
-unsigned long prcmu_qos_get_cpufreq_opp_delay(void);
-void prcmu_qos_set_cpufreq_opp_delay(unsigned long);
-void prcmu_qos_force_opp(int, s32);
-int prcmu_qos_requirement(int pm_qos_class);
-int prcmu_qos_add_requirement(int pm_qos_class, char *name, s32 value);
-int prcmu_qos_update_requirement(int pm_qos_class, char *name, s32 new_value);
-void prcmu_qos_remove_requirement(int pm_qos_class, char *name);
-int prcmu_qos_add_notifier(int prcmu_qos_class,
- struct notifier_block *notifier);
-int prcmu_qos_remove_notifier(int prcmu_qos_class,
- struct notifier_block *notifier);
-
-#else
-
static inline unsigned long prcmu_qos_get_cpufreq_opp_delay(void)
{
return 0;
@@ -613,6 +597,4 @@ static inline int prcmu_qos_remove_notifier(int prcmu_qos_class,
return 0;
}
-#endif
-
#endif /* __MACH_PRCMU_H */
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] mfd: db8500-prcmu: remove dead code for a non-existing config
@ 2021-12-27 6:48 ` Lukas Bulwahn
0 siblings, 0 replies; 8+ messages in thread
From: Lukas Bulwahn @ 2021-12-27 6:48 UTC (permalink / raw)
To: Linus Walleij, Lee Jones, linux-arm-kernel
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
The config DBX500_PRCMU_QOS_POWER was never introduced in the kernel
repository. So, the ifdef in ./include/linux/mfd/dbx500-prcmu.h was never
effective.
Remove these dead function prototypes.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
include/linux/mfd/dbx500-prcmu.h | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/include/linux/mfd/dbx500-prcmu.h b/include/linux/mfd/dbx500-prcmu.h
index cbf9d7619493..2a255362b5ac 100644
--- a/include/linux/mfd/dbx500-prcmu.h
+++ b/include/linux/mfd/dbx500-prcmu.h
@@ -556,22 +556,6 @@ static inline void prcmu_clear(unsigned int reg, u32 bits)
#define PRCMU_QOS_ARM_OPP 3
#define PRCMU_QOS_DEFAULT_VALUE -1
-#ifdef CONFIG_DBX500_PRCMU_QOS_POWER
-
-unsigned long prcmu_qos_get_cpufreq_opp_delay(void);
-void prcmu_qos_set_cpufreq_opp_delay(unsigned long);
-void prcmu_qos_force_opp(int, s32);
-int prcmu_qos_requirement(int pm_qos_class);
-int prcmu_qos_add_requirement(int pm_qos_class, char *name, s32 value);
-int prcmu_qos_update_requirement(int pm_qos_class, char *name, s32 new_value);
-void prcmu_qos_remove_requirement(int pm_qos_class, char *name);
-int prcmu_qos_add_notifier(int prcmu_qos_class,
- struct notifier_block *notifier);
-int prcmu_qos_remove_notifier(int prcmu_qos_class,
- struct notifier_block *notifier);
-
-#else
-
static inline unsigned long prcmu_qos_get_cpufreq_opp_delay(void)
{
return 0;
@@ -613,6 +597,4 @@ static inline int prcmu_qos_remove_notifier(int prcmu_qos_class,
return 0;
}
-#endif
-
#endif /* __MACH_PRCMU_H */
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] mfd: db8500-prcmu: remove dead code for a non-existing config
2021-12-27 6:48 ` Lukas Bulwahn
@ 2021-12-28 0:48 ` Linus Walleij
-1 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2021-12-28 0:48 UTC (permalink / raw)
To: Lukas Bulwahn; +Cc: Lee Jones, linux-arm-kernel, kernel-janitors, linux-kernel
On Mon, Dec 27, 2021 at 7:50 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> The config DBX500_PRCMU_QOS_POWER was never introduced in the kernel
> repository. So, the ifdef in ./include/linux/mfd/dbx500-prcmu.h was never
> effective.
>
> Remove these dead function prototypes.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
BTW: Lukas are you using this platform or just general winter cleaning?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd: db8500-prcmu: remove dead code for a non-existing config
@ 2021-12-28 0:48 ` Linus Walleij
0 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2021-12-28 0:48 UTC (permalink / raw)
To: Lukas Bulwahn; +Cc: Lee Jones, linux-arm-kernel, kernel-janitors, linux-kernel
On Mon, Dec 27, 2021 at 7:50 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> The config DBX500_PRCMU_QOS_POWER was never introduced in the kernel
> repository. So, the ifdef in ./include/linux/mfd/dbx500-prcmu.h was never
> effective.
>
> Remove these dead function prototypes.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
BTW: Lukas are you using this platform or just general winter cleaning?
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd: db8500-prcmu: remove dead code for a non-existing config
2021-12-28 0:48 ` Linus Walleij
@ 2021-12-28 8:11 ` Lukas Bulwahn
-1 siblings, 0 replies; 8+ messages in thread
From: Lukas Bulwahn @ 2021-12-28 8:11 UTC (permalink / raw)
To: Linus Walleij
Cc: Lee Jones, Linux ARM, kernel-janitors, Linux Kernel Mailing List
On Tue, Dec 28, 2021 at 1:48 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Mon, Dec 27, 2021 at 7:50 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> > The config DBX500_PRCMU_QOS_POWER was never introduced in the kernel
> > repository. So, the ifdef in ./include/linux/mfd/dbx500-prcmu.h was never
> > effective.
> >
> > Remove these dead function prototypes.
> >
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> BTW: Lukas are you using this platform or just general winter cleaning?
>
I am not using this platform, but just doing some janitorial work with
the checkkconfigsymbols.py script, which Randy Dunlap has pointed out
to me. This "general winter cleaning" really started as a "summer
break clean-up" and just took longer... I am also writing a blog post
summarizing the results of these whole kernel clean-up activities and
I will share it with you once it is published.
Lukas
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd: db8500-prcmu: remove dead code for a non-existing config
@ 2021-12-28 8:11 ` Lukas Bulwahn
0 siblings, 0 replies; 8+ messages in thread
From: Lukas Bulwahn @ 2021-12-28 8:11 UTC (permalink / raw)
To: Linus Walleij
Cc: Lee Jones, Linux ARM, kernel-janitors, Linux Kernel Mailing List
On Tue, Dec 28, 2021 at 1:48 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Mon, Dec 27, 2021 at 7:50 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> > The config DBX500_PRCMU_QOS_POWER was never introduced in the kernel
> > repository. So, the ifdef in ./include/linux/mfd/dbx500-prcmu.h was never
> > effective.
> >
> > Remove these dead function prototypes.
> >
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> BTW: Lukas are you using this platform or just general winter cleaning?
>
I am not using this platform, but just doing some janitorial work with
the checkkconfigsymbols.py script, which Randy Dunlap has pointed out
to me. This "general winter cleaning" really started as a "summer
break clean-up" and just took longer... I am also writing a blog post
summarizing the results of these whole kernel clean-up activities and
I will share it with you once it is published.
Lukas
> Yours,
> Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd: db8500-prcmu: remove dead code for a non-existing config
2021-12-27 6:48 ` Lukas Bulwahn
@ 2022-02-08 9:02 ` Lee Jones
-1 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2022-02-08 9:02 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Linus Walleij, linux-arm-kernel, kernel-janitors, linux-kernel
On Mon, 27 Dec 2021, Lukas Bulwahn wrote:
> The config DBX500_PRCMU_QOS_POWER was never introduced in the kernel
> repository. So, the ifdef in ./include/linux/mfd/dbx500-prcmu.h was never
> effective.
>
> Remove these dead function prototypes.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> include/linux/mfd/dbx500-prcmu.h | 18 ------------------
> 1 file changed, 18 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mfd: db8500-prcmu: remove dead code for a non-existing config
@ 2022-02-08 9:02 ` Lee Jones
0 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2022-02-08 9:02 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Linus Walleij, linux-arm-kernel, kernel-janitors, linux-kernel
On Mon, 27 Dec 2021, Lukas Bulwahn wrote:
> The config DBX500_PRCMU_QOS_POWER was never introduced in the kernel
> repository. So, the ifdef in ./include/linux/mfd/dbx500-prcmu.h was never
> effective.
>
> Remove these dead function prototypes.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> include/linux/mfd/dbx500-prcmu.h | 18 ------------------
> 1 file changed, 18 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-02-08 9:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-27 6:48 [PATCH] mfd: db8500-prcmu: remove dead code for a non-existing config Lukas Bulwahn
2021-12-27 6:48 ` Lukas Bulwahn
2021-12-28 0:48 ` Linus Walleij
2021-12-28 0:48 ` Linus Walleij
2021-12-28 8:11 ` Lukas Bulwahn
2021-12-28 8:11 ` Lukas Bulwahn
2022-02-08 9:02 ` Lee Jones
2022-02-08 9:02 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.