All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephan Mueller <smueller-T9tCv8IpfcWELgA04lAiVw@public.gmane.org>
To: Herbert Xu <herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
Cc: 'Quentin Gouchet'
	<quentin.gouchet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Daniel Borkmann
	<dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	'LKML' <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	'Linux API' <linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v12 1/2] crypto: AF_ALG: add AEAD support
Date: Fri, 27 Feb 2015 11:26:32 +0100	[thread overview]
Message-ID: <2021530.t7zNty0mPn@tauon> (raw)
In-Reply-To: <20150227094944.GA29071-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>

Am Freitag, 27. Februar 2015, 22:49:44 schrieb Herbert Xu:

Hi Herbert,

>On Thu, Feb 05, 2015 at 04:10:58PM +0100, Stephan Mueller wrote:
>> Am Donnerstag, 29. Januar 2015, 21:24:45 schrieb Stephan Mueller:
>> 
>> Hi Herbert,
>> 
>> > This patch adds the AEAD support for AF_ALG.
>> > 
>> > The implementation is based on algif_skcipher, but contains heavy
>> > modifications to streamline the interface for AEAD uses.
>> > 
>> > To use AEAD, the user space consumer has to use the salg_type named
>> > "aead".
>> 
>> I just saw Al Viro's patch to use the iov_iter API in
>> algif_skcipher.c. I looked at it but lacked documentation for using
>> it properly. Now I have a template that I will incorporate into
>> algif_aead.c
>
>Please resubmit once you have done this.

I have done that, but as indicated with an email to Al, I cannot get his 
patch for skcipher and hash to work. Similarly, my modification for the 
AEAD does not work either. So, I do not see that Al's patch can be 
merged as is.

Therefore, I have not submitted my patch as Al mentioned he wanted to 
look into his patchset.
>
>Thanks,


Ciao
Stephan

WARNING: multiple messages have this Message-ID (diff)
From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "'Quentin Gouchet'" <quentin.gouchet@gmail.com>,
	Daniel Borkmann <dborkman@redhat.com>,
	"'LKML'" <linux-kernel@vger.kernel.org>,
	linux-crypto@vger.kernel.org,
	"'Linux API'" <linux-api@vger.kernel.org>
Subject: Re: [PATCH v12 1/2] crypto: AF_ALG: add AEAD support
Date: Fri, 27 Feb 2015 11:26:32 +0100	[thread overview]
Message-ID: <2021530.t7zNty0mPn@tauon> (raw)
In-Reply-To: <20150227094944.GA29071@gondor.apana.org.au>

Am Freitag, 27. Februar 2015, 22:49:44 schrieb Herbert Xu:

Hi Herbert,

>On Thu, Feb 05, 2015 at 04:10:58PM +0100, Stephan Mueller wrote:
>> Am Donnerstag, 29. Januar 2015, 21:24:45 schrieb Stephan Mueller:
>> 
>> Hi Herbert,
>> 
>> > This patch adds the AEAD support for AF_ALG.
>> > 
>> > The implementation is based on algif_skcipher, but contains heavy
>> > modifications to streamline the interface for AEAD uses.
>> > 
>> > To use AEAD, the user space consumer has to use the salg_type named
>> > "aead".
>> 
>> I just saw Al Viro's patch to use the iov_iter API in
>> algif_skcipher.c. I looked at it but lacked documentation for using
>> it properly. Now I have a template that I will incorporate into
>> algif_aead.c
>
>Please resubmit once you have done this.

I have done that, but as indicated with an email to Al, I cannot get his 
patch for skcipher and hash to work. Similarly, my modification for the 
AEAD does not work either. So, I do not see that Al's patch can be 
merged as is.

Therefore, I have not submitted my patch as Al mentioned he wanted to 
look into his patchset.
>
>Thanks,


Ciao
Stephan

  parent reply	other threads:[~2015-02-27 10:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29 20:23 [PATCH v12 0/2] crypto: AF_ALG: add AEAD and RNG support Stephan Mueller
2015-01-29 20:24 ` [PATCH v12 1/2] crypto: AF_ALG: add AEAD support Stephan Mueller
     [not found]   ` <2035690.30evPElJOm-PJstQz4BMNNP20K/wil9xYQuADTiUCJX@public.gmane.org>
2015-02-05 15:10     ` Stephan Mueller
2015-02-05 15:10       ` Stephan Mueller
2015-02-27  9:49       ` Herbert Xu
     [not found]         ` <20150227094944.GA29071-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2015-02-27 10:26           ` Stephan Mueller [this message]
2015-02-27 10:26             ` Stephan Mueller
2015-02-27 18:34             ` Tadeusz Struk
     [not found]               ` <54F0B8BD.30600-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-02-27 18:54                 ` Stephan Mueller
2015-02-27 18:54                   ` Stephan Mueller
     [not found] ` <1681008.mocmysOoQU-PJstQz4BMNNP20K/wil9xYQuADTiUCJX@public.gmane.org>
2015-01-29 20:26   ` [PATCH v12 2/2] crypto: AF_ALG: enable AEAD interface compilation Stephan Mueller
2015-01-29 20:26     ` Stephan Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2021530.t7zNty0mPn@tauon \
    --to=smueller-t9tcv8ipfcwelga04laivw@public.gmane.org \
    --cc=dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=quentin.gouchet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.