From: kernel test robot <lkp@intel.com>
To: Caleb Connolly <caleb.connolly@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 3/7] iio: adc: qcom-spmi-rradc: introduce round robin adc
Date: Thu, 6 Jan 2022 05:05:49 +0800 [thread overview]
Message-ID: <202201060438.QiDzs9rA-lkp@intel.com> (raw)
In-Reply-To: <20220105183353.2505744-4-caleb.connolly@linaro.org>
Hi Caleb,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on jic23-iio/togreg lee-mfd/for-mfd-next v5.16-rc8 next-20220105]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Caleb-Connolly/iio-adc-introduce-Qualcomm-SPMI-Round-Robin-ADC/20220106-023716
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220106/202201060438.QiDzs9rA-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/167368793a009e8c1ce75b0b8b0965a4574af527
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Caleb-Connolly/iio-adc-introduce-Qualcomm-SPMI-Round-Robin-ADC/20220106-023716
git checkout 167368793a009e8c1ce75b0b8b0965a4574af527
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/iio/adc/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/iio/adc/qcom-spmi-rradc.c: In function 'rradc_prepare_batt_id_conversion':
>> drivers/iio/adc/qcom-spmi-rradc.c:624:25: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
624 | FIELD_PREP(BATT_ID_SETTLE_MASK, chip->batt_id_delay);
| ^~~~~~~~~~
cc1: some warnings being treated as errors
vim +/FIELD_PREP +624 drivers/iio/adc/qcom-spmi-rradc.c
607
608 static int rradc_prepare_batt_id_conversion(struct rradc_chip *chip,
609 enum rradc_channel_id chan_id,
610 u16 *data)
611 {
612 int ret, batt_id_delay;
613
614 ret = regmap_update_bits(chip->regmap, chip->base + RR_ADC_BATT_ID_CTRL,
615 RR_ADC_BATT_ID_CTRL_CHANNEL_CONV,
616 RR_ADC_BATT_ID_CTRL_CHANNEL_CONV);
617 if (ret < 0) {
618 dev_err(chip->dev, "Enabling BATT ID channel failed:%d\n", ret);
619 return ret;
620 }
621
622 if (chip->batt_id_delay != -EINVAL) {
623 batt_id_delay =
> 624 FIELD_PREP(BATT_ID_SETTLE_MASK, chip->batt_id_delay);
625 ret = regmap_update_bits(chip->regmap,
626 chip->base + RR_ADC_BATT_ID_CFG,
627 batt_id_delay, batt_id_delay);
628 if (ret < 0) {
629 dev_err(chip->dev,
630 "BATT_ID settling time config failed:%d\n",
631 ret);
632 goto out_disable_batt_id;
633 }
634 }
635
636 ret = regmap_update_bits(chip->regmap,
637 chip->base + RR_ADC_BATT_ID_TRIGGER,
638 RR_ADC_TRIGGER_CTL, RR_ADC_TRIGGER_CTL);
639 if (ret < 0) {
640 dev_err(chip->dev, "BATT_ID trigger set failed:%d\n", ret);
641 goto out_disable_batt_id;
642 }
643
644 ret = rradc_read_status_in_cont_mode(chip, chan_id);
645 if (ret < 0)
646 dev_err(chip->dev, "Error reading in continuous mode:%d\n",
647 ret);
648
649 /*
650 * Reset registers back to default values
651 */
652 ret = regmap_update_bits(chip->regmap,
653 chip->base + RR_ADC_BATT_ID_TRIGGER,
654 RR_ADC_TRIGGER_CTL, 0);
655 if (ret < 0)
656 dev_err(chip->dev, "BATT_ID trigger re-set failed:%d\n", ret);
657
658 out_disable_batt_id:
659 ret = regmap_update_bits(chip->regmap, chip->base + RR_ADC_BATT_ID_CTRL,
660 RR_ADC_BATT_ID_CTRL_CHANNEL_CONV, 0);
661 if (ret < 0)
662 dev_err(chip->dev, "Disabling BATT ID channel failed:%d\n",
663 ret);
664
665 return ret;
666 }
667
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 3/7] iio: adc: qcom-spmi-rradc: introduce round robin adc
Date: Thu, 06 Jan 2022 05:05:49 +0800 [thread overview]
Message-ID: <202201060438.QiDzs9rA-lkp@intel.com> (raw)
In-Reply-To: <20220105183353.2505744-4-caleb.connolly@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 4357 bytes --]
Hi Caleb,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on jic23-iio/togreg lee-mfd/for-mfd-next v5.16-rc8 next-20220105]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Caleb-Connolly/iio-adc-introduce-Qualcomm-SPMI-Round-Robin-ADC/20220106-023716
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220106/202201060438.QiDzs9rA-lkp(a)intel.com/config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/167368793a009e8c1ce75b0b8b0965a4574af527
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Caleb-Connolly/iio-adc-introduce-Qualcomm-SPMI-Round-Robin-ADC/20220106-023716
git checkout 167368793a009e8c1ce75b0b8b0965a4574af527
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/iio/adc/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/iio/adc/qcom-spmi-rradc.c: In function 'rradc_prepare_batt_id_conversion':
>> drivers/iio/adc/qcom-spmi-rradc.c:624:25: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
624 | FIELD_PREP(BATT_ID_SETTLE_MASK, chip->batt_id_delay);
| ^~~~~~~~~~
cc1: some warnings being treated as errors
vim +/FIELD_PREP +624 drivers/iio/adc/qcom-spmi-rradc.c
607
608 static int rradc_prepare_batt_id_conversion(struct rradc_chip *chip,
609 enum rradc_channel_id chan_id,
610 u16 *data)
611 {
612 int ret, batt_id_delay;
613
614 ret = regmap_update_bits(chip->regmap, chip->base + RR_ADC_BATT_ID_CTRL,
615 RR_ADC_BATT_ID_CTRL_CHANNEL_CONV,
616 RR_ADC_BATT_ID_CTRL_CHANNEL_CONV);
617 if (ret < 0) {
618 dev_err(chip->dev, "Enabling BATT ID channel failed:%d\n", ret);
619 return ret;
620 }
621
622 if (chip->batt_id_delay != -EINVAL) {
623 batt_id_delay =
> 624 FIELD_PREP(BATT_ID_SETTLE_MASK, chip->batt_id_delay);
625 ret = regmap_update_bits(chip->regmap,
626 chip->base + RR_ADC_BATT_ID_CFG,
627 batt_id_delay, batt_id_delay);
628 if (ret < 0) {
629 dev_err(chip->dev,
630 "BATT_ID settling time config failed:%d\n",
631 ret);
632 goto out_disable_batt_id;
633 }
634 }
635
636 ret = regmap_update_bits(chip->regmap,
637 chip->base + RR_ADC_BATT_ID_TRIGGER,
638 RR_ADC_TRIGGER_CTL, RR_ADC_TRIGGER_CTL);
639 if (ret < 0) {
640 dev_err(chip->dev, "BATT_ID trigger set failed:%d\n", ret);
641 goto out_disable_batt_id;
642 }
643
644 ret = rradc_read_status_in_cont_mode(chip, chan_id);
645 if (ret < 0)
646 dev_err(chip->dev, "Error reading in continuous mode:%d\n",
647 ret);
648
649 /*
650 * Reset registers back to default values
651 */
652 ret = regmap_update_bits(chip->regmap,
653 chip->base + RR_ADC_BATT_ID_TRIGGER,
654 RR_ADC_TRIGGER_CTL, 0);
655 if (ret < 0)
656 dev_err(chip->dev, "BATT_ID trigger re-set failed:%d\n", ret);
657
658 out_disable_batt_id:
659 ret = regmap_update_bits(chip->regmap, chip->base + RR_ADC_BATT_ID_CTRL,
660 RR_ADC_BATT_ID_CTRL_CHANNEL_CONV, 0);
661 if (ret < 0)
662 dev_err(chip->dev, "Disabling BATT ID channel failed:%d\n",
663 ret);
664
665 return ret;
666 }
667
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2022-01-05 21:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 18:33 [PATCH v2 0/7] iio: adc: introduce Qualcomm SPMI Round Robin ADC Caleb Connolly
2022-01-05 18:33 ` [PATCH v2 1/7] mfd: qcom-spmi-pmic: expose the PMIC revid information to clients Caleb Connolly
2022-01-05 18:33 ` [PATCH v2 2/7] dt-bindings: iio: adc: document qcom-spmi-rradc Caleb Connolly
2022-01-05 18:33 ` [PATCH v2 3/7] iio: adc: qcom-spmi-rradc: introduce round robin adc Caleb Connolly
2022-01-05 21:05 ` kernel test robot [this message]
2022-01-05 21:05 ` kernel test robot
2022-01-05 18:33 ` [PATCH v2 4/7] arm64: dts: qcom: pmi8998: add rradc node Caleb Connolly
2022-01-05 18:33 ` [PATCH v2 5/7] arm64: dts: qcom: sdm845-oneplus: enable rradc Caleb Connolly
2022-01-05 18:33 ` [PATCH v2 6/7] arm64: dts: qcom: sdm845-db845c: " Caleb Connolly
2022-01-05 18:33 ` [PATCH v2 7/7] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable RRADC Caleb Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202201060438.QiDzs9rA-lkp@intel.com \
--to=lkp@intel.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=caleb.connolly@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.