All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Maxim Kiselev <bigunclemax@gmail.com>
Cc: "fido_max@inbox.ru" <fido_max@inbox.ru>,
	Rob Herring <robh+dt@kernel.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>, Andrew Lunn <andrew@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] powerpc: dts: t1040rdb: fix ports names for Seville Ethernet switch
Date: Tue, 11 Jan 2022 13:13:56 +0000	[thread overview]
Message-ID: <20220111131355.djuyn6bbirqtsama@skbuf> (raw)
In-Reply-To: <CALHCpMgO2bqxPcaxwg29gEGF4te1HCgCa7SdNFVoxa6JDzrCrA@mail.gmail.com>

Hi Maxim,

On Mon, Jan 10, 2022 at 07:40:38AM +0000, Maxim Kiselev wrote:
> Here are photos of my boards.

Your patch is OK to change t1040rdb.dts, but please preserve the existing
port mappings in a new arch/powerpc/boot/dts/fsl/t1040rdb-rev-a.dts file.

You will also need to modify the /model and /compatible nodes of the new
device tree for Rev A, something like "fsl,T1040RDB-REV-A". Take a look
at arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3-rev-a.dts to see
an example of what I'd like to be done.

Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Maxim Kiselev <bigunclemax@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"fido_max@inbox.ru" <fido_max@inbox.ru>,
	Rob Herring <robh+dt@kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] powerpc: dts: t1040rdb: fix ports names for Seville Ethernet switch
Date: Tue, 11 Jan 2022 13:13:56 +0000	[thread overview]
Message-ID: <20220111131355.djuyn6bbirqtsama@skbuf> (raw)
In-Reply-To: <CALHCpMgO2bqxPcaxwg29gEGF4te1HCgCa7SdNFVoxa6JDzrCrA@mail.gmail.com>

Hi Maxim,

On Mon, Jan 10, 2022 at 07:40:38AM +0000, Maxim Kiselev wrote:
> Here are photos of my boards.

Your patch is OK to change t1040rdb.dts, but please preserve the existing
port mappings in a new arch/powerpc/boot/dts/fsl/t1040rdb-rev-a.dts file.

You will also need to modify the /model and /compatible nodes of the new
device tree for Rev A, something like "fsl,T1040RDB-REV-A". Take a look
at arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3-rev-a.dts to see
an example of what I'd like to be done.

Thanks.

  reply	other threads:[~2022-01-11 13:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-30 10:43 [PATCH] powerpc: dts: t1040rdb: fix ports names for Seville Ethernet switch Maxim Kiselev
2021-12-30 10:43 ` Maxim Kiselev
2021-12-30 13:00 ` Vladimir Oltean
2021-12-30 13:00   ` Vladimir Oltean
2021-12-30 13:24   ` Maxim Kiselev
     [not found]     ` <20211231125247.ugne3h44pmpzliin@skbuf>
2022-01-10  7:40       ` Maxim Kiselev
2022-01-11 13:13         ` Vladimir Oltean [this message]
2022-01-11 13:13           ` Vladimir Oltean
2022-01-11 15:22           ` [PATCH] powerpc: dts: add device tree for T1040RDB-REV-A Maxim Kiselev
2022-01-11 15:22             ` Maxim Kiselev
2022-01-11 15:29             ` Vladimir Oltean
2022-01-11 15:29               ` Vladimir Oltean
2022-01-11 17:37               ` [PATCH v2] powerpc: dts: t1040rdb: fix ports names for Seville Ethernet switch Maxim
2022-01-11 17:37                 ` Maxim
2022-01-12 18:50                 ` Vladimir Oltean
2022-01-12 18:50                   ` Vladimir Oltean
2022-01-20  6:29                 ` Michael Ellerman
2022-01-20  6:29                   ` Michael Ellerman
2022-01-21  9:14                   ` [PATCH v3] " Maxim Kiselev
2022-01-21  9:14                     ` Maxim Kiselev
2022-02-15  5:26                     ` Michael Ellerman
2022-02-15  5:26                       ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220111131355.djuyn6bbirqtsama@skbuf \
    --to=vladimir.oltean@nxp.com \
    --cc=andrew@lunn.ch \
    --cc=benh@kernel.crashing.org \
    --cc=bigunclemax@gmail.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=fido_max@inbox.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.