From: Maxim Kiselev <bigunclemax@gmail.com> To: mpe@ellerman.id.au Cc: andrew@lunn.ch, benh@kernel.crashing.org, bigunclemax@gmail.com, davem@davemloft.net, devicetree@vger.kernel.org, fido_max@inbox.ru, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, paulus@samba.org, robh+dt@kernel.org, vladimir.oltean@nxp.com Subject: [PATCH v3] powerpc: dts: t1040rdb: fix ports names for Seville Ethernet switch Date: Fri, 21 Jan 2022 12:14:47 +0300 [thread overview] Message-ID: <20220121091447.3412907-1-bigunclemax@gmail.com> (raw) In-Reply-To: <87czkmudh0.fsf@mpe.ellerman.id.au> On board rev A, the network interface labels for the switch ports written on the front panel are different than on rev B and later. This patch fixes network interface names for the switch ports according to labels that are written on the front panel of the board rev B. They start from ETH3 and end at ETH10. This patch also introduces a separate device tree for rev A. The main device tree is supposed to cover rev B and later. Fixes: e69eb0824d8c ("powerpc: dts: t1040rdb: add ports for Seville Ethernet switch") Signed-off-by: Maxim Kiselev <bigunclemax@gmail.com> Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- Here is the fix for the error in t1040rdb-rev-a.dts caused by containing '#include' directive inside '/include/' --- arch/powerpc/boot/dts/fsl/t1040rdb-rev-a.dts | 30 ++++++++++++++++++++ arch/powerpc/boot/dts/fsl/t1040rdb.dts | 8 +++--- 2 files changed, 34 insertions(+), 4 deletions(-) create mode 100644 arch/powerpc/boot/dts/fsl/t1040rdb-rev-a.dts diff --git a/arch/powerpc/boot/dts/fsl/t1040rdb-rev-a.dts b/arch/powerpc/boot/dts/fsl/t1040rdb-rev-a.dts new file mode 100644 index 0000000000000..73f8c998c64df --- /dev/null +++ b/arch/powerpc/boot/dts/fsl/t1040rdb-rev-a.dts @@ -0,0 +1,30 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * T1040RDB-REV-A Device Tree Source + * + * Copyright 2014 - 2015 Freescale Semiconductor Inc. + * + */ + +#include "t1040rdb.dts" + +/ { + model = "fsl,T1040RDB-REV-A"; + compatible = "fsl,T1040RDB-REV-A"; +}; + +&seville_port0 { + label = "ETH5"; +}; + +&seville_port2 { + label = "ETH7"; +}; + +&seville_port4 { + label = "ETH9"; +}; + +&seville_port6 { + label = "ETH11"; +}; diff --git a/arch/powerpc/boot/dts/fsl/t1040rdb.dts b/arch/powerpc/boot/dts/fsl/t1040rdb.dts index af0c8a6f56138..b6733e7e65805 100644 --- a/arch/powerpc/boot/dts/fsl/t1040rdb.dts +++ b/arch/powerpc/boot/dts/fsl/t1040rdb.dts @@ -119,7 +119,7 @@ &seville_port0 { managed = "in-band-status"; phy-handle = <&phy_qsgmii_0>; phy-mode = "qsgmii"; - label = "ETH5"; + label = "ETH3"; status = "okay"; }; @@ -135,7 +135,7 @@ &seville_port2 { managed = "in-band-status"; phy-handle = <&phy_qsgmii_2>; phy-mode = "qsgmii"; - label = "ETH7"; + label = "ETH5"; status = "okay"; }; @@ -151,7 +151,7 @@ &seville_port4 { managed = "in-band-status"; phy-handle = <&phy_qsgmii_4>; phy-mode = "qsgmii"; - label = "ETH9"; + label = "ETH7"; status = "okay"; }; @@ -167,7 +167,7 @@ &seville_port6 { managed = "in-band-status"; phy-handle = <&phy_qsgmii_6>; phy-mode = "qsgmii"; - label = "ETH11"; + label = "ETH9"; status = "okay"; }; -- 2.32.0
WARNING: multiple messages have this Message-ID (diff)
From: Maxim Kiselev <bigunclemax@gmail.com> To: mpe@ellerman.id.au Cc: andrew@lunn.ch, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, fido_max@inbox.ru, robh+dt@kernel.org, paulus@samba.org, vladimir.oltean@nxp.com, bigunclemax@gmail.com, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net Subject: [PATCH v3] powerpc: dts: t1040rdb: fix ports names for Seville Ethernet switch Date: Fri, 21 Jan 2022 12:14:47 +0300 [thread overview] Message-ID: <20220121091447.3412907-1-bigunclemax@gmail.com> (raw) In-Reply-To: <87czkmudh0.fsf@mpe.ellerman.id.au> On board rev A, the network interface labels for the switch ports written on the front panel are different than on rev B and later. This patch fixes network interface names for the switch ports according to labels that are written on the front panel of the board rev B. They start from ETH3 and end at ETH10. This patch also introduces a separate device tree for rev A. The main device tree is supposed to cover rev B and later. Fixes: e69eb0824d8c ("powerpc: dts: t1040rdb: add ports for Seville Ethernet switch") Signed-off-by: Maxim Kiselev <bigunclemax@gmail.com> Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- Here is the fix for the error in t1040rdb-rev-a.dts caused by containing '#include' directive inside '/include/' --- arch/powerpc/boot/dts/fsl/t1040rdb-rev-a.dts | 30 ++++++++++++++++++++ arch/powerpc/boot/dts/fsl/t1040rdb.dts | 8 +++--- 2 files changed, 34 insertions(+), 4 deletions(-) create mode 100644 arch/powerpc/boot/dts/fsl/t1040rdb-rev-a.dts diff --git a/arch/powerpc/boot/dts/fsl/t1040rdb-rev-a.dts b/arch/powerpc/boot/dts/fsl/t1040rdb-rev-a.dts new file mode 100644 index 0000000000000..73f8c998c64df --- /dev/null +++ b/arch/powerpc/boot/dts/fsl/t1040rdb-rev-a.dts @@ -0,0 +1,30 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * T1040RDB-REV-A Device Tree Source + * + * Copyright 2014 - 2015 Freescale Semiconductor Inc. + * + */ + +#include "t1040rdb.dts" + +/ { + model = "fsl,T1040RDB-REV-A"; + compatible = "fsl,T1040RDB-REV-A"; +}; + +&seville_port0 { + label = "ETH5"; +}; + +&seville_port2 { + label = "ETH7"; +}; + +&seville_port4 { + label = "ETH9"; +}; + +&seville_port6 { + label = "ETH11"; +}; diff --git a/arch/powerpc/boot/dts/fsl/t1040rdb.dts b/arch/powerpc/boot/dts/fsl/t1040rdb.dts index af0c8a6f56138..b6733e7e65805 100644 --- a/arch/powerpc/boot/dts/fsl/t1040rdb.dts +++ b/arch/powerpc/boot/dts/fsl/t1040rdb.dts @@ -119,7 +119,7 @@ &seville_port0 { managed = "in-band-status"; phy-handle = <&phy_qsgmii_0>; phy-mode = "qsgmii"; - label = "ETH5"; + label = "ETH3"; status = "okay"; }; @@ -135,7 +135,7 @@ &seville_port2 { managed = "in-band-status"; phy-handle = <&phy_qsgmii_2>; phy-mode = "qsgmii"; - label = "ETH7"; + label = "ETH5"; status = "okay"; }; @@ -151,7 +151,7 @@ &seville_port4 { managed = "in-band-status"; phy-handle = <&phy_qsgmii_4>; phy-mode = "qsgmii"; - label = "ETH9"; + label = "ETH7"; status = "okay"; }; @@ -167,7 +167,7 @@ &seville_port6 { managed = "in-band-status"; phy-handle = <&phy_qsgmii_6>; phy-mode = "qsgmii"; - label = "ETH11"; + label = "ETH9"; status = "okay"; }; -- 2.32.0
next prev parent reply other threads:[~2022-01-21 9:15 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-30 10:43 [PATCH] powerpc: dts: t1040rdb: fix ports names for Seville Ethernet switch Maxim Kiselev 2021-12-30 10:43 ` Maxim Kiselev 2021-12-30 13:00 ` Vladimir Oltean 2021-12-30 13:00 ` Vladimir Oltean 2021-12-30 13:24 ` Maxim Kiselev [not found] ` <20211231125247.ugne3h44pmpzliin@skbuf> 2022-01-10 7:40 ` Maxim Kiselev 2022-01-11 13:13 ` Vladimir Oltean 2022-01-11 13:13 ` Vladimir Oltean 2022-01-11 15:22 ` [PATCH] powerpc: dts: add device tree for T1040RDB-REV-A Maxim Kiselev 2022-01-11 15:22 ` Maxim Kiselev 2022-01-11 15:29 ` Vladimir Oltean 2022-01-11 15:29 ` Vladimir Oltean 2022-01-11 17:37 ` [PATCH v2] powerpc: dts: t1040rdb: fix ports names for Seville Ethernet switch Maxim 2022-01-11 17:37 ` Maxim 2022-01-12 18:50 ` Vladimir Oltean 2022-01-12 18:50 ` Vladimir Oltean 2022-01-20 6:29 ` Michael Ellerman 2022-01-20 6:29 ` Michael Ellerman 2022-01-21 9:14 ` Maxim Kiselev [this message] 2022-01-21 9:14 ` [PATCH v3] " Maxim Kiselev 2022-02-15 5:26 ` Michael Ellerman 2022-02-15 5:26 ` Michael Ellerman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220121091447.3412907-1-bigunclemax@gmail.com \ --to=bigunclemax@gmail.com \ --cc=andrew@lunn.ch \ --cc=benh@kernel.crashing.org \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=fido_max@inbox.ru \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=paulus@samba.org \ --cc=robh+dt@kernel.org \ --cc=vladimir.oltean@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.