* [PATCH] BRCMNAND: Fix reporting of uncorrectable errors on subpages during page read
@ 2021-12-21 4:15 Joel Peshkin
2021-12-28 8:33 ` Simon Glass
2022-01-15 12:38 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Joel Peshkin @ 2021-12-21 4:15 UTC (permalink / raw)
To: u-boot; +Cc: Joel Peshkin, Simon Glass
Previously, a subpage with an uncorrectable error followed by a subpage
with a correctable error would return an erroneous correctable status.
Signed-off-by: Joel Peshkin <joel.peshkin@broadcom.com>
Cc: Simon Glass <sjg@chromium.org>
---
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
index f8434ca..74c9348 100644
--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
@@ -1632,7 +1632,7 @@ static int brcmnand_read_by_pio(struct mtd_info *mtd, struct nand_chip *chip,
mtd->oobsize / trans,
host->hwcfg.sector_size_1k);
- if (!ret) {
+ if (ret != -EBADMSG) {
*err_addr = brcmnand_read_reg(ctrl,
BRCMNAND_UNCORR_ADDR) |
((u64)(brcmnand_read_reg(ctrl,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] BRCMNAND: Fix reporting of uncorrectable errors on subpages during page read
2021-12-21 4:15 [PATCH] BRCMNAND: Fix reporting of uncorrectable errors on subpages during page read Joel Peshkin
@ 2021-12-28 8:33 ` Simon Glass
2022-01-15 12:38 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2021-12-28 8:33 UTC (permalink / raw)
To: Joel Peshkin; +Cc: U-Boot Mailing List
On Mon, 20 Dec 2021 at 21:15, Joel Peshkin <joel.peshkin@broadcom.com> wrote:
>
> Previously, a subpage with an uncorrectable error followed by a subpage
> with a correctable error would return an erroneous correctable status.
>
> Signed-off-by: Joel Peshkin <joel.peshkin@broadcom.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
> drivers/mtd/nand/raw/brcmnand/brcmnand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
Note that we normally like to have the commit subject 60 chars at most.
>
> diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> index f8434ca..74c9348 100644
> --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> @@ -1632,7 +1632,7 @@ static int brcmnand_read_by_pio(struct mtd_info *mtd, struct nand_chip *chip,
> mtd->oobsize / trans,
> host->hwcfg.sector_size_1k);
>
> - if (!ret) {
> + if (ret != -EBADMSG) {
> *err_addr = brcmnand_read_reg(ctrl,
> BRCMNAND_UNCORR_ADDR) |
> ((u64)(brcmnand_read_reg(ctrl,
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] BRCMNAND: Fix reporting of uncorrectable errors on subpages during page read
2021-12-21 4:15 [PATCH] BRCMNAND: Fix reporting of uncorrectable errors on subpages during page read Joel Peshkin
2021-12-28 8:33 ` Simon Glass
@ 2022-01-15 12:38 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2022-01-15 12:38 UTC (permalink / raw)
To: Joel Peshkin; +Cc: u-boot, Simon Glass
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
On Mon, Dec 20, 2021 at 08:15:47PM -0800, Joel Peshkin wrote:
> Previously, a subpage with an uncorrectable error followed by a subpage
> with a correctable error would return an erroneous correctable status.
>
> Signed-off-by: Joel Peshkin <joel.peshkin@broadcom.com>
> Cc: Simon Glass <sjg@chromium.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-15 12:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-21 4:15 [PATCH] BRCMNAND: Fix reporting of uncorrectable errors on subpages during page read Joel Peshkin
2021-12-28 8:33 ` Simon Glass
2022-01-15 12:38 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.