[PATCH] init: do not create lat logs when not needed

[PATCH] init: do not create lat logs when not needed

[Damien Le Moal]

When any of the options disable_lat, disable_slat and disable_clat are
used, there is no need to create the lat log associated with the
disabled latency. In addition, when write_lat_log is also specified,
this change avoids the creation of empty latency log files.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
---
 init.c | 24 +++++++++++++++---------
 1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/init.c b/init.c
index 5f069d9a..07daaa84 100644
--- a/init.c
+++ b/init.c
@@ -1586,17 +1586,23 @@ static int add_job(struct thread_data *td, const char *jobname, int job_add_num,
 		else
 			suf = "log";
 
-		gen_log_name(logname, sizeof(logname), "lat", pre,
-				td->thread_number, suf, o->per_job_logs);
-		setup_log(&td->lat_log, &p, logname);
+		if (!o->disable_lat) {
+			gen_log_name(logname, sizeof(logname), "lat", pre,
+				     td->thread_number, suf, o->per_job_logs);
+			setup_log(&td->lat_log, &p, logname);
+		}
 
-		gen_log_name(logname, sizeof(logname), "slat", pre,
-				td->thread_number, suf, o->per_job_logs);
-		setup_log(&td->slat_log, &p, logname);
+		if (!o->disable_slat) {
+			gen_log_name(logname, sizeof(logname), "slat", pre,
+				     td->thread_number, suf, o->per_job_logs);
+			setup_log(&td->slat_log, &p, logname);
+		}
 
-		gen_log_name(logname, sizeof(logname), "clat", pre,
-				td->thread_number, suf, o->per_job_logs);
-		setup_log(&td->clat_log, &p, logname);
+		if (!o->disable_clat) {
+			gen_log_name(logname, sizeof(logname), "clat", pre,
+				     td->thread_number, suf, o->per_job_logs);
+			setup_log(&td->clat_log, &p, logname);
+		}
 
 	}
 
-- 
2.34.1

Re: [PATCH] init: do not create lat logs when not needed

[Niklas Cassel]

On Mon, Jan 17, 2022 at 11:11:27AM +0900, Damien Le Moal wrote:
> When any of the options disable_lat, disable_slat and disable_clat are
> used, there is no need to create the lat log associated with the
> disabled latency. In addition, when write_lat_log is also specified,
> this change avoids the creation of empty latency log files.
> 
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
>  init.c | 24 +++++++++++++++---------
>  1 file changed, 15 insertions(+), 9 deletions(-)
> 
> diff --git a/init.c b/init.c
> index 5f069d9a..07daaa84 100644
> --- a/init.c
> +++ b/init.c
> @@ -1586,17 +1586,23 @@ static int add_job(struct thread_data *td, const char *jobname, int job_add_num,
>  		else
>  			suf = "log";
>  
> -		gen_log_name(logname, sizeof(logname), "lat", pre,
> -				td->thread_number, suf, o->per_job_logs);
> -		setup_log(&td->lat_log, &p, logname);
> +		if (!o->disable_lat) {
> +			gen_log_name(logname, sizeof(logname), "lat", pre,
> +				     td->thread_number, suf, o->per_job_logs);
> +			setup_log(&td->lat_log, &p, logname);
> +		}
>  
> -		gen_log_name(logname, sizeof(logname), "slat", pre,
> -				td->thread_number, suf, o->per_job_logs);
> -		setup_log(&td->slat_log, &p, logname);
> +		if (!o->disable_slat) {
> +			gen_log_name(logname, sizeof(logname), "slat", pre,
> +				     td->thread_number, suf, o->per_job_logs);
> +			setup_log(&td->slat_log, &p, logname);
> +		}
>  
> -		gen_log_name(logname, sizeof(logname), "clat", pre,
> -				td->thread_number, suf, o->per_job_logs);
> -		setup_log(&td->clat_log, &p, logname);
> +		if (!o->disable_clat) {
> +			gen_log_name(logname, sizeof(logname), "clat", pre,
> +				     td->thread_number, suf, o->per_job_logs);
> +			setup_log(&td->clat_log, &p, logname);
> +		}
>  
>  	}
>  
> -- 
> 2.34.1
> 

Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>

Re: [PATCH] init: do not create lat logs when not needed

[Jens Axboe]

On Mon, 17 Jan 2022 11:11:27 +0900, Damien Le Moal wrote:
> When any of the options disable_lat, disable_slat and disable_clat are
> used, there is no need to create the lat log associated with the
> disabled latency. In addition, when write_lat_log is also specified,
> this change avoids the creation of empty latency log files.
> 
> 

Applied, thanks!

[1/1] init: do not create lat logs when not needed
      commit: ef37053efdfb8c3b8b6deef43c0969753e6adb44

Best regards,
-- 
Jens Axboe