* [PATCH] init: do not create lat logs when not needed
@ 2022-01-17 2:11 Damien Le Moal
2022-01-17 9:51 ` Niklas Cassel
2022-01-17 14:22 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Damien Le Moal @ 2022-01-17 2:11 UTC (permalink / raw)
To: fio, Jens Axboe; +Cc: Niklas Cassel
When any of the options disable_lat, disable_slat and disable_clat are
used, there is no need to create the lat log associated with the
disabled latency. In addition, when write_lat_log is also specified,
this change avoids the creation of empty latency log files.
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
---
init.c | 24 +++++++++++++++---------
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/init.c b/init.c
index 5f069d9a..07daaa84 100644
--- a/init.c
+++ b/init.c
@@ -1586,17 +1586,23 @@ static int add_job(struct thread_data *td, const char *jobname, int job_add_num,
else
suf = "log";
- gen_log_name(logname, sizeof(logname), "lat", pre,
- td->thread_number, suf, o->per_job_logs);
- setup_log(&td->lat_log, &p, logname);
+ if (!o->disable_lat) {
+ gen_log_name(logname, sizeof(logname), "lat", pre,
+ td->thread_number, suf, o->per_job_logs);
+ setup_log(&td->lat_log, &p, logname);
+ }
- gen_log_name(logname, sizeof(logname), "slat", pre,
- td->thread_number, suf, o->per_job_logs);
- setup_log(&td->slat_log, &p, logname);
+ if (!o->disable_slat) {
+ gen_log_name(logname, sizeof(logname), "slat", pre,
+ td->thread_number, suf, o->per_job_logs);
+ setup_log(&td->slat_log, &p, logname);
+ }
- gen_log_name(logname, sizeof(logname), "clat", pre,
- td->thread_number, suf, o->per_job_logs);
- setup_log(&td->clat_log, &p, logname);
+ if (!o->disable_clat) {
+ gen_log_name(logname, sizeof(logname), "clat", pre,
+ td->thread_number, suf, o->per_job_logs);
+ setup_log(&td->clat_log, &p, logname);
+ }
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] init: do not create lat logs when not needed
2022-01-17 2:11 [PATCH] init: do not create lat logs when not needed Damien Le Moal
@ 2022-01-17 9:51 ` Niklas Cassel
2022-01-17 14:22 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Niklas Cassel @ 2022-01-17 9:51 UTC (permalink / raw)
To: Damien Le Moal; +Cc: fio, Jens Axboe
On Mon, Jan 17, 2022 at 11:11:27AM +0900, Damien Le Moal wrote:
> When any of the options disable_lat, disable_slat and disable_clat are
> used, there is no need to create the lat log associated with the
> disabled latency. In addition, when write_lat_log is also specified,
> this change avoids the creation of empty latency log files.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
> init.c | 24 +++++++++++++++---------
> 1 file changed, 15 insertions(+), 9 deletions(-)
>
> diff --git a/init.c b/init.c
> index 5f069d9a..07daaa84 100644
> --- a/init.c
> +++ b/init.c
> @@ -1586,17 +1586,23 @@ static int add_job(struct thread_data *td, const char *jobname, int job_add_num,
> else
> suf = "log";
>
> - gen_log_name(logname, sizeof(logname), "lat", pre,
> - td->thread_number, suf, o->per_job_logs);
> - setup_log(&td->lat_log, &p, logname);
> + if (!o->disable_lat) {
> + gen_log_name(logname, sizeof(logname), "lat", pre,
> + td->thread_number, suf, o->per_job_logs);
> + setup_log(&td->lat_log, &p, logname);
> + }
>
> - gen_log_name(logname, sizeof(logname), "slat", pre,
> - td->thread_number, suf, o->per_job_logs);
> - setup_log(&td->slat_log, &p, logname);
> + if (!o->disable_slat) {
> + gen_log_name(logname, sizeof(logname), "slat", pre,
> + td->thread_number, suf, o->per_job_logs);
> + setup_log(&td->slat_log, &p, logname);
> + }
>
> - gen_log_name(logname, sizeof(logname), "clat", pre,
> - td->thread_number, suf, o->per_job_logs);
> - setup_log(&td->clat_log, &p, logname);
> + if (!o->disable_clat) {
> + gen_log_name(logname, sizeof(logname), "clat", pre,
> + td->thread_number, suf, o->per_job_logs);
> + setup_log(&td->clat_log, &p, logname);
> + }
>
> }
>
> --
> 2.34.1
>
Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] init: do not create lat logs when not needed
2022-01-17 2:11 [PATCH] init: do not create lat logs when not needed Damien Le Moal
2022-01-17 9:51 ` Niklas Cassel
@ 2022-01-17 14:22 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2022-01-17 14:22 UTC (permalink / raw)
To: fio, Damien Le Moal; +Cc: Niklas Cassel
On Mon, 17 Jan 2022 11:11:27 +0900, Damien Le Moal wrote:
> When any of the options disable_lat, disable_slat and disable_clat are
> used, there is no need to create the lat log associated with the
> disabled latency. In addition, when write_lat_log is also specified,
> this change avoids the creation of empty latency log files.
>
>
Applied, thanks!
[1/1] init: do not create lat logs when not needed
commit: ef37053efdfb8c3b8b6deef43c0969753e6adb44
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-17 14:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-17 2:11 [PATCH] init: do not create lat logs when not needed Damien Le Moal
2022-01-17 9:51 ` Niklas Cassel
2022-01-17 14:22 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.