All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/ast: Create threshold values for AST2600
@ 2022-01-17  8:36 ` KuoHsiang Chou
  0 siblings, 0 replies; 3+ messages in thread
From: KuoHsiang Chou @ 2022-01-17  8:36 UTC (permalink / raw)
  To: tzimmermann, dri-devel, linux-kernel
  Cc: airlied, airlied, daniel, kuohsiang_chou, arc_sung, tommy_huang,
	hungju_huang, luke_chen

The threshold value is used for AST2600 only.

Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com>
---
 drivers/gpu/drm/ast/ast_mode.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 1c7a57a03..7f2e248a6 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -471,7 +471,10 @@ static void ast_set_color_reg(struct ast_private *ast,
 static void ast_set_crtthd_reg(struct ast_private *ast)
 {
 	/* Set Threshold */
-	if (ast->chip == AST2300 || ast->chip == AST2400 ||
+	if (ast->chip == AST2600) {
+		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa7, 0xe0);
+		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa6, 0xa0);
+	} else if (ast->chip == AST2300 || ast->chip == AST2400 ||
 	    ast->chip == AST2500) {
 		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa7, 0x78);
 		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa6, 0x60);
--
2.27.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH] drm/ast: Create threshold values for AST2600
@ 2022-01-17  8:36 ` KuoHsiang Chou
  0 siblings, 0 replies; 3+ messages in thread
From: KuoHsiang Chou @ 2022-01-17  8:36 UTC (permalink / raw)
  To: tzimmermann, dri-devel, linux-kernel
  Cc: hungju_huang, airlied, tommy_huang, airlied, arc_sung, luke_chen

The threshold value is used for AST2600 only.

Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com>
---
 drivers/gpu/drm/ast/ast_mode.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 1c7a57a03..7f2e248a6 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -471,7 +471,10 @@ static void ast_set_color_reg(struct ast_private *ast,
 static void ast_set_crtthd_reg(struct ast_private *ast)
 {
 	/* Set Threshold */
-	if (ast->chip == AST2300 || ast->chip == AST2400 ||
+	if (ast->chip == AST2600) {
+		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa7, 0xe0);
+		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa6, 0xa0);
+	} else if (ast->chip == AST2300 || ast->chip == AST2400 ||
 	    ast->chip == AST2500) {
 		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa7, 0x78);
 		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa6, 0x60);
--
2.27.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/ast: Create threshold values for AST2600
  2022-01-17  8:36 ` KuoHsiang Chou
  (?)
@ 2022-01-19 15:54 ` Thomas Zimmermann
  -1 siblings, 0 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2022-01-19 15:54 UTC (permalink / raw)
  To: KuoHsiang Chou, dri-devel, linux-kernel
  Cc: hungju_huang, airlied, tommy_huang, airlied, arc_sung, luke_chen


[-- Attachment #1.1: Type: text/plain, Size: 1364 bytes --]

Hi

Am 17.01.22 um 09:36 schrieb KuoHsiang Chou:
> The threshold value is used for AST2600 only.
> 
> Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com>
> ---
>   drivers/gpu/drm/ast/ast_mode.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
> index 1c7a57a03..7f2e248a6 100644
> --- a/drivers/gpu/drm/ast/ast_mode.c
> +++ b/drivers/gpu/drm/ast/ast_mode.c
> @@ -471,7 +471,10 @@ static void ast_set_color_reg(struct ast_private *ast,
>   static void ast_set_crtthd_reg(struct ast_private *ast)
>   {
>   	/* Set Threshold */
> -	if (ast->chip == AST2300 || ast->chip == AST2400 ||
> +	if (ast->chip == AST2600) {
> +		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa7, 0xe0);
> +		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa6, 0xa0);
> +	} else if (ast->chip == AST2300 || ast->chip == AST2400 ||
>   	    ast->chip == AST2500) {
>   		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa7, 0x78);
>   		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa6, 0x60);
> --
> 2.27.0
> 

Merged into drm-misc-next. Thanks for the patch.

Best regards
Thomas

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-19 15:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-17  8:36 [PATCH] drm/ast: Create threshold values for AST2600 KuoHsiang Chou
2022-01-17  8:36 ` KuoHsiang Chou
2022-01-19 15:54 ` Thomas Zimmermann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.