All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miles Chen <miles.chen@mediatek.com>
To: <jason@zx2c4.com>
Cc: <ardb@kernel.org>, <davem@davemloft.net>,
	<gregkh@linuxfoundation.org>, <herbert@gondor.apana.org.au>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>, <matthias.bgg@gmail.com>,
	<miles.chen@mediatek.com>
Subject: Re: [PATCH] lib/crypto: blake2s: fix a CFI failure
Date: Wed, 19 Jan 2022 17:16:23 +0800	[thread overview]
Message-ID: <20220119091626.3636-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <CAHmME9rWs_w_dMfDLFuD-tr79cnVyuny4fLn9Wh0+bs76Nt0MA@mail.gmail.com>

>typedef void (*blake2s_compress_t)(struct blake2s_state *state,
>				   const u8 *block, size_t nblocks, u32 inc);
>
>should become
>
>typedef void (*blake2s_compress_t)(struct blake2s_state *state,
>				   const u8 *block, size_t nblocks, const u32 inc);
>
>Does making that change fix things for you?
>
>Thanks,
>Jason

Thanks for your fast response.
It does not work. I tried this before reverting the commit 6048fdcc5f26.

Miles

WARNING: multiple messages have this Message-ID (diff)
From: Miles Chen <miles.chen@mediatek.com>
To: <jason@zx2c4.com>
Cc: <ardb@kernel.org>, <davem@davemloft.net>,
	<gregkh@linuxfoundation.org>, <herbert@gondor.apana.org.au>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>, <matthias.bgg@gmail.com>,
	<miles.chen@mediatek.com>
Subject: Re: [PATCH] lib/crypto: blake2s: fix a CFI failure
Date: Wed, 19 Jan 2022 17:16:23 +0800	[thread overview]
Message-ID: <20220119091626.3636-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <CAHmME9rWs_w_dMfDLFuD-tr79cnVyuny4fLn9Wh0+bs76Nt0MA@mail.gmail.com>

>typedef void (*blake2s_compress_t)(struct blake2s_state *state,
>				   const u8 *block, size_t nblocks, u32 inc);
>
>should become
>
>typedef void (*blake2s_compress_t)(struct blake2s_state *state,
>				   const u8 *block, size_t nblocks, const u32 inc);
>
>Does making that change fix things for you?
>
>Thanks,
>Jason

Thanks for your fast response.
It does not work. I tried this before reverting the commit 6048fdcc5f26.

Miles

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Miles Chen <miles.chen@mediatek.com>
To: <jason@zx2c4.com>
Cc: <ardb@kernel.org>, <davem@davemloft.net>,
	<gregkh@linuxfoundation.org>, <herbert@gondor.apana.org.au>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>, <matthias.bgg@gmail.com>,
	<miles.chen@mediatek.com>
Subject: Re: [PATCH] lib/crypto: blake2s: fix a CFI failure
Date: Wed, 19 Jan 2022 17:16:23 +0800	[thread overview]
Message-ID: <20220119091626.3636-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <CAHmME9rWs_w_dMfDLFuD-tr79cnVyuny4fLn9Wh0+bs76Nt0MA@mail.gmail.com>

>typedef void (*blake2s_compress_t)(struct blake2s_state *state,
>				   const u8 *block, size_t nblocks, u32 inc);
>
>should become
>
>typedef void (*blake2s_compress_t)(struct blake2s_state *state,
>				   const u8 *block, size_t nblocks, const u32 inc);
>
>Does making that change fix things for you?
>
>Thanks,
>Jason

Thanks for your fast response.
It does not work. I tried this before reverting the commit 6048fdcc5f26.

Miles

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-01-19  9:16 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-19  8:24 [PATCH] lib/crypto: blake2s: fix a CFI failure miles.chen
2022-01-19  8:24 ` miles.chen
2022-01-19  8:24 ` miles.chen
2022-01-19  9:00 ` Jason A. Donenfeld
2022-01-19  9:00   ` Jason A. Donenfeld
2022-01-19  9:00   ` Jason A. Donenfeld
2022-01-19  9:09   ` Jason A. Donenfeld
2022-01-19  9:09     ` Jason A. Donenfeld
2022-01-19  9:09     ` Jason A. Donenfeld
2022-01-19  9:16     ` Miles Chen [this message]
2022-01-19  9:16       ` Miles Chen
2022-01-19  9:16       ` Miles Chen
2022-01-19  9:09   ` Ard Biesheuvel
2022-01-19  9:09     ` Ard Biesheuvel
2022-01-19  9:09     ` Ard Biesheuvel
2022-01-19  9:13     ` Ard Biesheuvel
2022-01-19  9:13       ` Ard Biesheuvel
2022-01-19  9:13       ` Ard Biesheuvel
2022-01-19  9:43       ` Miles Chen
2022-01-19  9:43         ` Miles Chen
2022-01-19  9:43         ` Miles Chen
2022-01-19 10:10     ` Miles Chen
2022-01-19 10:10       ` Miles Chen
2022-01-19 10:10       ` Miles Chen
2022-01-19  9:24   ` Miles Chen
2022-01-19  9:24     ` Miles Chen
2022-01-19  9:24     ` Miles Chen
2022-01-19  9:55     ` Jason A. Donenfeld
2022-01-19  9:55       ` Jason A. Donenfeld
2022-01-19  9:55       ` Jason A. Donenfeld
2022-01-19 10:06       ` Miles Chen
2022-01-19 10:06         ` Miles Chen
2022-01-19 10:06         ` Miles Chen
2022-01-19 10:11         ` Jason A. Donenfeld
2022-01-19 10:11           ` Jason A. Donenfeld
2022-01-19 10:11           ` Jason A. Donenfeld
2022-01-19 10:56           ` Jason A. Donenfeld
2022-01-19 10:56             ` Jason A. Donenfeld
2022-01-19 10:56             ` Jason A. Donenfeld
2022-01-19 12:14             ` Jason A. Donenfeld
2022-01-19 12:14               ` Jason A. Donenfeld
2022-01-19 12:14               ` Jason A. Donenfeld
2022-01-19 12:18               ` Ard Biesheuvel
2022-01-19 12:18                 ` Ard Biesheuvel
2022-01-19 12:18                 ` Ard Biesheuvel
2022-01-19 13:34                 ` Jason A. Donenfeld
2022-01-19 13:34                   ` Jason A. Donenfeld
2022-01-19 13:34                   ` Jason A. Donenfeld
2022-01-19 13:54                   ` [PATCH] lib/crypto: blake2s: avoid indirect calls to compression function for Clang CFI Jason A. Donenfeld
2022-01-19 13:54                     ` Jason A. Donenfeld
2022-01-19 13:54                     ` Jason A. Donenfeld
2022-01-19 14:46                     ` Miles Chen
2022-01-19 14:46                       ` Miles Chen
2022-01-19 14:46                       ` Miles Chen
2022-01-19 22:24                     ` Nathan Chancellor
2022-01-19 22:24                       ` Nathan Chancellor
2022-01-19 22:24                       ` Nathan Chancellor
2022-01-20  9:44                       ` Jason A. Donenfeld
2022-01-20  9:44                         ` Jason A. Donenfeld
2022-01-20  9:44                         ` Jason A. Donenfeld
2022-01-21 19:54                     ` Eric Biggers
2022-01-21 19:54                       ` Eric Biggers
2022-01-21 19:54                       ` Eric Biggers
2022-01-21 20:22                       ` Jason A. Donenfeld
2022-01-21 20:22                         ` Jason A. Donenfeld
2022-01-21 20:22                         ` Jason A. Donenfeld
2022-01-21 20:51                         ` Sami Tolvanen
2022-01-21 20:51                           ` Sami Tolvanen
2022-01-21 20:51                           ` Sami Tolvanen
2022-01-24 19:28                     ` [PATCH v2] " Jason A. Donenfeld
2022-01-24 19:28                       ` Jason A. Donenfeld
2022-01-24 19:59                       ` Nick Desaulniers
2022-01-24 19:59                         ` Nick Desaulniers
2022-01-25  6:40                       ` Eric Biggers
2022-01-25  6:40                         ` Eric Biggers
2022-01-25 12:23                         ` Jason A. Donenfeld
2022-01-25 12:23                           ` Jason A. Donenfeld
2022-01-26 22:54                           ` Eric Biggers
2022-01-26 22:54                             ` Eric Biggers
2022-01-26 22:51                     ` [PATCH] " John Stultz
2022-01-26 22:51                       ` John Stultz
2022-01-26 22:51                       ` John Stultz
2022-01-19 14:40                 ` [PATCH] lib/crypto: blake2s: fix a CFI failure David Laight
2022-01-19 14:40                   ` David Laight
2022-01-19 14:40                   ` David Laight
2022-01-19 15:03                   ` Jason A. Donenfeld
2022-01-19 15:03                     ` Jason A. Donenfeld
2022-01-19 15:03                     ` Jason A. Donenfeld
2022-01-19 12:34             ` Miles Chen
2022-01-19 12:34               ` Miles Chen
2022-01-19 12:34               ` Miles Chen
2022-01-19 10:13         ` Ard Biesheuvel
2022-01-19 10:13           ` Ard Biesheuvel
2022-01-19 10:13           ` Ard Biesheuvel
2022-01-19 10:20           ` Jason A. Donenfeld
2022-01-19 10:20             ` Jason A. Donenfeld
2022-01-19 10:20             ` Jason A. Donenfeld
2022-01-19 10:35             ` Ard Biesheuvel
2022-01-19 10:35               ` Ard Biesheuvel
2022-01-19 10:35               ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220119091626.3636-1-miles.chen@mediatek.com \
    --to=miles.chen@mediatek.com \
    --cc=ardb@kernel.org \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jason@zx2c4.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.