From: Eric Biggers <ebiggers@kernel.org> To: "Jason A. Donenfeld" <Jason@zx2c4.com> Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Crypto Mailing List <linux-crypto@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, llvm@lists.linux.dev, Nick Desaulniers <ndesaulniers@google.com>, Sami Tolvanen <samitolvanen@google.com>, Nathan Chancellor <nathan@kernel.org>, Herbert Xu <herbert@gondor.apana.org.au>, Miles Chen <miles.chen@mediatek.com>, Ard Biesheuvel <ardb@kernel.org> Subject: Re: [PATCH v2] lib/crypto: blake2s: avoid indirect calls to compression function for Clang CFI Date: Mon, 24 Jan 2022 22:40:42 -0800 [thread overview] Message-ID: <Ye+bam3aSIjz8n9E@sol.localdomain> (raw) In-Reply-To: <20220124192849.14755-1-Jason@zx2c4.com> On Mon, Jan 24, 2022 at 08:28:49PM +0100, Jason A. Donenfeld wrote: > blake2s_compress_generic is weakly aliased by blake2s_generic. The Don't you mean "weakly aliased by blake2s_compress"? > Fixes: 6048fdcc5f26 ("lib/crypto: blake2s: include as built-in") > Reported-by: Miles Chen <miles.chen@mediatek.com> > Tested-by: Miles Chen <miles.chen@mediatek.com> > Tested-by: Nathan Chancellor <nathan@kernel.org> > Link: https://github.com/ClangBuiltLinux/linux/issues/1567 > Cc: Nick Desaulniers <ndesaulniers@google.com> > Cc: Sami Tolvanen <samitolvanen@google.com> > Cc: Ard Biesheuvel <ardb@kernel.org> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> > --- Otherwise this looks fine, though it's unfortunate this is needed. You can add: Reviewed-by: Eric Biggers <ebiggers@google.com> > Changes v1->v2: > - Wrapped columns at 80 for Eric. It is the recommended coding style, so not just for me :-) - Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org> To: "Jason A. Donenfeld" <Jason@zx2c4.com> Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Crypto Mailing List <linux-crypto@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, llvm@lists.linux.dev, Nick Desaulniers <ndesaulniers@google.com>, Sami Tolvanen <samitolvanen@google.com>, Nathan Chancellor <nathan@kernel.org>, Herbert Xu <herbert@gondor.apana.org.au>, Miles Chen <miles.chen@mediatek.com>, Ard Biesheuvel <ardb@kernel.org> Subject: Re: [PATCH v2] lib/crypto: blake2s: avoid indirect calls to compression function for Clang CFI Date: Mon, 24 Jan 2022 22:40:42 -0800 [thread overview] Message-ID: <Ye+bam3aSIjz8n9E@sol.localdomain> (raw) In-Reply-To: <20220124192849.14755-1-Jason@zx2c4.com> On Mon, Jan 24, 2022 at 08:28:49PM +0100, Jason A. Donenfeld wrote: > blake2s_compress_generic is weakly aliased by blake2s_generic. The Don't you mean "weakly aliased by blake2s_compress"? > Fixes: 6048fdcc5f26 ("lib/crypto: blake2s: include as built-in") > Reported-by: Miles Chen <miles.chen@mediatek.com> > Tested-by: Miles Chen <miles.chen@mediatek.com> > Tested-by: Nathan Chancellor <nathan@kernel.org> > Link: https://github.com/ClangBuiltLinux/linux/issues/1567 > Cc: Nick Desaulniers <ndesaulniers@google.com> > Cc: Sami Tolvanen <samitolvanen@google.com> > Cc: Ard Biesheuvel <ardb@kernel.org> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> > --- Otherwise this looks fine, though it's unfortunate this is needed. You can add: Reviewed-by: Eric Biggers <ebiggers@google.com> > Changes v1->v2: > - Wrapped columns at 80 for Eric. It is the recommended coding style, so not just for me :-) - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-25 6:40 UTC|newest] Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-19 8:24 [PATCH] lib/crypto: blake2s: fix a CFI failure miles.chen 2022-01-19 8:24 ` miles.chen 2022-01-19 8:24 ` miles.chen 2022-01-19 9:00 ` Jason A. Donenfeld 2022-01-19 9:00 ` Jason A. Donenfeld 2022-01-19 9:00 ` Jason A. Donenfeld 2022-01-19 9:09 ` Jason A. Donenfeld 2022-01-19 9:09 ` Jason A. Donenfeld 2022-01-19 9:09 ` Jason A. Donenfeld 2022-01-19 9:16 ` Miles Chen 2022-01-19 9:16 ` Miles Chen 2022-01-19 9:16 ` Miles Chen 2022-01-19 9:09 ` Ard Biesheuvel 2022-01-19 9:09 ` Ard Biesheuvel 2022-01-19 9:09 ` Ard Biesheuvel 2022-01-19 9:13 ` Ard Biesheuvel 2022-01-19 9:13 ` Ard Biesheuvel 2022-01-19 9:13 ` Ard Biesheuvel 2022-01-19 9:43 ` Miles Chen 2022-01-19 9:43 ` Miles Chen 2022-01-19 9:43 ` Miles Chen 2022-01-19 10:10 ` Miles Chen 2022-01-19 10:10 ` Miles Chen 2022-01-19 10:10 ` Miles Chen 2022-01-19 9:24 ` Miles Chen 2022-01-19 9:24 ` Miles Chen 2022-01-19 9:24 ` Miles Chen 2022-01-19 9:55 ` Jason A. Donenfeld 2022-01-19 9:55 ` Jason A. Donenfeld 2022-01-19 9:55 ` Jason A. Donenfeld 2022-01-19 10:06 ` Miles Chen 2022-01-19 10:06 ` Miles Chen 2022-01-19 10:06 ` Miles Chen 2022-01-19 10:11 ` Jason A. Donenfeld 2022-01-19 10:11 ` Jason A. Donenfeld 2022-01-19 10:11 ` Jason A. Donenfeld 2022-01-19 10:56 ` Jason A. Donenfeld 2022-01-19 10:56 ` Jason A. Donenfeld 2022-01-19 10:56 ` Jason A. Donenfeld 2022-01-19 12:14 ` Jason A. Donenfeld 2022-01-19 12:14 ` Jason A. Donenfeld 2022-01-19 12:14 ` Jason A. Donenfeld 2022-01-19 12:18 ` Ard Biesheuvel 2022-01-19 12:18 ` Ard Biesheuvel 2022-01-19 12:18 ` Ard Biesheuvel 2022-01-19 13:34 ` Jason A. Donenfeld 2022-01-19 13:34 ` Jason A. Donenfeld 2022-01-19 13:34 ` Jason A. Donenfeld 2022-01-19 13:54 ` [PATCH] lib/crypto: blake2s: avoid indirect calls to compression function for Clang CFI Jason A. Donenfeld 2022-01-19 13:54 ` Jason A. Donenfeld 2022-01-19 13:54 ` Jason A. Donenfeld 2022-01-19 14:46 ` Miles Chen 2022-01-19 14:46 ` Miles Chen 2022-01-19 14:46 ` Miles Chen 2022-01-19 22:24 ` Nathan Chancellor 2022-01-19 22:24 ` Nathan Chancellor 2022-01-19 22:24 ` Nathan Chancellor 2022-01-20 9:44 ` Jason A. Donenfeld 2022-01-20 9:44 ` Jason A. Donenfeld 2022-01-20 9:44 ` Jason A. Donenfeld 2022-01-21 19:54 ` Eric Biggers 2022-01-21 19:54 ` Eric Biggers 2022-01-21 19:54 ` Eric Biggers 2022-01-21 20:22 ` Jason A. Donenfeld 2022-01-21 20:22 ` Jason A. Donenfeld 2022-01-21 20:22 ` Jason A. Donenfeld 2022-01-21 20:51 ` Sami Tolvanen 2022-01-21 20:51 ` Sami Tolvanen 2022-01-21 20:51 ` Sami Tolvanen 2022-01-24 19:28 ` [PATCH v2] " Jason A. Donenfeld 2022-01-24 19:28 ` Jason A. Donenfeld 2022-01-24 19:59 ` Nick Desaulniers 2022-01-24 19:59 ` Nick Desaulniers 2022-01-25 6:40 ` Eric Biggers [this message] 2022-01-25 6:40 ` Eric Biggers 2022-01-25 12:23 ` Jason A. Donenfeld 2022-01-25 12:23 ` Jason A. Donenfeld 2022-01-26 22:54 ` Eric Biggers 2022-01-26 22:54 ` Eric Biggers 2022-01-26 22:51 ` [PATCH] " John Stultz 2022-01-26 22:51 ` John Stultz 2022-01-26 22:51 ` John Stultz 2022-01-19 14:40 ` [PATCH] lib/crypto: blake2s: fix a CFI failure David Laight 2022-01-19 14:40 ` David Laight 2022-01-19 14:40 ` David Laight 2022-01-19 15:03 ` Jason A. Donenfeld 2022-01-19 15:03 ` Jason A. Donenfeld 2022-01-19 15:03 ` Jason A. Donenfeld 2022-01-19 12:34 ` Miles Chen 2022-01-19 12:34 ` Miles Chen 2022-01-19 12:34 ` Miles Chen 2022-01-19 10:13 ` Ard Biesheuvel 2022-01-19 10:13 ` Ard Biesheuvel 2022-01-19 10:13 ` Ard Biesheuvel 2022-01-19 10:20 ` Jason A. Donenfeld 2022-01-19 10:20 ` Jason A. Donenfeld 2022-01-19 10:20 ` Jason A. Donenfeld 2022-01-19 10:35 ` Ard Biesheuvel 2022-01-19 10:35 ` Ard Biesheuvel 2022-01-19 10:35 ` Ard Biesheuvel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Ye+bam3aSIjz8n9E@sol.localdomain \ --to=ebiggers@kernel.org \ --cc=Jason@zx2c4.com \ --cc=ardb@kernel.org \ --cc=herbert@gondor.apana.org.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=llvm@lists.linux.dev \ --cc=miles.chen@mediatek.com \ --cc=nathan@kernel.org \ --cc=ndesaulniers@google.com \ --cc=samitolvanen@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.