From: Alex Sierra <alex.sierra@amd.com> To: <akpm@linux-foundation.org>, <Felix.Kuehling@amd.com>, <linux-mm@kvack.org>, <rcampbell@nvidia.com>, <linux-ext4@vger.kernel.org>, <linux-xfs@vger.kernel.org> Cc: <amd-gfx@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>, <hch@lst.de>, <jgg@nvidia.com>, <jglisse@redhat.com>, <apopple@nvidia.com>, <willy@infradead.org> Subject: [PATCH v4 03/10] mm/gup: fail get_user_pages for LONGTERM dev coherent type Date: Wed, 26 Jan 2022 21:09:42 -0600 [thread overview] Message-ID: <20220127030949.19396-4-alex.sierra@amd.com> (raw) In-Reply-To: <20220127030949.19396-1-alex.sierra@amd.com> Avoid long term pinning for Coherent device type pages. This could interfere with their own device memory manager. For now, we are just returning error for PIN_LONGTERM Coherent device type pages. Eventually, these type of pages will get migrated to system memory, once the device migration pages support is added. Signed-off-by: Alex Sierra <alex.sierra@amd.com> --- mm/gup.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/mm/gup.c b/mm/gup.c index 886d6148d3d0..5291d7221826 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -1720,6 +1720,12 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages, * If we get a movable page, since we are going to be pinning * these entries, try to move them out if possible. */ + if (is_dev_private_or_coherent_page(head)) { + WARN_ON_ONCE(is_device_private_page(head)); + ret = -EFAULT; + goto unpin_pages; + } + if (!is_pinnable_page(head)) { if (PageHuge(head)) { if (!isolate_huge_page(head, &movable_page_list)) @@ -1750,6 +1756,7 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages, if (list_empty(&movable_page_list) && !isolation_error_count) return nr_pages; +unpin_pages: if (gup_flags & FOLL_PIN) { unpin_user_pages(pages, nr_pages); } else { -- 2.32.0
WARNING: multiple messages have this Message-ID (diff)
From: Alex Sierra <alex.sierra@amd.com> To: <akpm@linux-foundation.org>, <Felix.Kuehling@amd.com>, <linux-mm@kvack.org>, <rcampbell@nvidia.com>, <linux-ext4@vger.kernel.org>, <linux-xfs@vger.kernel.org> Cc: willy@infradead.org, apopple@nvidia.com, dri-devel@lists.freedesktop.org, jglisse@redhat.com, amd-gfx@lists.freedesktop.org, jgg@nvidia.com, hch@lst.de Subject: [PATCH v4 03/10] mm/gup: fail get_user_pages for LONGTERM dev coherent type Date: Wed, 26 Jan 2022 21:09:42 -0600 [thread overview] Message-ID: <20220127030949.19396-4-alex.sierra@amd.com> (raw) In-Reply-To: <20220127030949.19396-1-alex.sierra@amd.com> Avoid long term pinning for Coherent device type pages. This could interfere with their own device memory manager. For now, we are just returning error for PIN_LONGTERM Coherent device type pages. Eventually, these type of pages will get migrated to system memory, once the device migration pages support is added. Signed-off-by: Alex Sierra <alex.sierra@amd.com> --- mm/gup.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/mm/gup.c b/mm/gup.c index 886d6148d3d0..5291d7221826 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -1720,6 +1720,12 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages, * If we get a movable page, since we are going to be pinning * these entries, try to move them out if possible. */ + if (is_dev_private_or_coherent_page(head)) { + WARN_ON_ONCE(is_device_private_page(head)); + ret = -EFAULT; + goto unpin_pages; + } + if (!is_pinnable_page(head)) { if (PageHuge(head)) { if (!isolate_huge_page(head, &movable_page_list)) @@ -1750,6 +1756,7 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages, if (list_empty(&movable_page_list) && !isolation_error_count) return nr_pages; +unpin_pages: if (gup_flags & FOLL_PIN) { unpin_user_pages(pages, nr_pages); } else { -- 2.32.0
next prev parent reply other threads:[~2022-01-27 3:10 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-27 3:09 [PATCH v4 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping Alex Sierra 2022-01-27 3:09 ` Alex Sierra 2022-01-27 3:09 ` [PATCH v4 01/10] mm: add zone device coherent type memory support Alex Sierra 2022-01-27 3:09 ` Alex Sierra 2022-01-28 1:57 ` Alistair Popple 2022-01-28 1:57 ` Alistair Popple 2022-01-27 3:09 ` [PATCH v4 02/10] mm: add device coherent vma selection for memory migration Alex Sierra 2022-01-27 3:09 ` Alex Sierra 2022-01-28 2:07 ` Alistair Popple 2022-01-28 2:07 ` Alistair Popple 2022-01-27 3:09 ` Alex Sierra [this message] 2022-01-27 3:09 ` [PATCH v4 03/10] mm/gup: fail get_user_pages for LONGTERM dev coherent type Alex Sierra 2022-01-28 2:36 ` Alistair Popple 2022-01-28 2:36 ` Alistair Popple 2022-01-27 3:09 ` [PATCH v4 04/10] drm/amdkfd: add SPM support for SVM Alex Sierra 2022-01-27 3:09 ` Alex Sierra 2022-01-28 2:38 ` Alistair Popple 2022-01-28 2:38 ` Alistair Popple 2022-01-27 3:09 ` [PATCH v4 05/10] drm/amdkfd: coherent type as sys mem on migration to ram Alex Sierra 2022-01-27 3:09 ` Alex Sierra 2022-01-27 3:09 ` [PATCH v4 06/10] lib: test_hmm add ioctl to get zone device type Alex Sierra 2022-01-27 3:09 ` Alex Sierra 2022-01-28 4:22 ` Alistair Popple 2022-01-28 4:22 ` Alistair Popple 2022-01-27 3:09 ` [PATCH v4 07/10] lib: test_hmm add module param for " Alex Sierra 2022-01-27 3:09 ` Alex Sierra 2022-01-28 4:22 ` Alistair Popple 2022-01-28 4:22 ` Alistair Popple 2022-01-27 3:09 ` [PATCH v4 08/10] lib: add support for device coherent type in test_hmm Alex Sierra 2022-01-27 3:09 ` Alex Sierra 2022-01-28 4:25 ` Alistair Popple 2022-01-28 4:25 ` Alistair Popple 2022-01-27 3:09 ` [PATCH v4 09/10] tools: update hmm-test to support device coherent type Alex Sierra 2022-01-27 3:09 ` Alex Sierra 2022-01-27 3:09 ` [PATCH v4 10/10] tools: update test_hmm script to support SP config Alex Sierra 2022-01-27 3:09 ` Alex Sierra 2022-01-27 22:32 ` [PATCH v4 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping Andrew Morton 2022-01-27 22:32 ` Andrew Morton 2022-01-27 23:20 ` Sierra Guiza, Alejandro (Alex) 2022-01-27 23:20 ` Sierra Guiza, Alejandro (Alex) 2022-01-28 7:08 ` Andrew Morton 2022-01-28 7:08 ` Andrew Morton 2022-01-28 15:00 ` Deucher, Alexander 2022-01-28 15:00 ` Deucher, Alexander 2022-01-28 17:09 ` Felix Kuehling 2022-01-28 17:09 ` Felix Kuehling 2022-02-02 14:57 ` Christoph Hellwig 2022-02-02 14:57 ` Christoph Hellwig 2022-02-02 15:42 ` Jason Gunthorpe 2022-02-02 15:42 ` Jason Gunthorpe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220127030949.19396-4-alex.sierra@amd.com \ --to=alex.sierra@amd.com \ --cc=Felix.Kuehling@amd.com \ --cc=akpm@linux-foundation.org \ --cc=amd-gfx@lists.freedesktop.org \ --cc=apopple@nvidia.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=hch@lst.de \ --cc=jgg@nvidia.com \ --cc=jglisse@redhat.com \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-xfs@vger.kernel.org \ --cc=rcampbell@nvidia.com \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.