From: Jason Gunthorpe <jgg@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alex Sierra <alex.sierra@amd.com>,
Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
jglisse@redhat.com, apopple@nvidia.com, willy@infradead.org
Subject: Re: [PATCH v4 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping
Date: Wed, 2 Feb 2022 11:42:32 -0400 [thread overview]
Message-ID: <20220202154232.GU1786498@nvidia.com> (raw)
In-Reply-To: <20220202145750.GA25170@lst.de>
On Wed, Feb 02, 2022 at 03:57:50PM +0100, Christoph Hellwig wrote:
> On Thu, Jan 27, 2022 at 02:32:58PM -0800, Andrew Morton wrote:
> > On Wed, 26 Jan 2022 21:09:39 -0600 Alex Sierra <alex.sierra@amd.com> wrote:
> >
> > > This patch series introduces MEMORY_DEVICE_COHERENT, a type of memory
> > > owned by a device that can be mapped into CPU page tables like
> > > MEMORY_DEVICE_GENERIC and can also be migrated like
> > > MEMORY_DEVICE_PRIVATE.
> >
> > Some more reviewer input appears to be desirable here.
> >
> > I was going to tentatively add it to -mm and -next, but problems.
> > 5.17-rc1's mm/migrate.c:migrate_vma_check_page() is rather different
> > from the tree you patched. Please redo, refresh and resend?
>
> I really hate adding more types with the weird one off page refcount.
> We need to clean that mess up first.
Is there anyone who could give an outline of what is needed to make
fsdax use compound pages/folios for its PMD stuff?
I already suggested removing that as a way forward, and was shot down,
but nobody is standing up to maintain this code and fix it :(
We got devdax and the DRM stuff fixed now, so FSDAX is the next
blocker on this work.
The people who want this to advance have no idea about FSs or what to
do, unfortunately.
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Alex Sierra <alex.sierra@amd.com>,
rcampbell@nvidia.com, willy@infradead.org,
Felix.Kuehling@amd.com, apopple@nvidia.com,
amd-gfx@lists.freedesktop.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, jglisse@redhat.com,
dri-devel@lists.freedesktop.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH v4 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping
Date: Wed, 2 Feb 2022 11:42:32 -0400 [thread overview]
Message-ID: <20220202154232.GU1786498@nvidia.com> (raw)
In-Reply-To: <20220202145750.GA25170@lst.de>
On Wed, Feb 02, 2022 at 03:57:50PM +0100, Christoph Hellwig wrote:
> On Thu, Jan 27, 2022 at 02:32:58PM -0800, Andrew Morton wrote:
> > On Wed, 26 Jan 2022 21:09:39 -0600 Alex Sierra <alex.sierra@amd.com> wrote:
> >
> > > This patch series introduces MEMORY_DEVICE_COHERENT, a type of memory
> > > owned by a device that can be mapped into CPU page tables like
> > > MEMORY_DEVICE_GENERIC and can also be migrated like
> > > MEMORY_DEVICE_PRIVATE.
> >
> > Some more reviewer input appears to be desirable here.
> >
> > I was going to tentatively add it to -mm and -next, but problems.
> > 5.17-rc1's mm/migrate.c:migrate_vma_check_page() is rather different
> > from the tree you patched. Please redo, refresh and resend?
>
> I really hate adding more types with the weird one off page refcount.
> We need to clean that mess up first.
Is there anyone who could give an outline of what is needed to make
fsdax use compound pages/folios for its PMD stuff?
I already suggested removing that as a way forward, and was shot down,
but nobody is standing up to maintain this code and fix it :(
We got devdax and the DRM stuff fixed now, so FSDAX is the next
blocker on this work.
The people who want this to advance have no idea about FSs or what to
do, unfortunately.
Jason
next prev parent reply other threads:[~2022-02-02 15:42 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 3:09 [PATCH v4 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping Alex Sierra
2022-01-27 3:09 ` Alex Sierra
2022-01-27 3:09 ` [PATCH v4 01/10] mm: add zone device coherent type memory support Alex Sierra
2022-01-27 3:09 ` Alex Sierra
2022-01-28 1:57 ` Alistair Popple
2022-01-28 1:57 ` Alistair Popple
2022-01-27 3:09 ` [PATCH v4 02/10] mm: add device coherent vma selection for memory migration Alex Sierra
2022-01-27 3:09 ` Alex Sierra
2022-01-28 2:07 ` Alistair Popple
2022-01-28 2:07 ` Alistair Popple
2022-01-27 3:09 ` [PATCH v4 03/10] mm/gup: fail get_user_pages for LONGTERM dev coherent type Alex Sierra
2022-01-27 3:09 ` Alex Sierra
2022-01-28 2:36 ` Alistair Popple
2022-01-28 2:36 ` Alistair Popple
2022-01-27 3:09 ` [PATCH v4 04/10] drm/amdkfd: add SPM support for SVM Alex Sierra
2022-01-27 3:09 ` Alex Sierra
2022-01-28 2:38 ` Alistair Popple
2022-01-28 2:38 ` Alistair Popple
2022-01-27 3:09 ` [PATCH v4 05/10] drm/amdkfd: coherent type as sys mem on migration to ram Alex Sierra
2022-01-27 3:09 ` Alex Sierra
2022-01-27 3:09 ` [PATCH v4 06/10] lib: test_hmm add ioctl to get zone device type Alex Sierra
2022-01-27 3:09 ` Alex Sierra
2022-01-28 4:22 ` Alistair Popple
2022-01-28 4:22 ` Alistair Popple
2022-01-27 3:09 ` [PATCH v4 07/10] lib: test_hmm add module param for " Alex Sierra
2022-01-27 3:09 ` Alex Sierra
2022-01-28 4:22 ` Alistair Popple
2022-01-28 4:22 ` Alistair Popple
2022-01-27 3:09 ` [PATCH v4 08/10] lib: add support for device coherent type in test_hmm Alex Sierra
2022-01-27 3:09 ` Alex Sierra
2022-01-28 4:25 ` Alistair Popple
2022-01-28 4:25 ` Alistair Popple
2022-01-27 3:09 ` [PATCH v4 09/10] tools: update hmm-test to support device coherent type Alex Sierra
2022-01-27 3:09 ` Alex Sierra
2022-01-27 3:09 ` [PATCH v4 10/10] tools: update test_hmm script to support SP config Alex Sierra
2022-01-27 3:09 ` Alex Sierra
2022-01-27 22:32 ` [PATCH v4 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping Andrew Morton
2022-01-27 22:32 ` Andrew Morton
2022-01-27 23:20 ` Sierra Guiza, Alejandro (Alex)
2022-01-27 23:20 ` Sierra Guiza, Alejandro (Alex)
2022-01-28 7:08 ` Andrew Morton
2022-01-28 7:08 ` Andrew Morton
2022-01-28 15:00 ` Deucher, Alexander
2022-01-28 15:00 ` Deucher, Alexander
2022-01-28 17:09 ` Felix Kuehling
2022-01-28 17:09 ` Felix Kuehling
2022-02-02 14:57 ` Christoph Hellwig
2022-02-02 14:57 ` Christoph Hellwig
2022-02-02 15:42 ` Jason Gunthorpe [this message]
2022-02-02 15:42 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220202154232.GU1786498@nvidia.com \
--to=jgg@nvidia.com \
--cc=Felix.Kuehling@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alex.sierra@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=apopple@nvidia.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=jglisse@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rcampbell@nvidia.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.