[PATCH] include: configs: move USB first in the boot order for rk3399

[PATCH] include: configs: move USB first in the boot order for rk3399

[Dan Johansen]

In Manjaro ARM we have used this patch for years now and it was
requested that we upstream it.

This will make all rk3399 based boards try USB boot before
SD or eMMC. Can be quite handy on some devices, where the
other devices are not easy to get to.

Signed-off-by: Dan Johansen <strit@manjaro.org>
---
 include/configs/rockchip-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
index ba7061a287..5dc92373b2 100644
--- a/include/configs/rockchip-common.h
+++ b/include/configs/rockchip-common.h
@@ -55,9 +55,9 @@
 
 #ifdef CONFIG_ROCKCHIP_RK3399
 #define BOOT_TARGET_DEVICES(func) \
+	BOOT_TARGET_USB(func) \
 	BOOT_TARGET_MMC(func) \
 	BOOT_TARGET_NVME(func) \
-	BOOT_TARGET_USB(func) \
 	BOOT_TARGET_PXE(func) \
 	BOOT_TARGET_DHCP(func) \
 	BOOT_TARGET_SF(func)
-- 
2.34.1

Re: [PATCH] include: configs: move USB first in the boot order for rk3399

[Kever Yang]

Hi Dan,
    Thanks for your patch.
    Most of the board would like to boot from SD->MMC->NVME, only if
there no firmware found in the onboard storage, them the U-Boot try
with USB or network.
    So I'm afraid this patch can not be applied.

Thanks,
- Kever

Dan Johansen <strit@manjaro.org> 于2022年1月28日周五 05:56写道：
>
> In Manjaro ARM we have used this patch for years now and it was
> requested that we upstream it.
>
> This will make all rk3399 based boards try USB boot before
> SD or eMMC. Can be quite handy on some devices, where the
> other devices are not easy to get to.
>
> Signed-off-by: Dan Johansen <strit@manjaro.org>
> ---
>  include/configs/rockchip-common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
> index ba7061a287..5dc92373b2 100644
> --- a/include/configs/rockchip-common.h
> +++ b/include/configs/rockchip-common.h
> @@ -55,9 +55,9 @@
>
>  #ifdef CONFIG_ROCKCHIP_RK3399
>  #define BOOT_TARGET_DEVICES(func) \
> +       BOOT_TARGET_USB(func) \
>         BOOT_TARGET_MMC(func) \
>         BOOT_TARGET_NVME(func) \
> -       BOOT_TARGET_USB(func) \
>         BOOT_TARGET_PXE(func) \
>         BOOT_TARGET_DHCP(func) \
>         BOOT_TARGET_SF(func)
> --
> 2.34.1
>

Re: [PATCH] include: configs: move USB first in the boot order for rk3399

[Dan Johansen]

Okay, no problem.

I was just asked to upstream it, so that was my attempt.

Have a good day.

Den 14.03.2022 kl. 08.57 skrev Kever Yang:
> Hi Dan,
>      Thanks for your patch.
>      Most of the board would like to boot from SD->MMC->NVME, only if
> there no firmware found in the onboard storage, them the U-Boot try
> with USB or network.
>      So I'm afraid this patch can not be applied.
>
> Thanks,
> - Kever
>
> Dan Johansen<strit@manjaro.org>  于2022年1月28日周五 05:56写道：
>> In Manjaro ARM we have used this patch for years now and it was
>> requested that we upstream it.
>>
>> This will make all rk3399 based boards try USB boot before
>> SD or eMMC. Can be quite handy on some devices, where the
>> other devices are not easy to get to.
>>
>> Signed-off-by: Dan Johansen<strit@manjaro.org>
>> ---
>>   include/configs/rockchip-common.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
>> index ba7061a287..5dc92373b2 100644
>> --- a/include/configs/rockchip-common.h
>> +++ b/include/configs/rockchip-common.h
>> @@ -55,9 +55,9 @@
>>
>>   #ifdef CONFIG_ROCKCHIP_RK3399
>>   #define BOOT_TARGET_DEVICES(func) \
>> +       BOOT_TARGET_USB(func) \
>>          BOOT_TARGET_MMC(func) \
>>          BOOT_TARGET_NVME(func) \
>> -       BOOT_TARGET_USB(func) \
>>          BOOT_TARGET_PXE(func) \
>>          BOOT_TARGET_DHCP(func) \
>>          BOOT_TARGET_SF(func)
>> --
>> 2.34.1
>>
-- 
Kind regards
*Dan Johansen*
Project lead of the *Manjaro ARM* project
Manjaro-ARM <https://manjaro.org>