From: Maxime Ripard <maxime@cerno.tech> To: "Noralf Trønnes" <noralf@tronnes.org> Cc: robh+dt@kernel.org, thierry.reding@gmail.com, sam@ravnborg.org, dave.stevenson@raspberrypi.com, david@lechnology.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels Date: Thu, 27 Jan 2022 10:37:22 +0100 [thread overview] Message-ID: <20220127093722.hsed3ny3gzk55o7w@houat> (raw) In-Reply-To: <20220125175700.37408-2-noralf@tronnes.org> [-- Attachment #1: Type: text/plain, Size: 2325 bytes --] Hi, On Tue, Jan 25, 2022 at 06:56:58PM +0100, Noralf Trønnes wrote: > Add binding for MIPI DBI compatible SPI panels. > > v2: > - Fix path for panel-common.yaml > - Use unevaluatedProperties > - Drop properties which are in the allOf section > - Drop model property (Rob) > > Signed-off-by: Noralf Trønnes <noralf@tronnes.org> > --- > .../display/panel/panel-mipi-dbi-spi.yaml | 59 +++++++++++++++++++ > 1 file changed, 59 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml > new file mode 100644 > index 000000000000..b7cbeea0f8aa > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/panel-mipi-dbi-spi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MIPI DBI SPI Panels Device Tree Bindings > + > +maintainers: > + - Noralf Trønnes <noralf@tronnes.org> > + > +description: > + This binding is for display panels using a MIPI DBI controller > + in SPI mode. > + > +allOf: > + - $ref: panel-common.yaml# > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +properties: > + compatible: > + const: panel-mipi-dbi-spi You need contains here, otherwise it will error out if you have two compatibles. > + write-only: > + type: boolean > + description: > + Controller is not readable (ie. MISO is not wired up). > + > + dc-gpios: > + maxItems: 1 > + description: | > + Controller data/command selection (D/CX) in 4-line SPI mode. > + If not set, the controller is in 3-line SPI mode. > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + display@0{ > + compatible = "panel-mipi-dbi-spi"; We should have two compatibles in the example too Maxime [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech> To: "Noralf Trønnes" <noralf@tronnes.org> Cc: devicetree@vger.kernel.org, david@lechnology.com, dave.stevenson@raspberrypi.com, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, thierry.reding@gmail.com, sam@ravnborg.org Subject: Re: [PATCH v2 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels Date: Thu, 27 Jan 2022 10:37:22 +0100 [thread overview] Message-ID: <20220127093722.hsed3ny3gzk55o7w@houat> (raw) In-Reply-To: <20220125175700.37408-2-noralf@tronnes.org> [-- Attachment #1: Type: text/plain, Size: 2325 bytes --] Hi, On Tue, Jan 25, 2022 at 06:56:58PM +0100, Noralf Trønnes wrote: > Add binding for MIPI DBI compatible SPI panels. > > v2: > - Fix path for panel-common.yaml > - Use unevaluatedProperties > - Drop properties which are in the allOf section > - Drop model property (Rob) > > Signed-off-by: Noralf Trønnes <noralf@tronnes.org> > --- > .../display/panel/panel-mipi-dbi-spi.yaml | 59 +++++++++++++++++++ > 1 file changed, 59 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml > new file mode 100644 > index 000000000000..b7cbeea0f8aa > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/panel-mipi-dbi-spi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MIPI DBI SPI Panels Device Tree Bindings > + > +maintainers: > + - Noralf Trønnes <noralf@tronnes.org> > + > +description: > + This binding is for display panels using a MIPI DBI controller > + in SPI mode. > + > +allOf: > + - $ref: panel-common.yaml# > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +properties: > + compatible: > + const: panel-mipi-dbi-spi You need contains here, otherwise it will error out if you have two compatibles. > + write-only: > + type: boolean > + description: > + Controller is not readable (ie. MISO is not wired up). > + > + dc-gpios: > + maxItems: 1 > + description: | > + Controller data/command selection (D/CX) in 4-line SPI mode. > + If not set, the controller is in 3-line SPI mode. > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + display@0{ > + compatible = "panel-mipi-dbi-spi"; We should have two compatibles in the example too Maxime [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-01-27 9:37 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-25 17:56 [PATCH v2 0/3] drm/panel: Add MIPI DBI compatible SPI driver Noralf Trønnes 2022-01-25 17:56 ` Noralf Trønnes 2022-01-25 17:56 ` [PATCH v2 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels Noralf Trønnes 2022-01-25 17:56 ` Noralf Trønnes 2022-01-27 9:37 ` Maxime Ripard [this message] 2022-01-27 9:37 ` Maxime Ripard 2022-02-07 23:20 ` Rob Herring 2022-02-07 23:20 ` Rob Herring 2022-02-08 12:16 ` Noralf Trønnes 2022-02-08 12:16 ` Noralf Trønnes 2022-02-09 9:04 ` Maxime Ripard 2022-02-09 9:04 ` Maxime Ripard 2022-02-09 12:29 ` Noralf Trønnes 2022-02-09 12:29 ` Noralf Trønnes 2022-01-25 17:56 ` [PATCH v2 2/3] drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev Noralf Trønnes 2022-01-25 17:56 ` Noralf Trønnes 2022-01-25 17:57 ` [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver Noralf Trønnes 2022-01-25 17:57 ` Noralf Trønnes 2022-01-27 10:04 ` Maxime Ripard 2022-01-27 10:04 ` Maxime Ripard 2022-01-27 17:53 ` Noralf Trønnes 2022-01-27 17:53 ` Noralf Trønnes 2022-02-02 10:09 ` Maxime Ripard 2022-02-02 10:09 ` Maxime Ripard 2022-02-02 13:53 ` Noralf Trønnes 2022-02-02 13:53 ` Noralf Trønnes 2022-02-02 17:14 ` Sam Ravnborg 2022-02-02 17:14 ` Sam Ravnborg 2022-02-03 15:06 ` Maxime Ripard 2022-02-03 15:06 ` Maxime Ripard 2022-01-27 17:19 ` David Lechner 2022-01-27 17:19 ` David Lechner 2022-01-27 20:08 ` Noralf Trønnes 2022-01-27 20:08 ` Noralf Trønnes 2022-01-27 19:59 ` Sam Ravnborg 2022-01-27 20:26 ` Noralf Trønnes 2022-01-27 20:26 ` Noralf Trønnes 2022-01-27 17:13 ` [PATCH v2 0/3] " David Lechner 2022-01-27 17:13 ` David Lechner 2022-01-27 20:02 ` Noralf Trønnes 2022-01-27 20:02 ` Noralf Trønnes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220127093722.hsed3ny3gzk55o7w@houat \ --to=maxime@cerno.tech \ --cc=dave.stevenson@raspberrypi.com \ --cc=david@lechnology.com \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=noralf@tronnes.org \ --cc=robh+dt@kernel.org \ --cc=sam@ravnborg.org \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.