From: David Lechner <david@lechnology.com> To: "Noralf Trønnes" <noralf@tronnes.org>, robh+dt@kernel.org, thierry.reding@gmail.com Cc: sam@ravnborg.org, maxime@cerno.tech, dave.stevenson@raspberrypi.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver Date: Thu, 27 Jan 2022 11:19:10 -0600 [thread overview] Message-ID: <2ee03a80-fddb-e28c-1c29-cd88759ed849@lechnology.com> (raw) In-Reply-To: <20220125175700.37408-4-noralf@tronnes.org> On 1/25/22 11:57 AM, Noralf Trønnes wrote: > Add a driver that will work with most MIPI DBI compatible SPI panels. > This avoids adding a driver for every new MIPI DBI compatible controller > that is to be used by Linux. The 'compatible' Device Tree property with > a '.bin' suffix will be used to load a firmware file that contains the > controller configuration. > > Example (driver will load sainsmart18.bin): > > display@0 { > compatible = "sainsmart18", "panel-mipi-dbi-spi"; > reg = <0>; > reset-gpios = <&gpio 25 0>; > dc-gpios = <&gpio 24 0>; > }; > ... > +static int panel_mipi_dbi_spi_probe(struct spi_device *spi) > +{ > + struct device *dev = &spi->dev; > + struct drm_display_mode mode; > + struct mipi_dbi_dev *dbidev; > + const struct firmware *fw; > + const char *compatible; > + struct drm_device *drm; > + struct property *prop; > + bool fw_found = false; > + struct mipi_dbi *dbi; > + struct gpio_desc *dc; > + char fw_name[40]; > + int ret; > + > + dbidev = devm_drm_dev_alloc(dev, &panel_mipi_dbi_driver, struct mipi_dbi_dev, drm); > + if (IS_ERR(dbidev)) > + return PTR_ERR(dbidev); > + > + dbi = &dbidev->dbi; > + drm = &dbidev->drm; > + > + of_property_for_each_string(dev->of_node, "compatible", prop, compatible) { > + snprintf(fw_name, sizeof(fw_name), "%s.bin", compatible); > + > + ret = firmware_request_nowarn(&fw, fw_name, dev); > + if (ret) { > + drm_dbg(drm, "No config file found for compatible: '%s' (error=%d)\n", > + compatible, ret); > + continue; > + } > + Should we add a directory prefix to the firmware file name to avoid the possibility of file name clashes with unrelated firmwares?
WARNING: multiple messages have this Message-ID (diff)
From: David Lechner <david@lechnology.com> To: "Noralf Trønnes" <noralf@tronnes.org>, robh+dt@kernel.org, thierry.reding@gmail.com Cc: devicetree@vger.kernel.org, sam@ravnborg.org, maxime@cerno.tech, dri-devel@lists.freedesktop.org, dave.stevenson@raspberrypi.com Subject: Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver Date: Thu, 27 Jan 2022 11:19:10 -0600 [thread overview] Message-ID: <2ee03a80-fddb-e28c-1c29-cd88759ed849@lechnology.com> (raw) In-Reply-To: <20220125175700.37408-4-noralf@tronnes.org> On 1/25/22 11:57 AM, Noralf Trønnes wrote: > Add a driver that will work with most MIPI DBI compatible SPI panels. > This avoids adding a driver for every new MIPI DBI compatible controller > that is to be used by Linux. The 'compatible' Device Tree property with > a '.bin' suffix will be used to load a firmware file that contains the > controller configuration. > > Example (driver will load sainsmart18.bin): > > display@0 { > compatible = "sainsmart18", "panel-mipi-dbi-spi"; > reg = <0>; > reset-gpios = <&gpio 25 0>; > dc-gpios = <&gpio 24 0>; > }; > ... > +static int panel_mipi_dbi_spi_probe(struct spi_device *spi) > +{ > + struct device *dev = &spi->dev; > + struct drm_display_mode mode; > + struct mipi_dbi_dev *dbidev; > + const struct firmware *fw; > + const char *compatible; > + struct drm_device *drm; > + struct property *prop; > + bool fw_found = false; > + struct mipi_dbi *dbi; > + struct gpio_desc *dc; > + char fw_name[40]; > + int ret; > + > + dbidev = devm_drm_dev_alloc(dev, &panel_mipi_dbi_driver, struct mipi_dbi_dev, drm); > + if (IS_ERR(dbidev)) > + return PTR_ERR(dbidev); > + > + dbi = &dbidev->dbi; > + drm = &dbidev->drm; > + > + of_property_for_each_string(dev->of_node, "compatible", prop, compatible) { > + snprintf(fw_name, sizeof(fw_name), "%s.bin", compatible); > + > + ret = firmware_request_nowarn(&fw, fw_name, dev); > + if (ret) { > + drm_dbg(drm, "No config file found for compatible: '%s' (error=%d)\n", > + compatible, ret); > + continue; > + } > + Should we add a directory prefix to the firmware file name to avoid the possibility of file name clashes with unrelated firmwares?
next prev parent reply other threads:[~2022-01-27 17:19 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-25 17:56 [PATCH v2 0/3] drm/panel: Add MIPI DBI compatible SPI driver Noralf Trønnes 2022-01-25 17:56 ` Noralf Trønnes 2022-01-25 17:56 ` [PATCH v2 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels Noralf Trønnes 2022-01-25 17:56 ` Noralf Trønnes 2022-01-27 9:37 ` Maxime Ripard 2022-01-27 9:37 ` Maxime Ripard 2022-02-07 23:20 ` Rob Herring 2022-02-07 23:20 ` Rob Herring 2022-02-08 12:16 ` Noralf Trønnes 2022-02-08 12:16 ` Noralf Trønnes 2022-02-09 9:04 ` Maxime Ripard 2022-02-09 9:04 ` Maxime Ripard 2022-02-09 12:29 ` Noralf Trønnes 2022-02-09 12:29 ` Noralf Trønnes 2022-01-25 17:56 ` [PATCH v2 2/3] drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev Noralf Trønnes 2022-01-25 17:56 ` Noralf Trønnes 2022-01-25 17:57 ` [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver Noralf Trønnes 2022-01-25 17:57 ` Noralf Trønnes 2022-01-27 10:04 ` Maxime Ripard 2022-01-27 10:04 ` Maxime Ripard 2022-01-27 17:53 ` Noralf Trønnes 2022-01-27 17:53 ` Noralf Trønnes 2022-02-02 10:09 ` Maxime Ripard 2022-02-02 10:09 ` Maxime Ripard 2022-02-02 13:53 ` Noralf Trønnes 2022-02-02 13:53 ` Noralf Trønnes 2022-02-02 17:14 ` Sam Ravnborg 2022-02-02 17:14 ` Sam Ravnborg 2022-02-03 15:06 ` Maxime Ripard 2022-02-03 15:06 ` Maxime Ripard 2022-01-27 17:19 ` David Lechner [this message] 2022-01-27 17:19 ` David Lechner 2022-01-27 20:08 ` Noralf Trønnes 2022-01-27 20:08 ` Noralf Trønnes 2022-01-27 19:59 ` Sam Ravnborg 2022-01-27 20:26 ` Noralf Trønnes 2022-01-27 20:26 ` Noralf Trønnes 2022-01-27 17:13 ` [PATCH v2 0/3] " David Lechner 2022-01-27 17:13 ` David Lechner 2022-01-27 20:02 ` Noralf Trønnes 2022-01-27 20:02 ` Noralf Trønnes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2ee03a80-fddb-e28c-1c29-cd88759ed849@lechnology.com \ --to=david@lechnology.com \ --cc=dave.stevenson@raspberrypi.com \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=maxime@cerno.tech \ --cc=noralf@tronnes.org \ --cc=robh+dt@kernel.org \ --cc=sam@ravnborg.org \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.