Re: [PATCH v4 08/11] gpiolib: cdev: Add hardware timestamp clock type

From: kernel test robot <lkp@intel.com>
To: Dipen Patel <dipenp@nvidia.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org
Subject: Re: [PATCH v4 08/11] gpiolib: cdev: Add hardware timestamp clock type
Date: Wed, 2 Feb 2022 11:19:31 +0800	[thread overview]
Message-ID: <202202021145.SEtKjkEh-lkp@intel.com> (raw)
In-Reply-To: <20220201222630.21246-9-dipenp@nvidia.com>

Hi Dipen,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 07f8c60fe60f84977dc815ec8a6b1100827c34dd]

url:    https://github.com/0day-ci/linux/commits/Dipen-Patel/Intro-to-Hardware-timestamping-engine/20220202-062447
base:   07f8c60fe60f84977dc815ec8a6b1100827c34dd
config: riscv-randconfig-r042-20220131 (https://download.01.org/0day-ci/archive/20220202/202202021145.SEtKjkEh-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 6b1e844b69f15bb7dffaf9365cd2b355d2eb7579)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/0day-ci/linux/commit/09c0523049e7be3241a2ec74e139ebad40f4e46c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Dipen-Patel/Intro-to-Hardware-timestamping-engine/20220202-062447
        git checkout 09c0523049e7be3241a2ec74e139ebad40f4e46c
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/gpio/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpio/gpiolib-cdev.c:835:3: warning: variable 'flags' is uninitialized when used here [-Wuninitialized]
                   flags |= test_bit(FLAG_ACTIVE_LOW, &line->desc->flags) ?
                   ^~~~~
   drivers/gpio/gpiolib-cdev.c:831:21: note: initialize the variable 'flags' to silence this warning
           unsigned long flags;
                              ^
                               = 0
   1 warning generated.

vim +/flags +835 drivers/gpio/gpiolib-cdev.c

   828	
   829	static int hte_edge_setup(struct line *line, u64 eflags)
   830	{
   831		unsigned long flags;
   832		struct hte_ts_desc *hdesc = &line->hdesc;
   833	
   834		if (eflags & GPIO_V2_LINE_FLAG_EDGE_RISING)
 > 835			flags |= test_bit(FLAG_ACTIVE_LOW, &line->desc->flags) ?
   836					  HTE_FALLING_EDGE_TS : HTE_RISING_EDGE_TS;
   837		if (eflags & GPIO_V2_LINE_FLAG_EDGE_FALLING)
   838			flags |= test_bit(FLAG_ACTIVE_LOW, &line->desc->flags) ?
   839					  HTE_RISING_EDGE_TS : HTE_FALLING_EDGE_TS;
   840	
   841		hdesc->attr.edge_flags = flags;
   842		hdesc->attr.line_data = line->desc;
   843		hdesc->attr.line_id = desc_to_gpio(line->desc);
   844		line->total_discard_seq = 0;
   845	
   846		return hte_req_ts_by_linedata_ns(hdesc, process_hw_ts,
   847						 process_hw_ts_thread, line);
   848	}
   849	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org