[PATCH] spi: spi-zynqmp-gqspi: fix for_each_child.cocci warnings

* [PATCH] spi: spi-zynqmp-gqspi: fix for_each_child.cocci warnings
  2022-02-04 19:10 [xilinx-xlnx:xlnx_rebase_v5.15 857/872] drivers/spi/spi-zynqmp-gqspi.c:1393:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 1398 kernel test robot
@ 2022-02-04 19:03 ` kernel test robot
  0 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2022-02-04 19:03 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 2055 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
CC: Mark Brown <broonie@kernel.org>
CC: linux-spi(a)vger.kernel.org
CC: linux-arm-kernel(a)lists.infradead.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/spi/spi-zynqmp-gqspi.c:1393:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 1398.
drivers/spi/spi-zynqmp-gqspi.c:1405:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 1410.


Semantic patch information:
 False positives can be due to function calls within the for_each
 loop that may encapsulate an of_node_put.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Fixes: f0fcd7d14036 ("spi: spi-zynqmp-gqspi: Fix suspend/resume")
CC: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head:   1183ce490adb103e5e569b8ebd74c50c885ddc05
commit: f0fcd7d140361b1f54cfd76afb8c3afc9bf218a5 [857/872] spi: spi-zynqmp-gqspi: Fix suspend/resume
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago

Please take the patch only if it's a positive warning. Thanks!

 spi-zynqmp-gqspi.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/spi/spi-zynqmp-gqspi.c
+++ b/drivers/spi/spi-zynqmp-gqspi.c
@@ -1395,6 +1395,7 @@ static int zynqmp_qspi_probe(struct plat
 					   &rx_bus_width);
 		if (!ret) {
 			xqspi->rx_bus_width = rx_bus_width;
+			of_node_put(nc);
 			break;
 		}
 	}
@@ -1407,6 +1408,7 @@ static int zynqmp_qspi_probe(struct plat
 					   &tx_bus_width);
 		if (!ret) {
 			xqspi->tx_bus_width = tx_bus_width;
+			of_node_put(nc);
 			break;
 		}
 	}

^ permalink raw reply	[flat|nested] 8+ messages in thread