All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] spi: spi-zynqmp-gqspi: fix for_each_child.cocci warnings
@ 2022-02-07 21:30 ` Julia Lawall
  0 siblings, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2022-02-07 21:30 UTC (permalink / raw)
  To: Amit Kumar Mahapatra, Michal Simek, Naga Sureshkumar Relli,
	Mark Brown, linux-spi
  Cc: linux-arm-kernel, linux-kernel, kbuild-all, linux-arm-kernel

From: kernel test robot <lkp@intel.com>

for_each_available_child_of_node should have of_node_put() before break.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Fixes: f0fcd7d14036 ("spi: spi-zynqmp-gqspi: Fix suspend/resume")
CC: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>

---

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head:   1183ce490adb103e5e569b8ebd74c50c885ddc05
commit: f0fcd7d140361b1f54cfd76afb8c3afc9bf218a5 [857/872] spi: spi-zynqmp-gqspi: Fix suspend/resume
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago

Please take the patch only if it's a positive warning. Thanks!

 spi-zynqmp-gqspi.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/spi/spi-zynqmp-gqspi.c
+++ b/drivers/spi/spi-zynqmp-gqspi.c
@@ -1395,6 +1395,7 @@ static int zynqmp_qspi_probe(struct plat
 					   &rx_bus_width);
 		if (!ret) {
 			xqspi->rx_bus_width = rx_bus_width;
+			of_node_put(nc);
 			break;
 		}
 	}
@@ -1407,6 +1408,7 @@ static int zynqmp_qspi_probe(struct plat
 					   &tx_bus_width);
 		if (!ret) {
 			xqspi->tx_bus_width = tx_bus_width;
+			of_node_put(nc);
 			break;
 		}
 	}

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] spi: spi-zynqmp-gqspi: fix for_each_child.cocci warnings
@ 2022-02-07 21:30 ` Julia Lawall
  0 siblings, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2022-02-07 21:30 UTC (permalink / raw)
  To: Amit Kumar Mahapatra, Michal Simek, Naga Sureshkumar Relli,
	Mark Brown, linux-spi
  Cc: linux-arm-kernel, linux-kernel, kbuild-all, linux-arm-kernel

From: kernel test robot <lkp@intel.com>

for_each_available_child_of_node should have of_node_put() before break.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Fixes: f0fcd7d14036 ("spi: spi-zynqmp-gqspi: Fix suspend/resume")
CC: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>

---

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head:   1183ce490adb103e5e569b8ebd74c50c885ddc05
commit: f0fcd7d140361b1f54cfd76afb8c3afc9bf218a5 [857/872] spi: spi-zynqmp-gqspi: Fix suspend/resume
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago

Please take the patch only if it's a positive warning. Thanks!

 spi-zynqmp-gqspi.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/spi/spi-zynqmp-gqspi.c
+++ b/drivers/spi/spi-zynqmp-gqspi.c
@@ -1395,6 +1395,7 @@ static int zynqmp_qspi_probe(struct plat
 					   &rx_bus_width);
 		if (!ret) {
 			xqspi->rx_bus_width = rx_bus_width;
+			of_node_put(nc);
 			break;
 		}
 	}
@@ -1407,6 +1408,7 @@ static int zynqmp_qspi_probe(struct plat
 					   &tx_bus_width);
 		if (!ret) {
 			xqspi->tx_bus_width = tx_bus_width;
+			of_node_put(nc);
 			break;
 		}
 	}

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] spi: spi-zynqmp-gqspi: fix for_each_child.cocci warnings
@ 2022-02-07 21:30 ` Julia Lawall
  0 siblings, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2022-02-07 21:30 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1346 bytes --]

From: kernel test robot <lkp@intel.com>

for_each_available_child_of_node should have of_node_put() before break.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Fixes: f0fcd7d14036 ("spi: spi-zynqmp-gqspi: Fix suspend/resume")
CC: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>

---

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head:   1183ce490adb103e5e569b8ebd74c50c885ddc05
commit: f0fcd7d140361b1f54cfd76afb8c3afc9bf218a5 [857/872] spi: spi-zynqmp-gqspi: Fix suspend/resume
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago

Please take the patch only if it's a positive warning. Thanks!

 spi-zynqmp-gqspi.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/spi/spi-zynqmp-gqspi.c
+++ b/drivers/spi/spi-zynqmp-gqspi.c
@@ -1395,6 +1395,7 @@ static int zynqmp_qspi_probe(struct plat
 					   &rx_bus_width);
 		if (!ret) {
 			xqspi->rx_bus_width = rx_bus_width;
+			of_node_put(nc);
 			break;
 		}
 	}
@@ -1407,6 +1408,7 @@ static int zynqmp_qspi_probe(struct plat
 					   &tx_bus_width);
 		if (!ret) {
 			xqspi->tx_bus_width = tx_bus_width;
+			of_node_put(nc);
 			break;
 		}
 	}

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] spi: spi-zynqmp-gqspi: fix for_each_child.cocci warnings
  2022-02-07 21:30 ` Julia Lawall
  (?)
@ 2022-02-09 13:13   ` Mark Brown
  -1 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2022-02-09 13:13 UTC (permalink / raw)
  To: Julia Lawall
  Cc: Amit Kumar Mahapatra, Michal Simek, Naga Sureshkumar Relli,
	linux-spi, linux-arm-kernel, linux-kernel, kbuild-all

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

On Mon, Feb 07, 2022 at 10:30:15PM +0100, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
> 
> for_each_available_child_of_node should have of_node_put() before break.
> 
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci

This doesn't apply against current code, please check and resend.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] spi: spi-zynqmp-gqspi: fix for_each_child.cocci warnings
@ 2022-02-09 13:13   ` Mark Brown
  0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2022-02-09 13:13 UTC (permalink / raw)
  To: Julia Lawall
  Cc: Amit Kumar Mahapatra, Michal Simek, Naga Sureshkumar Relli,
	linux-spi, linux-arm-kernel, linux-kernel, kbuild-all


[-- Attachment #1.1: Type: text/plain, Size: 326 bytes --]

On Mon, Feb 07, 2022 at 10:30:15PM +0100, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
> 
> for_each_available_child_of_node should have of_node_put() before break.
> 
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci

This doesn't apply against current code, please check and resend.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] spi: spi-zynqmp-gqspi: fix for_each_child.cocci warnings
@ 2022-02-09 13:13   ` Mark Brown
  0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2022-02-09 13:13 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

On Mon, Feb 07, 2022 at 10:30:15PM +0100, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
> 
> for_each_available_child_of_node should have of_node_put() before break.
> 
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci

This doesn't apply against current code, please check and resend.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] spi: spi-zynqmp-gqspi: fix for_each_child.cocci warnings
  2022-02-04 19:10 [xilinx-xlnx:xlnx_rebase_v5.15 857/872] drivers/spi/spi-zynqmp-gqspi.c:1393:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 1398 kernel test robot
@ 2022-02-04 19:03 ` kernel test robot
  0 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2022-02-04 19:03 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 2055 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
CC: Mark Brown <broonie@kernel.org>
CC: linux-spi(a)vger.kernel.org
CC: linux-arm-kernel(a)lists.infradead.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/spi/spi-zynqmp-gqspi.c:1393:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 1398.
drivers/spi/spi-zynqmp-gqspi.c:1405:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 1410.


Semantic patch information:
 False positives can be due to function calls within the for_each
 loop that may encapsulate an of_node_put.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Fixes: f0fcd7d14036 ("spi: spi-zynqmp-gqspi: Fix suspend/resume")
CC: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head:   1183ce490adb103e5e569b8ebd74c50c885ddc05
commit: f0fcd7d140361b1f54cfd76afb8c3afc9bf218a5 [857/872] spi: spi-zynqmp-gqspi: Fix suspend/resume
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago

Please take the patch only if it's a positive warning. Thanks!

 spi-zynqmp-gqspi.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/spi/spi-zynqmp-gqspi.c
+++ b/drivers/spi/spi-zynqmp-gqspi.c
@@ -1395,6 +1395,7 @@ static int zynqmp_qspi_probe(struct plat
 					   &rx_bus_width);
 		if (!ret) {
 			xqspi->rx_bus_width = rx_bus_width;
+			of_node_put(nc);
 			break;
 		}
 	}
@@ -1407,6 +1408,7 @@ static int zynqmp_qspi_probe(struct plat
 					   &tx_bus_width);
 		if (!ret) {
 			xqspi->tx_bus_width = tx_bus_width;
+			of_node_put(nc);
 			break;
 		}
 	}

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-02-09 13:15 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-07 21:30 [PATCH] spi: spi-zynqmp-gqspi: fix for_each_child.cocci warnings Julia Lawall
2022-02-07 21:30 ` Julia Lawall
2022-02-07 21:30 ` Julia Lawall
2022-02-09 13:13 ` Mark Brown
2022-02-09 13:13   ` Mark Brown
2022-02-09 13:13   ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2022-02-04 19:10 [xilinx-xlnx:xlnx_rebase_v5.15 857/872] drivers/spi/spi-zynqmp-gqspi.c:1393:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 1398 kernel test robot
2022-02-04 19:03 ` [PATCH] spi: spi-zynqmp-gqspi: fix for_each_child.cocci warnings kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.