From: Jakub Kicinski <kuba@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
Imre Kaloz <kaloz@openwrt.org>,
Krzysztof Halasa <khalasa@piap.pl>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH 09/13 v2] net: ixp4xx_hss: Check features using syscon
Date: Fri, 11 Feb 2022 16:38:17 -0800 [thread overview]
Message-ID: <20220211163817.682df7c3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20220211223238.648934-10-linus.walleij@linaro.org>
On Fri, 11 Feb 2022 23:32:34 +0100 Linus Walleij wrote:
> If we access the syscon (expansion bus config registers) using the
> syscon regmap instead of relying on direct accessor functions,
> we do not need to call this static code in the machine
> (arch/arm/mach-ixp4xx/common.c) which makes things less dependent
> on custom machine-dependent code.
>
> Look up the syscon regmap and handle the error: this will make
> deferred probe work with relation to the syscon.
>
> Select the syscon in Kconfig and depend on OF so we know that
> all we need will be available.
>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - No changes.
>
> Network maintainers: I'm looking for an ACK to take this
> change through ARM SoC along with other changes removing
> these accessor functions.
Acked-by: Jakub Kicinski <kuba@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
Imre Kaloz <kaloz@openwrt.org>,
Krzysztof Halasa <khalasa@piap.pl>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH 09/13 v2] net: ixp4xx_hss: Check features using syscon
Date: Fri, 11 Feb 2022 16:38:17 -0800 [thread overview]
Message-ID: <20220211163817.682df7c3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20220211223238.648934-10-linus.walleij@linaro.org>
On Fri, 11 Feb 2022 23:32:34 +0100 Linus Walleij wrote:
> If we access the syscon (expansion bus config registers) using the
> syscon regmap instead of relying on direct accessor functions,
> we do not need to call this static code in the machine
> (arch/arm/mach-ixp4xx/common.c) which makes things less dependent
> on custom machine-dependent code.
>
> Look up the syscon regmap and handle the error: this will make
> deferred probe work with relation to the syscon.
>
> Select the syscon in Kconfig and depend on OF so we know that
> all we need will be available.
>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - No changes.
>
> Network maintainers: I'm looking for an ACK to take this
> change through ARM SoC along with other changes removing
> these accessor functions.
Acked-by: Jakub Kicinski <kuba@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-12 0:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 22:32 [PATCH 00/13 v2] IXP4xx spring cleaning Linus Walleij
2022-02-11 22:32 ` [PATCH 01/13 v2] ARM: ixp4xx: Delete Gateway 7001 boardfiles Linus Walleij
2022-02-11 22:32 ` [PATCH 02/13 v2] ARM: ixp4xx: Delete the Goramo MLR boardfile Linus Walleij
2022-02-11 22:32 ` [PATCH 03/13 v2] ARM: ixp4xx: Delete old PCI driver Linus Walleij
2022-02-11 22:32 ` [PATCH 04/13 v2] ARM: ixp4xx: Drop stale Kconfig entry Linus Walleij
2022-02-11 22:32 ` [PATCH 05/13 v2] ARM: ixp4xx: Drop UDC info setting function Linus Walleij
2022-02-11 22:32 ` [PATCH 06/13 v2] soc: ixp4xx: Add features from regmap helper Linus Walleij
2022-02-11 22:32 ` [PATCH 07/13 v2] soc: ixp4xx-npe: Access syscon regs using regmap Linus Walleij
2022-02-11 22:32 ` [PATCH 08/13 v2] net: ixp4xx_eth: Drop platform data support Linus Walleij
2022-02-11 22:32 ` Linus Walleij
2022-02-12 0:37 ` Jakub Kicinski
2022-02-12 0:37 ` Jakub Kicinski
2022-02-11 22:32 ` [PATCH 09/13 v2] net: ixp4xx_hss: Check features using syscon Linus Walleij
2022-02-11 22:32 ` Linus Walleij
2022-02-12 0:38 ` Jakub Kicinski [this message]
2022-02-12 0:38 ` Jakub Kicinski
2022-02-11 22:32 ` [PATCH 10/13 v2] ARM: ixp4xx: Remove feature bit accessors Linus Walleij
2022-02-11 22:32 ` [PATCH 11/13 v2] ARM: ixp4xx: Drop custom DMA coherency and bouncing Linus Walleij
2022-02-11 22:32 ` Linus Walleij
2022-02-11 22:32 ` [PATCH 12/13 v2] ARM: ixp4xx: Drop all common code Linus Walleij
2022-02-11 22:32 ` [PATCH 13/13 v2] ARM: ixp4xx: Convert to SPARSE_IRQ and P2V Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220211163817.682df7c3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=kaloz@openwrt.org \
--cc=khalasa@piap.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.