From: Guenter Roeck <linux@roeck-us.net> To: Roger Quadros <rogerq@kernel.org> Cc: miquel.raynal@bootlin.com, krzysztof.kozlowski@canonical.com, vigneshr@ti.com, nm@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: rawnand: omap2: Prevent invalid configuration and build error Date: Sat, 19 Feb 2022 07:08:36 -0800 [thread overview] Message-ID: <20220219150836.GA1035394@roeck-us.net> (raw) In-Reply-To: <20220118123525.8020-1-rogerq@kernel.org> On Tue, Jan 18, 2022 at 02:35:25PM +0200, Roger Quadros wrote: > We need to select MEMORY as well otherwise OMAP_GPMC will not be built. > For simplicity let's select MEMORY and OMAP_GPMC unconditionally as > this driver depends on OMAP_GPMC driver and uses symbols from there. > > Fixes: dbcb124acebd ("mtd: rawnand: omap2: Select GPMC device driver for ARCH_K3") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Roger Quadros <rogerq@kernel.org> This patch ignores OMAP_GPMC dependencies and results in: WARNING: unmet direct dependencies detected for OMAP_GPMC Depends on [n]: MEMORY [=y] && OF_ADDRESS [=n] Selected by [m]: - MTD_NAND_OMAP2 [=m] && MTD [=m] && MTD_RAW_NAND [=m] && (ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST [=y]) && HAS_IOMEM [=y] when configuring sparc64:allmodconfig, and in the following build failure when trying to build that image. Building sparc64:allmodconfig ... failed -------------- Error log: <stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp] sparc64-linux-ld: drivers/memory/omap-gpmc.o: in function `gpmc_probe_generic_child': omap-gpmc.c:(.text.unlikely+0x14c4): undefined reference to `of_platform_device_create' Guenter > --- > drivers/mtd/nand/raw/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig > index 20408b7db540..d986ab4e4c35 100644 > --- a/drivers/mtd/nand/raw/Kconfig > +++ b/drivers/mtd/nand/raw/Kconfig > @@ -42,7 +42,8 @@ config MTD_NAND_OMAP2 > tristate "OMAP2, OMAP3, OMAP4 and Keystone NAND controller" > depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST > depends on HAS_IOMEM > - select OMAP_GPMC if ARCH_K3 > + select MEMORY > + select OMAP_GPMC > help > Support for NAND flash on Texas Instruments OMAP2, OMAP3, OMAP4 > and Keystone platforms. > -- > 2.17.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net> To: Roger Quadros <rogerq@kernel.org> Cc: miquel.raynal@bootlin.com, krzysztof.kozlowski@canonical.com, vigneshr@ti.com, nm@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: rawnand: omap2: Prevent invalid configuration and build error Date: Sat, 19 Feb 2022 07:08:36 -0800 [thread overview] Message-ID: <20220219150836.GA1035394@roeck-us.net> (raw) In-Reply-To: <20220118123525.8020-1-rogerq@kernel.org> On Tue, Jan 18, 2022 at 02:35:25PM +0200, Roger Quadros wrote: > We need to select MEMORY as well otherwise OMAP_GPMC will not be built. > For simplicity let's select MEMORY and OMAP_GPMC unconditionally as > this driver depends on OMAP_GPMC driver and uses symbols from there. > > Fixes: dbcb124acebd ("mtd: rawnand: omap2: Select GPMC device driver for ARCH_K3") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Roger Quadros <rogerq@kernel.org> This patch ignores OMAP_GPMC dependencies and results in: WARNING: unmet direct dependencies detected for OMAP_GPMC Depends on [n]: MEMORY [=y] && OF_ADDRESS [=n] Selected by [m]: - MTD_NAND_OMAP2 [=m] && MTD [=m] && MTD_RAW_NAND [=m] && (ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST [=y]) && HAS_IOMEM [=y] when configuring sparc64:allmodconfig, and in the following build failure when trying to build that image. Building sparc64:allmodconfig ... failed -------------- Error log: <stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp] sparc64-linux-ld: drivers/memory/omap-gpmc.o: in function `gpmc_probe_generic_child': omap-gpmc.c:(.text.unlikely+0x14c4): undefined reference to `of_platform_device_create' Guenter > --- > drivers/mtd/nand/raw/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig > index 20408b7db540..d986ab4e4c35 100644 > --- a/drivers/mtd/nand/raw/Kconfig > +++ b/drivers/mtd/nand/raw/Kconfig > @@ -42,7 +42,8 @@ config MTD_NAND_OMAP2 > tristate "OMAP2, OMAP3, OMAP4 and Keystone NAND controller" > depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST > depends on HAS_IOMEM > - select OMAP_GPMC if ARCH_K3 > + select MEMORY > + select OMAP_GPMC > help > Support for NAND flash on Texas Instruments OMAP2, OMAP3, OMAP4 > and Keystone platforms. > -- > 2.17.1 > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-02-19 15:08 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-18 12:35 [PATCH] mtd: rawnand: omap2: Prevent invalid configuration and build error Roger Quadros 2022-01-18 12:35 ` Roger Quadros 2022-01-18 15:28 ` Krzysztof Kozlowski 2022-01-18 15:28 ` Krzysztof Kozlowski 2022-01-23 15:23 ` Miquel Raynal 2022-01-23 15:23 ` Miquel Raynal 2022-01-23 15:33 ` Miquel Raynal 2022-01-23 15:33 ` Miquel Raynal 2022-02-19 15:08 ` Guenter Roeck [this message] 2022-02-19 15:08 ` Guenter Roeck 2022-02-19 19:11 ` Roger Quadros 2022-02-19 19:11 ` Roger Quadros
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220219150836.GA1035394@roeck-us.net \ --to=linux@roeck-us.net \ --cc=krzysztof.kozlowski@canonical.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=miquel.raynal@bootlin.com \ --cc=nm@ti.com \ --cc=rogerq@kernel.org \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.