All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: usb-audio: Add mute TLV for playback volumes on RODE NT-USB
@ 2022-03-11 20:14 Lars-Peter Clausen
  2022-03-12  7:51 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Lars-Peter Clausen @ 2022-03-11 20:14 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: alsa-devel, Lars-Peter Clausen

For the RODE NT-USB the lowest Playback mixer volume setting mutes the
audio output. But it is not reported as such causing e.g. PulseAudio to
accidentally mute the device when selecting a low volume.

Fix this by applying the existing quirk for this kind of issue when the
device is detected.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 sound/usb/mixer_quirks.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
index e447ddd6854c..d35cf54cab33 100644
--- a/sound/usb/mixer_quirks.c
+++ b/sound/usb/mixer_quirks.c
@@ -3360,9 +3360,10 @@ void snd_usb_mixer_fu_apply_quirk(struct usb_mixer_interface *mixer,
 		if (unitid == 7 && cval->control == UAC_FU_VOLUME)
 			snd_dragonfly_quirk_db_scale(mixer, cval, kctl);
 		break;
-	/* lowest playback value is muted on C-Media devices */
-	case USB_ID(0x0d8c, 0x000c):
-	case USB_ID(0x0d8c, 0x0014):
+	/* lowest playback value is muted on some devices */
+	case USB_ID(0x0d8c, 0x000c): /* C-Media */
+	case USB_ID(0x0d8c, 0x0014): /* C-Media */
+	case USB_ID(0x19f7, 0x0003): /* RODE NT-USB */
 		if (strstr(kctl->id.name, "Playback"))
 			cval->min_mute = 1;
 		break;
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: usb-audio: Add mute TLV for playback volumes on RODE NT-USB
  2022-03-11 20:14 [PATCH] ALSA: usb-audio: Add mute TLV for playback volumes on RODE NT-USB Lars-Peter Clausen
@ 2022-03-12  7:51 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2022-03-12  7:51 UTC (permalink / raw)
  To: Lars-Peter Clausen; +Cc: alsa-devel, Takashi Iwai

On Fri, 11 Mar 2022 21:14:00 +0100,
Lars-Peter Clausen wrote:
> 
> For the RODE NT-USB the lowest Playback mixer volume setting mutes the
> audio output. But it is not reported as such causing e.g. PulseAudio to
> accidentally mute the device when selecting a low volume.
> 
> Fix this by applying the existing quirk for this kind of issue when the
> device is detected.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks, applied now.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-12  7:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-11 20:14 [PATCH] ALSA: usb-audio: Add mute TLV for playback volumes on RODE NT-USB Lars-Peter Clausen
2022-03-12  7:51 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.