From: Jason Gunthorpe <jgg@nvidia.com> To: Jacob Pan <jacob.jun.pan@linux.intel.com> Cc: iommu@lists.linux-foundation.org, LKML <linux-kernel@vger.kernel.org>, Joerg Roedel <joro@8bytes.org>, Christoph Hellwig <hch@infradead.org>, Lu Baolu <baolu.lu@linux.intel.com>, Jean-Philippe Brucker <jean-philippe@linaro.com>, Jacob Pan <jacob.jun.pan@intel.com>, Raj Ashok <ashok.raj@intel.com>, "Kumar, Sanjay K" <sanjay.k.kumar@intel.com>, Dave Jiang <dave.jiang@intel.com>, Tony Luck <tony.luck@intel.com>, "Zanussi, Tom" <tom.zanussi@intel.com>, Dan Williams <dan.j.williams@intel.com>, "Tian, Kevin" <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com> Subject: Re: [PATCH v2 3/8] iommu/vt-d: Implement device_pasid domain attach ops Date: Tue, 15 Mar 2022 11:33:22 -0300 [thread overview] Message-ID: <20220315143322.GW11336@nvidia.com> (raw) In-Reply-To: <20220315050713.2000518-4-jacob.jun.pan@linux.intel.com> On Mon, Mar 14, 2022 at 10:07:07PM -0700, Jacob Pan wrote: > + /* > + * Each domain could have multiple devices attached with shared or per > + * device PASIDs. At the domain level, we keep track of unique PASIDs and > + * device user count. > + * E.g. If a domain has two devices attached, device A has PASID 0, 1; > + * device B has PASID 0, 2. Then the domain would have PASID 0, 1, 2. > + */ A 2d array of xarray's seems like a poor data structure for this task. AFACIT this wants to store a list of (device, pasid) tuples, so a simple linked list, 1d xarray vector or a red black tree seems more appropriate.. > + if (entry) { > + pinfo = entry; > + } else { > + pinfo = kzalloc(sizeof(*pinfo), GFP_ATOMIC); > + if (!pinfo) > + return -ENOMEM; > + pinfo->pasid = pasid; > + /* Store the new PASID info in the per domain array */ > + ret = xa_err(__xa_store(&dmar_domain->pasids, pasid, pinfo, > + GFP_ATOMIC)); > + if (ret) > + goto xa_store_err; > + } > + /* Store PASID in per device-domain array, this is for tracking devTLB */ > + ret = xa_err(xa_store(&info->pasids, pasid, pinfo, GFP_ATOMIC)); > + if (ret) > + goto xa_store_err; > + > + atomic_inc(&pinfo->users); > + xa_unlock(&dmar_domain->pasids); > + > + return 0; > + > +xa_store_err: > + xa_unlock(&dmar_domain->pasids); > + spin_lock_irqsave(&iommu->lock, flags); > + intel_pasid_tear_down_entry(iommu, dev, pasid, false); > + spin_unlock_irqrestore(&iommu->lock, flags); > + > + if (!atomic_read(&pinfo->users)) { > + __xa_erase(&dmar_domain->pasids, pasid); This isn't locked right Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe via iommu <iommu@lists.linux-foundation.org> To: Jacob Pan <jacob.jun.pan@linux.intel.com> Cc: "Tian, Kevin" <kevin.tian@intel.com>, Tony Luck <tony.luck@intel.com>, Dave Jiang <dave.jiang@intel.com>, Raj Ashok <ashok.raj@intel.com>, "Zanussi, Tom" <tom.zanussi@intel.com>, "Kumar, Sanjay K" <sanjay.k.kumar@intel.com>, LKML <linux-kernel@vger.kernel.org>, Christoph Hellwig <hch@infradead.org>, iommu@lists.linux-foundation.org, Jacob Pan <jacob.jun.pan@intel.com>, Dan Williams <dan.j.williams@intel.com>, Jean-Philippe Brucker <jean-philippe@linaro.com> Subject: Re: [PATCH v2 3/8] iommu/vt-d: Implement device_pasid domain attach ops Date: Tue, 15 Mar 2022 11:33:22 -0300 [thread overview] Message-ID: <20220315143322.GW11336@nvidia.com> (raw) In-Reply-To: <20220315050713.2000518-4-jacob.jun.pan@linux.intel.com> On Mon, Mar 14, 2022 at 10:07:07PM -0700, Jacob Pan wrote: > + /* > + * Each domain could have multiple devices attached with shared or per > + * device PASIDs. At the domain level, we keep track of unique PASIDs and > + * device user count. > + * E.g. If a domain has two devices attached, device A has PASID 0, 1; > + * device B has PASID 0, 2. Then the domain would have PASID 0, 1, 2. > + */ A 2d array of xarray's seems like a poor data structure for this task. AFACIT this wants to store a list of (device, pasid) tuples, so a simple linked list, 1d xarray vector or a red black tree seems more appropriate.. > + if (entry) { > + pinfo = entry; > + } else { > + pinfo = kzalloc(sizeof(*pinfo), GFP_ATOMIC); > + if (!pinfo) > + return -ENOMEM; > + pinfo->pasid = pasid; > + /* Store the new PASID info in the per domain array */ > + ret = xa_err(__xa_store(&dmar_domain->pasids, pasid, pinfo, > + GFP_ATOMIC)); > + if (ret) > + goto xa_store_err; > + } > + /* Store PASID in per device-domain array, this is for tracking devTLB */ > + ret = xa_err(xa_store(&info->pasids, pasid, pinfo, GFP_ATOMIC)); > + if (ret) > + goto xa_store_err; > + > + atomic_inc(&pinfo->users); > + xa_unlock(&dmar_domain->pasids); > + > + return 0; > + > +xa_store_err: > + xa_unlock(&dmar_domain->pasids); > + spin_lock_irqsave(&iommu->lock, flags); > + intel_pasid_tear_down_entry(iommu, dev, pasid, false); > + spin_unlock_irqrestore(&iommu->lock, flags); > + > + if (!atomic_read(&pinfo->users)) { > + __xa_erase(&dmar_domain->pasids, pasid); This isn't locked right Jason _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-03-15 14:33 UTC|newest] Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-15 5:07 [PATCH v2 0/8] Enable PASID for DMA API users Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-15 5:07 ` [PATCH v2 1/8] iommu: Assign per device max PASID Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-15 5:07 ` [PATCH v2 2/8] iommu: Add attach/detach_dev_pasid domain ops Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-15 10:24 ` Tian, Kevin 2022-03-15 10:24 ` Tian, Kevin 2022-03-15 11:26 ` Jean-Philippe Brucker 2022-03-15 11:26 ` Jean-Philippe Brucker 2022-03-15 11:49 ` Tian, Kevin 2022-03-15 11:49 ` Tian, Kevin 2022-03-15 16:11 ` Jacob Pan 2022-03-15 16:11 ` Jacob Pan 2022-03-18 12:01 ` Lu Baolu 2022-03-18 12:01 ` Lu Baolu 2022-03-18 13:50 ` Jason Gunthorpe 2022-03-18 13:50 ` Jason Gunthorpe via iommu 2022-03-18 11:52 ` Lu Baolu 2022-03-18 11:52 ` Lu Baolu 2022-03-18 13:48 ` Jason Gunthorpe 2022-03-18 13:48 ` Jason Gunthorpe via iommu 2022-03-15 5:07 ` [PATCH v2 3/8] iommu/vt-d: Implement device_pasid domain attach ops Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-15 10:33 ` Tian, Kevin 2022-03-15 10:33 ` Tian, Kevin 2022-03-15 22:23 ` Jacob Pan 2022-03-15 22:23 ` Jacob Pan 2022-03-15 14:33 ` Jason Gunthorpe [this message] 2022-03-15 14:33 ` Jason Gunthorpe via iommu 2022-03-15 22:36 ` Jacob Pan 2022-03-15 22:36 ` Jacob Pan 2022-03-15 23:04 ` Jason Gunthorpe 2022-03-15 23:04 ` Jason Gunthorpe via iommu 2022-03-16 20:50 ` Jacob Pan 2022-03-16 20:50 ` Jacob Pan 2022-03-16 22:15 ` Jason Gunthorpe 2022-03-16 22:15 ` Jason Gunthorpe via iommu 2022-03-16 22:23 ` Luck, Tony 2022-03-16 22:23 ` Luck, Tony 2022-03-17 0:04 ` Jason Gunthorpe 2022-03-17 0:04 ` Jason Gunthorpe via iommu 2022-03-18 5:47 ` Tian, Kevin 2022-03-18 5:47 ` Tian, Kevin 2022-03-18 13:47 ` Jason Gunthorpe 2022-03-18 13:47 ` Jason Gunthorpe via iommu 2022-03-17 0:49 ` Jacob Pan 2022-03-17 0:49 ` Jacob Pan 2022-03-17 13:23 ` Jason Gunthorpe 2022-03-17 13:23 ` Jason Gunthorpe via iommu 2022-03-17 18:23 ` Jacob Pan 2022-03-17 18:23 ` Jacob Pan 2022-03-16 7:41 ` Tian, Kevin 2022-03-16 7:41 ` Tian, Kevin 2022-03-16 21:01 ` Jacob Pan 2022-03-16 21:01 ` Jacob Pan 2022-03-18 5:33 ` Tian, Kevin 2022-03-18 5:33 ` Tian, Kevin 2022-03-28 21:41 ` Jacob Pan 2022-03-28 21:41 ` Jacob Pan 2022-03-16 7:39 ` Tian, Kevin 2022-03-16 7:39 ` Tian, Kevin 2022-03-16 20:51 ` Jacob Pan 2022-03-16 20:51 ` Jacob Pan 2022-03-15 5:07 ` [PATCH v2 4/8] iommu/vt-d: Use device_pasid attach op for RID2PASID Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-16 7:54 ` Tian, Kevin 2022-03-16 7:54 ` Tian, Kevin 2022-03-17 20:45 ` Jacob Pan 2022-03-17 20:45 ` Jacob Pan 2022-03-15 5:07 ` [PATCH v2 5/8] iommu: Add PASID support for DMA mapping API users Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-15 11:16 ` Robin Murphy 2022-03-15 11:16 ` Robin Murphy 2022-03-15 14:22 ` Jason Gunthorpe 2022-03-15 14:22 ` Jason Gunthorpe via iommu 2022-03-15 16:31 ` Jacob Pan 2022-03-15 16:31 ` Jacob Pan 2022-03-15 17:05 ` Jason Gunthorpe 2022-03-15 17:05 ` Jason Gunthorpe via iommu 2022-03-15 21:24 ` Jacob Pan 2022-03-15 21:24 ` Jacob Pan 2022-03-16 10:32 ` Tian, Kevin 2022-03-16 10:32 ` Tian, Kevin 2022-03-16 8:41 ` Tian, Kevin 2022-03-16 8:41 ` Tian, Kevin 2022-03-16 14:07 ` Jason Gunthorpe 2022-03-16 14:07 ` Jason Gunthorpe via iommu 2022-03-15 14:35 ` Jason Gunthorpe 2022-03-15 14:35 ` Jason Gunthorpe via iommu 2022-03-15 16:38 ` Jacob Pan 2022-03-15 16:38 ` Jacob Pan 2022-03-15 23:05 ` Jason Gunthorpe 2022-03-15 23:05 ` Jason Gunthorpe via iommu 2022-03-18 12:43 ` Lu Baolu 2022-03-18 12:43 ` Lu Baolu 2022-03-28 21:44 ` Jacob Pan 2022-03-28 21:44 ` Jacob Pan 2022-03-15 5:07 ` [PATCH v2 6/8] dmaengine: idxd: Use DMA API for in-kernel DMA with PASID Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-18 6:10 ` Tian, Kevin 2022-03-18 6:10 ` Tian, Kevin 2022-03-29 17:39 ` Jacob Pan 2022-03-29 17:39 ` Jacob Pan 2022-03-15 5:07 ` [PATCH v2 7/8] iommu/vt-d: Delete supervisor/kernel SVA Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-18 6:16 ` Tian, Kevin 2022-03-18 6:16 ` Tian, Kevin 2022-03-29 17:42 ` Jacob Pan 2022-03-29 17:42 ` Jacob Pan 2022-03-15 5:07 ` [PATCH v2 8/8] iommu: Remove unused driver data in sva_bind_device Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-15 11:37 ` Jean-Philippe Brucker 2022-03-15 11:37 ` Jean-Philippe Brucker 2022-03-15 5:07 ` [PATCH v2 9/9] dmaengine: idxd: separate user and kernel pasid enabling Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-18 6:28 ` Tian, Kevin 2022-03-18 6:28 ` Tian, Kevin 2022-03-15 8:16 ` [PATCH v2 0/8] Enable PASID for DMA API users Tian, Kevin 2022-03-15 8:16 ` Tian, Kevin 2022-03-15 15:49 ` Jacob Pan 2022-03-15 15:49 ` Jacob Pan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220315143322.GW11336@nvidia.com \ --to=jgg@nvidia.com \ --cc=ashok.raj@intel.com \ --cc=baolu.lu@linux.intel.com \ --cc=dan.j.williams@intel.com \ --cc=dave.jiang@intel.com \ --cc=hch@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@intel.com \ --cc=jacob.jun.pan@linux.intel.com \ --cc=jean-philippe@linaro.com \ --cc=joro@8bytes.org \ --cc=kevin.tian@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=sanjay.k.kumar@intel.com \ --cc=tom.zanussi@intel.com \ --cc=tony.luck@intel.com \ --cc=yi.l.liu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.