From: "Tian, Kevin" <kevin.tian@intel.com> To: Jacob Pan <jacob.jun.pan@linux.intel.com>, "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Joerg Roedel <joro@8bytes.org>, "Jason Gunthorpe" <jgg@nvidia.com>, Christoph Hellwig <hch@infradead.org>, Lu Baolu <baolu.lu@linux.intel.com>, Jean-Philippe Brucker <jean-philippe@linaro.com> Cc: "Luck, Tony" <tony.luck@intel.com>, "Jiang, Dave" <dave.jiang@intel.com>, "Raj, Ashok" <ashok.raj@intel.com>, "Zanussi, Tom" <tom.zanussi@intel.com>, "Kumar, Sanjay K" <sanjay.k.kumar@intel.com>, "Pan, Jacob jun" <jacob.jun.pan@intel.com>, "Williams, Dan J" <dan.j.williams@intel.com> Subject: RE: [PATCH v2 7/8] iommu/vt-d: Delete supervisor/kernel SVA Date: Fri, 18 Mar 2022 06:16:58 +0000 [thread overview] Message-ID: <BN9PR11MB5276B2AB27F5AD50BC18AE718C139@BN9PR11MB5276.namprd11.prod.outlook.com> (raw) In-Reply-To: <20220315050713.2000518-8-jacob.jun.pan@linux.intel.com> > From: Jacob Pan <jacob.jun.pan@linux.intel.com> > Sent: Tuesday, March 15, 2022 1:07 PM > > In-kernel DMA with PASID should use DMA API now, remove supervisor > PASID > SVA support. Remove special cases in bind mm and page request service. > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> so you removed all the references to SVM_FLAG_SUPERVISOR_MODE but the definition is still kept in include/linux/intel-svm.h... > --- > drivers/iommu/intel/svm.c | 42 ++++++++------------------------------- > 1 file changed, 8 insertions(+), 34 deletions(-) > > diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c > index 2c53689da461..37d6218f173b 100644 > --- a/drivers/iommu/intel/svm.c > +++ b/drivers/iommu/intel/svm.c > @@ -516,11 +516,10 @@ static void intel_svm_free_pasid(struct mm_struct > *mm) > > static struct iommu_sva *intel_svm_bind_mm(struct intel_iommu *iommu, > struct device *dev, > - struct mm_struct *mm, > - unsigned int flags) > + struct mm_struct *mm) > { > struct device_domain_info *info = get_domain_info(dev); > - unsigned long iflags, sflags; > + unsigned long iflags, sflags = 0; > struct intel_svm_dev *sdev; > struct intel_svm *svm; > int ret = 0; > @@ -533,16 +532,13 @@ static struct iommu_sva > *intel_svm_bind_mm(struct intel_iommu *iommu, > > svm->pasid = mm->pasid; > svm->mm = mm; > - svm->flags = flags; > INIT_LIST_HEAD_RCU(&svm->devs); > > - if (!(flags & SVM_FLAG_SUPERVISOR_MODE)) { > - svm->notifier.ops = &intel_mmuops; > - ret = mmu_notifier_register(&svm->notifier, mm); > - if (ret) { > - kfree(svm); > - return ERR_PTR(ret); > - } > + svm->notifier.ops = &intel_mmuops; > + ret = mmu_notifier_register(&svm->notifier, mm); > + if (ret) { > + kfree(svm); > + return ERR_PTR(ret); > } > > ret = pasid_private_add(svm->pasid, svm); > @@ -583,8 +579,6 @@ static struct iommu_sva *intel_svm_bind_mm(struct > intel_iommu *iommu, > } > > /* Setup the pasid table: */ > - sflags = (flags & SVM_FLAG_SUPERVISOR_MODE) ? > - PASID_FLAG_SUPERVISOR_MODE : 0; > sflags |= cpu_feature_enabled(X86_FEATURE_LA57) ? > PASID_FLAG_FL5LP : 0; > spin_lock_irqsave(&iommu->lock, iflags); > ret = intel_pasid_setup_first_level(iommu, dev, mm->pgd, mm- > >pasid, > @@ -957,7 +951,7 @@ static irqreturn_t prq_event_thread(int irq, void *d) > * to unbind the mm while any page faults are > outstanding. > */ > svm = pasid_private_find(req->pasid); > - if (IS_ERR_OR_NULL(svm) || (svm->flags & > SVM_FLAG_SUPERVISOR_MODE)) > + if (IS_ERR_OR_NULL(svm)) > goto bad_req; > } > > @@ -1011,29 +1005,9 @@ static irqreturn_t prq_event_thread(int irq, void > *d) > struct iommu_sva *intel_svm_bind(struct device *dev, struct mm_struct > *mm, void *drvdata) > { > struct intel_iommu *iommu = device_to_iommu(dev, NULL, NULL); > - unsigned int flags = 0; > struct iommu_sva *sva; > int ret; > > - if (drvdata) > - flags = *(unsigned int *)drvdata; > - > - if (flags & SVM_FLAG_SUPERVISOR_MODE) { > - if (!ecap_srs(iommu->ecap)) { > - dev_err(dev, "%s: Supervisor PASID not supported\n", > - iommu->name); > - return ERR_PTR(-EOPNOTSUPP); > - } > - > - if (mm) { > - dev_err(dev, "%s: Supervisor PASID with user > provided mm\n", > - iommu->name); > - return ERR_PTR(-EINVAL); > - } > - > - mm = &init_mm; > - } > - > mutex_lock(&pasid_mutex); > ret = intel_svm_alloc_pasid(dev, mm, flags); > if (ret) { > -- > 2.25.1 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: "Tian, Kevin" <kevin.tian@intel.com> To: Jacob Pan <jacob.jun.pan@linux.intel.com>, "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Joerg Roedel <joro@8bytes.org>, "Jason Gunthorpe" <jgg@nvidia.com>, Christoph Hellwig <hch@infradead.org>, Lu Baolu <baolu.lu@linux.intel.com>, Jean-Philippe Brucker <jean-philippe@linaro.com> Cc: "Pan, Jacob jun" <jacob.jun.pan@intel.com>, "Raj, Ashok" <ashok.raj@intel.com>, "Kumar, Sanjay K" <sanjay.k.kumar@intel.com>, "Jiang, Dave" <dave.jiang@intel.com>, "Luck, Tony" <tony.luck@intel.com>, "Zanussi, Tom" <tom.zanussi@intel.com>, "Williams, Dan J" <dan.j.williams@intel.com>, "Liu, Yi L" <yi.l.liu@intel.com> Subject: RE: [PATCH v2 7/8] iommu/vt-d: Delete supervisor/kernel SVA Date: Fri, 18 Mar 2022 06:16:58 +0000 [thread overview] Message-ID: <BN9PR11MB5276B2AB27F5AD50BC18AE718C139@BN9PR11MB5276.namprd11.prod.outlook.com> (raw) In-Reply-To: <20220315050713.2000518-8-jacob.jun.pan@linux.intel.com> > From: Jacob Pan <jacob.jun.pan@linux.intel.com> > Sent: Tuesday, March 15, 2022 1:07 PM > > In-kernel DMA with PASID should use DMA API now, remove supervisor > PASID > SVA support. Remove special cases in bind mm and page request service. > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> so you removed all the references to SVM_FLAG_SUPERVISOR_MODE but the definition is still kept in include/linux/intel-svm.h... > --- > drivers/iommu/intel/svm.c | 42 ++++++++------------------------------- > 1 file changed, 8 insertions(+), 34 deletions(-) > > diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c > index 2c53689da461..37d6218f173b 100644 > --- a/drivers/iommu/intel/svm.c > +++ b/drivers/iommu/intel/svm.c > @@ -516,11 +516,10 @@ static void intel_svm_free_pasid(struct mm_struct > *mm) > > static struct iommu_sva *intel_svm_bind_mm(struct intel_iommu *iommu, > struct device *dev, > - struct mm_struct *mm, > - unsigned int flags) > + struct mm_struct *mm) > { > struct device_domain_info *info = get_domain_info(dev); > - unsigned long iflags, sflags; > + unsigned long iflags, sflags = 0; > struct intel_svm_dev *sdev; > struct intel_svm *svm; > int ret = 0; > @@ -533,16 +532,13 @@ static struct iommu_sva > *intel_svm_bind_mm(struct intel_iommu *iommu, > > svm->pasid = mm->pasid; > svm->mm = mm; > - svm->flags = flags; > INIT_LIST_HEAD_RCU(&svm->devs); > > - if (!(flags & SVM_FLAG_SUPERVISOR_MODE)) { > - svm->notifier.ops = &intel_mmuops; > - ret = mmu_notifier_register(&svm->notifier, mm); > - if (ret) { > - kfree(svm); > - return ERR_PTR(ret); > - } > + svm->notifier.ops = &intel_mmuops; > + ret = mmu_notifier_register(&svm->notifier, mm); > + if (ret) { > + kfree(svm); > + return ERR_PTR(ret); > } > > ret = pasid_private_add(svm->pasid, svm); > @@ -583,8 +579,6 @@ static struct iommu_sva *intel_svm_bind_mm(struct > intel_iommu *iommu, > } > > /* Setup the pasid table: */ > - sflags = (flags & SVM_FLAG_SUPERVISOR_MODE) ? > - PASID_FLAG_SUPERVISOR_MODE : 0; > sflags |= cpu_feature_enabled(X86_FEATURE_LA57) ? > PASID_FLAG_FL5LP : 0; > spin_lock_irqsave(&iommu->lock, iflags); > ret = intel_pasid_setup_first_level(iommu, dev, mm->pgd, mm- > >pasid, > @@ -957,7 +951,7 @@ static irqreturn_t prq_event_thread(int irq, void *d) > * to unbind the mm while any page faults are > outstanding. > */ > svm = pasid_private_find(req->pasid); > - if (IS_ERR_OR_NULL(svm) || (svm->flags & > SVM_FLAG_SUPERVISOR_MODE)) > + if (IS_ERR_OR_NULL(svm)) > goto bad_req; > } > > @@ -1011,29 +1005,9 @@ static irqreturn_t prq_event_thread(int irq, void > *d) > struct iommu_sva *intel_svm_bind(struct device *dev, struct mm_struct > *mm, void *drvdata) > { > struct intel_iommu *iommu = device_to_iommu(dev, NULL, NULL); > - unsigned int flags = 0; > struct iommu_sva *sva; > int ret; > > - if (drvdata) > - flags = *(unsigned int *)drvdata; > - > - if (flags & SVM_FLAG_SUPERVISOR_MODE) { > - if (!ecap_srs(iommu->ecap)) { > - dev_err(dev, "%s: Supervisor PASID not supported\n", > - iommu->name); > - return ERR_PTR(-EOPNOTSUPP); > - } > - > - if (mm) { > - dev_err(dev, "%s: Supervisor PASID with user > provided mm\n", > - iommu->name); > - return ERR_PTR(-EINVAL); > - } > - > - mm = &init_mm; > - } > - > mutex_lock(&pasid_mutex); > ret = intel_svm_alloc_pasid(dev, mm, flags); > if (ret) { > -- > 2.25.1
next prev parent reply other threads:[~2022-03-18 6:17 UTC|newest] Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-15 5:07 [PATCH v2 0/8] Enable PASID for DMA API users Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-15 5:07 ` [PATCH v2 1/8] iommu: Assign per device max PASID Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-15 5:07 ` [PATCH v2 2/8] iommu: Add attach/detach_dev_pasid domain ops Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-15 10:24 ` Tian, Kevin 2022-03-15 10:24 ` Tian, Kevin 2022-03-15 11:26 ` Jean-Philippe Brucker 2022-03-15 11:26 ` Jean-Philippe Brucker 2022-03-15 11:49 ` Tian, Kevin 2022-03-15 11:49 ` Tian, Kevin 2022-03-15 16:11 ` Jacob Pan 2022-03-15 16:11 ` Jacob Pan 2022-03-18 12:01 ` Lu Baolu 2022-03-18 12:01 ` Lu Baolu 2022-03-18 13:50 ` Jason Gunthorpe 2022-03-18 13:50 ` Jason Gunthorpe via iommu 2022-03-18 11:52 ` Lu Baolu 2022-03-18 11:52 ` Lu Baolu 2022-03-18 13:48 ` Jason Gunthorpe 2022-03-18 13:48 ` Jason Gunthorpe via iommu 2022-03-15 5:07 ` [PATCH v2 3/8] iommu/vt-d: Implement device_pasid domain attach ops Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-15 10:33 ` Tian, Kevin 2022-03-15 10:33 ` Tian, Kevin 2022-03-15 22:23 ` Jacob Pan 2022-03-15 22:23 ` Jacob Pan 2022-03-15 14:33 ` Jason Gunthorpe 2022-03-15 14:33 ` Jason Gunthorpe via iommu 2022-03-15 22:36 ` Jacob Pan 2022-03-15 22:36 ` Jacob Pan 2022-03-15 23:04 ` Jason Gunthorpe 2022-03-15 23:04 ` Jason Gunthorpe via iommu 2022-03-16 20:50 ` Jacob Pan 2022-03-16 20:50 ` Jacob Pan 2022-03-16 22:15 ` Jason Gunthorpe 2022-03-16 22:15 ` Jason Gunthorpe via iommu 2022-03-16 22:23 ` Luck, Tony 2022-03-16 22:23 ` Luck, Tony 2022-03-17 0:04 ` Jason Gunthorpe 2022-03-17 0:04 ` Jason Gunthorpe via iommu 2022-03-18 5:47 ` Tian, Kevin 2022-03-18 5:47 ` Tian, Kevin 2022-03-18 13:47 ` Jason Gunthorpe 2022-03-18 13:47 ` Jason Gunthorpe via iommu 2022-03-17 0:49 ` Jacob Pan 2022-03-17 0:49 ` Jacob Pan 2022-03-17 13:23 ` Jason Gunthorpe 2022-03-17 13:23 ` Jason Gunthorpe via iommu 2022-03-17 18:23 ` Jacob Pan 2022-03-17 18:23 ` Jacob Pan 2022-03-16 7:41 ` Tian, Kevin 2022-03-16 7:41 ` Tian, Kevin 2022-03-16 21:01 ` Jacob Pan 2022-03-16 21:01 ` Jacob Pan 2022-03-18 5:33 ` Tian, Kevin 2022-03-18 5:33 ` Tian, Kevin 2022-03-28 21:41 ` Jacob Pan 2022-03-28 21:41 ` Jacob Pan 2022-03-16 7:39 ` Tian, Kevin 2022-03-16 7:39 ` Tian, Kevin 2022-03-16 20:51 ` Jacob Pan 2022-03-16 20:51 ` Jacob Pan 2022-03-15 5:07 ` [PATCH v2 4/8] iommu/vt-d: Use device_pasid attach op for RID2PASID Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-16 7:54 ` Tian, Kevin 2022-03-16 7:54 ` Tian, Kevin 2022-03-17 20:45 ` Jacob Pan 2022-03-17 20:45 ` Jacob Pan 2022-03-15 5:07 ` [PATCH v2 5/8] iommu: Add PASID support for DMA mapping API users Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-15 11:16 ` Robin Murphy 2022-03-15 11:16 ` Robin Murphy 2022-03-15 14:22 ` Jason Gunthorpe 2022-03-15 14:22 ` Jason Gunthorpe via iommu 2022-03-15 16:31 ` Jacob Pan 2022-03-15 16:31 ` Jacob Pan 2022-03-15 17:05 ` Jason Gunthorpe 2022-03-15 17:05 ` Jason Gunthorpe via iommu 2022-03-15 21:24 ` Jacob Pan 2022-03-15 21:24 ` Jacob Pan 2022-03-16 10:32 ` Tian, Kevin 2022-03-16 10:32 ` Tian, Kevin 2022-03-16 8:41 ` Tian, Kevin 2022-03-16 8:41 ` Tian, Kevin 2022-03-16 14:07 ` Jason Gunthorpe 2022-03-16 14:07 ` Jason Gunthorpe via iommu 2022-03-15 14:35 ` Jason Gunthorpe 2022-03-15 14:35 ` Jason Gunthorpe via iommu 2022-03-15 16:38 ` Jacob Pan 2022-03-15 16:38 ` Jacob Pan 2022-03-15 23:05 ` Jason Gunthorpe 2022-03-15 23:05 ` Jason Gunthorpe via iommu 2022-03-18 12:43 ` Lu Baolu 2022-03-18 12:43 ` Lu Baolu 2022-03-28 21:44 ` Jacob Pan 2022-03-28 21:44 ` Jacob Pan 2022-03-15 5:07 ` [PATCH v2 6/8] dmaengine: idxd: Use DMA API for in-kernel DMA with PASID Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-18 6:10 ` Tian, Kevin 2022-03-18 6:10 ` Tian, Kevin 2022-03-29 17:39 ` Jacob Pan 2022-03-29 17:39 ` Jacob Pan 2022-03-15 5:07 ` [PATCH v2 7/8] iommu/vt-d: Delete supervisor/kernel SVA Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-18 6:16 ` Tian, Kevin [this message] 2022-03-18 6:16 ` Tian, Kevin 2022-03-29 17:42 ` Jacob Pan 2022-03-29 17:42 ` Jacob Pan 2022-03-15 5:07 ` [PATCH v2 8/8] iommu: Remove unused driver data in sva_bind_device Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-15 11:37 ` Jean-Philippe Brucker 2022-03-15 11:37 ` Jean-Philippe Brucker 2022-03-15 5:07 ` [PATCH v2 9/9] dmaengine: idxd: separate user and kernel pasid enabling Jacob Pan 2022-03-15 5:07 ` Jacob Pan 2022-03-18 6:28 ` Tian, Kevin 2022-03-18 6:28 ` Tian, Kevin 2022-03-15 8:16 ` [PATCH v2 0/8] Enable PASID for DMA API users Tian, Kevin 2022-03-15 8:16 ` Tian, Kevin 2022-03-15 15:49 ` Jacob Pan 2022-03-15 15:49 ` Jacob Pan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BN9PR11MB5276B2AB27F5AD50BC18AE718C139@BN9PR11MB5276.namprd11.prod.outlook.com \ --to=kevin.tian@intel.com \ --cc=ashok.raj@intel.com \ --cc=baolu.lu@linux.intel.com \ --cc=dan.j.williams@intel.com \ --cc=dave.jiang@intel.com \ --cc=hch@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@intel.com \ --cc=jacob.jun.pan@linux.intel.com \ --cc=jean-philippe@linaro.com \ --cc=jgg@nvidia.com \ --cc=joro@8bytes.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sanjay.k.kumar@intel.com \ --cc=tom.zanussi@intel.com \ --cc=tony.luck@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.